Attention is currently required from: jolly. dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43047?usp=email ) Change subject: V1.2: Add TERMINAL CAPABILITY for IoT support ...................................................................... Patch Set 1: (3 comments) File src/ipa/libipa/euicc.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43047/comment/c3e90e4c_96c611d1?... : PS1, Line 360: /* Send terminal capablilities, see also 3gpp TS 102.221 V16.2.0, section 11.1.19.2.4 */ I would change the section to 11.1.19 only, this function is now about the TERMINAL CAPABILITY command in general. https://gerrit.osmocom.org/c/onomondo-ipa/+/43047/comment/545dd5e2_ed2e0a19?... : PS1, Line 534: { I think we should add a spec reference here: 3gpp TS 102.221, section 11.1.19.2.4 GSMA SGP.32, section 3.8.2 https://gerrit.osmocom.org/c/onomondo-ipa/+/43047/comment/e4fb86d3_6a2fe84e?... : PS1, Line 545: if (!ctx->cfg->iot_euicc_emu_enabled) { I think we should pack termcap_euicc and termcap_iot into one TLV object and send it with a single TERMINAL CAPABILITY command. The spec does not say it absolutely, but I don't think that you can send multiple TERMINAL CAPABILITY commands where each one activates a different feature. I think that a consecutive TERMINAL CAPABILTY command will overwrite the changes of the previous one. - correct me if I am wrong. -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I1116bee93b31ee4a159125d840d7c5866be6fdb4 Gerrit-Change-Number: 43047 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Comment-Date: Wed, 22 Jul 2026 14:26:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No