osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43085?usp=email )
Change subject: testenv: init: check distro argument early
......................................................................
testenv: init: check distro argument early
Check the --distro argument and print a proper error, instead of failing
later on with a stack trace if it is unsupported.
Change-Id: I9d51c2b236f10f4c10e991873df47b4f3297e6e1
---
M _testenv/testenv/__init__.py
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
daniel: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/_testenv/testenv/__init__.py b/_testenv/testenv/__init__.py
index b9ec676..ed302ab 100644
--- a/_testenv/testenv/__init__.py
+++ b/_testenv/testenv/__init__.py
@@ -260,6 +260,15 @@
args.podman = False
+def verify_args_init():
+ if args.action != "init":
+ return
+
+ distro_arg = getattr(args, "distro", None)
+ if distro_arg and distro_arg not in distros_repodirs:
+ raise NoTraceException(f"--distro must be one of {', '.join(distros_repodirs)}")
+
+
def verify_args_run():
if args.action != "run":
return
@@ -304,6 +313,7 @@
def init_args():
parse_args()
+ verify_args_init()
verify_args_run()
set_args_defaults()
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43085?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9d51c2b236f10f4c10e991873df47b4f3297e6e1
Gerrit-Change-Number: 43085
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43083?usp=email )
Change subject: testenv: Dockerfile: rebar3 version via apt-cache
......................................................................
testenv: Dockerfile: rebar3 version via apt-cache
When building for Debian Unstable, we need a higher rebar3 version so it
is compatible with the Erlang OTP version in the distribution. Get the
version of rebar3 from the distribution via apt-cache and download it
instead of hardcoding a version number.
Related: OS#7025#note-10
Change-Id: Ie3c8812c41648dd5ca655114dec00ae7d48eaba8
---
M _testenv/data/podman/Dockerfile
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
fixeria: Looks good to me, approved
daniel: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/_testenv/data/podman/Dockerfile b/_testenv/data/podman/Dockerfile
index a1473df..cc0a9f6 100644
--- a/_testenv/data/podman/Dockerfile
+++ b/_testenv/data/podman/Dockerfile
@@ -119,11 +119,12 @@
&& \
apt-get clean
-# Install rebar3 as described in https://rebar3.org/docs/getting-started/
-# instead of using the Debian package, as the latter pulls in ~600 MB of GUI
-# dependencies that we don't need:
-# https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1083096
-RUN wget https://github.com/erlang/rebar3/releases/download/3.24.0/rebar3 -O /usr/bin/rebar3 && \
+# Install rebar3 from the official release binary instead of using the Debian
+# package, as the latter pulls in ~600 MB of GUI dependencies that we don't
+# need: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1083096
+RUN set -x && \
+ export REBAR3_VERSION=$(apt-cache madison rebar3 | awk '{print $3}' | cut -d- -f 1) && \
+ wget https://github.com/erlang/rebar3/releases/download/$REBAR3_VERSION/rebar3 -O /usr/bin/rebar3 && \
chmod +x /usr/bin/rebar3 && \
rebar3 --version
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43083?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie3c8812c41648dd5ca655114dec00ae7d48eaba8
Gerrit-Change-Number: 43083
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43029?usp=email )
Change subject: V1.2: Add EimConfigurationData.indirectProfileDownload
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/ipa/libipa/proc_eim_pkg_retr.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43029/comment/d3e53420_03cb2b07… :
PS1, Line 122: "Indirect profile download is not suppoted by eIM, we don't support direct profile download, -- cannot continue!\n");
Its probably difficult for end users to understand what "we" refers to. I always try to use phrases like "... not supported by this IPAd" or similar.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43029?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ic40111531e6f35d5ea7f3789de6cae0f1c0d5ba7
Gerrit-Change-Number: 43029
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 22 Jul 2026 08:32:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes