Attention is currently required from: dexter.
Hello Jenkins Builder, jolly,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-eim/+/42992?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: contrib/tryme_euiccDataRequest: fixup example tag string
......................................................................
contrib/tryme_euiccDataRequest: fixup example tag string
The eUICC data request takes a string with TLV tags as input. The
example in this example still uses tags from SGP.32 V.1.0.1, let's
update the string so that it is compliant with SGP.32 V.1.2.
(see also SGP.32, section 2.11.1.2)
Change-Id: I5be04c954330638d3e7d78e8f5f280bebb707efa
Related: SYS:8100
---
M contrib/tryme_euiccDataRequest.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/92/42992/4
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42992?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I5be04c954330638d3e7d78e8f5f280bebb707efa
Gerrit-Change-Number: 42992
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43085?usp=email )
Change subject: testenv: init: check distro argument early
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43085?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9d51c2b236f10f4c10e991873df47b4f3297e6e1
Gerrit-Change-Number: 43085
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Tue, 21 Jul 2026 13:42:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
dexter has abandoned this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42994?usp=email )
Change subject: doc/build.md: fix typo
......................................................................
Abandoned
my spell checker got set off by this, but since its still correct, we can abandon this patch.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42994?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ie6a066f3289fbdde40f55bd9f38a3dd90102e7e6
Gerrit-Change-Number: 42994
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43085?usp=email )
Change subject: testenv: init: check distro argument early
......................................................................
testenv: init: check distro argument early
Check the --distro argument and print a proper error, instead of failing
later on with a stack trace if it is unsupported.
Change-Id: I9d51c2b236f10f4c10e991873df47b4f3297e6e1
---
M _testenv/testenv/__init__.py
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/43085/1
diff --git a/_testenv/testenv/__init__.py b/_testenv/testenv/__init__.py
index b9ec676..0f70f8a 100644
--- a/_testenv/testenv/__init__.py
+++ b/_testenv/testenv/__init__.py
@@ -260,6 +260,14 @@
args.podman = False
+def verify_args_init():
+ if args.action != "init":
+ return
+
+ if args.distro and args.distro not in distros_repodirs:
+ raise NoTraceException(f"--distro must be one of {', '.join(distros_repodirs)}")
+
+
def verify_args_run():
if args.action != "run":
return
@@ -304,6 +312,7 @@
def init_args():
parse_args()
+ verify_args_init()
verify_args_run()
set_args_defaults()
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43085?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9d51c2b236f10f4c10e991873df47b4f3297e6e1
Gerrit-Change-Number: 43085
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43083?usp=email )
Change subject: testenv: Dockerfile: rebar3 version via apt-cache
......................................................................
testenv: Dockerfile: rebar3 version via apt-cache
When building for Debian Unstable, we need a higher rebar3 version so it
is compatible with the Erlang OTP version in the distribution. Get the
version of rebar3 from the distribution via apt-cache and download it
instead of hardcoding a version number.
Related: OS#7025#note-10
Change-Id: Ie3c8812c41648dd5ca655114dec00ae7d48eaba8
---
M _testenv/data/podman/Dockerfile
1 file changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/43083/1
diff --git a/_testenv/data/podman/Dockerfile b/_testenv/data/podman/Dockerfile
index a1473df..cc0a9f6 100644
--- a/_testenv/data/podman/Dockerfile
+++ b/_testenv/data/podman/Dockerfile
@@ -119,11 +119,12 @@
&& \
apt-get clean
-# Install rebar3 as described in https://rebar3.org/docs/getting-started/
-# instead of using the Debian package, as the latter pulls in ~600 MB of GUI
-# dependencies that we don't need:
-# https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1083096
-RUN wget https://github.com/erlang/rebar3/releases/download/3.24.0/rebar3 -O /usr/bin/rebar3 && \
+# Install rebar3 from the official release binary instead of using the Debian
+# package, as the latter pulls in ~600 MB of GUI dependencies that we don't
+# need: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1083096
+RUN set -x && \
+ export REBAR3_VERSION=$(apt-cache madison rebar3 | awk '{print $3}' | cut -d- -f 1) && \
+ wget https://github.com/erlang/rebar3/releases/download/$REBAR3_VERSION/rebar3 -O /usr/bin/rebar3 && \
chmod +x /usr/bin/rebar3 && \
rebar3 --version
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43083?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie3c8812c41648dd5ca655114dec00ae7d48eaba8
Gerrit-Change-Number: 43083
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/43081?usp=email )
Change subject: rebar.lock: use a more recent version of gen_netlink
......................................................................
rebar.lock: use a more recent version of gen_netlink
This works around a compiler bug in OTP 29.0.3 [1].
Change-Id: Iae0c4b3827c7ae5c8076fbf782adf8db02d975ea
Related: [1] https://github.com/erlang/otp/issues/11368
Related: OS#7025
---
M rebar.lock
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
osmith: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/rebar.lock b/rebar.lock
index cd1bc6e..b4f0a9e 100644
--- a/rebar.lock
+++ b/rebar.lock
@@ -10,7 +10,7 @@
1},
{<<"gen_netlink">>,
{git,"https://github.com/osmocom/gen_netlink",
- {ref,"0de39ae6496fc55a145795c45e4b3119a9ee777c"}},
+ {ref,"fb4cbfbc750deb263035c11f11e4b0616efb71dc"}},
1},
{<<"gen_socket">>,
{git,"https://github.com/osmocom/gen_socket",
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/43081?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Iae0c4b3827c7ae5c8076fbf782adf8db02d975ea
Gerrit-Change-Number: 43081
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Attention is currently required from: fixeria.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/43081?usp=email )
Change subject: rebar.lock: use a more recent version of gen_netlink
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
thanks for fixing it!
gen_netlink patch: https://github.com/osmocom/gen_netlink/commit/fb4cbfbc750deb263035c11f11e4b…
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/43081?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Iae0c4b3827c7ae5c8076fbf782adf8db02d975ea
Gerrit-Change-Number: 43081
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 17 Jul 2026 11:34:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes