osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/simtrace2/+/42943?usp=email )
Change subject: Bump version: 0.9.0.4-3248-dirty → 0.9.1
......................................................................
Patch Set 1:
(1 comment)
File debian/changelog:
https://gerrit.osmocom.org/c/simtrace2/+/42943/comment/c461e1fd_075750cb?us… :
PS1, Line 9: * Use gsmtap_inst_fd2() to remove compiler warning
I have verified that we don't need a configure.ac adjustment for the min libosmocore version for this.
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/42943?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I0d06c6f15aa99be7609eac9afb6b9df8e6cf3dc5
Gerrit-Change-Number: 42943
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 08 Jul 2026 06:52:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: dexter.
fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42733?usp=email )
Change subject: cosmetic: remove excess linebreaks
......................................................................
Patch Set 1: Code-Review-2
(2 comments)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/42733/comment/ef1fbdf2_8c0be250?usp=em… :
PS1, Line 1131:
> I think it's useful to sepaate the "main" block from class definitions with an extra line. […]
It's actually recommended in PEP8 to separate top-level classes and methods using two empty lines, see https://peps.python.org/pep-0008/#blank-lines.
File pySim/transport/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/42733/comment/9909f306_26b1f44c?usp=em… :
PS1, Line 28:
> I'm not quite sure what you are trying to achieve here. […]
Acknowledged
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42733?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I2272abcdbba0e57c5118b69bc9398cd909a469b5
Gerrit-Change-Number: 42733
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Jul 2026 23:24:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/42910?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: common: flush paging queue in nm_bts_fsm's NOTINSTALLED on_enter
......................................................................
common: flush paging queue in nm_bts_fsm's NOTINSTALLED on_enter
paging_reset() exists to flush stale paging records from the queue,
but was never called anywhere. Stale paging records can accumulate
when the OML link goes down: osmo-bts does not exit, so the paging
queue survives into the next BSC session.
Call it alongside bts_cbch_reset() and bts_asci_notification_reset()
in st_op_disabled_notinstalled_on_enter(), which fires after all TRXs
are confirmed closed and before a new OML connection is accepted.
Change-Id: I109ab282986b68b68ba5c11859c44b771c0416fd
AI-Assisted: yes (Claude)
---
M src/common/nm_bts_fsm.c
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
laforge: Looks good to me, approved
osmith: Looks good to me, but someone else must approve
diff --git a/src/common/nm_bts_fsm.c b/src/common/nm_bts_fsm.c
index 5c4a534..e5bfb76 100644
--- a/src/common/nm_bts_fsm.c
+++ b/src/common/nm_bts_fsm.c
@@ -37,6 +37,7 @@
#include <osmo-bts/phy_link.h>
#include <osmo-bts/cbch.h>
#include <osmo-bts/notification.h>
+#include <osmo-bts/paging.h>
#define X(s) (1 << (s))
@@ -69,6 +70,7 @@
TALLOC_FREE(bts->mo.nm_attr);
bts_cbch_reset(bts);
bts_asci_notification_reset(bts);
+ paging_reset(bts->paging_state);
if (bts->c0_power_red_db > 0)
bts_set_c0_pwr_red(bts, 0);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42910?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I109ab282986b68b68ba5c11859c44b771c0416fd
Gerrit-Change-Number: 42910
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel.
fixeria has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42937?usp=email )
Change subject: stp: Test that UDTS containing tcap is routed correctly
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42937?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I264ab424fbc3652249535bbe4f30029defa64c09
Gerrit-Change-Number: 42937
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Jul 2026 23:18:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: daniel.
fixeria has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42936?usp=email )
Change subject: stp: Add TCAP_N_NOTICE_req to send a UDTS with TCAP payload
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42936?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie13cecc2f2fc8a20d9646f0fb010b91c2ecf7766
Gerrit-Change-Number: 42936
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Jul 2026 23:16:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: daniel, pespin.
fixeria has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42935?usp=email )
Change subject: stp: add ASP_SCCP_N_NOTICE_req support and f_asp_tx_notice()
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42935?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I74c05405f1c99d43b4bf863f959275ee51301f2e
Gerrit-Change-Number: 42935
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Jul 2026 23:15:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes