Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43035?usp=email )
Change subject: V1.2: Add eimTransactionId to IpaEuiccDataRequest and IpaEuiccDataResponse
......................................................................
Patch Set 1:
(2 comments)
File src/ipa/libipa/proc_euicc_data_req.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43035/comment/6c7008df_35acebcc… :
PS1, Line 211:
I think at this point it is too late to set the eimTransactionId. You have to do this before the ipa_esipa_prvde_eim_pkg_rslt() call. Otherwise there will be no effect. (as it seems the if/else statement below was intended for producing log messages only)
https://gerrit.osmocom.org/c/onomondo-ipa/+/43035/comment/bad2f18e_a0175937… :
PS1, Line 216: IPA_LOGP(SIPA, LINFO, "IPA get EUICC data succeeded!\n");
When looking closer I can see that this code is a bit misleading. At the moment we do not generate an ipaEuiccDataResponseError. If one of those ES10b function calls above fails, there will just be no result for this tag. Maybe this is something we should address. (create a ticket?)
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43035?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I34db78c4eb8461c154459204ec13a2184085e96a
Gerrit-Change-Number: 43035
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 22 Jul 2026 11:22:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43088?usp=email )
Change subject: rest_handler, cosmetic: clean up order of variable assignments
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43088?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I2b998a619cf1db5532bcfe671d6d451d095c37f8
Gerrit-Change-Number: 43088
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 22 Jul 2026 10:08:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes