Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43032?usp=email )
Change subject: V1.2: Add new fields to ProfileInfo list
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43032?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I6667dba8dd84817cfee69daa1c44b98239fa171c
Gerrit-Change-Number: 43032
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 22 Jul 2026 09:53:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43031?usp=email )
Change subject: V1.2: Add setDefaultDpAddress function
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1:
I think this patch is correct. As mentioned, I would add a bit more "service logic" into the es10c function itself.
File src/ipa/libipa/es10c_set_def_dp_addr.h:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43031/comment/9ea8d8d3_3e414872… :
PS1, Line 20:
This is correct. However when the input and output parameters are simple, I sometimes use those ASN.1 generateds structs internally and I fall back to req/res structs that contain simplified members.
In es10b_get_euicc_chlg.h you find a radical example that would fit here also, you could just define the function like this:
int ipa_es10c_set_def_dp_addr(struct ipa_context *ctx, uint8_t *default_dp_address)
The advantage is that the function would be simpler to call for the API user since we do not need to call an extra free function. The disadvantage is that it is more difficult to maintain in case the ASN.1 spec gets extended.
(I just wanted to share some thoughts, as I said, the implementation is correct. You do not have to change it if you think it is ok as it is.)
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43031?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I514b03240289469142e6a41a7290a4afce199318
Gerrit-Change-Number: 43031
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 22 Jul 2026 09:53:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43030?usp=email )
Change subject: V1.2: EuiccResultData.setFallbackAttribute / unsetFallbackAttribute
......................................................................
Patch Set 1:
(2 comments)
File src/ipa/libipa/es10b_load_euicc_pkg.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43030/comment/dec39095_131ae2fd… :
PS1, Line 278:
I would suggest not to pretend that the setFallbackAttribute command was successful. It is probably better to fail in this case. Otherwise the REST API user of the eIM may end up with false information.
SGP.32 section 4.3.7 says:
If the eUICC does not support the Fallback Mechanism the procedure SHALL stop and
the result of this command SHALL indicate error (‘processingTerminated’ with
‘unknownOrDamagedCommand).
From that I deduct that the fallback mechanism is not a must-have for an SGP.32 V.1.2 compliant eUICC.
I would say that you can just put SetFallbackAttributeResult_undefinedError into the SetFallbackAttributeResult instead of hard failing the overall procedure, even though this is not 100% what is specified. We are not 100% spec compliant here either, so I think this is a good compromise.
https://gerrit.osmocom.org/c/onomondo-ipa/+/43030/comment/4891d719_29f57b34… :
PS1, Line 291:
(see comment above)
Here I would use: UnsetFallbackAttributeResult_undefinedError
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43030?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I59fba32cb12de22f71b3238adcbab5fc7f66e991
Gerrit-Change-Number: 43030
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 22 Jul 2026 09:26:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No