April 2026 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: ts_51_011/EF.SMSP: fix handling of 'alpha_id' field
by dexter 23 Apr '26

23 Apr '26

Attention is currently required from: fixeria, neels. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42662?usp=email ) Change subject: ts_51_011/EF.SMSP: fix handling of 'alpha_id' field ...................................................................... Patch Set 5: (2 comments) Patchset: PS5: This should fix the problem with EF.SMSP. Please also have a look at the patch before this one. File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/42662/comment/49808e36_8244a436?usp=em… : PS5, Line 344: self._construct = Struct('alpha_id'/GsmOrUcs2Adapter(Rpad(Bytes(this._.total_len-28))), If we leave out the COptional, we make the parser more sensitive to broken file contents (see also the patch before this one. This were the bugs that were caught by the tests when I pushed this patch. The reason why the parser gets more sensitive towards invalid input is the following: See: https://construct.readthedocs.io/en/latest/misc.html#conditional "Attempts to parse or build the subconstruct. If it fails during parsing, returns a None. If it fails during building, it puts nothing into the stream." In my opinion the parser should reject invalid input and not try to make sense of some broken input. That is why I prefer to remove the COptional from the construct definition. YFI: When the alpha_id is not present, we get the following results during decode: With COptional: alpha_id : 'null' Without COptional: alpha_id : '' -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42662?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0ec99b2648b22c56f9145345e4cd8776f9217701 Gerrit-Change-Number: 42662 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Apr 2026 14:06:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ci[master]: OBS: build_srcpkg.Dockerfile: add dh-runit
by osmith 23 Apr '26

23 Apr '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42668?usp=email ) Change subject: OBS: build_srcpkg.Dockerfile: add dh-runit ...................................................................... OBS: build_srcpkg.Dockerfile: add dh-runit Add dh-runit, so we can build source packages of newer versions of pcsc-lite. Related: https://salsa.debian.org/debian/pcsc-lite/-/commit/c7c40df72dc3c754341501e3… Change-Id: I8d852cebb9decb3c881fd3ff9b530213bade0216 --- M scripts/obs/data/build_srcpkg.Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/68/42668/1 diff --git a/scripts/obs/data/build_srcpkg.Dockerfile b/scripts/obs/data/build_srcpkg.Dockerfile index 4193e67..13c9f6a 100644 --- a/scripts/obs/data/build_srcpkg.Dockerfile +++ b/scripts/obs/data/build_srcpkg.Dockerfile @@ -16,6 +16,7 @@ default-libmysqlclient-dev \ dh-cmake \ dh-python \ + dh-runit \ dh-virtualenv \ dpkg-dev \ erlang-nox \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42668?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8d852cebb9decb3c881fd3ff9b530213bade0216 Gerrit-Change-Number: 42668 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pySim-prog/cards: fix programming of EF.SMSP
by dexter 23 Apr '26

23 Apr '26

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42667?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim-prog/cards: fix programming of EF.SMSP ...................................................................... pySim-prog/cards: fix programming of EF.SMSP The legacy code found in legacy/cards.py does not use the modern construct based encoder (pySim-read uses it). The card classes either use their own implementation of update_smsp or use the generic method provided by the SimCard class. The latter one is true for FairwavesSIM and WavemobileSim. Unfortunately the implementation found in the SimCard is wrong. It adds padding at the end of the file instead of the beginning. This completely messes up the contents of EF.SMSP for the cards using this method. To fix this, let's use the leftpad feature provided by the update_record. This will ensure a correct alignment of the file contents. Related: SYS#7765 Change-Id: Ie112418f1f1461762d61365d3863181ca6be7245 --- M pySim/legacy/cards.py M tests/pySim-prog_test/Fairwaves-SIM.ok M tests/pySim-prog_test/Wavemobile-SIM.ok 3 files changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/67/42667/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42667?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie112418f1f1461762d61365d3863181ca6be7245 Gerrit-Change-Number: 42667 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in osmo-remsim[master]: Fix: Prevent race conditions when accessing slotmap in bankd
by jolly 23 Apr '26

23 Apr '26

Attention is currently required from: lynxis lazus. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email ) Change subject: Fix: Prevent race conditions when accessing slotmap in bankd ...................................................................... Patch Set 2: (2 comments) File src/bankd/bankd_main.c: https://gerrit.osmocom.org/c/osmo-remsim/+/42664/comment/e087fccc_9b65b9ba?… : PS1, Line 1115: slotmaps_rdlock(g_worker->bankd->slotmaps); > write lock? Done File src/slotmap.h: https://gerrit.osmocom.org/c/osmo-remsim/+/42664/comment/ac1c6be7_6b0fe04a?… : PS1, Line 74: struct slot_mapping *slotmap_by_client(struct slotmaps *maps, const struct client_slot *client); > maybe add a postfix to the functions: _lock and _nolock? Done At least for the lookup functions. The delete function without locking already exists with the name _slotmap_del. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3464726f37beb7c47b4e1f00c018ffa4f3948906 Gerrit-Change-Number: 42664 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 23 Apr 2026 13:15:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-remsim[master]: Fix: Prevent race conditions when accessing slotmap in bankd
by jolly 23 Apr '26

23 Apr '26

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Fix: Prevent race conditions when accessing slotmap in bankd ...................................................................... Fix: Prevent race conditions when accessing slotmap in bankd All threads (main and workers) can use slotmap_by_bank() and slotmap_by_client() to get a mapping entry from the slot map. While working with this entry (reading values), it could be deleted by a different thread. For example, if a client connects to a worker, the worker will check if there is an existing mapping between a reader and this client. If it exists, slotmap_by_client() will return a pointer. If the mapping is deleted at this time by the server, the worker uses a pointer to a mapping entry that has just been freed. Change-Id: I3464726f37beb7c47b4e1f00c018ffa4f3948906 --- M src/bankd/bankd_main.c M src/slotmap.c M src/slotmap.h 3 files changed, 53 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/64/42664/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3464726f37beb7c47b4e1f00c018ffa4f3948906 Gerrit-Change-Number: 42664 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu>

1 0

[XS] Change in pysim[master]: pySim-prog/cards: fix programming of EF.SMSP
by dexter 23 Apr '26

23 Apr '26

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42667?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim-prog/cards: fix programming of EF.SMSP ...................................................................... pySim-prog/cards: fix programming of EF.SMSP The legacy code found in legacy/cards.py does not use the modern construct based encoder (pySim-read uses it). The card classes either use their own implementation of update_smsp or use the generic method provided by the SimCard class. The latter one is true for FairwavesSIM and WavemobileSim. Unfortunately the implementation found in the SimCard is wrong. It adds padding at the end of the file instead of the beginning. This completely messes up the contents of EF.SMSP for the cards using this method. To fix this, let's use the leftpad feature provided by the update_record. This will ensure a correct alignment of the file contents. Related: SYS#7765 Change-Id: Ie112418f1f1461762d61365d3863181ca6be7245 --- M pySim/legacy/cards.py M tests/pySim-prog_test/Fairwaves-SIM.ok 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/67/42667/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42667?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie112418f1f1461762d61365d3863181ca6be7245 Gerrit-Change-Number: 42667 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pySim-prog/cards: fix programming of EF.SMSP
by dexter 23 Apr '26

23 Apr '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42667?usp=email ) Change subject: pySim-prog/cards: fix programming of EF.SMSP ...................................................................... pySim-prog/cards: fix programming of EF.SMSP The legacy code found in legacy/cards.py does not use the modern construct based encoder (pySim-read uses it). The card classes either use their own implementation of update_smsp or use the generic method provided by the SimCard class. The latter one is true for FairwavesSIM and WavemobileSim. Unfortunately the implementation found in the SimCard is wrong. It adds padding at the end of the file instead of the beginning. This completely messes up the contents of EF.SMSP for the cards using this method. To fix this, let's use the leftpad feature provided by the update_record. This will ensure a correct alignment of the file contents. Related: SYS#7765 Change-Id: Ie112418f1f1461762d61365d3863181ca6be7245 --- M pySim/legacy/cards.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/67/42667/1 diff --git a/pySim/legacy/cards.py b/pySim/legacy/cards.py index 9efa66b..3b66328 100644 --- a/pySim/legacy/cards.py +++ b/pySim/legacy/cards.py @@ -152,7 +152,8 @@ return sw def update_smsp(self, smsp): - data, sw = self._scc.update_record(EF['SMSP'], 1, rpad(smsp, 84)) + print("using update_smsp") + data, sw = self._scc.update_record(EF['SMSP'], 1, smsp, leftpad=True) return sw def update_ad(self, mnc=None, opmode=None, ofm=None, path=EF['AD']): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42667?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie112418f1f1461762d61365d3863181ca6be7245 Gerrit-Change-Number: 42667 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: Allow adding extra parameters to podman
by osmith 23 Apr '26

23 Apr '26

Attention is currently required from: jolly. osmith has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42666?usp=email ) Change subject: testenv: Allow adding extra parameters to podman ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File _testenv/README.md: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42666/comment/cdbe4422_b0ee… : PS1, Line 98: podman. For example, it can be used to mount additional volume to pass- ```suggestion podman. For example, it can be used to mount an additional volume to pass- ``` https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42666/comment/8038a3d1_010e… : PS1, Line 100: spaces into patameters. ```suggestion spaces into parameters. ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a2be0d60efcd70ea2081e0314927885085bb5e0 Gerrit-Change-Number: 42666 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 23 Apr 2026 12:38:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: Allow adding extra parameters to podman
by jolly 23 Apr '26

23 Apr '26

Attention is currently required from: jolly, osmith. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42666?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: testenv: Allow adding extra parameters to podman ...................................................................... testenv: Allow adding extra parameters to podman Allows to add additional command line parameters to podman, if defined int the testsuite section of testenv.cfg: [testsuite] ... podman_extra=--volume /dev/bus/usb:/dev/bus/usb Change-Id: I6a2be0d60efcd70ea2081e0314927885085bb5e0 --- M _testenv/README.md M _testenv/testenv/podman.py M _testenv/testenv/testenv_cfg.py 3 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/42666/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a2be0d60efcd70ea2081e0314927885085bb5e0 Gerrit-Change-Number: 42666 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: Fix access pcscd in various RemsimBankd_Tests
by osmith 23 Apr '26

23 Apr '26

Attention is currently required from: jolly. osmith has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42647?usp=email ) Change subject: Fix access pcscd in various RemsimBankd_Tests ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42647?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibae1c5167daa0157058bc40ce1857c1e6bb9da31 Gerrit-Change-Number: 42647 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 23 Apr 2026 12:34:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026