Attention is currently required from: lynxis lazus.

jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email )

Change subject: Fix: Prevent race conditions when accessing slotmap in bankd ......................................................................

Patch Set 2:

(2 comments)

File src/bankd/bankd_main.c:

https://gerrit.osmocom.org/c/osmo-remsim/+/42664/comment/e087fccc_9b65b9ba?u... : PS1, Line 1115: slotmaps_rdlock(g_worker->bankd->slotmaps);

write lock?

Done

File src/slotmap.h:

https://gerrit.osmocom.org/c/osmo-remsim/+/42664/comment/ac1c6be7_6b0fe04a?u... : PS1, Line 74: struct slot_mapping *slotmap_by_client(struct slotmaps *maps, const struct client_slot *client);

maybe add a postfix to the functions: _lock and _nolock?

Done

At least for the lookup functions. The delete function without locking already exists with the name _slotmap_del.