Attention is currently required from: jolly.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Verified+1 by Jenkins Builder
Change subject: Fix: Prevent race conditions when accessing slotmap in bankd ......................................................................
Fix: Prevent race conditions when accessing slotmap in bankd
All threads (main and workers) can use slotmap_by_bank() and slotmap_by_client() to get a mapping entry from the slot map. While working with this entry (reading values), it could be deleted by a different thread.
For example, if a client connects to a worker, the worker will check if there is an existing mapping between a reader and this client. If it exists, slotmap_by_client() will return a pointer. If the mapping is deleted at this time by the server, the worker uses a pointer to a mapping entry that has just been freed.
Change-Id: I3464726f37beb7c47b4e1f00c018ffa4f3948906 --- M src/bankd/bankd_main.c M src/slotmap.c M src/slotmap.h 3 files changed, 53 insertions(+), 20 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/64/42664/2