April 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: Fix bankd connection at RemsimClient_Tests.TC_bank_disconnect_reconnect
by osmith 23 Apr '26

23 Apr '26

Attention is currently required from: jolly. osmith has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42646?usp=email ) Change subject: Fix bankd connection at RemsimClient_Tests.TC_bank_disconnect_reconnect ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42646?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0a8b339bcc4136442994b8825904df8aaf9aa95d Gerrit-Change-Number: 42646 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 23 Apr 2026 12:33:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: Allow adding extra parameters to podman
by Jenkins Builder 23 Apr '26

23 Apr '26

Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42666?usp=email ) Change subject: testenv: Allow adding extra parameters to podman ...................................................................... Patch Set 1: (1 comment) File _testenv/README.md: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42666/comment/3e58c126_3e02… : PS1, Line 99: through usb devices. Use spaces to seperate parameters, use quotes to include 'seperate' may be misspelled - perhaps 'separate'? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a2be0d60efcd70ea2081e0314927885085bb5e0 Gerrit-Change-Number: 42666 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 23 Apr 2026 12:28:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-remsim[master]: Fix: Prevent race conditions when accessing slotmap in bankd
by lynxis lazus 23 Apr '26

23 Apr '26

Attention is currently required from: jolly. lynxis lazus has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email ) Change subject: Fix: Prevent race conditions when accessing slotmap in bankd ...................................................................... Patch Set 1: (2 comments) File src/bankd/bankd_main.c: https://gerrit.osmocom.org/c/osmo-remsim/+/42664/comment/2c053d85_bb75810f?… : PS1, Line 1115: slotmaps_rdlock(g_worker->bankd->slotmaps); write lock? File src/slotmap.h: https://gerrit.osmocom.org/c/osmo-remsim/+/42664/comment/50b0f742_03a4c965?… : PS1, Line 74: struct slot_mapping *slotmap_by_client(struct slotmaps *maps, const struct client_slot *client); maybe add a postfix to the functions: _lock and _nolock? -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3464726f37beb7c47b4e1f00c018ffa4f3948906 Gerrit-Change-Number: 42664 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 23 Apr 2026 12:28:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: Allow adding extra parameters to podman
by jolly 23 Apr '26

23 Apr '26

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42666?usp=email ) Change subject: testenv: Allow adding extra parameters to podman ...................................................................... testenv: Allow adding extra parameters to podman Allows to add additional command line parameters to podman, if defined int the testsuite section of testenv.cfg: [testsuite] ... podman_extra=--volume /dev/bus/usb:/dev/bus/usb Change-Id: I6a2be0d60efcd70ea2081e0314927885085bb5e0 --- M _testenv/README.md M _testenv/testenv/podman.py M _testenv/testenv/testenv_cfg.py 3 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/42666/1 diff --git a/_testenv/README.md b/_testenv/README.md index a973b25..f57ee0e 100644 --- a/_testenv/README.md +++ b/_testenv/README.md @@ -94,6 +94,11 @@ testsuite to avoid consuming the whole RAM and freezing (or possibly getting killed from an out-of-memory daemon). +* `podman_extra=`: optional value that can be set to add extra parameters to + podman. For example, it can be used to mount additional volume to pass- + through usb devices. Use spaces to seperate parameters, use quotes to include + spaces into patameters. + #### Component section * `program=`: executable for starting a test component, may contain arguments. diff --git a/_testenv/testenv/podman.py b/_testenv/testenv/podman.py index 79fc5b9..92dfeb4 100644 --- a/_testenv/testenv/podman.py +++ b/_testenv/testenv/podman.py @@ -266,6 +266,10 @@ dest = os.readlink(testenv.custom_kernel_path) cmd += ["--volume", f"{dest}:{dest}:ro"] + podman_extra = testenv.testenv_cfg.get_podman_extra_first_cfg() + if podman_extra: + cmd += shlex.split(podman_extra) + cmd += [ "--volume", f"{testdir_topdir}:{testdir_topdir}", diff --git a/_testenv/testenv/testenv_cfg.py b/_testenv/testenv/testenv_cfg.py index 9edc102..eb9e030 100644 --- a/_testenv/testenv/testenv_cfg.py +++ b/_testenv/testenv/testenv_cfg.py @@ -207,6 +207,11 @@ return testenv.args.jobs +def get_podman_extra_first_cfg(): + _, cfg = next(iter(cfgs.items())) + return cfg["testsuite"].get("podman_extra", None) + + def verify_qemu_cfgs(): """Check if passed -C or -K args make sense with the testenv configs.""" testsuite = testenv.args.testsuite @@ -255,6 +260,7 @@ "program", "titan_min", "max_jobs_per_gb_ram", + "podman_extra", ] keys_valid_component = [ "clean", -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a2be0d60efcd70ea2081e0314927885085bb5e0 Gerrit-Change-Number: 42666 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[XS] Change in osmo-remsim[master]: Fix: Prevent bankd from exiting upon SIGPIPE
by lynxis lazus 23 Apr '26

23 Apr '26

Attention is currently required from: jolly. lynxis lazus has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42665?usp=email ) Change subject: Fix: Prevent bankd from exiting upon SIGPIPE ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-remsim/+/42665/comment/7bb2d5c9_74a6ec34?… : PS1, Line 9: IF a client disconnects from a worker thread while the worker is type: IF -> If File src/bankd/bankd_main.c: https://gerrit.osmocom.org/c/osmo-remsim/+/42665/comment/956b4893_410dfb43?… : PS1, Line 568: /* do nothing */ Can you copy the comment of DO NOT LOG anything into here too? -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42665?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I13d6e9da48d12f93c00bd2d021789bde71aca7cf Gerrit-Change-Number: 42665 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 23 Apr 2026 12:11:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-remsim[master]: Fix: Prevent bankd from exiting upon SIGPIPE
by jolly 23 Apr '26

23 Apr '26

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42665?usp=email ) Change subject: Fix: Prevent bankd from exiting upon SIGPIPE ...................................................................... Fix: Prevent bankd from exiting upon SIGPIPE IF a client disconnects from a worker thread while the worker is responding to a to a request from that client, the socket is closed and SIGPIPE is sent to the worker, causing the application to exit. To prevent this, all workers have a dummy handler to prevent this. Now the worker can handle the closing of the socket. Change-Id: I13d6e9da48d12f93c00bd2d021789bde71aca7cf --- M src/bankd/bankd_main.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/65/42665/1 diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index c6b0f1c..204ee24 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -562,6 +562,12 @@ /* do nothing */ } +/* signal handler for receiving SIGPIPE from worker thread */ +static void handle_sig_pipe(int sig) +{ + /* do nothing */ +} + static void handle_sig_usr1(int sig) { OSMO_ASSERT(sig == SIGUSR1); @@ -1068,6 +1074,8 @@ g_worker->slot.bank_id = 0xffff; g_worker->slot.slot_nr = 0xffff; + signal(SIGPIPE, handle_sig_pipe); + /* we continuously perform the same loop here, recycling the worker thread * once the client connection is gone or we have some trouble with the card/reader */ while (1) { -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42665?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I13d6e9da48d12f93c00bd2d021789bde71aca7cf Gerrit-Change-Number: 42665 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[M] Change in osmo-remsim[master]: Fix: Prevent race conditions when accessing slotmap in bankd
by jolly 23 Apr '26

23 Apr '26

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email ) Change subject: Fix: Prevent race conditions when accessing slotmap in bankd ...................................................................... Fix: Prevent race conditions when accessing slotmap in bankd All threads (main and workers) can use slotmap_by_bank() and slotmap_by_client() to get a mapping entry from the slot map. While working with this entry (reading values), it could be deleted by a different thread. For example, if a client connects to a worker, the worker will check if there is an existing mapping between a reader and this client. If it exists, slotmap_by_client() will return a pointer. If the mapping is deleted at this time by the server, the worker uses a pointer to a mapping entry that has just been freed. Change-Id: I3464726f37beb7c47b4e1f00c018ffa4f3948906 --- M src/bankd/bankd_main.c M src/slotmap.c M src/slotmap.h 3 files changed, 46 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/64/42664/1 diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index 99a5949..c6b0f1c 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -162,7 +162,7 @@ { struct bank_slot bs = map->bank; - slotmap_del(g_bankd->slotmaps, map); + _slotmap_del(g_bankd->slotmaps, map); /* kill/reset the respective worker, if any! */ send_signal_to_worker(&bs, NULL, SIGMAPDEL); @@ -209,11 +209,13 @@ rspro2client_slot(&cs, &creq->client); /* check if slot map exists */ - map = slotmap_by_bank(g_bankd->slotmaps, &bs); + slotmaps_rdlock(g_bankd->slotmaps); + map = _slotmap_by_bank(g_bankd->slotmaps, &bs); if (map) { if (client_slot_equals(&map->client, &cs)) { LOGPFSML(srvc->fi, LOGL_ERROR, "ignoring identical slotmap\n"); resp = rspro_gen_CreateMappingRes(ResultCode_ok); + slotmaps_unlock(g_bankd->slotmaps); goto send_resp; } else { LOGPFSML(srvc->fi, LOGL_NOTICE, "slot already connected to client %d:%d. Removing old mapping.\n", @@ -221,6 +223,7 @@ bankd_srvc_remove_mapping(map); } } + slotmaps_unlock(g_bankd->slotmaps); /* check if client map exists */ map = slotmap_by_client(g_bankd->slotmaps, &cs); @@ -256,7 +259,8 @@ } else { rspro2bank_slot(&bs, &rreq->bank); /* Remove a mapping */ - map = slotmap_by_bank(g_bankd->slotmaps, &bs); + slotmaps_rdlock(g_bankd->slotmaps); + map = _slotmap_by_bank(g_bankd->slotmaps, &bs); if (!map) { LOGPFSML(srvc->fi, LOGL_ERROR, "B(%lu:%lu) could not find to-be-deleted slotmap\n", rreq->bank.bankId, rreq->bank.slotNr); resp = rspro_gen_RemoveMappingRes(ResultCode_unknownSlotmap); @@ -271,6 +275,7 @@ resp = rspro_gen_RemoveMappingRes(ResultCode_ok); } } + slotmaps_unlock(g_bankd->slotmaps); } server_conn_send_rspro(srvc, resp); break; @@ -700,8 +705,10 @@ { struct slot_mapping *slmap; - slmap = slotmap_by_client(worker->bankd->slotmaps, &worker->client.clslot); + slotmaps_rdlock(worker->bankd->slotmaps); + slmap = _slotmap_by_client(worker->bankd->slotmaps, &worker->client.clslot); if (!slmap) { + slotmaps_unlock(worker->bankd->slotmaps); LOGW(worker, "No slotmap (yet) for client C(%u:%u)\n", worker->client.clslot.client_id, worker->client.clslot.slot_nr); /* check in 10s if the map has been installed meanwhile by main thread */ @@ -712,6 +719,7 @@ slmap->client.client_id, slmap->client.slot_nr, slmap->bank.bank_id, slmap->bank.slot_nr); worker->slot = slmap->bank; + slotmaps_unlock(worker->bankd->slotmaps); worker_set_state_timeout(worker, BW_ST_CONN_CLIENT_MAPPED, 10); return worker_open_card(worker); } @@ -1104,13 +1112,15 @@ g_worker->client.fd = -1; if (g_worker->state >= BW_ST_CONN_CLIENT_MAPPED) { struct slot_mapping *slmap; - slmap = slotmap_by_client(g_worker->bankd->slotmaps, &g_worker->client.clslot); + slotmaps_rdlock(g_worker->bankd->slotmaps); + slmap = _slotmap_by_client(g_worker->bankd->slotmaps, &g_worker->client.clslot); if (slmap) { - slotmap_del(g_bankd->slotmaps, slmap); + _slotmap_del(g_bankd->slotmaps, slmap); g_worker->slot.bank_id = 0xffff; g_worker->slot.slot_nr = 0xffff; worker_set_state(g_worker, BW_ST_CONN_CLIENT_UNMAPPED, true); } + slotmaps_unlock(g_worker->bankd->slotmaps); } g_worker->client.clslot.client_id = g_worker->client.clslot.slot_nr = 0; } diff --git a/src/slotmap.c b/src/slotmap.c index b1be0ab..6e46a5a 100644 --- a/src/slotmap.c +++ b/src/slotmap.c @@ -53,20 +53,40 @@ return (map->bank.bank_id << 16) | map->bank.slot_nr; } +/* lookup of map by client:slot */ +struct slot_mapping *_slotmap_by_client(struct slotmaps *maps, const struct client_slot *client) +{ + struct slot_mapping *map; + + llist_for_each_entry(map, &maps->mappings, list) { + if (client_slot_equals(&map->client, client)) + return map; + } + return NULL; +} + /* thread-safe lookup of map by client:slot */ struct slot_mapping *slotmap_by_client(struct slotmaps *maps, const struct client_slot *client) { struct slot_mapping *map; slotmaps_rdlock(maps); - llist_for_each_entry(map, &maps->mappings, list) { - if (client_slot_equals(&map->client, client)) { - slotmaps_unlock(maps); - return map; - } - } + map = _slotmap_by_client(maps, client); slotmaps_unlock(maps); + return map; +} + +/* lookup of map by bank:slot */ +struct slot_mapping *_slotmap_by_bank(struct slotmaps *maps, const struct bank_slot *bank) +{ + struct slot_mapping *map; + + llist_for_each_entry(map, &maps->mappings, list) { + if (bank_slot_equals(&map->bank, bank)) + return map; + } return NULL; + } /* thread-safe lookup of map by bank:slot */ @@ -75,14 +95,9 @@ struct slot_mapping *map; slotmaps_rdlock(maps); - llist_for_each_entry(map, &maps->mappings, list) { - if (bank_slot_equals(&map->bank, bank)) { - slotmaps_unlock(maps); - return map; - } - } + map = _slotmap_by_bank(maps, bank); slotmaps_unlock(maps); - return NULL; + return map; } diff --git a/src/slotmap.h b/src/slotmap.h index 3d07c8d..6c78e4e 100644 --- a/src/slotmap.h +++ b/src/slotmap.h @@ -72,9 +72,11 @@ /* thread-safe lookup of map by client:slot */ struct slot_mapping *slotmap_by_client(struct slotmaps *maps, const struct client_slot *client); +struct slot_mapping *_slotmap_by_client(struct slotmaps *maps, const struct client_slot *client); /* thread-safe lookup of map by bank:slot */ struct slot_mapping *slotmap_by_bank(struct slotmaps *maps, const struct bank_slot *bank); +struct slot_mapping *_slotmap_by_bank(struct slotmaps *maps, const struct bank_slot *bank); /* thread-safe creating of a new bank<->client map */ struct slot_mapping *slotmap_add(struct slotmaps *maps, const struct bank_slot *bank, const struct client_slot *client); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3464726f37beb7c47b4e1f00c018ffa4f3948906 Gerrit-Change-Number: 42664 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[XS] Change in osmo-ccid-firmware[master]: tests/sysmo-octsim/run-tests: tempfile -> mktemp
by osmith 23 Apr '26

23 Apr '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42663?usp=email ) Change subject: tests/sysmo-octsim/run-tests: tempfile -> mktemp ...................................................................... tests/sysmo-octsim/run-tests: tempfile -> mktemp Fix for: WARNING: tempfile is deprecated; consider using mktemp instead. Change-Id: I785a81173aae7202e4c01ead0ced11142d2e1794 --- M tests/sysmo-octsim/run-tests 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/tests/sysmo-octsim/run-tests b/tests/sysmo-octsim/run-tests index f4d5162..e33e858 100755 --- a/tests/sysmo-octsim/run-tests +++ b/tests/sysmo-octsim/run-tests @@ -8,7 +8,7 @@ TESTS=$* fi -TMP=`tempfile` +TMP="$(mktemp)" NUM_FAIL=0 # prepare test card -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42663?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I785a81173aae7202e4c01ead0ced11142d2e1794 Gerrit-Change-Number: 42663 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: OBS: build_srcpkg.Dockerfile: add dh-cmake
by osmith 23 Apr '26

23 Apr '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42651?usp=email ) Change subject: OBS: build_srcpkg.Dockerfile: add dh-cmake ...................................................................... OBS: build_srcpkg.Dockerfile: add dh-cmake Add dh-cmake, so we can build source packages of programs using cmake, such as kamailio. Change-Id: I8b5debce4f2fc0c41c69f861822394e139ac5dfc --- M scripts/obs/data/build_srcpkg.Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/scripts/obs/data/build_srcpkg.Dockerfile b/scripts/obs/data/build_srcpkg.Dockerfile index c752d39..4193e67 100644 --- a/scripts/obs/data/build_srcpkg.Dockerfile +++ b/scripts/obs/data/build_srcpkg.Dockerfile @@ -14,6 +14,7 @@ colordiff \ debhelper \ default-libmysqlclient-dev \ + dh-cmake \ dh-python \ dh-virtualenv \ dpkg-dev \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42651?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8b5debce4f2fc0c41c69f861822394e139ac5dfc Gerrit-Change-Number: 42651 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/master-builds.yml: pysim: allow skipping card tests
by osmith 23 Apr '26

23 Apr '26

Attention is currently required from: dexter, fixeria, laforge, neels. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/42661?usp=email ) Change subject: jobs/master-builds.yml: pysim: allow skipping card tests ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File jobs/master-builds.yml: https://gerrit.osmocom.org/c/osmo-ci/+/42661/comment/ea164c90_399e55ca?usp=… : PS2, Line 653: {check_jenkins_mark} "skip-card-test" || {timeout_cmd} ./contrib/jenkins.sh > Good idea, applied, thanks! I didn't know about `GERRIT_PIPELINE_JOB_SKIPPED`. FYI I just came up with that, we still need to adjust the comment generating script to take that into account. but by printing such a message, we can do that in a follow-up patch (I could also look into it if you prefer). -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42661?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I591717a2e2659c02447087dec23aa279cfd55551 Gerrit-Change-Number: 42661 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Apr 2026 11:26:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026