April 2026 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: cosmetic: xua_asp_fsm: Fix wrong indentation
by pespin 01 Apr '26

01 Apr '26

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42572?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: cosmetic: xua_asp_fsm: Fix wrong indentation ...................................................................... cosmetic: xua_asp_fsm: Fix wrong indentation Change-Id: I21c13ff7bc67c060e739eae38088ac00700680de --- M src/xua_asp_fsm.c 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/72/42572/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42572?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I21c13ff7bc67c060e739eae38088ac00700680de Gerrit-Change-Number: 42572 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: xua_lm: Add S_INACTIVE state and improve state transitions
by pespin 01 Apr '26

01 Apr '26

Attention is currently required from: fixeria, laforge, osmith. Hello Jenkins Builder, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42571?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: xua_lm: Add S_INACTIVE state and improve state transitions ...................................................................... xua_lm: Add S_INACTIVE state and improve state transitions The S_INACTIVE state will be needed once we support administrative state block in role ASP/(active)IPSP. It is also useful now since sometimes we just want to leave an asp in that state without any timer running (eg. asps in override which are not active until the active one goes inactive). Adding the S_INACTIVE state also allows transitioning states in role SG, since we now have somewhere to go instead of leaving it alwas as S_IDLE. The S_INACTIVE state also allows staying in that state until the ASP ACT ACK is received, moment at which the ASP is considered ACTIVE according to specs. Change-Id: I7e6127c150e479d0c436875b41824b3061e4fa48 --- M src/xua_default_lm_fsm.c 1 file changed, 140 insertions(+), 34 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/71/42571/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42571?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I7e6127c150e479d0c436875b41824b3061e4fa48 Gerrit-Change-Number: 42571 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: xua_lm: Add S_INACTIVE state and improve state transitions
by pespin 01 Apr '26

01 Apr '26

Attention is currently required from: laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42571?usp=email ) Change subject: xua_lm: Add S_INACTIVE state and improve state transitions ...................................................................... Patch Set 1: (1 comment) File src/xua_default_lm_fsm.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42571/comment/15b99306_d9fef… : PS1, Line 296: acitvation > activation Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42571?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I7e6127c150e479d0c436875b41824b3061e4fa48 Gerrit-Change-Number: 42571 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 01 Apr 2026 12:30:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: m3ua: Introduce test TC_adm_block_after_act
by pespin 01 Apr '26

01 Apr '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42550?usp=email ) Change subject: stp: m3ua: Introduce test TC_adm_block_after_act ...................................................................... stp: m3ua: Introduce test TC_adm_block_after_act Related: libosmo-sigtran.git Change-Id If8e34cfb05b8b63173b8bb01a520c058daf1fe39 Related: OS#6752 Change-Id: I18672d228c1d15ef99039bccbb972e0b2496b545 --- M stp/STP_Tests_M3UA.ttcn M stp/expected-results.xml 2 files changed, 22 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index 3eed8d3..ca7dead 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -679,6 +679,26 @@ f_clear_m3ua(); } +/* Test administrative state, VTY "[no] block": Activate ASP, then block it; + * it should send an unsolicited ASPIA ACK */ +testcase TC_adm_block_after_act() runs on RAW_M3UA_CT { + var Misc_Helpers.ro_charstring asps := { "asp-sender" }; + var M3uaConfigs m3ua_configs := m3ua_build_configs(asps); + var OCT4 rctx_sender := int2oct(m3ua_configs[0].routing_ctx, 4); + f_init_m3ua(m3ua_configs := m3ua_configs); + + f_M3UA_asp_up_act(0, rctx := rctx_sender); + f_vty_cs7_asp_cmd(g_m3ua_configs[0], "block"); + f_M3UA_exp(0, tr_M3UA_ASPIA_ACK(rctx_sender)); + f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_PENDING, rctx_sender)); + f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_INACTIVE, rctx_sender)); + + f_vty_cs7_asp_cmd(g_m3ua_configs[0], "no block"); + f_M3UA_asp_act(0, c_M3UA_TMT_override, rctx_sender, ntfy_after_act := c_M3UA_ST_I_AS_ACTIVE); + + f_clear_m3ua(); +} + /* Test administrative state, VTY "[no] shutdown" */ testcase TC_m3ua_sctp_srv_adm_shutdown() runs on RAW_M3UA_CT { var Misc_Helpers.ro_charstring asps := { "asp-sender" }; @@ -1890,6 +1910,7 @@ execute( TC_tmt_broadcast() ); execute( TC_act_rctx_data_no_rctx() ); execute( TC_adm_block_act_err() ); + execute( TC_adm_block_after_act() ); execute( TC_m3ua_sctp_srv_adm_shutdown() ); execute( TC_combinedlset_loadshare() ); execute( TC_inaccessible_sp_duna() ); diff --git a/stp/expected-results.xml b/stp/expected-results.xml index c3f13a0..5d70fff 100644 --- a/stp/expected-results.xml +++ b/stp/expected-results.xml @@ -39,6 +39,7 @@ <testcase classname='STP_Tests_M3UA' name='TC_clnt_no_snm_inactive' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_clnt_quirk_snm_inactive' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_adm_block_act_err' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_adm_block_after_act' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_clnt_sctp_adm_shutdown' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_ssnm_aspac_dava_aspia_duna' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_ssnm_distribution_dava_duna' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42550?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18672d228c1d15ef99039bccbb972e0b2496b545 Gerrit-Change-Number: 42550 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: xua_lm: Add S_INACTIVE state and improve state transitions
by osmith 01 Apr '26

01 Apr '26

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42571?usp=email ) Change subject: xua_lm: Add S_INACTIVE state and improve state transitions ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/xua_default_lm_fsm.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42571/comment/ba49c2a5_53380… : PS1, Line 296: acitvation activation -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42571?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I7e6127c150e479d0c436875b41824b3061e4fa48 Gerrit-Change-Number: 42571 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Apr 2026 12:28:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: m3ua: Introduce test TC_adm_block_after_act
by fixeria 01 Apr '26

01 Apr '26

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42550?usp=email ) Change subject: stp: m3ua: Introduce test TC_adm_block_after_act ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42550?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18672d228c1d15ef99039bccbb972e0b2496b545 Gerrit-Change-Number: 42550 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Apr 2026 12:14:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: asp: Fix wrong variable logged in ss7_asp_xua_srv_conn_rx_cb()
by pespin 01 Apr '26

01 Apr '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42575?usp=email ) Change subject: asp: Fix wrong variable logged in ss7_asp_xua_srv_conn_rx_cb() ...................................................................... asp: Fix wrong variable logged in ss7_asp_xua_srv_conn_rx_cb() Change-Id: I24206a19fe57772caf8036464a2e1b6b8630fd7a --- M src/ss7_asp.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/75/42575/1 diff --git a/src/ss7_asp.c b/src/ss7_asp.c index 6efd9f4..c1739f3 100644 --- a/src/ss7_asp.c +++ b/src/ss7_asp.c @@ -1117,7 +1117,7 @@ flags = msgb_sctp_msg_flags(msg); LOGPASP(asp, DLSS7, LOGL_DEBUG, "%s(): sctp_recvmsg() returned %d (flags=0x%x)\n", - __func__, rc, flags); + __func__, res, flags); if (flags & OSMO_STREAM_SCTP_MSG_FLAGS_NOTIFICATION) { union sctp_notification *notif = (union sctp_notification *) msgb_data(msg); @@ -1318,7 +1318,7 @@ flags = msgb_sctp_msg_flags(msg); LOGPASP(asp, DLSS7, LOGL_DEBUG, "%s(): sctp_recvmsg() returned %d (flags=0x%x)\n", - __func__, msgb_length(msg), flags); + __func__, res, flags); if (flags & OSMO_STREAM_SCTP_MSG_FLAGS_NOTIFICATION) { union sctp_notification *notif = (union sctp_notification *) msgb_data(msg); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42575?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I24206a19fe57772caf8036464a2e1b6b8630fd7a Gerrit-Change-Number: 42575 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: Support administrative block in role ASP
by pespin 01 Apr '26

01 Apr '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42573?usp=email ) Change subject: Support administrative block in role ASP ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42573?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If32902575e874d2acc9a5fc12509af42ed151739 Gerrit-Change-Number: 42573 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 01 Apr 2026 12:07:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: m3ua: Introduce test TC_adm_block_after_act
by pespin 01 Apr '26

01 Apr '26

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42550?usp=email ) Change subject: stp: m3ua: Introduce test TC_adm_block_after_act ...................................................................... Patch Set 3: (1 comment) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42550/comment/16c1341b_3d8a… : PS2, Line 684: TC_adm_block_after_act > You're missing to add this one to the `control` section below. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42550?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18672d228c1d15ef99039bccbb972e0b2496b545 Gerrit-Change-Number: 42550 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Apr 2026 12:03:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: m3ua: Introduce test TC_adm_block_after_act
by pespin 01 Apr '26

01 Apr '26

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42550?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: stp: m3ua: Introduce test TC_adm_block_after_act ...................................................................... stp: m3ua: Introduce test TC_adm_block_after_act Related: libosmo-sigtran.git Change-Id If8e34cfb05b8b63173b8bb01a520c058daf1fe39 Related: OS#6752 Change-Id: I18672d228c1d15ef99039bccbb972e0b2496b545 --- M stp/STP_Tests_M3UA.ttcn M stp/expected-results.xml 2 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/50/42550/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42550?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18672d228c1d15ef99039bccbb972e0b2496b545 Gerrit-Change-Number: 42550 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026