Attention is currently required from: fixeria, osmith.
dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42658?usp=email )
Change subject: contrib/jenkins.sh: separate JOB_TYPE for card tests
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
Looks good to me. However, I would add a comment that makes clear that "card-test" is for everything that requires access to physical cards.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42658?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: If76d812ee43b7eb3b57fdc660c60bf31fbff5b16
Gerrit-Change-Number: 42658
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 23 Apr 2026 15:05:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/42660?usp=email )
Change subject: jobs/master-builds.yml: pysim: separate JOB_TYPE for card tests
......................................................................
Patch Set 1:
(1 comment)
File jobs/master-builds.yml:
https://gerrit.osmocom.org/c/osmo-ci/+/42660/comment/660104f2_02828879?usp=… :
PS1, Line 645: (JOB_TYPE == "crad-test" && label == "simtester") ||
> I am a bit lost here. Don't we also have to touch jenkins. […]
See the related commit (`Depends: ...`).
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42660?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ia48d1b468f65d7c2e6b4128eeac36d0f3d03c45e
Gerrit-Change-Number: 42660
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 23 Apr 2026 14:50:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: fixeria.
dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/42660?usp=email )
Change subject: jobs/master-builds.yml: pysim: separate JOB_TYPE for card tests
......................................................................
Patch Set 1:
(1 comment)
File jobs/master-builds.yml:
https://gerrit.osmocom.org/c/osmo-ci/+/42660/comment/083f1f9b_1335caf1?usp=… :
PS1, Line 645: (JOB_TYPE == "crad-test" && label == "simtester") ||
I am a bit lost here. Don't we also have to touch jenkins.sh and add a case "card-test" in which we then would move the related lines?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42660?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ia48d1b468f65d7c2e6b4128eeac36d0f3d03c45e
Gerrit-Change-Number: 42660
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 23 Apr 2026 14:49:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: osmith.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42666?usp=email )
Change subject: testenv: Allow adding extra parameters to podman
......................................................................
Patch Set 2:
(2 comments)
File _testenv/README.md:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42666/comment/5a844806_23b2… :
PS1, Line 98: podman. For example, it can be used to mount additional volume to pass-
> ```suggestion […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42666/comment/6a394873_f0a3… :
PS1, Line 100: spaces into patameters.
> ```suggestion […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42666?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6a2be0d60efcd70ea2081e0314927885085bb5e0
Gerrit-Change-Number: 42666
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 23 Apr 2026 14:08:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: jolly.
Hello Jenkins Builder, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42666?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: testenv: Allow adding extra parameters to podman
......................................................................
testenv: Allow adding extra parameters to podman
Allows to add additional command line parameters to podman, if defined
int the testsuite section of testenv.cfg:
[testsuite]
...
podman_extra=--volume /dev/bus/usb:/dev/bus/usb
Change-Id: I6a2be0d60efcd70ea2081e0314927885085bb5e0
---
M _testenv/README.md
M _testenv/testenv/podman.py
M _testenv/testenv/testenv_cfg.py
3 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/42666/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42666?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6a2be0d60efcd70ea2081e0314927885085bb5e0
Gerrit-Change-Number: 42666
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>