Attention is currently required from: fixeria, osmith.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42658?usp=email )
Change subject: contrib/jenkins.sh: separate JOB_TYPE for card tests
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42658?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: If76d812ee43b7eb3b57fdc660c60bf31fbff5b16
Gerrit-Change-Number: 42658
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 23 Apr 2026 11:22:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: dexter, laforge, neels, osmith.
Hello Jenkins Builder, dexter, laforge, neels, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ci/+/42661?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: jobs/master-builds.yml: pysim: allow skipping card tests
......................................................................
jobs/master-builds.yml: pysim: allow skipping card tests
Skip tests requiring physical cards ("card-test") for commits
having a special marker in the COMMIT_MSG:
Jenkins: skip-card-tests
This speeds up the build verification significantly, and may be
useful for patches that do not modify the core logic (such as
documentation improvements and misc fixes).
Change-Id: I591717a2e2659c02447087dec23aa279cfd55551
---
M jobs/master-builds.yml
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/61/42661/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42661?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I591717a2e2659c02447087dec23aa279cfd55551
Gerrit-Change-Number: 42661
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: fixeria.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/42661?usp=email )
Change subject: jobs/master-builds.yml: pysim: allow skipping card tests
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Patchset:
PS2:
I think this is a good approach. In theory we could run another job on a more generic node first that checks if the job can be skipped, and then skip it in the pipeline... but that would make the pipeline longer and would be a lot more complex.
File jobs/master-builds.yml:
https://gerrit.osmocom.org/c/osmo-ci/+/42661/comment/48c63243_f6578481?usp=… :
PS2, Line 653: {check_jenkins_mark} "skip-card-test" || {timeout_cmd} ./contrib/jenkins.sh
We could print a specific string here when skipping the job. This could then be used in the script that generates the jenkins job to show that the job was skipped instead of linking to the log, so it is more obvious:
https://gitea.osmocom.org/osmocom/osmo-ci/src/branch/master/scripts/jenkins…
```suggestion
if {check_jenkins_mark} "skip-card-test"; then
echo "GERRIT_PIPELINE_JOB_SKIPPED"
else
{timeout_cmd} ./contrib/jenkins.sh
fi
```
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42661?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I591717a2e2659c02447087dec23aa279cfd55551
Gerrit-Change-Number: 42661
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 23 Apr 2026 10:44:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes