gerrit-log April 2026

gerrit-log@lists.osmocom.org

1 participants
515 discussions

[S] Change in libosmo-sigtran[master]: xua_lm: Use XLM SAP to send M-ASP_{UP, ACTIVE}.req
by fixeria 01 Apr '26

01 Apr '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42562?usp=email ) Change subject: xua_lm: Use XLM SAP to send M-ASP_{UP, ACTIVE}.req ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I5850d9ec9092ff3d099627856697a4184b0d5853 Gerrit-Change-Number: 42562 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Apr 2026 08:28:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[master]: Move xUA<->LM SAP logic to its own file
by fixeria 01 Apr '26

01 Apr '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42561?usp=email ) Change subject: Move xUA<->LM SAP logic to its own file ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/xua_lm_sap.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42561/comment/35bdbca8_11443… : PS1, Line 57: xua_xlm_prim_alloc_m_rk_reg_req cosmetic: spacing issues here and below -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42561?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I93d74dd7f6ea8f2e60a8bc41be15362e433e8962 Gerrit-Change-Number: 42561 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Apr 2026 08:26:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: xua asp block: SG: turn asp inactive when administratively blocked
by fixeria 01 Apr '26

01 Apr '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42559?usp=email ) Change subject: xua asp block: SG: turn asp inactive when administratively blocked ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/xua_asp_fsm.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42559/comment/11681356_5060d… : PS2, Line 937: case XUA_ASP_E_ADM_BLOCKED: cosmetic: shift inner code to the left -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42559?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If8e34cfb05b8b63173b8bb01a520c058daf1fe39 Gerrit-Change-Number: 42559 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Apr 2026 08:22:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: xua asp block: SGP/IPSP: Answer ASPAC with Err if blocked
by fixeria 01 Apr '26

01 Apr '26

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42549?usp=email ) Change subject: xua asp block: SGP/IPSP: Answer ASPAC with Err if blocked ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/ss7_asp_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42549/comment/1941ae5c_531a2… : PS3, Line 733: ss7_asp_set_blocked(asp, false); Don't you need to check `asp->cfg.proto` and `asp->cfg.role` here, like you do above? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42549?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I23851fe05c06b6bf59b902632029a2382231427e Gerrit-Change-Number: 42549 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Apr 2026 08:19:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: Use osmo_ss7_asp_active() in several places
by pespin 01 Apr '26

01 Apr '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42570?usp=email ) Change subject: Use osmo_ss7_asp_active() in several places ...................................................................... Use osmo_ss7_asp_active() in several places Change-Id: I172e691cb61ac68e2410b44e124737f7a4dd2775 --- M src/m3ua.c M src/sua.c M src/xua_as_fsm.c M src/xua_rkm.c 4 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/70/42570/1 diff --git a/src/m3ua.c b/src/m3ua.c index a22a64a..243f5b9 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -1166,7 +1166,7 @@ int rc; /* SNM only permitted in ACTIVE state */ - if (asp->fi->state != XUA_ASP_S_ACTIVE) { + if (!osmo_ss7_asp_active(asp)) { if (asp->fi->state == XUA_ASP_S_INACTIVE && asp->cfg.quirks & OSMO_SS7_ASP_QUIRK_SNM_INACTIVE) { LOGPASP(asp, DLM3UA, LOGL_NOTICE, "quirk snm_inactive active: " diff --git a/src/sua.c b/src/sua.c index 9ebe4c6..b169d50 100644 --- a/src/sua.c +++ b/src/sua.c @@ -1113,7 +1113,7 @@ static int sua_rx_snm(struct osmo_ss7_asp *asp, struct xua_msg *xua) { /* SNM only permitted in ACTIVE state */ - if (asp->fi->state != XUA_ASP_S_ACTIVE) { + if (!osmo_ss7_asp_active(asp)) { if (asp->fi->state == XUA_ASP_S_INACTIVE && asp->cfg.quirks & OSMO_SS7_ASP_QUIRK_SNM_INACTIVE) { LOGPASP(asp, DLSUA, LOGL_NOTICE, "quirk snm_inactive active: " "Accepting SSNM in state %s\n", osmo_fsm_inst_state_name(asp->fi)); diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c index 568834e..0ba1b2a 100644 --- a/src/xua_as_fsm.c +++ b/src/xua_as_fsm.c @@ -296,7 +296,7 @@ if (asp_cmp == asp) continue; - if (asp->fi && asp->fi->state == XUA_ASP_S_ACTIVE) + if (osmo_ss7_asp_active(asp)) return true; } diff --git a/src/xua_rkm.c b/src/xua_rkm.c index 16b494b..92fbdac 100644 --- a/src/xua_rkm.c +++ b/src/xua_rkm.c @@ -420,7 +420,7 @@ } /* Reject if ASP is still active */ - if (asp->fi->state == XUA_ASP_S_ACTIVE) { + if (osmo_ss7_asp_active(asp)) { msgb_append_dereg_res(resp, M3UA_RKM_DEREG_ERR_ASP_ACTIVE, 0); return -1; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42570?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I172e691cb61ac68e2410b44e124737f7a4dd2775 Gerrit-Change-Number: 42570 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

Jump to page:

2026

2025

2024

2023

2022

gerrit-log April 2026