April 2026 - gerrit-log - lists.osmocom.org

[L] Change in osmo-trx[master]: transceiver: add optional WebSDR device support
by Jenkins Builder 23 Apr '26

23 Apr '26

Attention is currently required from: Hoernchen, Timur Davydov, fixeria, laforge. Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email ) Change subject: transceiver: add optional WebSDR device support ...................................................................... Patch Set 11: (11 comments) File Transceiver52M/Transceiver.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/7be84dd2_4b7b4256?usp… : PS11, Line 246: int driveReceiveRadioShortVector(std::vector<short *> &bufs, int samples, int underrun, please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/ad6f1cf1_2a43d50a?usp… : PS11, Line 247: TIMESTAMP ts, unsigned samples_skipped); code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/6490d26d_2fdfc393?usp… : PS11, Line 249: bool driveReceiveRadio(unsigned samples_skipped = 0); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/154f877d_18ca04cc?usp… : PS11, Line 265: ssize_t driveReceiveFIFOBurst(size_t chan, char *burstBuffer, size_t burstBufferLen); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/27e75fb5_2381d280?usp… : PS11, Line 271: @brief modulation and sorting of GSM bursts from GSM core please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/05a7b7d7_003cd68e?usp… : PS11, Line 272: @param chan channel number please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/ec6d0c28_accd2d3e?usp… : PS11, Line 273: @param burstBuffer optional buffer containing burst to transmit, if not provided, will read from data socket please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/b4a3ce2f_6030f422?usp… : PS11, Line 274: @param burstBufferLen optional length of burst buffer, if not provided, will read from data socket please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/9ddc552b_c912611e?usp… : PS11, Line 277: bool driveTxPriorityQueue(size_t chan, char *burstBuffer = nullptr, size_t burstBufferLen = 0); please, no spaces at the start of a line File Transceiver52M/radioInterface.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/b2d4e71f_c2b83d93?usp… : PS11, Line 118: int driveReceiveRadio(unsigned samples_skipped = 0); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/f58043e6_c932342c?usp… : PS11, Line 137: int fillPullBuffer(std::vector<short *> &bufs, size_t samples, int recvunderrun, TIMESTAMP ts); please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d Gerrit-Change-Number: 42411 Gerrit-PatchSet: 11 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 22 Apr 2026 22:22:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-trx[master]: convolve: avoid function pointer casts by adding wrapper functions
by Timur Davydov 23 Apr '26

23 Apr '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/42655?usp=email ) Change subject: convolve: avoid function pointer casts by adding wrapper functions ...................................................................... convolve: avoid function pointer casts by adding wrapper functions Introduce _base_convolve_*_void() wrappers matching the expected function pointer signatures and use them instead of casting _base_convolve_* functions to (void *). This removes unsafe function pointer casts and improves type safety, which is required for stricter toolchains and non-native targets (e.g. WebAssembly) Change-Id: Idecb118be285eb3e4691d1761d0d8fa24fd80c75 --- M Transceiver52M/arch/x86/convolve.c 1 file changed, 27 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/55/42655/1 diff --git a/Transceiver52M/arch/x86/convolve.c b/Transceiver52M/arch/x86/convolve.c index 45a3719..aeec39d 100644 --- a/Transceiver52M/arch/x86/convolve.c +++ b/Transceiver52M/arch/x86/convolve.c @@ -62,19 +62,36 @@ int bounds_check(int x_len, int h_len, int y_len, int start, int len); +void _base_convolve_complex_void(const float *x, int x_len, + const float *h, int h_len, + float *y, int y_len, + int start, int len) +{ + _base_convolve_complex(x, x_len, h, h_len, y, y_len, start, len); +} + +void _base_convolve_real_void(const float *x, int x_len, + const float *h, int h_len, + float *y, int y_len, + int start, int len) +{ + _base_convolve_real(x, x_len, h, h_len, y, y_len, start, len); +} + + /* API: Initialize convolve module */ void convolve_init(void) { - c.conv_cmplx_4n = (void *)_base_convolve_complex; - c.conv_cmplx_8n = (void *)_base_convolve_complex; - c.conv_cmplx = (void *)_base_convolve_complex; - c.conv_real4 = (void *)_base_convolve_real; - c.conv_real8 = (void *)_base_convolve_real; - c.conv_real12 = (void *)_base_convolve_real; - c.conv_real16 = (void *)_base_convolve_real; - c.conv_real20 = (void *)_base_convolve_real; - c.conv_real4n = (void *)_base_convolve_real; - c.conv_real = (void *)_base_convolve_real; + c.conv_cmplx_4n = _base_convolve_complex_void; + c.conv_cmplx_8n = _base_convolve_complex_void; + c.conv_cmplx = _base_convolve_complex_void; + c.conv_real4 = _base_convolve_real_void; + c.conv_real8 = _base_convolve_real_void; + c.conv_real12 = _base_convolve_real_void; + c.conv_real16 = _base_convolve_real_void; + c.conv_real20 = _base_convolve_real_void; + c.conv_real4n = _base_convolve_real_void; + c.conv_real = _base_convolve_real_void; #if defined(HAVE_SSE3) && defined(HAVE___BUILTIN_CPU_SUPPORTS) if (__builtin_cpu_supports("sse3")) { -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42655?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Idecb118be285eb3e4691d1761d0d8fa24fd80c75 Gerrit-Change-Number: 42655 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[L] Change in osmo-trx[master]: device: add WebSDR radio backend
by Timur Davydov 23 Apr '26

23 Apr '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/42656?usp=email ) Change subject: device: add WebSDR radio backend ...................................................................... device: add WebSDR radio backend Introduce a new optional WebSDR device backend, enabled via --with-websdr. Add WebSDRDevice implementation and build integration, providing a RadioDevice interface backed by callback hooks for control and sample I/O. Intended for Web-based deployments where osmo-trx interacts with SDR hardware via a WebSDR/WebUSB frontend. Change-Id: Ie459cbd70388dd8ff5b89221d30770bab0bd9014 --- M Transceiver52M/device/Makefile.am A Transceiver52M/device/websdr/Makefile.am A Transceiver52M/device/websdr/WebSDRDevice.cpp A Transceiver52M/device/websdr/WebSDRDevice.h M configure.ac 5 files changed, 352 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/56/42656/1 diff --git a/Transceiver52M/device/Makefile.am b/Transceiver52M/device/Makefile.am index b5a5cec..62a013e 100644 --- a/Transceiver52M/device/Makefile.am +++ b/Transceiver52M/device/Makefile.am @@ -21,3 +21,7 @@ if DEVICE_BLADE SUBDIRS += bladerf endif + +if DEVICE_WEBSDR +SUBDIRS += websdr +endif diff --git a/Transceiver52M/device/websdr/Makefile.am b/Transceiver52M/device/websdr/Makefile.am new file mode 100644 index 0000000..86e4a4d --- /dev/null +++ b/Transceiver52M/device/websdr/Makefile.am @@ -0,0 +1,11 @@ +include $(top_srcdir)/Makefile.common + +AM_CPPFLAGS = -Wall $(STD_DEFINES_AND_INCLUDES) -I${srcdir}/../common +AM_CXXFLAGS = $(LIBOSMOCORE_CFLAGS) + +noinst_HEADERS = WebSDRDevice.h + +noinst_LTLIBRARIES = libdevice.la + +libdevice_la_SOURCES = WebSDRDevice.cpp +libdevice_la_LIBADD = $(top_builddir)/Transceiver52M/device/common/libdevice_common.la diff --git a/Transceiver52M/device/websdr/WebSDRDevice.cpp b/Transceiver52M/device/websdr/WebSDRDevice.cpp new file mode 100644 index 0000000..ebb97b4 --- /dev/null +++ b/Transceiver52M/device/websdr/WebSDRDevice.cpp @@ -0,0 +1,237 @@ +/* +* Copyright 2026 Wavelet Lab <info(a)wavelet-lab.com> +* +* SPDX-License-Identifier: AGPL-3.0+ +* +* This software is distributed under the terms of the GNU Affero Public License. +* See the COPYING file in the main directory for details. +* +* This use of this software may be subject to additional restrictions. +* See the LEGAL file in the main directory for details. + + This program is free software: you can redistribute it and/or modify + it under the terms of the GNU Affero General Public License as published by + the Free Software Foundation, either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU Affero General Public License for more details. + + You should have received a copy of the GNU Affero General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. + +*/ + +#include <stdint.h> +#include <string.h> +#include <stdlib.h> +#include "Logger.h" +#include "Threads.h" +#include "WebSDRDevice.h" + +#ifdef HAVE_CONFIG_H +#include "config.h" +#endif /* HAVE_CONFIG_H */ + +using namespace std; + +extern uint8_t g_tx_buffer[10000]; +extern uint32_t g_tx_ts; +extern uint32_t g_tx_len; + +#ifdef __EMSCRIPTEN__ + +#include <emscripten.h> + +EM_JS(bool, on_start_wrapper, (), { + return on_start(); +}); + +EM_JS(bool, on_stop_wrapper, (), { + return on_stop(); +}); + +EM_JS(bool, on_set_rx_frequency_wrapper, (unsigned frequency), { + return on_set_rx_frequency(frequency); +}); + +EM_JS(bool, on_set_tx_frequency_wrapper, (unsigned frequency), { + return on_set_tx_frequency(frequency); +}); + +EM_JS(void, write_log_wrapper, (const char *msg), { + write_log(msg); +}); + +EM_JS(int, on_write_samples_wrapper, (short* msg, int samples, uint64_t timestamp), { + return on_write_samples(msg, samples, timestamp); +}); + +#else /* __EMSCRIPTEN__ */ + +extern "C" { +bool on_start(); +bool on_stop(); +bool on_set_rx_frequency(unsigned frequency); +bool on_set_tx_frequency(unsigned frequency); +int on_write_samples(short* msg, int samples, uint64_t timestamp); + +static bool on_start_wrapper() { return on_start(); } +static bool on_stop_wrapper() { return on_stop(); } +static bool on_set_rx_frequency_wrapper(unsigned frequency) { return on_set_rx_frequency(frequency); } +static bool on_set_tx_frequency_wrapper(unsigned frequency) { return on_set_tx_frequency(frequency); } +static int on_write_samples_wrapper(short* msg, int samples, uint64_t timestamp) { return on_write_samples(msg, samples, timestamp); } +} + +#endif /* __EMSCRIPTEN__ */ + +WebSDRDevice::WebSDRDevice(InterfaceType iface, const struct trx_cfg *cfg) : + RadioDevice(iface, cfg) +{ + rx_gains.resize(chans); + tx_gains.resize(chans); + + rx_freqs.resize(chans); + tx_freqs.resize(chans); +} + +int WebSDRDevice::open() +{ + return NORMAL; +} + +bool WebSDRDevice::start() +{ + return on_start_wrapper(); +} + +bool WebSDRDevice::stop() +{ + return on_stop_wrapper(); +} + +int WebSDRDevice::readSamples(std::vector<short *> &bufs, int len, bool *overrun, + TIMESTAMP timestamp, bool *underrun) +{ + return 0; +} + +int WebSDRDevice::writeSamples(std::vector<short *> &bufs, int len, + bool *underrun, unsigned long long timestamp) +{ + memcpy(g_tx_buffer, bufs[0], 2 * len * sizeof(int16_t)); + g_tx_ts = timestamp; + g_tx_len = len; + return len; +} + +bool WebSDRDevice::setTxFreq(double wFreq, size_t chan) { + const bool res = on_set_tx_frequency_wrapper(static_cast<unsigned>(wFreq)); + if (res) + tx_freqs[chan] = wFreq; + + return res; +} + +bool WebSDRDevice::setRxFreq(double wFreq, size_t chan) { + const bool res = on_set_rx_frequency_wrapper(static_cast<unsigned>(wFreq)); + if (res) + rx_freqs[chan] = wFreq; + + return res; +} + +double WebSDRDevice::setRxGain(double dB, size_t chan) +{ + rx_gains[chan] = dB; + return dB; +} + +double WebSDRDevice::getRxGain(size_t chan) +{ + return rx_gains[chan]; +} + +double WebSDRDevice::maxRxGain() +{ + return 0; +} + +double WebSDRDevice::minRxGain() +{ + return 0; +} + +int WebSDRDevice::getNominalTxPower(size_t chan) +{ + return 0; +} + +bool WebSDRDevice::setRxAntenna(const std::string &ant, size_t chan) +{ + rx_paths[chan] = ant; + return true; +} + +std::string WebSDRDevice::getRxAntenna(size_t chan) +{ + return rx_paths[chan]; +} + +bool WebSDRDevice::setTxAntenna(const std::string &ant, size_t chan) +{ + tx_paths[chan] = ant; + return true; +} + +std::string WebSDRDevice::getTxAntenna(size_t chan) +{ + return tx_paths[chan]; +} + +GSM::Time WebSDRDevice::minLatency() { + return GSM::Time(1,1); +} + +double WebSDRDevice::getTxFreq(size_t chan) { + return tx_freqs[chan]; +} + +double WebSDRDevice::getRxFreq(size_t chan) { + return rx_freqs[chan]; +} + +double WebSDRDevice::setPowerAttenuation(int atten, size_t chan) { + tx_gains[chan] = atten; + return atten; +} + +double WebSDRDevice::getPowerAttenuation(size_t chan) { + return tx_gains[chan]; +} + +double WebSDRDevice::maxTxGain() +{ + return 0; +} + +double WebSDRDevice::minTxGain() +{ + return 0; +} + +RadioDevice *RadioDevice::make(InterfaceType iface, const struct trx_cfg *cfg) +{ + if (cfg->tx_sps != cfg->rx_sps) { + return NULL; + } + if (cfg->num_chans != 1) { + return NULL; + } + if (cfg->offset != 0.0) { + return NULL; + } + return new WebSDRDevice(iface, cfg); +} diff --git a/Transceiver52M/device/websdr/WebSDRDevice.h b/Transceiver52M/device/websdr/WebSDRDevice.h new file mode 100644 index 0000000..b4e0c04 --- /dev/null +++ b/Transceiver52M/device/websdr/WebSDRDevice.h @@ -0,0 +1,98 @@ +/* +* Copyright 2026 Wavelet Lab <info(a)wavelet-lab.com> +* +* SPDX-License-Identifier: AGPL-3.0+ +* +* This software is distributed under multiple licenses; see the COPYING file in +* the main directory for licensing information for this specific distribution. +* +* This use of this software may be subject to additional restrictions. +* See the LEGAL file in the main directory for details. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. +* +*/ + +#ifndef _WEBSDR_DEVICE_H_ +#define _WEBSDR_DEVICE_H_ + +#ifdef HAVE_CONFIG_H +#include "config.h" +#endif + +#include "radioDevice.h" + +#include <sys/time.h> +#include <math.h> +#include <string> +#include <iostream> + + +/** A class to handle a WebSDR device */ +class WebSDRDevice: public RadioDevice { +public: + + WebSDRDevice(InterfaceType iface, const struct trx_cfg *cfg); + + int open(); + bool start(); + bool stop(); + + enum TxWindowType getWindowType() { return TX_WINDOW_FIXED; } + + int readSamples(std::vector<short *> &buf, int len, bool *overrun, + TIMESTAMP timestamp = 0xffffffff, bool *underrun = NULL); + int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, + TIMESTAMP timestamp = 0xffffffff); + + bool updateAlignment(TIMESTAMP timestamp) { return true; } + + bool setTxFreq(double wFreq, size_t chan = 0); + bool setRxFreq(double wFreq, size_t chan = 0); + + TIMESTAMP initialWriteTimestamp(void) { return 0; } + TIMESTAMP initialReadTimestamp(void) { return 0; } + + double fullScaleInputValue() { return 32767.0 * 0.7071; } + double fullScaleOutputValue() { return 32767.0; } + + double setRxGain(double dB, size_t chan = 0); + double getRxGain(size_t chan = 0); + double maxRxGain(void); + double minRxGain(void); + double rssiOffset(size_t chan) { return 0.0f; } + + int getNominalTxPower(size_t chan = 0); + + bool setRxAntenna(const std::string &ant, size_t chan = 0); + std::string getRxAntenna(size_t chan = 0); + + bool setTxAntenna(const std::string &ant, size_t chan = 0); + std::string getTxAntenna(size_t chan = 0); + + bool requiresRadioAlign() { return false; } + + GSM::Time minLatency(); + + double getTxFreq(size_t chan = 0); + double getRxFreq(size_t chan = 0); + + double getSampleRate() { return 0; } + + double setPowerAttenuation(int atten, size_t chan); + double getPowerAttenuation(size_t chan=0); + double maxTxGain(void); + double minTxGain(void); + +private: + /* Cached TX/RX gains */ + std::vector<double> tx_gains, rx_gains; + + /* Cached TX/RX frequencies */ + std::vector<double> tx_freqs, rx_freqs; + +}; + +#endif // _WEBSDR_DEVICE_H_ diff --git a/configure.ac b/configure.ac index bf3bc5e..b0d79a9 100644 --- a/configure.ac +++ b/configure.ac @@ -310,6 +310,7 @@ AM_CONDITIONAL(DEVICE_LMS, [test "x$with_lms" = "xyes"]) AM_CONDITIONAL(DEVICE_IPC, [test "x$with_ipc" = "xyes"]) AM_CONDITIONAL(DEVICE_BLADE, [test "x$with_bladerf" = "xyes"]) +AM_CONDITIONAL(DEVICE_WEBSDR, [test "x$with_websdr" = "xyes"]) AM_CONDITIONAL(ARCH_ARM, [test "x$with_neon" = "xyes" || test "x$with_neon_vfpv4" = "xyes"]) AM_CONDITIONAL(ARCH_ARM_A15, [test "x$with_neon_vfpv4" = "xyes"]) AM_CONDITIONAL(ENABLE_MS_TRX, [test "x$with_mstrx" = "xyes"]) @@ -411,6 +412,7 @@ Transceiver52M/device/lms/Makefile \ Transceiver52M/device/ipc/Makefile \ Transceiver52M/device/bladerf/Makefile \ + Transceiver52M/device/websdr/Makefile \ tests/Makefile \ tests/CommonLibs/Makefile \ tests/Transceiver52M/Makefile \ -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42656?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie459cbd70388dd8ff5b89221d30770bab0bd9014 Gerrit-Change-Number: 42656 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[L] Change in osmo-trx[master]: transceiver: add optional WebSDR device support
by Timur Davydov 23 Apr '26

23 Apr '26

Attention is currently required from: Hoernchen, Timur Davydov, fixeria, laforge. Hello Hoernchen, Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: transceiver: add optional WebSDR device support ...................................................................... transceiver: add optional WebSDR device support - Add support for WebSDR devices enabled via the --with-websdr configure flag. - add libosmo-trx-websdr library and pkg-config file - update .gitignore for wasm and pkg-config artifacts Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d --- M .gitignore M Transceiver52M/Makefile.am M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h A Transceiver52M/libosmo-trx-websdr.pc.in A Transceiver52M/osmo-trx-websdr.cpp A Transceiver52M/osmo-trx-websdr.h M Transceiver52M/osmo-trx.cpp M Transceiver52M/radioInterface.cpp M Transceiver52M/radioInterface.h M configure.ac 11 files changed, 525 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/11/42411/11 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d Gerrit-Change-Number: 42411 Gerrit-PatchSet: 11 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in osmo-trx[master]: build: detect pthread_setname_np and sched_* APIs, guard usage
by Timur Davydov 23 Apr '26

23 Apr '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/42654?usp=email ) Change subject: build: detect pthread_setname_np and sched_* APIs, guard usage ...................................................................... build: detect pthread_setname_np and sched_* APIs, guard usage Add configure checks for pthread_setname_np and sched_* functions. Wrap their usage with HAVE_* guards to avoid build failures on platforms where they are unavailable. Return -ENOTSUP for unsupported scheduler operations. Improves portability across non-Linux and restricted environments (e.g. WebAssembly). Change-Id: Ic3f1492544439d88c5e6683330c6696de1c2f85b --- M CommonLibs/Threads.cpp M Transceiver52M/device/ipc/ipc-driver-test.c M Transceiver52M/ms/threadsched.cpp M Transceiver52M/ms/uhd_specific.h M Transceiver52M/osmo-trx.cpp M configure.ac 6 files changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/54/42654/1 diff --git a/CommonLibs/Threads.cpp b/CommonLibs/Threads.cpp index 91e78d7..b61a029 100644 --- a/CommonLibs/Threads.cpp +++ b/CommonLibs/Threads.cpp @@ -47,6 +47,7 @@ void set_selfthread_name(const char *name) { +#ifdef HAVE_PTHREAD_SETNAME_NP pthread_t selfid = pthread_self(); pid_t tid = osmo_gettid(); if (pthread_setname_np(selfid, name) == 0) { @@ -57,6 +58,7 @@ LOG(NOTICE) << "Thread "<< selfid << " (task " << tid << ") set name \"" << name << "\" failed: (" << err << ") " << strerror_buf(err, err_buf, sizeof(err_buf)); } +#endif /* HAVE_PTHREAD_SETNAME_NP */ } void thread_enable_cancel(bool cancel) diff --git a/Transceiver52M/device/ipc/ipc-driver-test.c b/Transceiver52M/device/ipc/ipc-driver-test.c index d8284c7..22395ce 100644 --- a/Transceiver52M/device/ipc/ipc-driver-test.c +++ b/Transceiver52M/device/ipc/ipc-driver-test.c @@ -256,7 +256,9 @@ { uint32_t chann = decoded_region->num_chans; ul_running = true; +#ifdef HAVE_PTHREAD_SETNAME_NP pthread_setname_np(pthread_self(), "uplink_rx"); +#endif /* HAVE_PTHREAD_SETNAME_NP */ while (!ipc_exit_requested) { int32_t read = uhdwrap_read(global_dev, chann); @@ -270,7 +272,9 @@ { int chann = decoded_region->num_chans; dl_running = true; +#ifdef HAVE_PTHREAD_SETNAME_NP pthread_setname_np(pthread_self(), "downlink_tx"); +#endif /* HAVE_PTHREAD_SETNAME_NP */ while (!ipc_exit_requested) { bool underrun; diff --git a/Transceiver52M/ms/threadsched.cpp b/Transceiver52M/ms/threadsched.cpp index ba5cae7..fbca3a8 100644 --- a/Transceiver52M/ms/threadsched.cpp +++ b/Transceiver52M/ms/threadsched.cpp @@ -40,7 +40,9 @@ void set_name_aff_sched(std::thread::native_handle_type h, const char *name, int cpunum, int schedtype, int prio) { +#ifdef HAVE_PTHREAD_SETNAME_NP pthread_setname_np(h, name); +#endif /* HAVE_PTHREAD_SETNAME_NP */ cpu_set_t cpuset; @@ -79,7 +81,9 @@ if (a) std::cerr << "thread arg rc:" << a << std::endl; pthread_create(&thread, &attr, fun, arg); +#ifdef HAVE_PTHREAD_SETNAME_NP pthread_setname_np(thread, name); +#endif /* HAVE_PTHREAD_SETNAME_NP */ pthread_attr_destroy(&attr); return thread; } diff --git a/Transceiver52M/ms/uhd_specific.h b/Transceiver52M/ms/uhd_specific.h index 151c002..4f1f789 100644 --- a/Transceiver52M/ms/uhd_specific.h +++ b/Transceiver52M/ms/uhd_specific.h @@ -235,7 +235,9 @@ static auto rx_burst_cap_this = this; static auto rx_burst_cap_bh = burst_handler; auto fn = [](void *args) -> void * { +#ifdef HAVE_PTHREAD_SETNAME_NP pthread_setname_np(pthread_self(), "rxrun"); +#endif /* HAVE_PTHREAD_SETNAME_NP */ uhd::stream_cmd_t stream_cmd(uhd::stream_cmd_t::STREAM_MODE_START_CONTINUOUS); stream_cmd.stream_now = true; diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp index fbc1492..f19df0c 100644 --- a/Transceiver52M/osmo-trx.cpp +++ b/Transceiver52M/osmo-trx.cpp @@ -500,6 +500,7 @@ static int set_sched_rr(unsigned int prio) { +#ifdef HAVE_SCHED_SETSCHEDULER struct sched_param param; int rc; memset(&param, 0, sizeof(param)); @@ -513,6 +514,9 @@ return -1; } return 0; +#else /* HAVE_SCHED_SETSCHEDULER */ + return -ENOTSUP; +#endif /* HAVE_SCHED_SETSCHEDULER */ } static void print_simd_info(void) diff --git a/configure.ac b/configure.ac index 01b2f34..fc6d6d8 100644 --- a/configure.ac +++ b/configure.ac @@ -277,6 +277,25 @@ AC_DEFINE(HAVE_ATOMIC_OPS, 1, [Support all required atomic operations], [AC_MSG_WARN("At least one aotmic operation missing, will use mutex")]) ]) +dnl Check for pthread_setname_np +AX_PTHREAD +if test "x$ax_pthread_ok" = "xyes"; then + saved_CFLAGS="$CFLAGS" + saved_LIBS="$LIBS" + CFLAGS="$CFLAGS $PTHREAD_CFLAGS" + LIBS="$LIBS $PTHREAD_LIBS" + + AC_CHECK_HEADERS([pthread.h]) + AC_CHECK_FUNCS([pthread_setname_np]) + + CFLAGS="$saved_CFLAGS" + LIBS="$saved_LIBS" +fi + +dnl Check the scheduller functions +AC_CHECK_HEADERS([sched.h]) +AC_CHECK_FUNCS([sched_setaffinity sched_setscheduler]) + AM_CONDITIONAL(DEVICE_UHD, [test "x$with_uhd" = "xyes"]) AM_CONDITIONAL(DEVICE_USRP1, [test "x$with_usrp1" = "xyes"]) AM_CONDITIONAL(DEVICE_LMS, [test "x$with_lms" = "xyes"]) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42654?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ic3f1492544439d88c5e6683330c6696de1c2f85b Gerrit-Change-Number: 42654 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[L] Change in libosmo-abis[master]: abis: add optional WebSDR E1 input driver
by Timur Davydov 22 Apr '26

22 Apr '26

Attention is currently required from: Timur Davydov. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/42652?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: abis: add optional WebSDR E1 input driver ...................................................................... abis: add optional WebSDR E1 input driver Add a new optional E1 input backend for WebSDR, enabled via --with-websdr. Introduce input/websdr.c and public callback API to replace socket-based IPA transport with a callback-driven interface for OML/RSL and OSMUX. Intended for WebAssembly builds where Osmocom components run in a browser and communicate with SDR via WebUSB. Change-Id: Ib804dc8eb67a91678603f54ea0beccd5c61e4a80 --- M configure.ac M include/Makefile.am A include/osmocom/abis/websdr.h M src/Makefile.am M src/e1_input.c M src/e1_input_vty.c M src/input/ipaccess.c A src/input/websdr.c 8 files changed, 774 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/52/42652/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/42652?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib804dc8eb67a91678603f54ea0beccd5c61e4a80 Gerrit-Change-Number: 42652 Gerrit-PatchSet: 4 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[L] Change in libosmo-abis[master]: abis: add optional WebSDR E1 input driver
by Jenkins Builder 22 Apr '26

22 Apr '26

Attention is currently required from: Timur Davydov. Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmo-abis/+/42652?usp=email ) Change subject: abis: add optional WebSDR E1 input driver ...................................................................... Patch Set 2: (1 comment) File src/input/websdr.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-abis/+/42652/comment/e661cc8a_ace85663… : PS2, Line 88: if (!msg) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/42652?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib804dc8eb67a91678603f54ea0beccd5c61e4a80 Gerrit-Change-Number: 42652 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 22 Apr 2026 21:14:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in libosmo-abis[master]: abis: add optional WebSDR E1 input driver
by Timur Davydov 22 Apr '26

22 Apr '26

Attention is currently required from: Timur Davydov. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/42652?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: abis: add optional WebSDR E1 input driver ...................................................................... abis: add optional WebSDR E1 input driver Add a new optional E1 input backend for WebSDR, enabled via --with-websdr. Introduce input/websdr.c and public callback API to replace socket-based IPA transport with a callback-driven interface for OML/RSL and OSMUX. Intended for WebAssembly builds where Osmocom components run in a browser and communicate with SDR via WebUSB. Change-Id: Ib804dc8eb67a91678603f54ea0beccd5c61e4a80 --- M configure.ac M include/Makefile.am A include/osmocom/abis/websdr.h M src/Makefile.am M src/e1_input.c M src/e1_input_vty.c M src/input/ipaccess.c A src/input/websdr.c 8 files changed, 775 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/52/42652/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/42652?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib804dc8eb67a91678603f54ea0beccd5c61e4a80 Gerrit-Change-Number: 42652 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in libosmocore[master]: vty: make CPU scheduling optional based on platform support
by Timur Davydov 22 Apr '26

22 Apr '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42653?usp=email ) Change subject: vty: make CPU scheduling optional based on platform support ...................................................................... vty: make CPU scheduling optional based on platform support Add configure checks for sched_* APIs and guard their usage in cpu_sched_vty with HAVE_SCHED_* macros. If scheduler functions are not available, return -ENOTSUP instead of failing at build time. Also change osmo_cpu_sched_vty_init() to return int. This improves portability on platforms lacking full sched support (e.g. non-Linux or restricted environments). Change-Id: Ic5b7e39fac16531d370cb81f769ba87fef18cb81 --- M configure.ac M include/osmocom/vty/cpu_sched_vty.h M src/vty/cpu_sched_vty.c 3 files changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/53/42653/1 diff --git a/configure.ac b/configure.ac index b5f858f..cde4446 100644 --- a/configure.ac +++ b/configure.ac @@ -162,6 +162,10 @@ AC_CHECK_HEADERS([sched.h sys/mount.h sys/param.h]) AC_CHECK_FUNCS([setns unshare mount]) +dnl Check the scheduller functions +AC_CHECK_HEADERS([sched.h]) +AC_CHECK_FUNCS([sched_setaffinity sched_setscheduler sched_getaffinity]) + dnl Check whether CLONE_NEWNET is available AC_CHECK_DECL([CLONE_NEWNET], [AC_DEFINE([HAVE_CLONE_NEWNET], [1], diff --git a/include/osmocom/vty/cpu_sched_vty.h b/include/osmocom/vty/cpu_sched_vty.h index 171f168..b04ee34 100644 --- a/include/osmocom/vty/cpu_sched_vty.h +++ b/include/osmocom/vty/cpu_sched_vty.h @@ -31,7 +31,7 @@ * \file cpu_sched_vty.h */ -void osmo_cpu_sched_vty_init(void *tall_ctx); +int osmo_cpu_sched_vty_init(void *tall_ctx); int osmo_cpu_sched_vty_apply_localthread(void); /*! @} */ diff --git a/src/vty/cpu_sched_vty.c b/src/vty/cpu_sched_vty.c index 4f3eeb1..a712860 100644 --- a/src/vty/cpu_sched_vty.c +++ b/src/vty/cpu_sched_vty.c @@ -331,6 +331,7 @@ static int my_sched_setaffinity(enum sched_vty_thread_id tid_type, pid_t pid, cpu_set_t *cpuset, size_t cpuset_size) { +#ifdef HAVE_SCHED_SETAFFINITY DIR *proc_dir; struct dirent *entry; char dirname[100]; @@ -369,7 +370,9 @@ closedir(proc_dir); return rc; - +#else /* HAVE_SCHED_SETAFFINITY */ + return -ENOTSUP; +#endif /* HAVE_SCHED_SETAFFINITY */ } DEFUN_ATTR(cfg_sched_cpu_affinity, cfg_sched_cpu_affinity_cmd, @@ -464,6 +467,7 @@ static int set_sched_rr(unsigned int prio) { +#ifdef HAVE_SCHED_SETSCHEDULER struct sched_param param; int rc; memset(&param, 0, sizeof(param)); @@ -476,6 +480,9 @@ return -1; } return 0; +#else /* HAVE_SCHED_SETSCHEDULER */ + return -ENOTSUP; +#endif /* HAVE_SCHED_SETSCHEDULER */ } DEFUN_ATTR(cfg_sched_policy, cfg_sched_policy_cmd, @@ -558,10 +565,12 @@ cpuset = CPU_ALLOC(get_num_cpus()); cpuset_size = CPU_ALLOC_SIZE(get_num_cpus()); CPU_ZERO_S(cpuset_size, cpuset); +#ifdef HAVE_SCHED_GETAFFINITY if (sched_getaffinity(tid_it, cpuset_size, cpuset) == 0) { if (generate_cpu_hex_mask(str_mask, sizeof(str_mask), cpuset, cpuset_size) < 0) str_mask[0] = '\0'; } +#endif /* HAVE_SCHED_GETAFFINITY */ CPU_FREE(cpuset); vty_out(vty, " TID: %lu, NAME: '%s', cpu-affinity: %s%s", -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic5b7e39fac16531d370cb81f769ba87fef18cb81 Gerrit-Change-Number: 42653 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[L] Change in libosmo-abis[master]: abis: add optional WebSDR E1 input driver
by Jenkins Builder 22 Apr '26

22 Apr '26

Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmo-abis/+/42652?usp=email ) Change subject: abis: add optional WebSDR E1 input driver ...................................................................... Patch Set 1: (8 comments) File include/osmocom/abis/websdr.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-abis/+/42652/comment/039314e4_c092de89… : PS1, Line 60: #endif /* OSMO_ABIS_WEBSDR_H */ adding a line without newline at end of file File src/input/websdr.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-abis/+/42652/comment/94253633_5ff87dfe… : PS1, Line 88: if (!msg) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-abis/+/42652/comment/75dfc40b_5f247532… : PS1, Line 145: switch(line->ops->cfg.ipa.role) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-abis/+/42652/comment/f88497ba_cd20fdb1… : PS1, Line 405: struct e1inp_line* line = g_line_cb; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-abis/+/42652/comment/6d813793_00340101… : PS1, Line 447: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-abis/+/42652/comment/1feebefa_2953cd77… : PS1, Line 502: if (ret == 0) suspect code indent for conditional statements (16, 23) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-abis/+/42652/comment/0a6242fa_0e02573c… : PS1, Line 503: goto discard_msg; Statements should start on a tabstop Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-abis/+/42652/comment/425614f1_0c33357b… : PS1, Line 601: int ws_ipa_push_raw_data(unsigned ts_nr, const char* data, unsigned sz) "foo* bar" should be "foo *bar" -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/42652?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib804dc8eb67a91678603f54ea0beccd5c61e4a80 Gerrit-Change-Number: 42652 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 22 Apr 2026 20:48:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026