Attention is currently required from: Hoernchen, Timur Davydov, fixeria, laforge.

Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email )

Change subject: transceiver: add optional WebSDR device support ......................................................................

Patch Set 11:

(11 comments)

File Transceiver52M/Transceiver.h:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/7be84dd2_4b7b4256?usp=... : PS11, Line 246: int driveReceiveRadioShortVector(std::vector<short *> &bufs, int samples, int underrun, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/ad6f1cf1_2a43d50a?usp=... : PS11, Line 247: TIMESTAMP ts, unsigned samples_skipped); code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/6490d26d_2fdfc393?usp=... : PS11, Line 249: bool driveReceiveRadio(unsigned samples_skipped = 0); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/154f877d_18ca04cc?usp=... : PS11, Line 265: ssize_t driveReceiveFIFOBurst(size_t chan, char *burstBuffer, size_t burstBufferLen); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/27e75fb5_2381d280?usp=... : PS11, Line 271: @brief modulation and sorting of GSM bursts from GSM core please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/05a7b7d7_003cd68e?usp=... : PS11, Line 272: @param chan channel number please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/ec6d0c28_accd2d3e?usp=... : PS11, Line 273: @param burstBuffer optional buffer containing burst to transmit, if not provided, will read from data socket please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/b4a3ce2f_6030f422?usp=... : PS11, Line 274: @param burstBufferLen optional length of burst buffer, if not provided, will read from data socket please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/9ddc552b_c912611e?usp=... : PS11, Line 277: bool driveTxPriorityQueue(size_t chan, char *burstBuffer = nullptr, size_t burstBufferLen = 0); please, no spaces at the start of a line

File Transceiver52M/radioInterface.h:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/b2d4e71f_c2b83d93?usp=... : PS11, Line 118: int driveReceiveRadio(unsigned samples_skipped = 0); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/f58043e6_c932342c?usp=... : PS11, Line 137: int fillPullBuffer(std::vector<short *> &bufs, size_t samples, int recvunderrun, TIMESTAMP ts); please, no spaces at the start of a line