April 2026 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: Support administrative block in role ASP
by pespin 01 Apr '26

01 Apr '26

Attention is currently required from: fixeria, laforge, osmith. Hello Jenkins Builder, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42573?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: Support administrative block in role ASP ...................................................................... Support administrative block in role ASP * Avoid activating later on if inactive when becoming blocked. * Move to inactive state (and notify peer with ASPIA) if active when becoming blocked. * Attempt re-activation if needed when becoming non-blocked. Related: OS#6752 Change-Id: If32902575e874d2acc9a5fc12509af42ed151739 --- M src/ss7_asp.c M src/ss7_asp_vty.c M src/xua_asp_fsm.c M src/xua_asp_fsm.h M src/xua_default_lm_fsm.c 5 files changed, 77 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/73/42573/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42573?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If32902575e874d2acc9a5fc12509af42ed151739 Gerrit-Change-Number: 42573 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: stp: m3ua: Expect unsolicited ASPIA ACK after unblocking ASP
by pespin 01 Apr '26

01 Apr '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42576?usp=email ) Change subject: stp: m3ua: Expect unsolicited ASPIA ACK after unblocking ASP ...................................................................... stp: m3ua: Expect unsolicited ASPIA ACK after unblocking ASP Since libosmo-sigtran.git Change-Id If32902575e874d2acc9a5fc12509af42ed151739, osmo-stp will send an unsolicited ASPIA ACK to the peer whenever the ASP becomes unblock, in order to somehow give a chance to the peer to notice something changed and for instance possibly attempt re-activation of the ASP. Related: OS#6752 Change-Id: I4b70e576beae3c386d68f17a60d6f23d1a54293a --- M stp/STP_Tests_M3UA.ttcn 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/76/42576/1 diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index ca7dead..ac9cc25 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -674,6 +674,9 @@ f_M3UA_exp(0, tr_M3UA_ERR('0000000D'O, rctx_sender)); f_vty_cs7_asp_cmd(g_m3ua_configs[0], "no block"); + /* osmo-stp transmits an unsolicited ASPIA ACK to inform it went locally unblocked, + * in order to give a chance to the peer to re-attempt re-activation. */ + f_M3UA_exp(0, tr_M3UA_ASPIA_ACK(rctx_sender)); f_M3UA_asp_act(0, c_M3UA_TMT_override, rctx_sender, ntfy_after_act := c_M3UA_ST_I_AS_ACTIVE); f_clear_m3ua(); @@ -694,6 +697,9 @@ f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_INACTIVE, rctx_sender)); f_vty_cs7_asp_cmd(g_m3ua_configs[0], "no block"); + /* osmo-stp transmits an unsolicited ASPIA ACK to inform it went locally unblocked, + * in order to give a chance to the peer to re-attempt re-activation. */ + f_M3UA_exp(0, tr_M3UA_ASPIA_ACK(rctx_sender)); f_M3UA_asp_act(0, c_M3UA_TMT_override, rctx_sender, ntfy_after_act := c_M3UA_ST_I_AS_ACTIVE); f_clear_m3ua(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42576?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4b70e576beae3c386d68f17a60d6f23d1a54293a Gerrit-Change-Number: 42576 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: cosmetic: xua_asp_fsm: Fix wrong indentation
by pespin 01 Apr '26

01 Apr '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42572?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: cosmetic: xua_asp_fsm: Fix wrong indentation ...................................................................... cosmetic: xua_asp_fsm: Fix wrong indentation Change-Id: I21c13ff7bc67c060e739eae38088ac00700680de --- M src/xua_asp_fsm.c 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c index bb163a0..39d121f 100644 --- a/src/xua_asp_fsm.c +++ b/src/xua_asp_fsm.c @@ -918,12 +918,12 @@ } if (asp->cfg.role == OSMO_SS7_ASP_ROLE_SG) { /* RFC4666 4.3.4.4: Transmit unsolicited ASPIA ACK no tnotify peer. - * "If the ASP receives an ASP Inactive Ack without having sent an - * ASP Inactive message, the ASP should now consider itself to be - * in the ASP-INACTIVE state. If the ASP was previously in the - * ASP-ACTIVE state, the ASP should then initiate procedures to - * return itself to its previous state." - */ + * "If the ASP receives an ASP Inactive Ack without having sent an + * ASP Inactive message, the ASP should now consider itself to be + * in the ASP-INACTIVE state. If the ASP was previously in the + * ASP-ACTIVE state, the ASP should then initiate procedures to + * return itself to its previous state." + */ xua_asp_tx_unsolicited_aspia_ack(asp); /* transition state and inform layer manager */ osmo_fsm_inst_state_chg(fi, XUA_ASP_S_INACTIVE, 0, 0); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42572?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I21c13ff7bc67c060e739eae38088ac00700680de Gerrit-Change-Number: 42572 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: xua_lm: Add S_INACTIVE state and improve state transitions
by pespin 01 Apr '26

01 Apr '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42571?usp=email ) Change subject: xua_lm: Add S_INACTIVE state and improve state transitions ...................................................................... xua_lm: Add S_INACTIVE state and improve state transitions The S_INACTIVE state will be needed once we support administrative state block in role ASP/(active)IPSP. It is also useful now since sometimes we just want to leave an asp in that state without any timer running (eg. asps in override which are not active until the active one goes inactive). Adding the S_INACTIVE state also allows transitioning states in role SG, since we now have somewhere to go instead of leaving it alwas as S_IDLE. The S_INACTIVE state also allows staying in that state until the ASP ACT ACK is received, moment at which the ASP is considered ACTIVE according to specs. Change-Id: I7e6127c150e479d0c436875b41824b3061e4fa48 --- M src/xua_default_lm_fsm.c 1 file changed, 140 insertions(+), 34 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/xua_default_lm_fsm.c b/src/xua_default_lm_fsm.c index dbe88e1..40d6e0d 100644 --- a/src/xua_default_lm_fsm.c +++ b/src/xua_default_lm_fsm.c @@ -53,6 +53,8 @@ S_WAIT_NOTIFY, /* we've sent a RK REG REQ and wait for the result */ S_RKM_REG, + /* Inactive, waiting to be activated based on policy */ + S_INACTIVE, /* all systems up, we're communicating */ S_ACTIVE, }; @@ -61,6 +63,8 @@ LM_E_SCTP_EST_IND, LM_E_ASP_UP_CONF, LM_E_ASP_UP_IND, + LM_E_ASP_DOWN_IND, + LM_E_ASP_ACT_CONF, LM_E_ASP_ACT_IND, LM_E_ASP_INACT_CONF, LM_E_ASP_INACT_IND, @@ -77,6 +81,8 @@ { LM_E_SCTP_EST_IND, "SCTP-ESTABLISH.ind" }, { LM_E_ASP_UP_CONF, "ASP-UP.conf" }, { LM_E_ASP_UP_IND, "ASP-UP.ind" }, + { LM_E_ASP_DOWN_IND, "ASP-DOWN.ind" }, + { LM_E_ASP_ACT_CONF, "ASP-ACT.conf" }, { LM_E_ASP_ACT_IND, "ASP-ACT.ind" }, { LM_E_ASP_INACT_CONF, "ASP-INACT.conf" }, { LM_E_ASP_INACT_IND, "ASP-INACT.ind" }, @@ -124,6 +130,7 @@ [S_WAIT_ASP_UP] = { .T = SS7_ASP_LM_T_WAIT_ASP_UP }, [S_WAIT_NOTIFY] = { .T = SS7_ASP_LM_T_WAIT_NOTIFY }, /* SS7_ASP_LM_T_WAIT_NOTIY_RKM if coming from S_RKM_REG */ [S_RKM_REG] = { .T = SS7_ASP_LM_T_WAIT_RK_REG_RESP }, + [S_INACTIVE] = { }, [S_ACTIVE] = { }, }; @@ -190,25 +197,42 @@ } } +static bool asp_act_needed(const struct osmo_ss7_asp *asp) +{ + /* Don't change active ASP if there's already one active in the AS. */ + if (ss7_asp_determine_traf_mode(asp) == OSMO_SS7_AS_TMOD_OVERRIDE) { + struct ss7_as_asp_assoc *assoc; + llist_for_each_entry(assoc, &asp->assoc_as_list, asp_entry) { + if (osmo_ss7_as_active(assoc->as)) + return false; + } + } + return true; +} + static void lm_idle(struct osmo_fsm_inst *fi, uint32_t event, void *data) { + switch (event) { + case LM_E_SCTP_EST_IND: + /* Try to transition to ASP-UP, wait to receive message for a few seconds */ + lm_fsm_state_chg(fi, S_WAIT_ASP_UP); + break; + } +} + +static void lm_wait_asp_up_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) +{ struct xua_layer_manager_default_priv *lmp = fi->priv; - switch (event) { - case LM_E_SCTP_EST_IND: - if (lmp->asp->cfg.role == OSMO_SS7_ASP_ROLE_ASP || - lmp->asp->cfg.role == OSMO_SS7_ASP_ROLE_IPSP) { - /* Try to transition to ASP-UP, wait to receive message for a few seconds */ - lm_fsm_state_chg(fi, S_WAIT_ASP_UP); - xlm_sap_down_simple(lmp->asp, OSMO_XLM_PRIM_M_ASP_UP, PRIM_OP_REQUEST); - } - /* role SG: Unimplemented, do nothing, stay in this state forever. */ - break; + if (lmp->asp->cfg.role == OSMO_SS7_ASP_ROLE_ASP || + lmp->asp->cfg.role == OSMO_SS7_ASP_ROLE_IPSP) { + xlm_sap_down_simple(lmp->asp, OSMO_XLM_PRIM_M_ASP_UP, PRIM_OP_REQUEST); } } static void lm_wait_asp_up(struct osmo_fsm_inst *fi, uint32_t event, void *data) { + struct xua_layer_manager_default_priv *lmp = fi->priv; const struct osmo_xlm_prim *oxp = data; switch (event) { @@ -220,10 +244,14 @@ break; case LM_E_ASP_UP_IND: ENSURE_SG_OR_IPSP(fi, event); - /* ASP is up, wait for some time if any NOTIFY - * indications about AS in this ASP are received. - */ - lm_fsm_state_chg(fi, S_WAIT_NOTIFY); + /* ASP is up */ + if (lmp->asp->cfg.role == OSMO_SS7_ASP_ROLE_IPSP) { + /* wait for some time if any NOTIFY indications about AS in this ASP + * are received */ + lm_fsm_state_chg(fi, S_WAIT_NOTIFY); + } else { + lm_fsm_state_chg(fi, S_INACTIVE); + } break; case LM_E_ERROR_IND: ENSURE_ASP_OR_IPSP(fi, event); @@ -240,7 +268,6 @@ static void lm_wait_notify(struct osmo_fsm_inst *fi, uint32_t event, void *data) { - struct xua_layer_manager_default_priv *lmp = fi->priv; struct osmo_xlm_prim *oxp = data; switch (event) { @@ -254,18 +281,10 @@ ENSURE_ASP_OR_IPSP(fi, event); OSMO_ASSERT(oxp->oph.primitive == OSMO_XLM_PRIM_M_NOTIFY); OSMO_ASSERT(oxp->oph.operation == PRIM_OP_INDICATION); - /* Not handling/interested in other status changes for now. */ if (oxp->u.notify.status_type != M3UA_NOTIFY_T_STATCHG) break; - - /* Don't change active ASP if there's already one active. */ - if (ss7_asp_determine_traf_mode(lmp->asp) == OSMO_SS7_AS_TMOD_OVERRIDE && - oxp->u.notify.status_info == M3UA_NOTIFY_I_AS_ACT) - break; - - lm_fsm_state_chg(fi, S_ACTIVE); - xlm_sap_down_simple(lmp->asp, OSMO_XLM_PRIM_M_ASP_ACTIVE, PRIM_OP_REQUEST); + lm_fsm_state_chg(fi, S_INACTIVE); break; case LM_E_ASP_ACT_IND: ENSURE_SG_OR_IPSP(fi, event); @@ -274,11 +293,8 @@ case LM_E_AS_INACTIVE_IND: /* we now know that an AS is associated with this ASP at * the SG, and that this AS is currently inactive */ - /* request the ASP to go into active state (which - * hopefully will bring the AS to active, too) */ - lm_fsm_state_chg(fi, S_ACTIVE); - if (lmp->asp->cfg.role != OSMO_SS7_ASP_ROLE_SG) - xlm_sap_down_simple(lmp->asp, OSMO_XLM_PRIM_M_ASP_ACTIVE, PRIM_OP_REQUEST); + /* Transition to S_INACTIVE, which will trigger activation if needed. */ + lm_fsm_state_chg(fi, S_INACTIVE); break; } }; @@ -291,6 +307,7 @@ switch (event) { case LM_E_RKM_REG_CONF: + ENSURE_ASP_OR_IPSP(fi, event); if (oxp->u.rk_reg.status != M3UA_RKM_REG_SUCCESS) { LOGPFSML(fi, LOGL_NOTICE, "Received RKM_REG_RSP with negative result\n"); xlm_sap_down_simple(lmp->asp, OSMO_XLM_PRIM_M_SCTP_RELEASE, PRIM_OP_REQUEST); @@ -320,6 +337,62 @@ } } +static void lm_inactive_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) +{ + struct xua_layer_manager_default_priv *lmp = fi->priv; + + if (lmp->asp->cfg.role == OSMO_SS7_ASP_ROLE_ASP || + lmp->asp->cfg.role == OSMO_SS7_ASP_ROLE_IPSP) { + if (asp_act_needed(lmp->asp)) + xlm_sap_down_simple(lmp->asp, OSMO_XLM_PRIM_M_ASP_ACTIVE, PRIM_OP_REQUEST); + } +} + +static void lm_inactive(struct osmo_fsm_inst *fi, uint32_t event, void *data) +{ + struct xua_layer_manager_default_priv *lmp = fi->priv; + struct osmo_xlm_prim *oxp = data; + + switch (event) { + case LM_E_ASP_ACT_CONF: + ENSURE_ASP_OR_IPSP(fi, event); + /* RFC4666 4.3.4.3: "[...] the ASP does not consider itself in the ASP-ACTIVE state + * until receipt of the ASP Active Ack message". */ + lm_fsm_state_chg(fi, S_ACTIVE); + break; + case LM_E_ASP_ACT_IND: + ENSURE_SG_OR_IPSP(fi, event); + lm_fsm_state_chg(fi, S_ACTIVE); + break; + case LM_E_AS_INACTIVE_IND: + /* request the ASP to go into active state if needed */ + if (asp_act_needed(lmp->asp)) + xlm_sap_down_simple(lmp->asp, OSMO_XLM_PRIM_M_ASP_ACTIVE, PRIM_OP_REQUEST); + break; + case LM_E_NOTIFY_IND: + ENSURE_ASP_OR_IPSP(fi, event); + OSMO_ASSERT(oxp->oph.primitive == OSMO_XLM_PRIM_M_NOTIFY); + OSMO_ASSERT(oxp->oph.operation == PRIM_OP_INDICATION); + /* request the ASP to go into active state if needed */ + if (asp_act_needed(lmp->asp)) + xlm_sap_down_simple(lmp->asp, OSMO_XLM_PRIM_M_ASP_ACTIVE, PRIM_OP_REQUEST); + break; + case LM_E_ERROR_IND: + ENSURE_ASP_OR_IPSP(fi, event); + OSMO_ASSERT(oxp->oph.primitive == OSMO_XLM_PRIM_M_ERROR); + OSMO_ASSERT(oxp->oph.operation == PRIM_OP_INDICATION); + /* Our ASPAC was most probably rejected by peer with an M3UA ERR. + * Go back to Wait Notify to either wait for some notificaiton to re-attempt, + * or end up timing out and reconnecting. */ + LOGPFSML(fi, LOGL_NOTICE, "Received M-ERROR.ind with error code %u (%s)\n", + oxp->u.error.code, get_value_string(m3ua_err_names, oxp->u.error.code)); + if (asp_act_needed(lmp->asp)) + lm_fsm_state_chg(fi, S_WAIT_NOTIFY); + /* else: stay in inactive */ + break; + } +} + static void lm_active(struct osmo_fsm_inst *fi, uint32_t event, void *data) { struct xua_layer_manager_default_priv *lmp = fi->priv; @@ -338,6 +411,10 @@ * ERR msg and continue from there in the case LM_E_ERROR_IND below. */ xlm_sap_down_simple(lmp->asp, OSMO_XLM_PRIM_M_ASP_ACTIVE, PRIM_OP_REQUEST); break; + case LM_E_ASP_INACT_IND: + ENSURE_SG_OR_IPSP(fi, event); + lm_fsm_state_chg(fi, S_INACTIVE); + break; case LM_E_AS_INACTIVE_IND: /* request the ASP to go into active state */ xlm_sap_down_simple(lmp->asp, OSMO_XLM_PRIM_M_ASP_ACTIVE, PRIM_OP_REQUEST); @@ -370,6 +447,9 @@ static void lm_allstate(struct osmo_fsm_inst *fi, uint32_t event, void *data) { switch (event) { + case LM_E_ASP_DOWN_IND: + lm_fsm_state_chg(fi, S_WAIT_ASP_UP); + break; case LM_E_SCTP_DISC_IND: lm_fsm_state_chg(fi, S_IDLE); break; @@ -427,9 +507,12 @@ S(LM_E_ASP_UP_IND) | S(LM_E_ERROR_IND), .out_state_mask = S(S_IDLE) | - S(S_WAIT_NOTIFY), + S(S_WAIT_ASP_UP) | + S(S_WAIT_NOTIFY) | + S(S_INACTIVE), .name = "WAIT_ASP_UP", .action = lm_wait_asp_up, + .onenter = lm_wait_asp_up_on_enter, }, [S_WAIT_NOTIFY] = { .in_event_mask = S(LM_E_AS_INACTIVE_IND) | @@ -437,7 +520,9 @@ S(LM_E_NOTIFY_IND) | S(LM_E_ASP_UP_CONF), .out_state_mask = S(S_IDLE) | + S(S_WAIT_ASP_UP) | S(S_RKM_REG) | + S(S_INACTIVE) | S(S_ACTIVE), .name = "WAIT_NOTIFY", .action = lm_wait_notify, @@ -450,14 +535,32 @@ .name = "RKM_REG", .action = lm_rkm_reg, }, - [S_ACTIVE] = { - .in_event_mask = S(LM_E_ASP_ACT_IND) | + [S_INACTIVE] = { + .in_event_mask = S(LM_E_ASP_ACT_CONF) | + S(LM_E_ASP_ACT_IND) | S(LM_E_ASP_INACT_CONF) | S(LM_E_AS_INACTIVE_IND) | S(LM_E_NOTIFY_IND) | S(LM_E_ERROR_IND), .out_state_mask = S(S_IDLE) | - S(S_WAIT_NOTIFY), + S(S_WAIT_ASP_UP) | + S(S_WAIT_NOTIFY) | + S(S_ACTIVE), + .name = "INACTIVE", + .action = lm_inactive, + .onenter = lm_inactive_on_enter, + }, + [S_ACTIVE] = { + .in_event_mask = S(LM_E_ASP_ACT_IND) | + S(LM_E_ASP_INACT_CONF) | + S(LM_E_ASP_INACT_IND) | + S(LM_E_AS_INACTIVE_IND) | + S(LM_E_NOTIFY_IND) | + S(LM_E_ERROR_IND), + .out_state_mask = S(S_IDLE) | + S(S_WAIT_ASP_UP) | + S(S_WAIT_NOTIFY) | + S(S_INACTIVE), .name = "ACTIVE", .action = lm_active, }, @@ -469,7 +572,9 @@ { XUA_SAP_LM, OSMO_XLM_PRIM_M_SCTP_RELEASE, PRIM_OP_INDICATION, LM_E_SCTP_DISC_IND }, { XUA_SAP_LM, OSMO_XLM_PRIM_M_ASP_UP, PRIM_OP_CONFIRM, LM_E_ASP_UP_CONF }, { XUA_SAP_LM, OSMO_XLM_PRIM_M_ASP_UP, PRIM_OP_INDICATION, LM_E_ASP_UP_IND }, + { XUA_SAP_LM, OSMO_XLM_PRIM_M_ASP_DOWN, PRIM_OP_INDICATION, LM_E_ASP_DOWN_IND }, { XUA_SAP_LM, OSMO_XLM_PRIM_M_ASP_ACTIVE, PRIM_OP_INDICATION, LM_E_ASP_ACT_IND }, + { XUA_SAP_LM, OSMO_XLM_PRIM_M_ASP_ACTIVE, PRIM_OP_CONFIRM, LM_E_ASP_ACT_CONF }, { XUA_SAP_LM, OSMO_XLM_PRIM_M_ASP_INACTIVE, PRIM_OP_CONFIRM, LM_E_ASP_INACT_CONF }, { XUA_SAP_LM, OSMO_XLM_PRIM_M_ASP_INACTIVE, PRIM_OP_INDICATION, LM_E_ASP_INACT_IND }, { XUA_SAP_LM, OSMO_XLM_PRIM_M_AS_STATUS, PRIM_OP_INDICATION, LM_E_AS_STATUS_IND }, @@ -488,7 +593,8 @@ .num_states = ARRAY_SIZE(lm_states), .timer_cb = lm_timer_cb, .event_names = lm_event_names, - .allstate_event_mask = S(LM_E_SCTP_DISC_IND), + .allstate_event_mask = S(LM_E_ASP_DOWN_IND) | + S(LM_E_SCTP_DISC_IND), .allstate_action = lm_allstate, .log_subsys = DLSS7, }; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42571?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I7e6127c150e479d0c436875b41824b3061e4fa48 Gerrit-Change-Number: 42571 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in pysim[master]: docs: auto-generate Card Filesystem Reference
by fixeria 01 Apr '26

01 Apr '26

Attention is currently required from: laforge. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42551?usp=email ) Change subject: docs: auto-generate Card Filesystem Reference ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > I've looked at the generated output and it looks good. […] I decided to indicate this information in a comment preceding the example: `file:` for files and `record Nr:` for records. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42551?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I06ddeefc6c11e04d7c24e116f3f39c8a6635856f Gerrit-Change-Number: 42551 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 01 Apr 2026 13:07:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in pysim[master]: filesystem: edit_{binary,record}_decoded: add encode/decode examples
by fixeria 01 Apr '26

01 Apr '26

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42552?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: filesystem: edit_{binary,record}_decoded: add encode/decode examples ...................................................................... filesystem: edit_{binary,record}_decoded: add encode/decode examples When invoking `edit_binary_decoded` or `edit_record_decoded`, the temp file opened in the editor now contains the EF's encode/decode test vectors as //-comment lines below the JSON content, similar to how 'git commit' appends comments to the commit message template. The comment block is stripped before JSON parsing on save, so it has no effect on the written data. The feature is implemented via a new module-level JsonEditor context manager class that encapsulates the full edit cycle: * write JSON + examples to a TemporaryDirectory * invoke the editor * read back, strip //-comments, parse and return the result Change-Id: I5a046a9c7ba7e08a98cf643d5a26bc669539b38f Related: OS#6900 --- M pySim/filesystem.py 1 file changed, 64 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/52/42552/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5a046a9c7ba7e08a98cf643d5a26bc669539b38f Gerrit-Change-Number: 42552 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in pysim[master]: docs: auto-generate Card Filesystem Reference
by fixeria 01 Apr '26

01 Apr '26

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42551?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: docs: auto-generate Card Filesystem Reference ...................................................................... docs: auto-generate Card Filesystem Reference Add a Sphinx extension (docs/pysim_fs_sphinx.py) that hooks into the builder-inited event and generates docs/filesystem.rst before Sphinx reads any source files. The generated page contains a hierarchical listing of all implemented EFs and DFs, organised by application/specification (UICC/TS 102 221, ADF.USIM/TS 31.102, ADF.ISIM/TS 31.103, SIM/TS 51.011). For each file, the class docstring and any _test_de_encode / _test_decode vectors are included as an encoding/decoding example table. docs/filesystem.rst is fully generated at build time and is therefore added to .gitignore. Add tests/unittests/test_fs_coverage.py that walks all pySim.* modules and verifies that every CardProfile, CardApplication, and standalone CardDF subclass with EF/DF children is either listed in the SECTIONS (and will appear in the docs) or explicitly EXCLUDED. Change-Id: I06ddeefc6c11e04d7c24e116f3f39c8a6635856f Related: OS#6316 --- M .gitignore M docs/conf.py M docs/index.rst A docs/pysim_fs_sphinx.py A tests/unittests/test_fs_coverage.py 5 files changed, 417 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/51/42551/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42551?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I06ddeefc6c11e04d7c24e116f3f39c8a6635856f Gerrit-Change-Number: 42551 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: asp: Fix wrong variable logged in ss7_asp_xua_srv_conn_rx_cb()
by osmith 01 Apr '26

01 Apr '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42575?usp=email ) Change subject: asp: Fix wrong variable logged in ss7_asp_xua_srv_conn_rx_cb() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42575?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I24206a19fe57772caf8036464a2e1b6b8630fd7a Gerrit-Change-Number: 42575 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Apr 2026 12:36:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: Create missing LayerManager fsm in dynamic srv xua asps
by osmith 01 Apr '26

01 Apr '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42574?usp=email ) Change subject: Create missing LayerManager fsm in dynamic srv xua asps ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42574?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id01e7a24e92aecc61aa2850632b3712bb338e9f2 Gerrit-Change-Number: 42574 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Apr 2026 12:35:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: Support administrative block in role ASP
by osmith 01 Apr '26

01 Apr '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42573?usp=email ) Change subject: Support administrative block in role ASP ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42573?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If32902575e874d2acc9a5fc12509af42ed151739 Gerrit-Change-Number: 42573 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Apr 2026 12:32:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026