April 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: jobs/gerrit-verifications.yml: pysim: allow skipping card tests
by laforge 24 Apr '26

24 Apr '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/42671?usp=email ) Change subject: jobs/gerrit-verifications.yml: pysim: allow skipping card tests ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I986d88545f64e13cd571ba9ff56bc924822e39a0 Gerrit-Change-Number: 42671 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Apr 2026 22:09:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/master-builds.yml: add missing job type 'distcheck'
by laforge 24 Apr '26

24 Apr '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/42670?usp=email ) Change subject: jobs/master-builds.yml: add missing job type 'distcheck' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42670?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4898ba712a29a6afc34bc22adec6a3131ce8c794 Gerrit-Change-Number: 42670 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Apr 2026 22:09:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/master-builds.yml: fix typo: crad-test -> card-test
by laforge 24 Apr '26

24 Apr '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/42669?usp=email ) Change subject: jobs/master-builds.yml: fix typo: crad-test -> card-test ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42669?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0686af6c026e298c86d3a64cc161e5c84ec7dc57 Gerrit-Change-Number: 42669 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Apr 2026 22:09:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: contrib/jenkins.sh: separate JOB_TYPE for card tests
by fixeria 23 Apr '26

23 Apr '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42658?usp=email ) Change subject: contrib/jenkins.sh: separate JOB_TYPE for card tests ...................................................................... contrib/jenkins.sh: separate JOB_TYPE for card tests A separate job gives us a possibility to skip tests requiring physical cards for specific commits that do not touch the core logic. See the related commits in osmo-ci.git. Change-Id: If76d812ee43b7eb3b57fdc660c60bf31fbff5b16 Related: osmo-ci.git Ia48d1b468f65d7c2e6b4128eeac36d0f3d03c45e Related: osmo-ci.git I986d88545f64e13cd571ba9ff56bc924822e39a0 --- M contrib/jenkins.sh 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index b95e80a..74198d7 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -32,15 +32,21 @@ # Execute automatically discovered unit tests first python -m unittest discover -v -s tests/unittests - # Run pySim-prog integration tests (requires physical cards) - cd tests/pySim-prog_test/ - ./pySim-prog_test.sh - cd ../../ - # Run pySim-trace test tests/pySim-trace_test/pySim-trace_test.sh + ;; +"card-test") # tests requiring physical cards + virtualenv -p python3 venv --system-site-packages + . venv/bin/activate - # Run pySim-shell integration tests (requires physical cards) + pip install -r requirements.txt + + # Run pySim-prog integration tests + cd tests/pySim-prog_test/ + ./pySim-prog_test.sh + cd ../../ + + # Run pySim-shell integration tests python3 -m unittest discover -v -s ./tests/pySim-shell_test/ # Run pySim-smpp2sim test -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42658?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If76d812ee43b7eb3b57fdc660c60bf31fbff5b16 Gerrit-Change-Number: 42658 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: tests: pySim-smpp2sim_test.sh: fix copy-pasted comment
by fixeria 23 Apr '26

23 Apr '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42659?usp=email ) Change subject: tests: pySim-smpp2sim_test.sh: fix copy-pasted comment ...................................................................... tests: pySim-smpp2sim_test.sh: fix copy-pasted comment Change-Id: I8167c6a3251bb6755810c96075010e920ceee8ac Jenkins: skip-card-test --- M tests/pySim-smpp2sim_test/pySim-smpp2sim_test.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/tests/pySim-smpp2sim_test/pySim-smpp2sim_test.sh b/tests/pySim-smpp2sim_test/pySim-smpp2sim_test.sh index cb12fb2..a5d35d1 100755 --- a/tests/pySim-smpp2sim_test/pySim-smpp2sim_test.sh +++ b/tests/pySim-smpp2sim_test/pySim-smpp2sim_test.sh @@ -1,6 +1,6 @@ #!/bin/bash -# Utility to verify the functionality of pySim-trace.py +# Utility to verify the functionality of pySim-smpp2sim.py # # (C) 2026 by sysmocom - s.f.m.c. GmbH # All Rights Reserved -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42659?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8167c6a3251bb6755810c96075010e920ceee8ac Gerrit-Change-Number: 42659 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in pysim[master]: contrib/jenkins.sh: add setup_venv()
by fixeria 23 Apr '26

23 Apr '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42657?usp=email ) Change subject: contrib/jenkins.sh: add setup_venv() ...................................................................... contrib/jenkins.sh: add setup_venv() Reduece code duplication by factoring out virtualenv setup and activation into a shell function. Change-Id: Ibb193d12d5502c78104ef53badc6037f08e92df1 --- M contrib/jenkins.sh 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 74198d7..fa2575b 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -10,6 +10,11 @@ export PYTHONUNBUFFERED=1 +setup_venv() { + virtualenv -p python3 venv --system-site-packages + . venv/bin/activate +} + if [ ! -d "./tests/" ] ; then echo "###############################################" echo "Please call from pySim-prog top directory" @@ -23,8 +28,7 @@ case "$JOB_TYPE" in "test") - virtualenv -p python3 venv --system-site-packages - . venv/bin/activate + setup_venv pip install -r requirements.txt pip install pyshark @@ -36,8 +40,7 @@ tests/pySim-trace_test/pySim-trace_test.sh ;; "card-test") # tests requiring physical cards - virtualenv -p python3 venv --system-site-packages - . venv/bin/activate + setup_venv pip install -r requirements.txt @@ -53,8 +56,7 @@ tests/pySim-smpp2sim_test/pySim-smpp2sim_test.sh ;; "distcheck") - virtualenv -p python3 venv --system-site-packages - . venv/bin/activate + setup_venv pip install . pip install pyshark @@ -67,8 +69,7 @@ # Print pylint version pip3 freeze | grep pylint - virtualenv -p python3 venv --system-site-packages - . venv/bin/activate + setup_venv pip install . @@ -86,8 +87,7 @@ contrib/*.py ;; "docs") - virtualenv -p python3 venv --system-site-packages - . venv/bin/activate + setup_venv pip install -r requirements.txt -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42657?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibb193d12d5502c78104ef53badc6037f08e92df1 Gerrit-Change-Number: 42657 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: tests: pySim-smpp2sim_test.sh: fix copy-pasted comment
by fixeria 23 Apr '26

23 Apr '26

Attention is currently required from: osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42659?usp=email ) Change subject: tests: pySim-smpp2sim_test.sh: fix copy-pasted comment ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42659?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8167c6a3251bb6755810c96075010e920ceee8ac Gerrit-Change-Number: 42659 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Apr 2026 19:32:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: contrib/jenkins.sh: add setup_venv()
by fixeria 23 Apr '26

23 Apr '26

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42657?usp=email ) Change subject: contrib/jenkins.sh: add setup_venv() ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42657?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibb193d12d5502c78104ef53badc6037f08e92df1 Gerrit-Change-Number: 42657 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 23 Apr 2026 19:32:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: contrib/jenkins.sh: separate JOB_TYPE for card tests
by fixeria 23 Apr '26

23 Apr '26

Attention is currently required from: dexter, laforge, osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42658?usp=email ) Change subject: contrib/jenkins.sh: separate JOB_TYPE for card tests ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patchset: PS5: Sorry for the noise. I discovered a few problems after deploying osmo-ci patches: https://gerrit.osmocom.org/c/osmo-ci/+/42669 jobs/master-builds.yml: fix typo: crad-test -> card-test [NEW] https://gerrit.osmocom.org/c/osmo-ci/+/42670 jobs/master-builds.yml: add missing job type 'distcheck' [NEW] https://gerrit.osmocom.org/c/osmo-ci/+/42671 jobs/gerrit-verifications.yml: pysim: allow skipping card tests [NEW] These fixes have been deployed too. We can merge this patchset now. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42658?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If76d812ee43b7eb3b57fdc660c60bf31fbff5b16 Gerrit-Change-Number: 42658 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Apr 2026 19:32:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/master-builds.yml: fix typo: crad-test -> card-test
by fixeria 23 Apr '26

23 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42669?usp=email ) Change subject: jobs/master-builds.yml: fix typo: crad-test -> card-test ...................................................................... jobs/master-builds.yml: fix typo: crad-test -> card-test Change-Id: I0686af6c026e298c86d3a64cc161e5c84ec7dc57 Fixes: ee1ef65 ("jobs/master-builds.yml: pysim: separate JOB_TYPE for card tests") --- M jobs/master-builds.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/69/42669/1 diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index fee8c57..9a18fc0 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -643,7 +643,7 @@ a2: !!python/tuple ["test", "card-test", "pylint", "docs"] combination_filter: > (JOB_TYPE == "test" && label == "osmocom-master") || - (JOB_TYPE == "crad-test" && label == "simtester") || + (JOB_TYPE == "card-test" && label == "simtester") || (JOB_TYPE == "pylint" && label == "osmocom-master") || (JOB_TYPE == "docs" && label == "osmocom-master") cmd: | -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42669?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0686af6c026e298c86d3a64cc161e5c84ec7dc57 Gerrit-Change-Number: 42669 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026