April 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: msc: Fix race condition in TC_reset_two(_1iu)
by osmith 02 Apr '26

02 Apr '26

Attention is currently required from: fixeria, jolly, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42578?usp=email ) Change subject: msc: Fix race condition in TC_reset_two(_1iu) ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42578/comment/ff7e09e0_810e… : PS1, Line 2414: istening ```suggestion * listening to events: */ ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42578?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I27afd7a47e6c6cf0f70e1ecc9e26dd2c220e72ab Gerrit-Change-Number: 42578 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Apr 2026 08:37:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: Fix race condition in TC_reset_two(_1iu)
by pespin 02 Apr '26

02 Apr '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42578?usp=email ) Change subject: msc: Fix race condition in TC_reset_two(_1iu) ...................................................................... msc: Fix race condition in TC_reset_two(_1iu) The test failed sporadically with: "RAN_Emulation.ttcnpp:600 Dynamic test case error: Sending data on the connection of port BSSAP to 659:SCCP_SP_PORT failed. (Broken pipe)" That's because it was simply waiting for a fixed amount of time while letting the underlaying RAN_Emulation do the RESET procedure. Sometimes it started tearing down the test before the procedure was fully completed, and RAN_Emulation failed passing the Reset (ACK) up the stack because the component was already unmapped. Fix the issue by making sure the RAN_Emulation finished the RESET procedure before stopping the testThe test. Change-Id: I27afd7a47e6c6cf0f70e1ecc9e26dd2c220e72ab --- M msc/MSC_Tests.ttcn 1 file changed, 17 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/42578/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index e9acddc..07e9b52 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -2407,10 +2407,20 @@ } /* Two BSSMAP resets from two different BSCs */ +private function f_tc_reset_two(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + f_init_handler(pars); + /* BSSAP Reset is performed by RAN_Emulation during its startup (main()). + * Simply do some query on RAN_Emulation to make sure it finished properly and hence it's + * istening to events: */ + f_ran_register_imsi(g_pars.imsi, g_pars.tmsi); +} testcase TC_reset_two() runs on MTC_CT { var BSC_ConnHdlr vc_conn; f_init(2); - f_sleep(2.0); + vc_conn := f_start_handler(refers(f_tc_reset_two), 420, ran_idx := 0); + vc_conn.done; + vc_conn := f_start_handler(refers(f_tc_reset_two), 420, ran_idx := 1); + vc_conn.done; setverdict(pass); } @@ -2418,7 +2428,12 @@ testcase TC_reset_two_1iu() runs on MTC_CT { var BSC_ConnHdlr vc_conn; f_init(3); - f_sleep(2.0); + vc_conn := f_start_handler(refers(f_tc_reset_two), 421, ran_idx := 0); + vc_conn.done; + vc_conn := f_start_handler(refers(f_tc_reset_two), 421, ran_idx := 1); + vc_conn.done; + vc_conn := f_start_handler(refers(f_tc_reset_two), 421, ran_idx := 2); + vc_conn.done; setverdict(pass); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42578?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I27afd7a47e6c6cf0f70e1ecc9e26dd2c220e72ab Gerrit-Change-Number: 42578 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: ASCI: Fix race condition in TC_assign_fail
by osmith 02 Apr '26

02 Apr '26

Attention is currently required from: fixeria, jolly, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42577?usp=email ) Change subject: msc: ASCI: Fix race condition in TC_assign_fail ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42577?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id80982b6b968bbe462aeac2b9be646ab50eace83 Gerrit-Change-Number: 42577 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Apr 2026 07:54:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: ASCI: Fix race condition in TC_assign_fail
by pespin 02 Apr '26

02 Apr '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42577?usp=email ) Change subject: msc: ASCI: Fix race condition in TC_assign_fail ...................................................................... msc: ASCI: Fix race condition in TC_assign_fail The f_sleep(0.5) to delay the registration of the PC for the 2nd SCCP connection sometimes fired too late and we received the VGCS/VBS Assignment Request before the channel ConnHdlr was registered in RAN_Emulation. Implement proper synchronization points to make sure the order of registers is accomplished while making sure the 2 ConnHdlrs are registered before they need it. Change-Id: Id80982b6b968bbe462aeac2b9be646ab50eace83 --- M msc/MSC_Tests_ASCI.ttcn 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/77/42577/1 diff --git a/msc/MSC_Tests_ASCI.ttcn b/msc/MSC_Tests_ASCI.ttcn index 135edb1..31047a6 100644 --- a/msc/MSC_Tests_ASCI.ttcn +++ b/msc/MSC_Tests_ASCI.ttcn @@ -76,6 +76,7 @@ const charstring COORD_BCC_TERMINATION_FAIL := "BCC_TERMINATION_FAIL"; const charstring COORD_ASSIGNMENT := "ASSIGNMENT"; const charstring COORD_CLEAR := "CLEAR"; +const charstring N_CONNECT_PC_REGISTERED := "N_CONNECT_PC_REGISTERED" template (value) DescriptiveGroupOrBroadcastCallReference_V ts_BSSMAP_IE_GroupCallRef(integer cr, @@ -255,6 +256,7 @@ f_init_handler(pars); f_create_bssmap_exp_n_connect(193); + COORD.send(N_CONNECT_PC_REGISTERED); timer T := 7.0; T.start; @@ -388,8 +390,9 @@ f_init_handler(pars); - /* Wait some time before registering, because this has to be the second connection to be registered. */ - f_sleep(0.5); + /* Wait for "control" to register first (VGCS/VBS Setup), because this has to be the second connection to be + * registered (VGCS/VBS Assignment Request). */ + COORD.receive(N_CONNECT_PC_REGISTERED); f_create_bssmap_exp_n_connect(193); timer T := 7.0; @@ -468,6 +471,11 @@ COORD_control.send(test); COORD_channel.send(test); + /* We need to make sure control resgisters first to receive the first SCCP connection (VGCS/VBS Setup) + * and channel later to receive the follow-up (VGCS/VBS Assignment Request) */ + COORD_control.receive(N_CONNECT_PC_REGISTERED); + COORD_channel.send(N_CONNECT_PC_REGISTERED); + /* Receive the test events until all three connections are released or not established. */ timer T := 7.0, Texit := 0.5; T.start; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42577?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id80982b6b968bbe462aeac2b9be646ab50eace83 Gerrit-Change-Number: 42577 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: lint/lint_diff: test_ruff: add pyosmocom
by osmith 02 Apr '26

02 Apr '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/41387?usp=email ) Change subject: lint/lint_diff: test_ruff: add pyosmocom ...................................................................... lint/lint_diff: test_ruff: add pyosmocom Ruff is very fast and detects some additional things that pylint (which is already used with pyosmocom) does not. Depends: pyosmocom I2ca3135f1ce38dcc06dc95c38f4b6258a60121cd Change-Id: I2fdb36c79efbd0f0fb4bdce3cd0045bb35d4cf64 --- M lint/lint_diff.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/lint/lint_diff.sh b/lint/lint_diff.sh index aa328ba..db5940a 100755 --- a/lint/lint_diff.sh +++ b/lint/lint_diff.sh @@ -105,6 +105,7 @@ osmo-ci osmo-dev osmo-ttcn3-hacks + pyosmocom " local format_projects=" osmo-ttcn3-hacks -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41387?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2fdb36c79efbd0f0fb4bdce3cd0045bb35d4cf64 Gerrit-Change-Number: 41387 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: stp: m3ua: Expect unsolicited ASPIA ACK after unblocking ASP
by osmith 02 Apr '26

02 Apr '26

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42576?usp=email ) Change subject: stp: m3ua: Expect unsolicited ASPIA ACK after unblocking ASP ...................................................................... Patch Set 1: (1 comment) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42576/comment/501ea5b0_c3c5… : PS1, Line 679: f_M3UA_exp(0, tr_M3UA_ASPIA_ACK(rctx_sender)); > Not needed, both cases are part of nightly, and latest is expectd to fail anyway since the whole fea […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42576?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4b70e576beae3c386d68f17a60d6f23d1a54293a Gerrit-Change-Number: 42576 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Apr 2026 07:27:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: stp: m3ua: Expect unsolicited ASPIA ACK after unblocking ASP
by osmith 02 Apr '26

02 Apr '26

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42576?usp=email ) Change subject: stp: m3ua: Expect unsolicited ASPIA ACK after unblocking ASP ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42576?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4b70e576beae3c386d68f17a60d6f23d1a54293a Gerrit-Change-Number: 42576 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Apr 2026 07:27:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: stp: m3ua: Expect unsolicited ASPIA ACK after unblocking ASP
by pespin 02 Apr '26

02 Apr '26

Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42576?usp=email ) Change subject: stp: m3ua: Expect unsolicited ASPIA ACK after unblocking ASP ...................................................................... Patch Set 1: (1 comment) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42576/comment/66dc2d00_981b… : PS1, Line 679: f_M3UA_exp(0, tr_M3UA_ASPIA_ACK(rctx_sender)); > wrap in `if (Misc_Helpers. […] Not needed, both cases are part of nightly, and latest is expectd to fail anyway since the whole feature is not implemented. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42576?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4b70e576beae3c386d68f17a60d6f23d1a54293a Gerrit-Change-Number: 42576 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Apr 2026 07:26:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: stp: m3ua: Expect unsolicited ASPIA ACK after unblocking ASP
by osmith 02 Apr '26

02 Apr '26

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42576?usp=email ) Change subject: stp: m3ua: Expect unsolicited ASPIA ACK after unblocking ASP ...................................................................... Patch Set 1: (1 comment) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42576/comment/919d5d2e_5098… : PS1, Line 679: f_M3UA_exp(0, tr_M3UA_ASPIA_ACK(rctx_sender)); wrap in `if (Misc_Helpers.f_osmo_repo_is("nightly")) {`? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42576?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4b70e576beae3c386d68f17a60d6f23d1a54293a Gerrit-Change-Number: 42576 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Apr 2026 07:25:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmo-sigtran[master]: Support administrative block in role ASP
by osmith 02 Apr '26

02 Apr '26

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42573?usp=email ) Change subject: Support administrative block in role ASP ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42573?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If32902575e874d2acc9a5fc12509af42ed151739 Gerrit-Change-Number: 42573 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Apr 2026 07:20:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026