April 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bsc[master]: ipaccess: fix buffer overread in ipacc_parse_supp_flags()
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42587?usp=email ) Change subject: ipaccess: fix buffer overread in ipacc_parse_supp_flags() ...................................................................... ipaccess: fix buffer overread in ipacc_parse_supp_flags() The loop used OSMO_MAX(e->len, 4), which iterates at least 4 times even when the IE is shorter than 4 bytes, causing a buffer overread. Replace with OSMO_MIN(e->len, sizeof(u32)) to cap the iteration both at the actual IE length and at the uint32_t accumulator size. Change-Id: I97c69a71eb650cbef1cc3652d0a2a966cfd6cf60 --- M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/87/42587/1 diff --git a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c index 23196fc..a197a79 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c @@ -47,7 +47,7 @@ { uint32_t u32 = 0; - for (unsigned int i = 0; i < OSMO_MAX(e->len, 4); i++) + for (unsigned int i = 0; i < OSMO_MIN(e->len, sizeof(u32)); i++) u32 |= e->val[i] << (i * 8); for (const struct value_string *vs = flags; vs->value && vs->str; vs++) { if (u32 & vs->value) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42587?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I97c69a71eb650cbef1cc3652d0a2a966cfd6cf60 Gerrit-Change-Number: 42587 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-bsc[master]: ipaccess: store Supported Features IE to the MO state
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42588?usp=email ) Change subject: ipaccess: store Supported Features IE to the MO state ...................................................................... ipaccess: store Supported Features IE to the MO state Change-Id: Ic89d42c478677ffda4d544f461e7850dd3157040 Related: OS#6324 --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c 2 files changed, 104 insertions(+), 31 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/88/42588/1 diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index 63cc8e2..cb19536 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -533,6 +533,11 @@ uint8_t availability; }; +struct ipacc_supp_feat { + bool present; + uint32_t val; +}; + struct gsm_abis_mo { uint8_t obj_class; uint8_t procedure_pending; @@ -555,6 +560,18 @@ union { struct { uint8_t obj_version; + /* relevant for NM_OC_BTS */ + struct ipacc_supp_feat max_ta; + /* relevant for NM_OC_RADIO_CARRIER */ + struct ipacc_supp_feat freq_bands; + /* relevant for NM_OC_BASEB_TRANSC */ + struct ipacc_supp_feat ciph_algos; + struct ipacc_supp_feat chan_types; + struct ipacc_supp_feat chan_modes; + struct ipacc_supp_feat rtp_features; + struct ipacc_supp_feat rsl_features; + /* relevant for NM_OC_GPRS_CELL */ + struct ipacc_supp_feat gprs_coding; } ipaccess; }; }; diff --git a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c index a197a79..34f3d02 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c @@ -40,29 +40,42 @@ } }; -static inline uint32_t ipacc_parse_supp_flags(const struct abis_om_fom_hdr *foh, - const struct value_string *flags, - const struct tlv_p_entry *e, - const char *text) +static void ipacc_parse_supp_flags(const struct abis_om_fom_hdr *foh, + const struct tlv_parsed *tp, + const enum ipac_eie tag, + struct ipacc_supp_feat *feat, + const struct value_string *flags, + const char *text) { - uint32_t u32 = 0; + const struct tlv_p_entry *e; - for (unsigned int i = 0; i < OSMO_MIN(e->len, sizeof(u32)); i++) - u32 |= e->val[i] << (i * 8); - for (const struct value_string *vs = flags; vs->value && vs->str; vs++) { - if (u32 & vs->value) - LOGPFOH(DNM, LOGL_INFO, foh, "%s '%s' is supported\n", text, vs->str); + feat->present = false; + feat->val = 0; + + if ((e = TLVP_GET(tp, tag)) == NULL) + return; + + for (unsigned int i = 0; i < OSMO_MIN(e->len, sizeof(feat->val)); i++) + feat->val |= e->val[i] << (i * 8); + feat->present = true; + + if (flags == NULL) { + LOGPFOH(DNM, LOGL_INFO, foh, "%s: %u\n", text, feat->val); + return; } - return u32; + for (const struct value_string *vs = flags; vs->value && vs->str; vs++) { + if (feat->val & vs->value) + LOGPFOH(DNM, LOGL_INFO, foh, "%s '%s' is supported\n", text, vs->str); + } } /* Parse ip.access Supported Features IE */ -int ipacc_parse_supp_features(const struct gsm_bts *bts, +int ipacc_parse_supp_features(struct gsm_bts *bts, const struct abis_om_fom_hdr *foh, const uint8_t *data, uint16_t data_len) { - const struct tlv_p_entry *e; + struct gsm_abis_mo *mo; struct tlv_parsed tp; if (tlv_parse(&tp, &ipacc_eie_tlv_def, data, data_len, 0, 0) < 0) { @@ -70,24 +83,67 @@ return -EINVAL; } - /* TODO: store the flags in the respective MO state */ - if ((e = TLVP_GET(&tp, NM_IPAC_EIE_FREQ_BANDS)) != NULL) - ipacc_parse_supp_flags(foh, abis_nm_ipacc_freq_band_desc, e, "Freq. band"); - if ((e = TLVP_GET(&tp, NM_IPAC_EIE_CIPH_ALGOS)) != NULL) - ipacc_parse_supp_flags(foh, abis_nm_ipacc_ciph_algo_desc, e, "Ciphering algorithm"); - if ((e = TLVP_GET(&tp, NM_IPAC_EIE_CHAN_TYPES)) != NULL) - ipacc_parse_supp_flags(foh, abis_nm_ipacc_chant_desc, e, "Channel type"); - if ((e = TLVP_GET(&tp, NM_IPAC_EIE_CHAN_MODES)) != NULL) - ipacc_parse_supp_flags(foh, abis_nm_ipacc_chanm_desc, e, "Channel mode"); - if ((e = TLVP_GET(&tp, NM_IPAC_EIE_GPRS_CODING)) != NULL) - ipacc_parse_supp_flags(foh, abis_nm_ipacc_gprs_coding_desc, e, "GPRS Coding Scheme"); - if ((e = TLVP_GET(&tp, NM_IPAC_EIE_RTP_FEATURES)) != NULL) - ipacc_parse_supp_flags(foh, abis_nm_ipacc_rtp_feat_desc, e, "RTP Feature"); - if ((e = TLVP_GET(&tp, NM_IPAC_EIE_RSL_FEATURES)) != NULL) - ipacc_parse_supp_flags(foh, abis_nm_ipacc_rsl_feat_desc, e, "RSL Feature"); - if (TLVP_PRES_LEN(&tp, NM_IPAC_EIE_MAX_TA, 1)) { - uint8_t u8 = *TLVP_VAL(&tp, NM_IPAC_EIE_MAX_TA); - LOGPFOH(DNM, LOGL_DEBUG, foh, "Max Timing Advance %u\n", u8); + /* store the flags to the respective MO state */ + mo = gsm_objclass2mo(bts, foh->obj_class, &foh->obj_inst); + if (mo == NULL) { + LOGPFOH(DNM, LOGL_ERROR, foh, + "%s(): gsm_objclass2mo() failed\n", __func__); + return -ENODEV; + } + + switch (mo->obj_class) { + case NM_OC_BTS: + ipacc_parse_supp_flags(foh, &tp, + NM_IPAC_EIE_MAX_TA, + &mo->ipaccess.max_ta, + NULL, "Max Timing Advance"); + break; + case NM_OC_RADIO_CARRIER: + ipacc_parse_supp_flags(foh, &tp, + NM_IPAC_EIE_FREQ_BANDS, + &mo->ipaccess.freq_bands, + abis_nm_ipacc_freq_band_desc, + "Freq. band"); + break; + case NM_OC_BASEB_TRANSC: + ipacc_parse_supp_flags(foh, &tp, + NM_IPAC_EIE_CIPH_ALGOS, + &mo->ipaccess.ciph_algos, + abis_nm_ipacc_ciph_algo_desc, + "Ciphering algorithm"); + ipacc_parse_supp_flags(foh, &tp, + NM_IPAC_EIE_CHAN_TYPES, + &mo->ipaccess.chan_types, + abis_nm_ipacc_chant_desc, + "Channel type"); + ipacc_parse_supp_flags(foh, &tp, + NM_IPAC_EIE_CHAN_MODES, + &mo->ipaccess.chan_modes, + abis_nm_ipacc_chanm_desc, + "Channel mode"); + ipacc_parse_supp_flags(foh, &tp, + NM_IPAC_EIE_RTP_FEATURES, + &mo->ipaccess.rtp_features, + abis_nm_ipacc_rtp_feat_desc, + "RTP Feature"); + ipacc_parse_supp_flags(foh, &tp, + NM_IPAC_EIE_RSL_FEATURES, + &mo->ipaccess.rsl_features, + abis_nm_ipacc_rsl_feat_desc, + "RSL Feature"); + break; + case NM_OC_GPRS_CELL: + ipacc_parse_supp_flags(foh, &tp, + NM_IPAC_EIE_GPRS_CODING, + &mo->ipaccess.gprs_coding, + abis_nm_ipacc_gprs_coding_desc, + "GPRS Coding Scheme"); + break; + default: + LOGPFOH(DNM, LOGL_NOTICE, foh, + "Unhandled NM_ATT_IPACC_SUPP_FEATURES IE: %s\n", + osmo_hexdump(data, data_len)); + return -ENOTSUP; } return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic89d42c478677ffda4d544f461e7850dd3157040 Gerrit-Change-Number: 42588 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: add TC_chan_act_nack_not_borken
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42583?usp=email ) Change subject: bsc: add TC_chan_act_nack_not_borken ...................................................................... bsc: add TC_chan_act_nack_not_borken Test that when the BTS NACKs a CHANnel ACTIVation with RSL_ERR_SERV_OPT_UNAVAIL or RSL_ERR_SERV_OPT_UNIMPL, the BSC: does NOT mark the lchan as BORKEN. Change-Id: I000b7b44749380c5af4da42abe37b4ada6e06ee4 Related: osmo-bsc.git Ide3830a697501a0c245a41451302f1e68d553b3c Related: OS#6324 --- M bsc/BSC_Tests.ttcn M bsc/expected-results.xml 2 files changed, 25 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/42583/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index a4c666e..9911368 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1623,6 +1623,29 @@ f_shutdown_helper(); } +/* Verify that a Chan Activ NACK with RSL_ERR_SERV_OPT_UNAVAIL or RSL_ERR_SERV_OPT_UNIMPL + * does not mark the lchan as BORKEN. The channel mode was not supported by the BTS, but + * the lchan hardware itself is fine and must remain available for future assignments. */ +testcase TC_chan_act_nack_not_borken() runs on test_CT { + var RSL_Message rx_rsl; + + f_init(1); + + f_ipa_tx(ts_RSL_CHAN_RQD('33'O, 33)); + rx_rsl := f_exp_ipa_rx(tr_RSL_CHAN_ACT); + f_ipa_tx(ts_RSL_CHAN_ACT_NACK(rx_rsl.ies[0].body.chan_nr, RSL_ERR_SERV_OPT_UNAVAIL)); + f_sleep(0.5); + f_vty_expect_borken(BSCVTY, false); + + f_ipa_tx(ts_RSL_CHAN_RQD('33'O, 33)); + rx_rsl := f_exp_ipa_rx(tr_RSL_CHAN_ACT); + f_ipa_tx(ts_RSL_CHAN_ACT_NACK(rx_rsl.ies[0].body.chan_nr, RSL_ERR_SERV_OPT_UNIMPL)); + f_sleep(0.5); + f_vty_expect_borken(BSCVTY, false); + + f_shutdown_helper(); +} + /* Test for channel exhaustion due to RACH overload */ testcase TC_chan_exhaustion() runs on test_CT { var ASP_RSL_Unitdata rsl_ud; @@ -12762,6 +12785,7 @@ execute( TC_chan_act_ack_est_ind_noreply() ); execute( TC_chan_act_ack_est_ind_refused() ); execute( TC_chan_act_nack() ); + execute( TC_chan_act_nack_not_borken() ); execute( TC_chan_exhaustion() ); execute( TC_chan_deact_silence() ); execute( TC_chan_rel_rll_rel_ind() ); diff --git a/bsc/expected-results.xml b/bsc/expected-results.xml index 90b613d..65a4ef1 100644 --- a/bsc/expected-results.xml +++ b/bsc/expected-results.xml @@ -35,6 +35,7 @@ <testcase classname='BSC_Tests' name='TC_chan_act_ack_est_ind_noreply' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_chan_act_ack_est_ind_refused' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_chan_act_nack' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_chan_act_nack_not_borken' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_chan_exhaustion' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_chan_deact_silence' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_chan_rel_rll_rel_ind' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42583?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I000b7b44749380c5af4da42abe37b4ada6e06ee4 Gerrit-Change-Number: 42583 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: verify Cell ID in BSSMAP HandoverPerformed
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42582?usp=email ) Change subject: bsc: verify Cell ID in BSSMAP HandoverPerformed ...................................................................... bsc: verify Cell ID in BSSMAP HandoverPerformed As per 3GPP TS 48.008 §3.2.1.25, HANDOVER PERFORMED must report the target cell. Add an optional cell_id parameter to the template (defaulting to '?' for backward compatibility) and update the two intra-BSC handover test helpers to assert that the Cell Identifier IE carries the target BTS (BTS 1: MCC=001 MNC=01 LAC=1 CI=1). Also remove the unnecessary interleave wrapper in f_tc_ho_during_lcs_loc_req(): the two receives arrive on separate ports (RAN_CONN vs BSSAP_LE) so sequential receive is sufficient. Change-Id: I82aadcc3a80c183cb93522b829071294b156a218 Related: osmo-bsc.git I4111351dc38fc2dbe844c2bd07b3ecfaaadd864e --- M bsc/BSC_Tests.ttcn M library/BSSMAP_Templates.ttcn 2 files changed, 21 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/42582/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index e97ecb0..a4c666e 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -5887,8 +5887,14 @@ } /* Since this is an internal handover we expect the BSC to inform the - * MSC about the event */ - RAN_CONN.receive(tr_BSSMAP_HandoverPerformed); + * MSC about the event. The Cell Identifier must report the *target* BTS + * (BTS 1: MCC=001 MNC=01 LAC=1 CI=1), not the source BTS. */ + alt { + [] RAN_CONN.receive(tr_BSSMAP_HandoverPerformed(tr_CellId_CGI('00F110'O, 1, 1))); + [] RAN_CONN.receive(tr_BSSMAP_HandoverPerformed) { + setverdict(fail, "BSSMAP HandoverPerformed indicates unexpected Cell ID"); + } + } /* Check the amount of MGCP transactions is still consistant with the * test expectation */ @@ -10855,17 +10861,21 @@ [] as_handover(hs); } + /* Expect the BSC to inform the MSC about the handover. The Cell Identifier + * must report the *target* BTS (BTS 1: MCC=001 MNC=01 LAC=1 CI=1). */ + alt { + [] RAN_CONN.receive(tr_BSSMAP_HandoverPerformed(tr_CellId_CGI('00F110'O, 1, 1))); + [] RAN_CONN.receive(tr_BSSMAP_HandoverPerformed) { + setverdict(fail, "BSSMAP HandoverPerformed indicates unexpected Cell ID"); + } + } + var PDU_BSSAP_LE rx_bsslap; - interleave { - /* Expect the BSC to inform the MSC about the handover */ - [] RAN_CONN.receive(tr_BSSMAP_HandoverPerformed); - /* Expect the BSC to inform the SMLC about the handover */ - [] BSSAP_LE.receive(tr_BSSMAP_LE_ConnInfo(BSSMAP_LE_PROT_BSSLAP, ?)) -> value(rx_bsslap) { + BSSAP_LE.receive(tr_BSSMAP_LE_ConnInfo(BSSMAP_LE_PROT_BSSLAP, ?)) -> value(rx_bsslap) { f_match_bsslap(rx_bsslap, tr_BSSLAP_Reset(BSSLAP_CAUSE_INTRA_BSS_HO)); } - } /* SMLC now responds with geo information data. */ BSSAP_LE.send(ts_BSSMAP_LE_PerfLocResp(gad_ell_point_unc_circle, omit)); diff --git a/library/BSSMAP_Templates.ttcn b/library/BSSMAP_Templates.ttcn index 563d6d1..deeabda 100644 --- a/library/BSSMAP_Templates.ttcn +++ b/library/BSSMAP_Templates.ttcn @@ -1331,14 +1331,15 @@ } } -template PDU_BSSAP tr_BSSMAP_HandoverPerformed +template PDU_BSSAP +tr_BSSMAP_HandoverPerformed(template (present) BSSMAP_IE_CellIdentifier cell_id := ?) modifies tr_BSSAP_BSSMAP := { pdu := { bssmap := { handoverPerformed := { messageType := '17'O, cause := ?, - cellIdentifier := ?, + cellIdentifier := cell_id, chosenChannel := *, chosenEncryptionAlgorithm := *, speechVersion := *, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42582?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I82aadcc3a80c183cb93522b829071294b156a218 Gerrit-Change-Number: 42582 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: library/RSL_Types: improve CHAN_ACTIV templates
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42581?usp=email ) Change subject: library/RSL_Types: improve CHAN_ACTIV templates ...................................................................... library/RSL_Types: improve CHAN_ACTIV templates Change-Id: I80af30fe9b24b93908876fd8059f45b6e3105406 --- M library/RSL_Types.ttcn 1 file changed, 8 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/81/42581/1 diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn index 4597cc0..d757731 100644 --- a/library/RSL_Types.ttcn +++ b/library/RSL_Types.ttcn @@ -1612,9 +1612,10 @@ /* DEDICATED CANNEL MANAGEMENT MESSAGES */ /* 8.4.1 BSC -> BTS */ - template (value) RSL_Message ts_RSL_CHAN_ACT(template (value) RslChannelNr chan_nr, - template (value) RSL_IE_ChannelMode mode, - template (value) RSL_IE_ActivationType at := c_RSL_IE_ActType_IA) := { + template (value) + RSL_Message ts_RSL_CHAN_ACT(template (value) RslChannelNr chan_nr, + template (value) RSL_IE_ChannelMode mode, + template (value) RSL_IE_ActivationType at := c_RSL_IE_ActType_IA) := { msg_disc := ts_RSL_MsgDisc(RSL_MDISC_DCHAN, false), msg_type := RSL_MT_CHAN_ACTIV, ies :={ @@ -1624,9 +1625,10 @@ /* lots of optional IEs */ } } - template RSL_Message tr_RSL_CHAN_ACT(template RslChannelNr chan_nr, - template RSL_IE_ChannelMode mode, - template (value) RSL_IE_ActivationType at := c_RSL_IE_ActType_IA) := { + template (present) RSL_Message + tr_RSL_CHAN_ACT(template (present) RslChannelNr chan_nr := ?, + template (present) RSL_IE_ChannelMode mode := ?, + template (present) RSL_IE_ActivationType at := ?) := { msg_disc := tr_RSL_MsgDisc(RSL_MDISC_DCHAN, false), msg_type := RSL_MT_CHAN_ACTIV, ies :={ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42581?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I80af30fe9b24b93908876fd8059f45b6e3105406 Gerrit-Change-Number: 42581 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: ASCI: Fix race condition in TC_assign_fail
by pespin 03 Apr '26

03 Apr '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42577?usp=email ) Change subject: msc: ASCI: Fix race condition in TC_assign_fail ...................................................................... msc: ASCI: Fix race condition in TC_assign_fail The f_sleep(0.5) to delay the registration of the PC for the 2nd SCCP connection sometimes fired too late and we received the VGCS/VBS Assignment Request before the channel ConnHdlr was registered in RAN_Emulation. Then in turn we need to delay call establishment until the channel is ready. Implement proper synchronization points to make sure the order of registers is accomplished while making sure the 2 ConnHdlrs are registered before they need it. Change-Id: Id80982b6b968bbe462aeac2b9be646ab50eace83 --- M msc/MSC_Tests_ASCI.ttcn 1 file changed, 22 insertions(+), 3 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified jolly: Looks good to me, but someone else must approve diff --git a/msc/MSC_Tests_ASCI.ttcn b/msc/MSC_Tests_ASCI.ttcn index 135edb1..9abcc28 100644 --- a/msc/MSC_Tests_ASCI.ttcn +++ b/msc/MSC_Tests_ASCI.ttcn @@ -76,6 +76,8 @@ const charstring COORD_BCC_TERMINATION_FAIL := "BCC_TERMINATION_FAIL"; const charstring COORD_ASSIGNMENT := "ASSIGNMENT"; const charstring COORD_CLEAR := "CLEAR"; +const charstring N_CONNECT_PC_REGISTERED := "N_CONNECT_PC_REGISTERED" +const charstring N_CALL_ESTABLISH := "N_CALL_ESTABLISH" template (value) DescriptiveGroupOrBroadcastCallReference_V ts_BSSMAP_IE_GroupCallRef(integer cr, @@ -143,6 +145,9 @@ var default mdcx := activate(as_optional_mgcp_mdcx(cpars.mgw_conn_2.mgw_rtp_ip, cpars.mgw_conn_2.mgw_rtp_port)); var default dlcx := activate(as_optional_mgcp_dlcx(cpars)); + /* Wait for other components to be prepared for the call: */ + COORD.receive(N_CALL_ESTABLISH); + /* Establish connection using the service type, defined by the test. */ if (test == COORD_TEST_COMPLETE_VBS) { f_establish_fully(EST_TYPE_VBS); @@ -255,6 +260,7 @@ f_init_handler(pars); f_create_bssmap_exp_n_connect(193); + COORD.send(N_CONNECT_PC_REGISTERED); timer T := 7.0; T.start; @@ -388,9 +394,12 @@ f_init_handler(pars); - /* Wait some time before registering, because this has to be the second connection to be registered. */ - f_sleep(0.5); + /* Wait for "control" to register first (VGCS/VBS Setup), because this has to be the second connection to be + * registered (VGCS/VBS Assignment Request). */ + COORD.receive(N_CONNECT_PC_REGISTERED); f_create_bssmap_exp_n_connect(193); + /* informwe applied the expect and we are ready: */ + COORD.send(N_CONNECT_PC_REGISTERED); timer T := 7.0; T.start; @@ -464,9 +473,19 @@ connect(self:COORD_control, vc_conn_control:COORD); connect(self:COORD_channel, vc_conn_channel:COORD); + COORD_channel.send(test); COORD_call.send(test); COORD_control.send(test); - COORD_channel.send(test); + + /* We need to make sure control resgisters first to receive the first SCCP connection (VGCS/VBS Setup) + * and channel later to receive the follow-up (VGCS/VBS Assignment Request) */ + COORD_control.receive(N_CONNECT_PC_REGISTERED); + COORD_channel.send(N_CONNECT_PC_REGISTERED); + /* channel confirms it is also applied on its side: */ + COORD_channel.receive(N_CONNECT_PC_REGISTERED); + + /* Inform we we can start the call: */ + COORD_call.send(N_CALL_ESTABLISH); /* Receive the test events until all three connections are released or not established. */ timer T := 7.0, Texit := 0.5; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42577?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id80982b6b968bbe462aeac2b9be646ab50eace83 Gerrit-Change-Number: 42577 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: ASCI: Fix race condition in TC_assign_fail
by fixeria 02 Apr '26

02 Apr '26

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42577?usp=email ) Change subject: msc: ASCI: Fix race condition in TC_assign_fail ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42577?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id80982b6b968bbe462aeac2b9be646ab50eace83 Gerrit-Change-Number: 42577 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Apr 2026 21:11:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: contrib/jenkins: add SKIP_FIRMWARE_CLEAN argument
by fixeria 02 Apr '26

02 Apr '26

Attention is currently required from: Hoernchen, lynxis lazus, osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42580?usp=email ) Change subject: contrib/jenkins: add SKIP_FIRMWARE_CLEAN argument ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42580?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I9e2342b8111645ef5d3b7bf4ac364ca592aa600b Gerrit-Change-Number: 42580 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 02 Apr 2026 21:09:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: enable GSMTAP logging
by fixeria 02 Apr '26

02 Apr '26

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39417?usp=email ) Change subject: s1gw: enable GSMTAP logging ...................................................................... Abandoned https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41628 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39417?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie787844e5b77b415260526f5abde78762c6b09db Gerrit-Change-Number: 39417 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: ASCI: Fix race condition in TC_assign_fail
by jolly 02 Apr '26

02 Apr '26

Attention is currently required from: fixeria, osmith, pespin. jolly has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42577?usp=email ) Change subject: msc: ASCI: Fix race condition in TC_assign_fail ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File msc/MSC_Tests_ASCI.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42577/comment/aee68ea4_0008… : PS1, Line 139: f_perform_lu(); > There is still a problem with a potential race condition. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42577?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id80982b6b968bbe462aeac2b9be646ab50eace83 Gerrit-Change-Number: 42577 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Apr 2026 18:41:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026