April 2026 - gerrit-log - lists.osmocom.org

[L] Change in pysim[master]: personalization: add param_source.py, add batch.py
by fixeria 24 Apr '26

24 Apr '26

Attention is currently required from: dexter, laforge, neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41845?usp=email ) Change subject: personalization: add param_source.py, add batch.py ...................................................................... Patch Set 9: (2 comments) File pySim/esim/saip/param_source.py: https://gerrit.osmocom.org/c/pysim/+/41845/comment/9391e7f1_0289ed8b?usp=em… : PS8, Line 116: > I wonder what happens when input_str is something like this: "12..345". […] This is a valid concern, indeed. I've added an additional check. https://gerrit.osmocom.org/c/pysim/+/41845/comment/86df4c62_e85134ad?usp=em… : PS8, Line 131: val = random.randint(*self.val_first_last) # TODO secure random source? > The line where you assign self. […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01ae40a06605eb205bfb409189fcd2b3a128855a Gerrit-Change-Number: 41845 Gerrit-PatchSet: 9 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Apr 2026 15:04:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: personalization: allow reading back multiple values from PES
by fixeria 24 Apr '26

24 Apr '26

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/40199?usp=email ) Change subject: personalization: allow reading back multiple values from PES ...................................................................... Abandoned I agree, it's better to fixup this commit into the previous one. Done in the next patchset. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iecb68af7c216c6b9dc3add469564416b6f37f7b2 Gerrit-Change-Number: 40199 Gerrit-PatchSet: 13 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: jobs/gerrit-verifications.yml: pysim: allow skipping card tests
by fixeria 24 Apr '26

24 Apr '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42671?usp=email ) Change subject: jobs/gerrit-verifications.yml: pysim: allow skipping card tests ...................................................................... jobs/gerrit-verifications.yml: pysim: allow skipping card tests I've already implemented this logic in 6a3b8a0, however by mistake I added it to master-builds.yml instead of gerrit-verifications.yml. This is wrong because we specifically need this feature for Jenkins verification, not for the master builds. For daily master builds, on the other hand, we specifically want to execute all existing job types, so revert my recent changes from master-builds.yml, but keep the new job type. Change-Id: I986d88545f64e13cd571ba9ff56bc924822e39a0 Fixes: 6a3b8a0 ("jobs/master-builds.yml: pysim: allow skipping card tests") --- M jobs/gerrit-verifications.yml M jobs/master-builds.yml 2 files changed, 12 insertions(+), 11 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved; Verified Jenkins Builder: Verified diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 1177a51..1585b10 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -103,6 +103,7 @@ timeout_cmd: '/usr/bin/timeout 30m' wrapper_cmd: '{timeout_cmd} /osmo-ci/scripts/wrapper_core_bt_on_error.sh' cmd: '{docker_run_ccache} {docker_img} {wrapper_cmd} /build/contrib/jenkins.sh' + check_jenkins_mark: 'git show --summary --format=%B | grep "^Jenkins:" | grep -q' gerrit_url: 'ssh://jenkins@gerrit.osmocom.org:29418' repos_url: '{gerrit_url}/{repos}' gerrit_project: '{repos}' @@ -535,16 +536,22 @@ concurrent: false slave_axis: !!python/tuple [simtester,osmocom-gerrit] a2_name: JOB_TYPE - a2: !!python/tuple ["test", "distcheck", "pylint", "docs"] + a2: !!python/tuple ["test", "card-test", "distcheck", "pylint", "docs"] combination_filter: > - (JOB_TYPE == "test" && label == "simtester") || + (JOB_TYPE == "test" && label == "osmocom-gerrit") || + (JOB_TYPE == "card-test" && label == "simtester") || (JOB_TYPE == "distcheck" && label == "osmocom-gerrit") || (JOB_TYPE == "pylint" && label == "osmocom-gerrit") || (JOB_TYPE == "docs" && label == "osmocom-gerrit") cmd: | case "$JOB_TYPE" in - "test") - {timeout_cmd} ./contrib/jenkins.sh + "card-test") + if {check_jenkins_mark} "skip-card-test"; then + # skip tests requiring physical cards + echo "GERRIT_PIPELINE_JOB_SKIPPED" + else + {timeout_cmd} ./contrib/jenkins.sh + fi ;; *) {docker_run} \ diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 4fcffdf..68c62fd 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -86,7 +86,6 @@ timeout_cmd: '/usr/bin/timeout 30m' wrapper_cmd: '{timeout_cmd} /osmo-ci/scripts/wrapper_core_bt_on_error.sh' cmd: '{docker_run_ccache} {docker_img} {wrapper_cmd} /build/contrib/jenkins.sh' - check_jenkins_mark: 'git show --summary --format=%B | grep "^Jenkins:" | grep -q' trigger: email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org gerrit_url: 'https://gerrit.osmocom.org' @@ -650,12 +649,7 @@ cmd: | case "$JOB_TYPE" in "card-test") - if {check_jenkins_mark} "skip-card-test"; then - # skip tests requiring physical cards - echo "GERRIT_PIPELINE_JOB_SKIPPED" - else - {timeout_cmd} ./contrib/jenkins.sh - fi + {timeout_cmd} ./contrib/jenkins.sh ;; *) {docker_run} \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I986d88545f64e13cd571ba9ff56bc924822e39a0 Gerrit-Change-Number: 42671 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: jobs/gerrit-verifications.yml: pysim: allow skipping card tests
by fixeria 24 Apr '26

24 Apr '26

Attention is currently required from: osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/42671?usp=email ) Change subject: jobs/gerrit-verifications.yml: pysim: allow skipping card tests ...................................................................... Patch Set 2: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I986d88545f64e13cd571ba9ff56bc924822e39a0 Gerrit-Change-Number: 42671 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Apr 2026 13:31:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: Fix: Prevent bankd from exiting upon SIGPIPE
by laforge 24 Apr '26

24 Apr '26

Attention is currently required from: jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42665?usp=email ) Change subject: Fix: Prevent bankd from exiting upon SIGPIPE ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42665?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I13d6e9da48d12f93c00bd2d021789bde71aca7cf Gerrit-Change-Number: 42665 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 24 Apr 2026 13:30:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-remsim[master]: Fix: Prevent race conditions when accessing slotmap in bankd
by laforge 24 Apr '26

24 Apr '26

Attention is currently required from: jolly, lynxis lazus. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email ) Change subject: Fix: Prevent race conditions when accessing slotmap in bankd ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: I actually think the naming with leading underscore from patchset 1 is better than the _nolock suffix, but it's not critical. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3464726f37beb7c47b4e1f00c018ffa4f3948906 Gerrit-Change-Number: 42664 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 24 Apr 2026 13:30:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: jobs/gerrit-verifications.yml: pysim: allow skipping card tests
by laforge 24 Apr '26

24 Apr '26

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/42671?usp=email ) Change subject: jobs/gerrit-verifications.yml: pysim: allow skipping card tests ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I'd have preferred a clean 100% revert of the wrong change followed by a commit for the new/fixed approach. not critical. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I986d88545f64e13cd571ba9ff56bc924822e39a0 Gerrit-Change-Number: 42671 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Apr 2026 13:26:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ci[master]: jobs/gerrit-verifications.yml: pysim: allow skipping card tests
by laforge 24 Apr '26

24 Apr '26

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/42671?usp=email ) Change subject: jobs/gerrit-verifications.yml: pysim: allow skipping card tests ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I986d88545f64e13cd571ba9ff56bc924822e39a0 Gerrit-Change-Number: 42671 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Apr 2026 13:25:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: jobs/gerrit-verifications.yml: pysim: allow skipping card tests
by fixeria 24 Apr '26

24 Apr '26

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/42671?usp=email ) Change subject: jobs/gerrit-verifications.yml: pysim: allow skipping card tests ...................................................................... Patch Set 2: (1 comment) File jobs/gerrit-verifications.yml: https://gerrit.osmocom.org/c/osmo-ci/+/42671/comment/29fc6a6c_4184ca09?usp=… : PS1, Line 541: label == "simtester" > https://gerrit.osmocom.org/c/docker-playground/+/42675 debian-trixie-build: add tshark […] Merged. I've updated this patch, testing now. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I986d88545f64e13cd571ba9ff56bc924822e39a0 Gerrit-Change-Number: 42671 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 24 Apr 2026 10:02:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: jobs/gerrit-verifications.yml: pysim: allow skipping card tests
by fixeria 24 Apr '26

24 Apr '26

Attention is currently required from: fixeria, laforge, osmith. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/42671?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+2 by osmith, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: jobs/gerrit-verifications.yml: pysim: allow skipping card tests ...................................................................... jobs/gerrit-verifications.yml: pysim: allow skipping card tests I've already implemented this logic in 6a3b8a0, however by mistake I added it to master-builds.yml instead of gerrit-verifications.yml. This is wrong because we specifically need this feature for Jenkins verification, not for the master builds. For daily master builds, on the other hand, we specifically want to execute all existing job types, so revert my recent changes from master-builds.yml, but keep the new job type. Change-Id: I986d88545f64e13cd571ba9ff56bc924822e39a0 Fixes: 6a3b8a0 ("jobs/master-builds.yml: pysim: allow skipping card tests") --- M jobs/gerrit-verifications.yml M jobs/master-builds.yml 2 files changed, 12 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/71/42671/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I986d88545f64e13cd571ba9ff56bc924822e39a0 Gerrit-Change-Number: 42671 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026