April 2026 - gerrit-log - lists.osmocom.org

[L] Change in pysim[master]: personalization: add param_source.py, add batch.py
by neels 24 Apr '26

24 Apr '26

Attention is currently required from: dexter, fixeria, laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41845?usp=email ) Change subject: personalization: add param_source.py, add batch.py ...................................................................... Patch Set 10: (1 comment) Patchset: PS8: > I have squashed a few later patches into this one to avoid merge conflicts and reduce the load on je […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01ae40a06605eb205bfb409189fcd2b3a128855a Gerrit-Change-Number: 41845 Gerrit-PatchSet: 10 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Apr 2026 21:25:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>

1 0

[S] Change in pysim[master]: ts_51_011/EF.SMSP: fix handling of 'alpha_id' field
by lynxis lazus 24 Apr '26

24 Apr '26

Attention is currently required from: dexter, fixeria, neels. lynxis lazus has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42662?usp=email ) Change subject: ts_51_011/EF.SMSP: fix handling of 'alpha_id' field ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/42662/comment/cb305ce4_cae86776?usp=em… : PS5, Line 344: self._construct = Struct('alpha_id'/GsmOrUcs2Adapter(Rpad(Bytes(this._.total_len-28))), > If we leave out the COptional, we make the parser more sensitive to broken file contents (see also t […] maybe add a short comment about COptional can't be used, see comment below. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42662?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0ec99b2648b22c56f9145345e4cd8776f9217701 Gerrit-Change-Number: 42662 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Apr 2026 21:17:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: ConfigurableParameter: do not magically overwrite the 'name' attribute
by fixeria 24 Apr '26

24 Apr '26

Attention is currently required from: laforge, neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41918?usp=email ) Change subject: ConfigurableParameter: do not magically overwrite the 'name' attribute ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/41918/comment/9d9a349a_bf7dde2b?usp=em… : PS2, Line 7: Co > do we have a rationale for that? it was one of the neat features to not force everyone to manually s […] Neels: please explain this change. The commit message does not tell why magically overwriting the name is wrong, and I have no idea either... -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41918?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6f631444c6addeb7ccc5f6c55b9be3dc83409169 Gerrit-Change-Number: 41918 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 24 Apr 2026 21:00:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: personalization audit: optionally audit all (unknown) SD keys
by fixeria 24 Apr '26

24 Apr '26

Attention is currently required from: laforge, neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40209?usp=email ) Change subject: personalization audit: optionally audit all (unknown) SD keys ...................................................................... Patch Set 10: (1 comment) File pySim/esim/saip/batch.py: https://gerrit.osmocom.org/c/pysim/+/40209/comment/5a55c6ed_0dac2a2b?usp=em… : PS10, Line 186: upp_audit[audit_key] = set((audit_val, )) Is it possible that the same KVN/ID combination appears in more than one SD PE? If so, the second occurrence silently replaces the first. We could handle this gracefully: ```suggestion upp_audit.add_values({audit_key: audit_val}) ``` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40209?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icaf6f7b589f117868633c0968a99f2f0252cf612 Gerrit-Change-Number: 40209 Gerrit-PatchSet: 10 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 24 Apr 2026 20:57:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in pysim[master]: comment in uicc.py on Security Domain Keys: add SCP81
by fixeria 24 Apr '26

24 Apr '26

Attention is currently required from: laforge, neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40204?usp=email ) Change subject: comment in uicc.py on Security Domain Keys: add SCP81 ...................................................................... Patch Set 10: (1 comment) Patchset: PS6: > We should give a spec reference We do have a spec. reference in the header of this file, so I am assuming the SCP81 range comes from there too? From ddbfc043ac0fd977a0b18f4b729b9211eea4d432, I see this is a non-public spec. so I cannot verify if it's actually defined there. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40204?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib0205880f58e78c07688b4637abd5f67ea0570d1 Gerrit-Change-Number: 40204 Gerrit-PatchSet: 10 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 24 Apr 2026 19:47:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libosmo-abis[master]: abis: align e1 input init prototypes for stricter compilers
by Timur Davydov 24 Apr '26

24 Apr '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/42677?usp=email ) Change subject: abis: align e1 input init prototypes for stricter compilers ...................................................................... abis: align e1 input init prototypes for stricter compilers Change return types of e1inp_dahdi_init(), e1inp_e1d_init() and e1inp_rs232_init() from void to int to match their implementations. Required for stricter compilers (e.g. Emscripten) which reject mismatched function prototypes. Change-Id: I93cd079003abb5665f1995647cfa94dc8e901ed9 --- M src/e1_input.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/77/42677/1 diff --git a/src/e1_input.c b/src/e1_input.c index c5ee38f..8c381ab 100644 --- a/src/e1_input.c +++ b/src/e1_input.c @@ -1151,10 +1151,10 @@ }; void e1inp_misdn_init(void); -void e1inp_dahdi_init(void); -void e1inp_e1d_init(void); +int e1inp_dahdi_init(void); +int e1inp_e1d_init(void); void e1inp_ipaccess_init(void); -void e1inp_rs232_init(void); +int e1inp_rs232_init(void); void e1inp_unixsocket_init(void); void e1inp_init(void) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/42677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I93cd079003abb5665f1995647cfa94dc8e901ed9 Gerrit-Change-Number: 42677 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in pysim[master]: personalization: make AlgorithmID a new EnumParam
by fixeria 24 Apr '26

24 Apr '26

Attention is currently required from: laforge, neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40201?usp=email ) Change subject: personalization: make AlgorithmID a new EnumParam ...................................................................... Patch Set 10: (1 comment) Patchset: PS7: > now if we still don't fix asn1tools and want to work around here, I would argue that anything repres […] Acknowledged. We should at least try to reuse the existing enum API of Python rather than reinventing the wheel here... I'll try reworking this patch to make use of it. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40201?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I71c2ec1b753c66cb577436944634f32792353240 Gerrit-Change-Number: 40201 Gerrit-PatchSet: 10 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 24 Apr 2026 17:59:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-ttcn3-hacks[master]: remsim: server: add a client timeout test
by lynxis lazus 24 Apr '26

24 Apr '26

Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154?usp=email to look at the new patch set (#4). Change subject: remsim: server: add a client timeout test ...................................................................... remsim: server: add a client timeout test 1. Connect to the server 2. Don't answer to IPA PINGs 3. Server closes the connection 4. Client reconnects 5. Older server versions will crash Related: OS#6957 Change-Id: Iec52d3ce229c2ab84ab0ff9d8dbbff59b7f3fbd9 --- M remsim/REMSIM_Tests.ttcn M remsim/RemsimServer_Tests.ttcn 2 files changed, 64 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/54/42154/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iec52d3ce229c2ab84ab0ff9d8dbbff59b7f3fbd9 Gerrit-Change-Number: 42154 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: remsim: server: add a client timeout test
by lynxis lazus 24 Apr '26

24 Apr '26

Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: remsim: server: add a client timeout test ...................................................................... remsim: server: add a client timeout test 1. Connect to the server 2. Don't answer to IPA PINGs 3. Server closes the connection 4. Client reconnects 5. Older server versions will crash Related: OS#6957 Change-Id: Iec52d3ce229c2ab84ab0ff9d8dbbff59b7f3fbd9 --- M remsim/REMSIM_Tests.ttcn M remsim/RemsimServer_Tests.ttcn 2 files changed, 64 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/54/42154/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iec52d3ce229c2ab84ab0ff9d8dbbff59b7f3fbd9 Gerrit-Change-Number: 42154 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: remsim: server: add a client timeout test
by lynxis lazus 24 Apr '26

24 Apr '26

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154?usp=email ) Change subject: remsim: server: add a client timeout test ...................................................................... Patch Set 2: (7 comments) File remsim/RemsimServer_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/bdc1b9e7_6f85… : PS2, Line 183: testcase TC_connect_client_timeout_reconnect() runs on test_CT { > TC_connect_client_ipa_ping_timeout_reconnect Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/8fc304fd_4fb4… : PS2, Line 189: g_T_guard.start(180.0); > These timings are way to high. […] There is no VTY on the remsim server. I've reduced the time outs a little bit. I hope this won't run into instabilities. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/1360ec24_5dfc… : PS2, Line 197: mtc.stop; > Misc_Helpers.f_shutdown() here and below. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/e9f78437_06be… : PS2, Line 216: } > these are usually indented one more level. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/f8ce79ff_c1b5… : PS2, Line 219: setverdict(fail, "Timed out. Server did not closed the connection."); > did not close Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/ab306907_eaec… : PS2, Line 232: if (not match(js.clients[0], tr_JsClient(CONNECTED_CLIENT, rspro[1].rspro_id))) { > Shouldn't this be rspro[0]. […] It is the same rspro_id for all clients. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/7b170985_15bf… : PS2, Line 661: execute( TC_connect_client_timeout_reconnect() ); > if it crashes, add a comment saying it crashes on version "<= N" and put it at the end. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iec52d3ce229c2ab84ab0ff9d8dbbff59b7f3fbd9 Gerrit-Change-Number: 42154 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Apr 2026 17:10:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026