April 2026 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: pySim/ts_51_011.py: add multi-record test vector for EF_PL
by dexter 07 Apr '26

07 Apr '26

Attention is currently required from: fixeria. dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42598?usp=email ) Change subject: pySim/ts_51_011.py: add multi-record test vector for EF_PL ...................................................................... Patch Set 1: Code-Review+2 Verified+1 (1 comment) Patchset: PS1: Now it also looks much better in the examples of the manual. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9f7a444b18056b1683cbd52a25af950125531746 Gerrit-Change-Number: 42598 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Apr 2026 16:00:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: tests: fix TransRecEF _test_de_encode to operate at file level
by dexter 07 Apr '26

07 Apr '26

Attention is currently required from: fixeria. dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42597?usp=email ) Change subject: tests: fix TransRecEF _test_de_encode to operate at file level ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4a9610f9ee39833cd0c90f64f89f5fbdd6f0846d Gerrit-Change-Number: 42597 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Apr 2026 15:56:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: filesystem: JsonEditor: offer interactive retry on error
by fixeria 07 Apr '26

07 Apr '26

Attention is currently required from: dexter. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42554?usp=email ) Change subject: filesystem: JsonEditor: offer interactive retry on error ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42554?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9161b7becea0d8dfd3f5f740fbb253da2f061a1d Gerrit-Change-Number: 42554 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Apr 2026 15:50:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: filesystem: JsonEditor: use NamedTemporaryFile
by fixeria 07 Apr '26

07 Apr '26

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42553?usp=email ) Change subject: filesystem: JsonEditor: use NamedTemporaryFile ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42553?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If3b0bd0fcc90732407dbd03b9cc883f7abeb948e Gerrit-Change-Number: 42553 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 07 Apr 2026 15:50:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in pysim[master]: docs: auto-generate Card Filesystem Reference
by fixeria 07 Apr '26

07 Apr '26

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42551?usp=email ) Change subject: docs: auto-generate Card Filesystem Reference ...................................................................... Patch Set 5: (1 comment) Patchset: PS4: > If there were such test vectors containing more than one language, I assume they would appear as arr […] See https://gerrit.osmocom.org/c/pysim/+/42597 and https://gerrit.osmocom.org/c/pysim/+/42598 adding a multi-record test vector. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42551?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I06ddeefc6c11e04d7c24e116f3f39c8a6635856f Gerrit-Change-Number: 42551 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 07 Apr 2026 15:49:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pySim/ts_51_011.py: add multi-record test vector for EF_PL
by fixeria 07 Apr '26

07 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42598?usp=email ) Change subject: pySim/ts_51_011.py: add multi-record test vector for EF_PL ...................................................................... pySim/ts_51_011.py: add multi-record test vector for EF_PL Change-Id: I9f7a444b18056b1683cbd52a25af950125531746 --- M pySim/ts_51_011.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/98/42598/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 51676c3..0dbf6eb 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -1068,6 +1068,7 @@ ( '6465', ["de"] ), ( '656e', ["en"] ), ( 'ffff', [None] ), + ( '656e64657275ffffffff', ["en", "de", "ru", None, None] ), ] def __init__(self, fid='2f05', sfid=0x05, name='EF.PL', desc='Preferred Languages'): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9f7a444b18056b1683cbd52a25af950125531746 Gerrit-Change-Number: 42598 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: tests: fix TransRecEF _test_de_encode to operate at file level
by fixeria 07 Apr '26

07 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42597?usp=email ) Change subject: tests: fix TransRecEF _test_de_encode to operate at file level ...................................................................... tests: fix TransRecEF _test_de_encode to operate at file level Previously, _test_de_encode vectors for TransRecEF subclasses were tested via decode_record_hex()/encode_record_hex(), i.e. one record at a time, with the decoded value being a scalar. Switch test_de_encode_record() in TransRecEF_Test to use decode_hex() / encode_hex() instead, so that vectors represent whole-file content (decoded value is a list of records) -- consistent with how LinFixedEF handles _test_de_encode. Update all existing vectors accordingly. Change-Id: I4a9610f9ee39833cd0c90f64f89f5fbdd6f0846d --- M pySim/ts_51_011.py M tests/unittests/test_files.py 2 files changed, 15 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/97/42597/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 44eccfa..51676c3 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -420,7 +420,7 @@ # TS 51.011 Section 10.3.1 class EF_LP(TransRecEF): _test_de_encode = [ - ( "24", "24"), + ( "24", ["24"] ), ] def __init__(self, fid='6f05', sfid=None, name='EF.LP', size=(1, None), rec_len=1, desc='Language Preference'): @@ -477,8 +477,8 @@ # TS 51.011 Section 10.3.4 class EF_PLMNsel(TransRecEF): _test_de_encode = [ - ( "22F860", { "mcc": "228", "mnc": "06" } ), - ( "330420", { "mcc": "334", "mnc": "020" } ), + ( "22F860", [{ "mcc": "228", "mnc": "06" }] ), + ( "330420", [{ "mcc": "334", "mnc": "020" }] ), ] def __init__(self, fid='6f30', sfid=None, name='EF.PLMNsel', desc='PLMN selector', size=(24, None), rec_len=3, **kwargs): @@ -692,7 +692,7 @@ # TS 51.011 Section 10.3.20 / 10.3.22 class EF_VGCS(TransRecEF): _test_de_encode = [ - ( "92f9ffff", "299" ), + ( "92f9ffff", ["299"] ), ] def __init__(self, fid='6fb1', sfid=None, name='EF.VGCS', size=(4, 200), rec_len=4, desc='Voice Group Call Service', **kwargs): @@ -828,9 +828,9 @@ # TS 51.011 Section 10.3.35..37 class EF_xPLMNwAcT(TransRecEF): _test_de_encode = [ - ( '62F2104000', { "mcc": "262", "mnc": "01", "act": [ "E-UTRAN NB-S1", "E-UTRAN WB-S1" ] } ), - ( '62F2108000', { "mcc": "262", "mnc": "01", "act": [ "UTRAN" ] } ), - ( '62F220488C', { "mcc": "262", "mnc": "02", "act": ['E-UTRAN NB-S1', 'E-UTRAN WB-S1', 'EC-GSM-IoT', 'GSM', 'NG-RAN'] } ), + ( '62F2104000', [{ "mcc": "262", "mnc": "01", "act": [ "E-UTRAN NB-S1", "E-UTRAN WB-S1" ] }] ), + ( '62F2108000', [{ "mcc": "262", "mnc": "01", "act": [ "UTRAN" ] }] ), + ( '62F220488C', [{ "mcc": "262", "mnc": "02", "act": ['E-UTRAN NB-S1', 'E-UTRAN WB-S1', 'EC-GSM-IoT', 'GSM', 'NG-RAN'] }] ), ] def __init__(self, fid='1234', sfid=None, name=None, desc=None, size=(40, None), rec_len=5, **kwargs): super().__init__(fid, sfid=sfid, name=name, desc=desc, size=size, rec_len=rec_len, **kwargs) @@ -1065,9 +1065,9 @@ # TS 102 221 Section 13.3 / TS 31.101 Section 13 / TS 51.011 Section 10.1.2 class EF_PL(TransRecEF): _test_de_encode = [ - ( '6465', "de" ), - ( '656e', "en" ), - ( 'ffff', None ), + ( '6465', ["de"] ), + ( '656e', ["en"] ), + ( 'ffff', [None] ), ] def __init__(self, fid='2f05', sfid=0x05, name='EF.PL', desc='Preferred Languages'): diff --git a/tests/unittests/test_files.py b/tests/unittests/test_files.py index 5bbbddd..e7c50dc 100755 --- a/tests/unittests/test_files.py +++ b/tests/unittests/test_files.py @@ -176,12 +176,11 @@ def test_de_encode_record(self): - """Test the decoder and encoder for a transparent record-oriented EF. Performs first a decoder - test, and then re-encodes the decoded data, comparing the re-encoded data with the - initial input data. + """Test the decoder and encoder for a transparent record-oriented EF at the whole-file + level. Performs first a decode test, then re-encodes and compares with the input. Requires the given TransRecEF subclass to have a '_test_de_encode' attribute, - containing a list of tuples. Each tuple has to be a 2-tuple (hexstring, decoded_dict). + containing a list of 2-tuples (hexstring, decoded_list). """ for c in self.classes: name = get_qualified_name(c) @@ -192,14 +191,12 @@ encoded = t[0] decoded = t[1] logging.debug("Testing decode of %s", name) - re_dec = inst.decode_record_hex(encoded) + re_dec = inst.decode_hex(encoded) self.assertEqual(decoded, re_dec) # re-encode the decoded data logging.debug("Testing re-encode of %s", name) - re_enc = inst.encode_record_hex(re_dec, len(encoded)//2) + re_enc = inst.encode_hex(re_dec, len(encoded)//2) self.assertEqual(encoded.upper(), re_enc.upper()) - # there's no point in testing padded input, as TransRecEF have a fixed record - # size and we cannot ever receive more input data than that size. class TransparentEF_Test(unittest.TestCase): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4a9610f9ee39833cd0c90f64f89f5fbdd6f0846d Gerrit-Change-Number: 42597 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: filesystem: JsonEditor: use NamedTemporaryFile
by dexter 07 Apr '26

07 Apr '26

Attention is currently required from: fixeria. dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42553?usp=email ) Change subject: filesystem: JsonEditor: use NamedTemporaryFile ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42553?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If3b0bd0fcc90732407dbd03b9cc883f7abeb948e Gerrit-Change-Number: 42553 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Apr 2026 15:44:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bsc[master]: lchan_fsm: ignore late lchan_rtp_fsm events
by dexter 07 Apr '26

07 Apr '26

Attention is currently required from: fixeria, neels. dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42591?usp=email ) Change subject: lchan_fsm: ignore late lchan_rtp_fsm events ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I have checked back the changes. To me everything looks good. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie6333bd941e4e5a6ddf0e3f113b8764e8bc2bbc0 Gerrit-Change-Number: 42591 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Apr 2026 15:41:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in pysim[master]: docs: auto-generate Card Filesystem Reference
by dexter 07 Apr '26

07 Apr '26

dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42551?usp=email ) Change subject: docs: auto-generate Card Filesystem Reference ...................................................................... Patch Set 5: (1 comment) File docs/pysim_fs_sphinx.py: https://gerrit.osmocom.org/c/pysim/+/42551/comment/64130382_9d79bcda?usp=em… : PS4, Line 121: for attr in ('_test_de_encode', '_test_decode'): > We don't want deprecated representations, though the fact that the only user of _test_encode is for […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42551?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I06ddeefc6c11e04d7c24e116f3f39c8a6635856f Gerrit-Change-Number: 42551 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 07 Apr 2026 15:34:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026