Attention is currently required from: laforge, neels.

fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41918?usp=email )

Change subject: ConfigurableParameter: do not magically overwrite the 'name' attribute ......................................................................

Patch Set 5:

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/pysim/+/41918/comment/50628d31_4402010a?usp=ema... : PS2, Line 7: Co

This tiny detail is just not worth even considering to spend time on. All time I spend ranting on this is another layer of ridiculous folly. We are discussing a class attribute.

This is not about discussing or ranting, but about documenting/explaining your changes (ideally in COMMIT_MSG), so that others could understand them. I was not closely following development of this API, so it was not clear to me what's wrong with the existing logic, and now I do understand the problem.

I welcome you to experiment with it to find a way that works well with this super weird code in place.

Harald's idea with automatic naming looks good to me. I guess it was simply not foreseen that classes would try to override the automatic naming. And it's actually easy to improve the logic instead of removing it: we can check if the `name` is already assigned and generate one automatically only if it's not. But I am not sure if it's worth it given that all classes seem to be setting `name` manually. @laforge@osmocom.org what do you think?

This here is an instance of very annoying code review, [...]

You may find this annoying, but do **do** need to understand the context in order to help with getting **your** patches merged. Honestly speaking, getting such emotional bursts in response to explain something does not make my task easy at all...