Attention is currently required from: laforge, neels.
fixeria has uploaded a new patch set (#5) to the change originally created by neels. ( https://gerrit.osmocom.org/c/pysim/+/42260?usp=email )
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: ConfigurableParameter: safer val length check
......................................................................
ConfigurableParameter: safer val length check
validate_val() calls len() to check the value against allow_len,
min_len and max_len. len() requires the object to have a __len__()
method, which integers do not — calling len() on an int raises
TypeError.
Fix this by checking for __len__ first: if present, use len(val) as
usual; otherwise fall back to len(str(val)), which gives the number
of decimal digits for integer values.
Change-Id: Ibe91722ed1477b00d20ef5e4e7abd9068ff2f3e4
Jenkins: skip-card-test
---
M pySim/esim/saip/personalization.py
1 file changed, 12 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/60/42260/5
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42260?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ibe91722ed1477b00d20ef5e4e7abd9068ff2f3e4
Gerrit-Change-Number: 42260
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Attention is currently required from: fixeria, laforge, neels.
fixeria has uploaded a new patch set (#5) to the change originally created by neels. ( https://gerrit.osmocom.org/c/pysim/+/42262?usp=email )
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: test_configurable_parameters.py: add tests for new parameters
......................................................................
test_configurable_parameters.py: add tests for new parameters
For:
SmspTpScAddr
MilenageRotation
MilenageXoringConstants
TuakNrOfKeccak
Change-Id: Iecbea14fe31a9ee08d871dcde7f295d26d7bd001
Jenkins: skip-card-test
---
M tests/unittests/test_configurable_parameters.py
M tests/unittests/xo/test_configurable_parameters
2 files changed, 380 insertions(+), 43 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/62/42262/5
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42262?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iecbea14fe31a9ee08d871dcde7f295d26d7bd001
Gerrit-Change-Number: 42262
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/42653?usp=email )
Change subject: vty: make CPU scheduling optional based on platform support
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/42653/comment/dcbf3972_6ccf200e?… :
PS1, Line 15: Also change osmo_cpu_sched_vty_init() to return int.
> This would break ABI. […]
The function osmo_cpu_sched_vty_init() is already implemented with return type int in cpu_sched_vty.c (see line 610).
However, in the header file cpu_sched_vty.h it was incorrectly declared as returning void. This mismatch leads to inconsistent declarations across translation units.
More strict compilers, such as Emscripten, reject this with an error, as they do not allow conflicting function signatures.
So this change does not actually modify the ABI — it fixes the header to match the existing implementation.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42653?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic5b7e39fac16531d370cb81f769ba87fef18cb81
Gerrit-Change-Number: 42653
Gerrit-PatchSet: 1
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 25 Apr 2026 21:11:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>