Attention is currently required from: dexter.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42551?usp=email )
Change subject: docs: auto-generate Card Filesystem Reference
......................................................................
Patch Set 4:
(1 comment)
File docs/pysim_fs_sphinx.py:
https://gerrit.osmocom.org/c/pysim/+/42551/comment/30896e24_9a13acda?usp=em… :
PS4, Line 121: for attr in ('_test_de_encode', '_test_decode'):
> we do not use _test_encode here? I know we rarely have it. […]
The comment near `_test_encode` in `class EF_MSISDN` states: "Ensure deprecated representations still work" - do we really want to include deprecated representations in the user manual?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42551?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I06ddeefc6c11e04d7c24e116f3f39c8a6635856f
Gerrit-Change-Number: 42551
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Apr 2026 14:14:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42551?usp=email )
Change subject: docs: auto-generate Card Filesystem Reference
......................................................................
Patch Set 4:
(1 comment)
File docs/pysim_fs_sphinx.py:
https://gerrit.osmocom.org/c/pysim/+/42551/comment/b9660a0b_6eb05438?usp=em… :
PS4, Line 144: lines.append(f' // {comment}\n')
> This appears in the JSON examples in the manual. […]
The next patch (https://gerrit.osmocom.org/c/pysim/+/42552) is adding exactly that: it's adding examples to the temporary file as comments, and then strips all comments before loading JSON from that file. It's a pity that such a wide-spread format still does not support comments...
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42551?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I06ddeefc6c11e04d7c24e116f3f39c8a6635856f
Gerrit-Change-Number: 42551
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Apr 2026 13:54:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: fixeria.
dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42551?usp=email )
Change subject: docs: auto-generate Card Filesystem Reference
......................................................................
Patch Set 4:
(1 comment)
File docs/pysim_fs_sphinx.py:
https://gerrit.osmocom.org/c/pysim/+/42551/comment/6366ecd4_5c5da267?usp=em… :
PS4, Line 144: lines.append(f' // {comment}\n')
> This appears in the JSON examples in the manual. […]
Ah, I see there is a follow up patch that does the comment stripping.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42551?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I06ddeefc6c11e04d7c24e116f3f39c8a6635856f
Gerrit-Change-Number: 42551
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Apr 2026 13:52:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: fixeria.
dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42551?usp=email )
Change subject: docs: auto-generate Card Filesystem Reference
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I would also recommend to look at the generated examples for EF.PL. The examples seem to be correctly generated but the file may take multiple concatenated values. In pySim-shell, it looks like this:
[
"de",
"en",
null,
null,
null
]
Nevertheless, the examples work, they just show how to encode the file contents for a signle language. Maybe this can be fixed by adding another unit-tests that encodes multiple languages.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42551?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I06ddeefc6c11e04d7c24e116f3f39c8a6635856f
Gerrit-Change-Number: 42551
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Apr 2026 13:49:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria.
dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42551?usp=email )
Change subject: docs: auto-generate Card Filesystem Reference
......................................................................
Patch Set 4: Code-Review+1 Verified+1
(3 comments)
Patchset:
PS4:
I have now looked through this and also tried it out. As it seems everything works as expected. Please have a quick look at the two comments I put.
As it seems now we now need more unit-tests so that the manual gets more examples...
File docs/pysim_fs_sphinx.py:
https://gerrit.osmocom.org/c/pysim/+/42551/comment/604ce236_f5d59c70?usp=em… :
PS4, Line 121: for attr in ('_test_de_encode', '_test_decode'):
we do not use _test_encode here? I know we rarely have it. I think EF_MSISDN is the only file that uses it.
https://gerrit.osmocom.org/c/pysim/+/42551/comment/5453a005_c6267dd2?usp=em… :
PS4, Line 144: lines.append(f' // {comment}\n')
This appears in the JSON examples in the manual. For me it is obvious what this means, but maybe users will copy+paste those examples. Then the comment causes an error. Maybe we should add functionality to pySim-shell to strip any comments from the JSON? I also think that we had this discussion before. If you say a good way how to format this differently in the manual text, I would recommend to change this. If it is difficult or messes up the formatting I would keep it like it is.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42551?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I06ddeefc6c11e04d7c24e116f3f39c8a6635856f
Gerrit-Change-Number: 42551
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Apr 2026 13:44:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42590?usp=email )
Change subject: assignment_fsm: check ipaccess channel mode support
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/assignment_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/42590/comment/21992dcf_aa3dcec5?usp… :
PS1, Line 375: const struct ipacc_supp_feat *feat =
> might be prudent to add an OSMO_ASSERT on the correct BTS type here. […]
I can add an assert, but this is a static function that is currently used only once, and even if someone calls it for a non-ipaccess BTS nothing bad will happen: it will return `true` early because `!feat->present` will be `true` (because Supported Features IE was never received).
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42590?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I680ba7993786f5486d671f931e75df4543670a37
Gerrit-Change-Number: 42590
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 07 Apr 2026 13:28:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42592?usp=email )
Change subject: lchan_fsm: don't mark lchan as BORKEN on unsupported mode NACK
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42592?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ide3830a697501a0c245a41451302f1e68d553b3c
Gerrit-Change-Number: 42592
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Apr 2026 11:02:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes