April 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-sgsn[master]: Fixed PDP QoS return length and terminal reconnection issues.
by fixeria 06 Apr '26

06 Apr '26

Attention is currently required from: canghaiwuhen, laforge. fixeria has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email ) Change subject: Fixed PDP QoS return length and terminal reconnection issues. ...................................................................... Patch Set 18: (1 comment) Patchset: PS18: I decided to rework and split this patch myself, so that it does not get stuck in Gerrit forever. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I11c24b64f0e49cf80c825969dbf018b2948d855c Gerrit-Change-Number: 42050 Gerrit-PatchSet: 18 Gerrit-Owner: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Comment-Date: Mon, 06 Apr 2026 16:22:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-bsc[master]: lchan_fsm: don't mark lchan as BORKEN on unsupported mode NACK
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc/+/42592?usp=email ) Change subject: lchan_fsm: don't mark lchan as BORKEN on unsupported mode NACK ...................................................................... lchan_fsm: don't mark lchan as BORKEN on unsupported mode NACK When the BTS NACKs a Channel Activation with RSL_ERR_SERV_OPT_UNAVAIL or RSL_ERR_SERV_OPT_UNIMPL, it means the requested service or channel mode is not supported - not that the hardware is broken. In this case the lchan should transition to LCHAN_ST_WAIT_AFTER_ERROR rather than LCHAN_ST_BORKEN, which is reserved for genuine hardware failures. Change-Id: Ide3830a697501a0c245a41451302f1e68d553b3c Related: osmo-ttcn3-hacks.git I000b7b44749380c5af4da42abe37b4ada6e06ee4 Related: OS#6324 --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 14 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/92/42592/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42592?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ide3830a697501a0c245a41451302f1e68d553b3c Gerrit-Change-Number: 42592 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: assignment_fsm: pass lchan to lchan_type_compat_with_mode()
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42589?usp=email ) Change subject: assignment_fsm: pass lchan to lchan_type_compat_with_mode() ...................................................................... assignment_fsm: pass lchan to lchan_type_compat_with_mode() The lchan pointer is needed by the next patch, which will check the BTS ipaccess supported-features flags to reject channel modes that the BTS has reported as unsupported before attempting to activate the lchan. Change-Id: I51d5d1a1cf3c51f85f738196967d5c69870681bb Related: OS#6324 --- M src/osmo-bsc/assignment_fsm.c 1 file changed, 7 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/89/42589/1 diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c index e5392f6..11408d6 100644 --- a/src/osmo-bsc/assignment_fsm.c +++ b/src/osmo-bsc/assignment_fsm.c @@ -365,14 +365,15 @@ new_lchan->ts->max_primary_lchans : 0)); } -static bool lchan_type_compat_with_mode(enum gsm_chan_t type, const struct channel_mode_and_rate *ch_mode_rate) +static bool lchan_type_compat_with_mode(const struct gsm_lchan *lchan, + const struct channel_mode_and_rate *ch_mode_rate) { enum gsm48_chan_mode chan_mode = ch_mode_rate->chan_mode; enum channel_rate chan_rate = ch_mode_rate->chan_rate; switch (gsm48_chan_mode_to_non_vamos(chan_mode)) { case GSM48_CMODE_SIGN: - switch (type) { + switch (lchan->type) { case GSM_LCHAN_TCH_F: return chan_rate == CH_RATE_FULL; case GSM_LCHAN_TCH_H: return chan_rate == CH_RATE_HALF; case GSM_LCHAN_SDCCH: return chan_rate == CH_RATE_SDCCH; @@ -385,7 +386,7 @@ case GSM48_CMODE_DATA_6k0: /* these services can all run on TCH/H, but we may have * an explicit override by the 'chan_rate' argument */ - switch (type) { + switch (lchan->type) { case GSM_LCHAN_TCH_F: return chan_rate == CH_RATE_FULL; case GSM_LCHAN_TCH_H: @@ -398,7 +399,7 @@ case GSM48_CMODE_DATA_14k5: case GSM48_CMODE_SPEECH_EFR: /* these services all explicitly require a TCH/F */ - return type == GSM_LCHAN_TCH_F; + return lchan->type == GSM_LCHAN_TCH_F; default: return false; @@ -473,7 +474,7 @@ /* Check if the currently existing lchan is compatible with the * preferred rate/codec. */ for (i = 0; i < req->n_ch_mode_rate; i++) { - if (!lchan_type_compat_with_mode(conn->lchan->type, &req->ch_mode_rate_list[i])) + if (!lchan_type_compat_with_mode(conn->lchan, &req->ch_mode_rate_list[i])) continue; conn->assignment.selected_ch_mode_rate = req->ch_mode_rate_list[i]; return true; @@ -664,7 +665,7 @@ conn->assignment.new_lchan = req->target_lchan; matching_mode = false; for (i = 0; i < req->n_ch_mode_rate; i++) { - if (!lchan_type_compat_with_mode(conn->assignment.new_lchan->type, &req->ch_mode_rate_list[i])) + if (!lchan_type_compat_with_mode(conn->assignment.new_lchan, &req->ch_mode_rate_list[i])) continue; conn->assignment.selected_ch_mode_rate = req->ch_mode_rate_list[i]; matching_mode = true; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I51d5d1a1cf3c51f85f738196967d5c69870681bb Gerrit-Change-Number: 42589 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: lchan_fsm: ignore late lchan_rtp_fsm events
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42591?usp=email ) Change subject: lchan_fsm: ignore late lchan_rtp_fsm events ...................................................................... lchan_fsm: ignore late lchan_rtp_fsm events The lchan_rtp_fsm is a child FSM that manages the MGW/RTP endpoint. When the parent lchan_fsm transitions away before the child has finished its work (e.g. a CRCX timeout or a DLCX completing after the lchan is already idle), the child can still deliver LCHAN_EV_RTP_RELEASED or LCHAN_EV_RTP_ERROR to the parent. Currently these late events are not in the in_event_mask of every state that can be reached with the child still running: * LCHAN_ST_UNUSED: entered from WAIT_AFTER_ERROR after the error timer fires, while a DLCX triggered at error time may still be in flight. * LCHAN_ST_WAIT_AFTER_ERROR: already handles LCHAN_EV_RTP_RELEASED but misses LCHAN_EV_RTP_ERROR (e.g. CRCX timeout arriving after the NACK was handled). Add the missing events to both states' in_event_mask and provide a no-op handler in lchan_fsm_unused() so that the assert is not hit. Change-Id: Ie6333bd941e4e5a6ddf0e3f113b8764e8bc2bbc0 --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/91/42591/1 diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 55875f0..524d66e 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -736,6 +736,11 @@ lchan_fsm_state_chg(LCHAN_ST_WAIT_TS_READY); break; + case LCHAN_EV_RTP_RELEASED: + case LCHAN_EV_RTP_ERROR: + /* Ignore late lchan_rtp_fsm events arriving after the lchan is back to UNUSED. */ + break; + default: OSMO_ASSERT(false); } @@ -1710,6 +1715,8 @@ .action = lchan_fsm_unused, .in_event_mask = 0 | S(LCHAN_EV_ACTIVATE) + | S(LCHAN_EV_RTP_RELEASED) /* ignore late lchan_rtp_fsm release events */ + | S(LCHAN_EV_RTP_ERROR) /* ignore late lchan_rtp_fsm error events */ , .out_state_mask = 0 | S(LCHAN_ST_WAIT_TS_READY) @@ -1869,6 +1876,7 @@ .onenter = lchan_fsm_wait_after_error_onenter, .in_event_mask = 0 | S(LCHAN_EV_RTP_RELEASED) /* ignore late lchan_rtp_fsm release events */ + | S(LCHAN_EV_RTP_ERROR) /* ignore late lchan_rtp_fsm error events */ , .out_state_mask = 0 | S(LCHAN_ST_UNUSED) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie6333bd941e4e5a6ddf0e3f113b8764e8bc2bbc0 Gerrit-Change-Number: 42591 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-bsc[master]: assignment_fsm: check ipaccess channel mode support
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42590?usp=email ) Change subject: assignment_fsm: check ipaccess channel mode support ...................................................................... assignment_fsm: check ipaccess channel mode support Add ipacc_chan_mode_supported(), which checks the NM_IPAC_F_CHANM_* flags stored in the Baseband Transceiver's MO state (populated during OML bring-up) to decide whether the BTS can handle a requested channel mode. If the IE containing supported channel modes was never received, the function returns true as if the given mode was supported. Without this change, requesting a channel mode not supported by the BTS results in a NACK to the RSL Channel Activation, which causes the lchan to be marked as BROKEN and thus unavailable. Change-Id: I680ba7993786f5486d671f931e75df4543670a37 Related: OS#6324 --- M src/osmo-bsc/assignment_fsm.c 1 file changed, 102 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/90/42590/1 diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c index 11408d6..54a57aa 100644 --- a/src/osmo-bsc/assignment_fsm.c +++ b/src/osmo-bsc/assignment_fsm.c @@ -365,6 +365,86 @@ new_lchan->ts->max_primary_lchans : 0)); } +/* Check whether the ipaccess BTS supports the requested channel mode. + * Returns false if the BTS has reported its supported channel modes and the + * requested mode is absent from that list. Returns true if the Supported + * Features IE was never received (older osmo-bts versions do not send it). */ +static bool ipacc_chan_mode_supported(const struct gsm_lchan *lchan, + const struct channel_mode_and_rate *ch_mode_rate) +{ + const struct ipacc_supp_feat *feat = + &lchan->ts->trx->bb_transc.mo.ipaccess.chan_modes; + uint32_t flag = 0; + + /* Supported Features IE was not received */ + if (!feat->present) + return true; + + switch (gsm48_chan_mode_to_non_vamos(ch_mode_rate->chan_mode)) { + case GSM48_CMODE_SPEECH_V1: + flag = (lchan->type == GSM_LCHAN_TCH_H) + ? NM_IPAC_F_CHANM_SPEECH_HS : NM_IPAC_F_CHANM_SPEECH_FS; + break; + case GSM48_CMODE_SPEECH_EFR: + flag = NM_IPAC_F_CHANM_SPEECH_EFS; + break; + case GSM48_CMODE_SPEECH_AMR: + flag = (lchan->type == GSM_LCHAN_TCH_H) + ? NM_IPAC_F_CHANM_SPEECH_AHS : NM_IPAC_F_CHANM_SPEECH_AFS; + break; + case GSM48_CMODE_DATA_3k6: + case GSM48_CMODE_DATA_6k0: + case GSM48_CMODE_DATA_12k0: + case GSM48_CMODE_DATA_14k5: + if (ch_mode_rate->data_transparent) { + switch (ch_mode_rate->data_rate.t) { + case RSL_CMOD_CSD_T_1200_75: + flag = NM_IPAC_F_CHANM_CSD_T_1200_75; + break; + case RSL_CMOD_CSD_T_600: + flag = NM_IPAC_F_CHANM_CSD_T_600; + break; + case RSL_CMOD_CSD_T_1k2: + flag = NM_IPAC_F_CHANM_CSD_T_1k2; + break; + case RSL_CMOD_CSD_T_2k4: + flag = NM_IPAC_F_CHANM_CSD_T_2k4; + break; + case RSL_CMOD_CSD_T_4k8: + flag = NM_IPAC_F_CHANM_CSD_T_4k8; + break; + case RSL_CMOD_CSD_T_9k6: + flag = NM_IPAC_F_CHANM_CSD_T_9k6; + break; + case RSL_CMOD_CSD_T_14k4: + flag = NM_IPAC_F_CHANM_CSD_T_14k4; + break; + default: + return true; /* unhandled T rate */ + } + } else { + switch (ch_mode_rate->data_rate.nt) { + case RSL_CMOD_CSD_NT_6k0: + flag = NM_IPAC_F_CHANM_CSD_NT_4k8; + break; + case RSL_CMOD_CSD_NT_12k0: + flag = NM_IPAC_F_CHANM_CSD_NT_9k6; + break; + case RSL_CMOD_CSD_NT_14k5: + flag = NM_IPAC_F_CHANM_CSD_NT_14k4; + break; + default: + return true; /* unhandled NT rate */ + } + } + break; + default: + return true; /* unknown channel mode */ + } + + return (feat->val & flag) != 0; +} + static bool lchan_type_compat_with_mode(const struct gsm_lchan *lchan, const struct channel_mode_and_rate *ch_mode_rate) { @@ -373,6 +453,8 @@ switch (gsm48_chan_mode_to_non_vamos(chan_mode)) { case GSM48_CMODE_SIGN: + /* Signalling does not require a specific channel mode on the BTS, + * so skip the ipaccess feature check (below) and return directly. */ switch (lchan->type) { case GSM_LCHAN_TCH_F: return chan_rate == CH_RATE_FULL; case GSM_LCHAN_TCH_H: return chan_rate == CH_RATE_HALF; @@ -388,22 +470,39 @@ * an explicit override by the 'chan_rate' argument */ switch (lchan->type) { case GSM_LCHAN_TCH_F: - return chan_rate == CH_RATE_FULL; + if (chan_rate != CH_RATE_FULL) + return false; + break; case GSM_LCHAN_TCH_H: - return chan_rate == CH_RATE_HALF; + if (chan_rate != CH_RATE_HALF) + return false; + break; default: return false; } + break; case GSM48_CMODE_DATA_12k0: case GSM48_CMODE_DATA_14k5: case GSM48_CMODE_SPEECH_EFR: /* these services all explicitly require a TCH/F */ - return lchan->type == GSM_LCHAN_TCH_F; + if (lchan->type != GSM_LCHAN_TCH_F) + return false; + break; default: return false; } + + switch (lchan->ts->trx->bts->type) { + case GSM_BTS_TYPE_NANOBTS: + case GSM_BTS_TYPE_OSMOBTS: + /* osmo-bts and nanoBTS report supported channel modes during + * the OML bring-up - additionally check them */ + return ipacc_chan_mode_supported(lchan, ch_mode_rate); + default: + return true; + } } static __attribute__((constructor)) void assignment_fsm_init(void) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42590?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I680ba7993786f5486d671f931e75df4543670a37 Gerrit-Change-Number: 42590 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: lchan_fsm: don't mark lchan as BORKEN on unsupported mode NACK
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42592?usp=email ) Change subject: lchan_fsm: don't mark lchan as BORKEN on unsupported mode NACK ...................................................................... lchan_fsm: don't mark lchan as BORKEN on unsupported mode NACK When the BTS NACKs a Channel Activation with RSL_ERR_SERV_OPT_UNAVAIL or RSL_ERR_SERV_OPT_UNIMPL, it means the requested service or channel mode is not supported - not that the hardware is broken. In this case the lchan should transition to LCHAN_ST_WAIT_AFTER_ERROR rather than LCHAN_ST_BORKEN, which is reserved for genuine hardware failures. Also add LCHAN_EV_RTP_ERROR to LCHAN_ST_WAIT_AFTER_ERROR's in_event_mask so that a late LCHAN_EV_RTP_ERROR (e.g. MGCP CRCX timeout arriving after the NACK was already handled) is silently absorbed rather than triggering an unexpected-event warning. Change-Id: Ide3830a697501a0c245a41451302f1e68d553b3c Related: osmo-ttcn3-hacks.git I000b7b44749380c5af4da42abe37b4ada6e06ee4 Related: OS#6324 --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 14 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/92/42592/1 diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 524d66e..afb5cc8 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -977,12 +977,22 @@ lchan->release.rsl_error_cause = *(uint8_t*)data; lchan->release.rr_cause = bsc_gsm48_rr_cause_from_rsl_cause(lchan->release.rsl_error_cause); lchan->release.in_error = true; - if (lchan->release.rsl_error_cause != RSL_ERR_RCH_ALR_ACTV_ALLOC) - next_state = LCHAN_ST_BORKEN; - else + switch (lchan->release.rsl_error_cause) { + case RSL_ERR_RCH_ALR_ACTV_ALLOC: /* Taking this over from legacy code: send an RF Chan Release even though * the Activ was NACKed. Is this really correct? */ next_state = LCHAN_ST_WAIT_RF_RELEASE_ACK; + break; + case RSL_ERR_SERV_OPT_UNAVAIL: + case RSL_ERR_SERV_OPT_UNIMPL: + /* BTS does not support the requested service or mode; the lchan + * itself is not broken, so don't mark it as such. */ + next_state = LCHAN_ST_WAIT_AFTER_ERROR; + break; + default: + next_state = LCHAN_ST_BORKEN; + break; + } lchan_fail_to(next_state, "Chan Activ NACK: %s (0x%x)", rsl_err_name(lchan->release.rsl_error_cause), lchan->release.rsl_error_cause); @@ -1759,6 +1769,7 @@ .out_state_mask = 0 | S(LCHAN_ST_UNUSED) | S(LCHAN_ST_WAIT_RLL_RTP_ESTABLISH) + | S(LCHAN_ST_WAIT_AFTER_ERROR) | S(LCHAN_ST_BORKEN) | S(LCHAN_ST_WAIT_RF_RELEASE_ACK) , -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42592?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ide3830a697501a0c245a41451302f1e68d553b3c Gerrit-Change-Number: 42592 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: handover_fsm: fix send_handover_performed() using wrong lchan
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42593?usp=email ) Change subject: handover_fsm: fix send_handover_performed() using wrong lchan ...................................................................... handover_fsm: fix send_handover_performed() using wrong lchan send_handover_performed() is called from handover_end() before gscon_change_primary_lchan() updates conn->lchan to the new lchan. As a result, the Cell Identifier, Chosen Channel, Chosen Encryption Algorithm, and Speech Version/Codec IEs were all populated from the source (old) lchan rather than the target (new) lchan. As per 3GPP TS 48.008 §3.2.1.25, HANDOVER PERFORMED must report the target cell and channel. For intra-BSC handover to a different BTS this caused the MSC to receive the wrong Cell Identifier. Fix by initialising lchan from ho->new_lchan instead of conn->lchan, and deriving the BTS via lchan->ts->trx->bts. Change-Id: I4111351dc38fc2dbe844c2bd07b3ecfaaadd864e Related: osmo-ttcn3-hacks.git I82aadcc3a80c183cb93522b829071294b156a218 Found-By: Claude Sonnet 4.6 --- M src/osmo-bsc/handover_fsm.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/93/42593/1 diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index 24766a5..cddb138 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -897,8 +897,8 @@ static void send_handover_performed(struct gsm_subscriber_connection *conn) { - struct gsm_lchan *lchan = conn->lchan; struct handover *ho = &conn->ho; + struct gsm_lchan *lchan = ho->new_lchan; struct osmo_cell_global_id *cell; struct gsm0808_handover_performed ho_perf_params = {}; struct msgb *msg; @@ -909,7 +909,7 @@ ho_perf_params.cause = GSM0808_CAUSE_HANDOVER_SUCCESSFUL; /* Cell Identifier 3.2.2.17 */ - cell = cgi_for_msc(conn->sccp.msc, conn_get_bts(conn)); + cell = cgi_for_msc(conn->sccp.msc, lchan->ts->trx->bts); if (!cell) { LOG_HO(conn, LOGL_ERROR, "Failed to generate Cell Identifier IE, can't send HANDOVER PERFORMED!\n"); return; @@ -941,7 +941,7 @@ if (gscon_is_aoip(conn)) { /* Extrapolate speech codec from speech mode */ gsm0808_speech_codec_from_chan_type(&sc, ho_perf_params.speech_version_chosen); - sc.cfg = conn->lchan->current_ch_mode_rate.s15_s0; + sc.cfg = lchan->current_ch_mode_rate.s15_s0; memcpy(&ho_perf_params.speech_codec_chosen, &sc, sizeof(sc)); ho_perf_params.speech_codec_chosen_present = true; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42593?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4111351dc38fc2dbe844c2bd07b3ecfaaadd864e Gerrit-Change-Number: 42593 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: bssap: use LOGPFSML in bssmap_handle_assignm_req()
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42585?usp=email ) Change subject: bssap: use LOGPFSML in bssmap_handle_assignm_req() ...................................................................... bssap: use LOGPFSML in bssmap_handle_assignm_req() Change-Id: If99661c0ff1177214bacdb2d1bcb9da1d2d2957c --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/85/42585/1 diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c index 7a9688d..dbd1a20 100644 --- a/src/osmo-bsc/osmo_bsc_bssap.c +++ b/src/osmo-bsc/osmo_bsc_bssap.c @@ -1144,7 +1144,7 @@ /* Check for channel type element, if its missing, immediately reject */ if (!TLVP_PRESENT(&tp, GSM0808_IE_CHANNEL_TYPE)) { - LOGP(DMSC, LOGL_ERROR, "Mandatory channel type not present.\n"); + LOGPFSML(conn->fi, LOGL_ERROR, "Mandatory channel type not present.\n"); cause = GSM0808_CAUSE_INFORMATION_ELEMENT_OR_FIELD_MISSING; goto reject; } @@ -1153,7 +1153,7 @@ rc = gsm0808_dec_channel_type(&ct, TLVP_VAL(&tp, GSM0808_IE_CHANNEL_TYPE), TLVP_LEN(&tp, GSM0808_IE_CHANNEL_TYPE)); if (rc < 0) { - LOGP(DMSC, LOGL_ERROR, "unable to decode channel type.\n"); + LOGPFSML(conn->fi, LOGL_ERROR, "unable to decode channel type.\n"); cause = GSM0808_CAUSE_INCORRECT_VALUE; goto reject; } @@ -1167,7 +1167,7 @@ rc = gsm0808_dec_group_callref(&gc, TLVP_VAL(&tp, GSM0808_IE_GROUP_CALL_REFERENCE), TLVP_LEN(&tp, GSM0808_IE_GROUP_CALL_REFERENCE)); if (rc < 0) { - LOGP(DMSC, LOGL_ERROR, "Unable to decode Group Call Reference.\n"); + LOGPFSML(conn->fi, LOGL_ERROR, "Unable to decode Group Call Reference.\n"); cause = GSM0808_CAUSE_INCORRECT_VALUE; goto reject; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42585?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If99661c0ff1177214bacdb2d1bcb9da1d2d2957c Gerrit-Change-Number: 42585 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-bsc[master]: bssap: mark some pointers as const
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42584?usp=email ) Change subject: bssap: mark some pointers as const ...................................................................... bssap: mark some pointers as const Change-Id: Iebb28d6ae0b468545994669248a442dd17f36d4c --- M include/osmocom/bsc/vgcs_fsm.h M src/osmo-bsc/osmo_bsc_bssap.c 2 files changed, 33 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/42584/1 diff --git a/include/osmocom/bsc/vgcs_fsm.h b/include/osmocom/bsc/vgcs_fsm.h index 80ea21f..57acae0 100644 --- a/include/osmocom/bsc/vgcs_fsm.h +++ b/include/osmocom/bsc/vgcs_fsm.h @@ -104,9 +104,12 @@ int vgcs_vbs_chan_start(struct gsm_subscriber_connection *conn, struct msgb *msg); int vgcs_vbs_call_start(struct gsm_subscriber_connection *conn, struct msgb *msg); -int bssmap_handle_ass_req_ct_speech(struct gsm_subscriber_connection *conn, struct gsm_bts *bts, - struct tlv_parsed *tp, struct gsm0808_channel_type *ct, - struct assignment_request *req, uint8_t *cause); +int bssmap_handle_ass_req_ct_speech(struct gsm_subscriber_connection *conn, + struct gsm_bts *bts, + const struct tlv_parsed *tp, + const struct gsm0808_channel_type *ct, + struct assignment_request *req, + uint8_t *cause); void bsc_tx_setup_ack(struct gsm_subscriber_connection *conn, struct gsm0808_vgcs_feature_flags *ff); void bsc_tx_setup_refuse(struct gsm_subscriber_connection *conn, uint8_t cause); void bsc_tx_vgcs_vbs_assignment_result(struct gsm_subscriber_connection *conn, struct gsm0808_channel_type *ct, diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c index 395fa49..7a9688d 100644 --- a/src/osmo-bsc/osmo_bsc_bssap.c +++ b/src/osmo-bsc/osmo_bsc_bssap.c @@ -684,7 +684,8 @@ * lchan is requested. The preferred lchan will be requested first. If we * find an alternate setting here, this one will be tried secondly if our * primary choice fails. */ -static int select_data_rates(struct assignment_request *req, struct gsm0808_channel_type *ct, +static int select_data_rates(struct assignment_request *req, + const struct gsm0808_channel_type *ct, struct gsm_subscriber_connection *conn) { int rc, i, nc = 0; @@ -815,7 +816,8 @@ return 0; } -static int select_sign_chan(struct assignment_request *req, struct gsm0808_channel_type *ct) +static int select_sign_chan(struct assignment_request *req, + const struct gsm0808_channel_type *ct) { int i, nc = 0; @@ -864,7 +866,8 @@ return nc > 0 ? 0 : -EINVAL; } -static int bssmap_handle_ass_req_tp_cic(struct tlv_parsed *tp, bool aoip, uint16_t *cic, uint8_t *cause) +static int bssmap_handle_ass_req_tp_cic(const struct tlv_parsed *tp, + bool aoip, uint16_t *cic, uint8_t *cause) { if (TLVP_PRESENT(tp, GSM0808_IE_CIRCUIT_IDENTITY_CODE)) { /* CIC is permitted in both AoIP and SCCPlite */ @@ -882,7 +885,7 @@ return 0; } -static int bssmap_handle_ass_req_tp_rtp_addr(struct tlv_parsed *tp, bool aoip, char *msc_rtp_addr, +static int bssmap_handle_ass_req_tp_rtp_addr(const struct tlv_parsed *tp, bool aoip, char *msc_rtp_addr, size_t msc_rtp_addr_len, uint16_t *msc_rtp_port, uint8_t *cause) { struct sockaddr_storage rtp_addr; @@ -927,7 +930,8 @@ return 0; } -static int bssmap_handle_ass_req_tp_osmux(struct gsm_subscriber_connection *conn, struct tlv_parsed *tp, +static int bssmap_handle_ass_req_tp_osmux(struct gsm_subscriber_connection *conn, + const struct tlv_parsed *tp, bool *use_osmux, uint8_t *osmux_cid, uint8_t *cause) { int rc; @@ -963,8 +967,9 @@ return 0; } -static int bssmap_handle_ass_req_tp_codec_list(struct gsm_subscriber_connection *conn, struct tlv_parsed *tp, bool aoip, - uint8_t *cause) +static int bssmap_handle_ass_req_tp_codec_list(struct gsm_subscriber_connection *conn, + const struct tlv_parsed *tp, + bool aoip, uint8_t *cause) { int rc; @@ -993,7 +998,7 @@ return 0; } -static int bssmap_handle_ass_req_tp_rtp_ext(struct tlv_parsed *tp, +static int bssmap_handle_ass_req_tp_rtp_ext(const struct tlv_parsed *tp, struct assignment_request *req, uint8_t *cause) { @@ -1013,8 +1018,10 @@ return 0; } -static int bssmap_handle_ass_req_ct_data(struct gsm_subscriber_connection *conn, struct tlv_parsed *tp, - struct gsm0808_channel_type *ct, struct assignment_request *req, +static int bssmap_handle_ass_req_ct_data(struct gsm_subscriber_connection *conn, + const struct tlv_parsed *tp, + const struct gsm0808_channel_type *ct, + struct assignment_request *req, uint8_t *cause) { bool aoip = gscon_is_aoip(conn); @@ -1045,9 +1052,12 @@ return 0; } -int bssmap_handle_ass_req_ct_speech(struct gsm_subscriber_connection *conn, struct gsm_bts *bts, - struct tlv_parsed *tp, struct gsm0808_channel_type *ct, - struct assignment_request *req, uint8_t *cause) +int bssmap_handle_ass_req_ct_speech(struct gsm_subscriber_connection *conn, + struct gsm_bts *bts, + const struct tlv_parsed *tp, + const struct gsm0808_channel_type *ct, + struct assignment_request *req, + uint8_t *cause) { bool aoip = gscon_is_aoip(conn); int rc; @@ -1084,8 +1094,10 @@ return 0; } -static int bssmap_handle_ass_req_ct_sign(struct gsm_subscriber_connection *conn, struct gsm0808_channel_type *ct, - struct assignment_request *req, uint8_t *cause) +static int bssmap_handle_ass_req_ct_sign(struct gsm_subscriber_connection *conn, + const struct gsm0808_channel_type *ct, + struct assignment_request *req, + uint8_t *cause) { int rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42584?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iebb28d6ae0b468545994669248a442dd17f36d4c Gerrit-Change-Number: 42584 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: bssap: use LOGPFSML in bssmap_handle_ass_req_tp_codec_list()
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42586?usp=email ) Change subject: bssap: use LOGPFSML in bssmap_handle_ass_req_tp_codec_list() ...................................................................... bssap: use LOGPFSML in bssmap_handle_ass_req_tp_codec_list() Change-Id: Ie51ada174388f4c3e9ffe8a5bec4297bda38584b --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/86/42586/1 diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c index dbd1a20..fa16aac 100644 --- a/src/osmo-bsc/osmo_bsc_bssap.c +++ b/src/osmo-bsc/osmo_bsc_bssap.c @@ -982,14 +982,14 @@ TLVP_VAL(tp, GSM0808_IE_SPEECH_CODEC_LIST), TLVP_LEN(tp, GSM0808_IE_SPEECH_CODEC_LIST)); if (rc < 0) { - LOGP(DMSC, LOGL_ERROR, "Unable to decode speech codec list\n"); + LOGPFSML(conn->fi, LOGL_ERROR, "Unable to decode speech codec list\n"); *cause = GSM0808_CAUSE_INCORRECT_VALUE; return -1; } } if (aoip && !conn->codec_list.len) { - LOGP(DMSC, LOGL_ERROR, "%s: AoIP Assignment Request:" + LOGPFSML(conn->fi, LOGL_ERROR, "%s: AoIP Assignment Request:" " Missing or empty Speech Codec List IE\n", bsc_subscr_name(conn->bsub)); *cause = GSM0808_CAUSE_INFORMATION_ELEMENT_OR_FIELD_MISSING; return -1; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42586?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie51ada174388f4c3e9ffe8a5bec4297bda38584b Gerrit-Change-Number: 42586 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026