April 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: jobs/master-builds.yml: fix typo: crad-test -> card-test
by fixeria 24 Apr '26

24 Apr '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42669?usp=email ) Change subject: jobs/master-builds.yml: fix typo: crad-test -> card-test ...................................................................... jobs/master-builds.yml: fix typo: crad-test -> card-test Change-Id: I0686af6c026e298c86d3a64cc161e5c84ec7dc57 Fixes: ee1ef65 ("jobs/master-builds.yml: pysim: separate JOB_TYPE for card tests") --- M jobs/master-builds.yml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index fee8c57..9a18fc0 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -643,7 +643,7 @@ a2: !!python/tuple ["test", "card-test", "pylint", "docs"] combination_filter: > (JOB_TYPE == "test" && label == "osmocom-master") || - (JOB_TYPE == "crad-test" && label == "simtester") || + (JOB_TYPE == "card-test" && label == "simtester") || (JOB_TYPE == "pylint" && label == "osmocom-master") || (JOB_TYPE == "docs" && label == "osmocom-master") cmd: | -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42669?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0686af6c026e298c86d3a64cc161e5c84ec7dc57 Gerrit-Change-Number: 42669 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ci[master]: jobs/gerrit-verifications.yml: pysim: allow skipping card tests
by fixeria 24 Apr '26

24 Apr '26

Attention is currently required from: osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/42671?usp=email ) Change subject: jobs/gerrit-verifications.yml: pysim: allow skipping card tests ...................................................................... Patch Set 1: (1 comment) File jobs/gerrit-verifications.yml: https://gerrit.osmocom.org/c/osmo-ci/+/42671/comment/912ac202_c1fafd9b?usp=… : PS1, Line 541: label == "simtester" > Running `JOB_TYPE == "test"` on `simtester` is still a bottleneck, because it cannot execute jobs in […] https://gerrit.osmocom.org/c/docker-playground/+/42675 debian-trixie-build: add tshark If this patch gets merged, I'll simply amend the present patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I986d88545f64e13cd571ba9ff56bc924822e39a0 Gerrit-Change-Number: 42671 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Apr 2026 23:41:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in docker-playground[master]: debian-trixie-build: add tshark
by fixeria 24 Apr '26

24 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/42675?usp=email ) Change subject: debian-trixie-build: add tshark ...................................................................... debian-trixie-build: add tshark This is needed for running pysim unit tests on generic nodes. As of now we're executing them on the 'simtester' node, which cannot run more than one job at once, making build verification for large pysim patchsets extremely slow. Change-Id: Idbe934e5cc29b06fd1b13b85893de5856eca836e Related: osmo-ci.git I986d88545f64e13cd571ba9ff56bc924822e39a0 --- M debian-trixie-build/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/75/42675/1 diff --git a/debian-trixie-build/Dockerfile b/debian-trixie-build/Dockerfile index dcac78e..0a7affd 100644 --- a/debian-trixie-build/Dockerfile +++ b/debian-trixie-build/Dockerfile @@ -179,6 +179,7 @@ telnet \ tex-gyre \ texinfo \ + tshark \ unzip \ virtualenv \ xsltproc \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/42675?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Idbe934e5cc29b06fd1b13b85893de5856eca836e Gerrit-Change-Number: 42675 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: jobs/gerrit-verifications.yml: pysim: allow skipping card tests
by fixeria 24 Apr '26

24 Apr '26

Attention is currently required from: osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/42671?usp=email ) Change subject: jobs/gerrit-verifications.yml: pysim: allow skipping card tests ...................................................................... Patch Set 1: (1 comment) File jobs/gerrit-verifications.yml: https://gerrit.osmocom.org/c/osmo-ci/+/42671/comment/bfe464fb_84af3465?usp=… : PS1, Line 541: label == "simtester" Running `JOB_TYPE == "test"` on `simtester` is still a bottleneck, because it cannot execute jobs in parallel. It takes ~20 min. for a single patch to pass build verification. I tried running `test` on `osmocom-gerrit`, but the container that is used for running tests does not have `tshark` (needed by `pyshark`), so pySim-trace related tests fail. I'll prepare a patch adding `tshark` and another patch for this repository. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I986d88545f64e13cd571ba9ff56bc924822e39a0 Gerrit-Change-Number: 42671 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Apr 2026 22:55:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in pysim[master]: MncLen
by fixeria 24 Apr '26

24 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42672?usp=email ) Change subject: MncLen ...................................................................... MncLen Change-Id: I6c600faeab00ffb072acbe94c9a8b2d1397c07d3 Jenkins: skip-card-test --- M pySim/esim/saip/personalization.py 1 file changed, 67 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/72/42672/1 diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index dbbc5c4..35ab2a1 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -22,9 +22,11 @@ import pprint from typing import List, Tuple, Generator, Optional +from construct.core import StreamError from osmocom.tlv import camel_to_snake from osmocom.utils import hexstr from pySim.utils import enc_iccid, dec_iccid, enc_imsi, dec_imsi, h2b, b2h, rpad, sanitize_iccid +from pySim.ts_31_102 import EF_AD from pySim.ts_51_011 import EF_SMSP from pySim.esim.saip import param_source from pySim.esim.saip import ProfileElement, ProfileElementSD, ProfileElementSequence @@ -647,6 +649,71 @@ yield { cls.name: cls.tuple_to_str((international, digits)) } +class MncLen(ConfigurableParameter): + """MNC length. Must be either 2 or 3. Sets only the MNC length field in EF-AD (Administrative Data).""" + name = 'MNC-LEN' + allow_chars = '23' + strip_chars = ' \t\r\n' + numeric_base = 10 + max_len = 1 + min_len = 1 + example_input = '2' + default_source = param_source.ConstantSource + + @classmethod + def validate_val(cls, val): + val = super().validate_val(val) + val = int(val) + if val not in (2, 3): + raise ValueError(f"MNC-LEN must be either 2 or 3, not {val!r}") + return val + + @classmethod + def apply_val(cls, pes: ProfileElementSequence, val): + """val must be an int: either 2 or 3""" + for pe in pes.get_pes_for_type('usim'): + if not hasattr(pe, 'files'): + continue + # decode existing values + f_ad = pe.files['ef-ad'] + if not f_ad.body: + continue + try: + ef_ad = EF_AD() + ef_ad_dec = ef_ad.decode_bin(f_ad.body) + except StreamError: + continue + if 'mnc_len' not in ef_ad_dec: + continue + # change mnc_len + ef_ad_dec['mnc_len'] = val + # re-encode into the File body + f_ad.body = ef_ad.encode_bin(ef_ad_dec) + pe.file2pe(f_ad) + + @classmethod + def get_values_from_pes(cls, pes: ProfileElementSequence): + for naa in ('isim',):# 'isim', 'csim'): + for pe in pes.get_pes_for_type(naa): + if not hasattr(pe, 'files'): + continue + f_ad = pe.files.get('ef-ad', None) + if f_ad is None: + continue + + try: + ef_ad = EF_AD() + ef_ad_dec = ef_ad.decode_bin(f_ad.body) + except StreamError: + continue + + mnc_len = ef_ad_dec.get('mnc_len', None) + if mnc_len is None: + continue + + yield { cls.name: str(mnc_len) } + + class SdKey(BinaryParam): """Configurable Security Domain (SD) Key. Value is presented as bytes. Non-abstract implementations are generated in SdKey.generate_sd_key_classes""" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42672?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6c600faeab00ffb072acbe94c9a8b2d1397c07d3 Gerrit-Change-Number: 42672 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: sdkeys kv40 aes
by fixeria 24 Apr '26

24 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42673?usp=email ) Change subject: sdkeys kv40 aes ...................................................................... sdkeys kv40 aes Change-Id: If5b53c840ebd1f224f9bb4706a602b415194f47b Jenkins: skip-card-test --- M tests/unittests/test_configurable_parameters.py 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/73/42673/1 diff --git a/tests/unittests/test_configurable_parameters.py b/tests/unittests/test_configurable_parameters.py index 8d31f8a..a58093c 100755 --- a/tests/unittests/test_configurable_parameters.py +++ b/tests/unittests/test_configurable_parameters.py @@ -310,11 +310,14 @@ p13n.SdKeyScp80Kvn03DesDek, #p13n.SdKeyScp80Kvn03DesEnc, #p13n.SdKeyScp80Kvn03DesMac, - p13n.SdKeyScp81Kvn40Dek , + #p13n.SdKeyScp81Kvn40AesDek, + p13n.SdKeyScp81Kvn40DesDek, #p13n.SdKeyScp81Kvn40Tlspsk, - #p13n.SdKeyScp81Kvn41Dek , + #p13n.SdKeyScp81Kvn41AesDek, + #p13n.SdKeyScp81Kvn41DesDek, p13n.SdKeyScp81Kvn41Tlspsk, - #p13n.SdKeyScp81Kvn42Dek , + #p13n.SdKeyScp81Kvn42AesDek, + #p13n.SdKeyScp81Kvn42DesDek, #p13n.SdKeyScp81Kvn42Tlspsk, ): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42673?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If5b53c840ebd1f224f9bb4706a602b415194f47b Gerrit-Change-Number: 42673 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: personalization: fix EF_SMSP length, alpha_id padding
by fixeria 24 Apr '26

24 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42674?usp=email ) Change subject: personalization: fix EF_SMSP length, alpha_id padding ...................................................................... personalization: fix EF_SMSP length, alpha_id padding The efFileSize needs to be updated and the alpha_id needs to be != None. Change-Id: Ief6e02517f3e96158a2509d763b88aec4bd5a296 Jenkins: skip-card-test --- M pySim/esim/saip/personalization.py 1 file changed, 20 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/74/42674/1 diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index 35ab2a1..2433042 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -619,10 +619,28 @@ ef_smsp_dec['tp_sc_addr']['ton_npi']['type_of_number'] = 'international' if international else 'unknown' # ensure the parameter_indicators.tp_sc_addr is True ef_smsp_dec['parameter_indicators']['tp_sc_addr'] = True - # re-encode into the File body - f_smsp.body = ef_smsp.encode_record_bin(ef_smsp_dec, 1) + + # alpha_id padding: to make room for a human readable SMSC name that can be provisioned to the profile later + # on, alpha_id needs to be empty but padded 0xff to some length. + # - alpha_id is optional, setting alpha_id = '' ensures the IE is present. + # - the length of the file is 28+Y where Y is the length of the alpha_id -- here the intended length of our padding + # (see 3GPP TS 31.102 4.2.27 EF.SMSP). So if we want a maximum length of alpha_id = 14, we set the total + # file size to 28+14 = 42. + # - this file size has to go in two places: encode_record_bin() needs to know the length to encode the right + # length of fillFileContent. + # - the f_smsp needs to show the right file size in the PES, as in + # 'ef-smsp': [('fileDescriptor', {'efFileSize': '2a', ... + # (where 2a == 42) + # - To generate the right amount of fillFileContent, pass total_len=42 to encode_record_bin(). + # - To show the right size in the PES, set f_smsp.rec_len = 42 + ef_smsp_dec['alpha_id'] = '' + f_smsp.rec_len = 42 + + # re-encode into the File body. + # #print("SMSP (new): %s" % f_smsp.body) # re-generate the pe.decoded member from the File instance + f_smsp.body = ef_smsp.encode_record_bin(ef_smsp_dec, 1, total_len=f_smsp.rec_len) pe.file2pe(f_smsp) @classmethod -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42674?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ief6e02517f3e96158a2509d763b88aec4bd5a296 Gerrit-Change-Number: 42674 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in pysim[master]: personalization: implement reading back values from a PES
by fixeria 24 Apr '26

24 Apr '26

Attention is currently required from: dexter, laforge, neels. fixeria has uploaded a new patch set (#14) to the change originally created by neels. ( https://gerrit.osmocom.org/c/pysim/+/40198?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by dexter, Code-Review+2 by neels, Verified-1 by Jenkins Builder Change subject: personalization: implement reading back values from a PES ...................................................................... personalization: implement reading back values from a PES Implement get_values_from_pes(), the reverse direction of apply_val(): read back and return values from a ProfileElementSequence. Implement for all ConfigurableParameter subclasses. Future: SdKey.get_values_from_pes() is reading pe.decoded[], which works fine, but I07dfc378705eba1318e9e8652796cbde106c6a52 will change this implementation to use the higher level ProfileElementSD members. Implementation detail: Implement get_values_from_pes() as classmethod that returns a generator. Subclasses should yield all occurences of their parameter in a given PES. For example, the ICCID can appear in multiple places. Iccid.get_values_from_pes() yields all of the individual values. A set() of the results quickly tells whether the PES is consistent. Rationales for reading back values: This allows auditing an eSIM profile, particularly for producing an output.csv from a batch personalization (that generated lots of random key material which now needs to be fed to an HLR...). Reading back from a binary result is more reliable than storing the values that were fed into a personalization. By auditing final DER results with this code, I discovered: - "oh, there already was some key material in my UPP template." - "all IMSIs ended up the same, forgot to set up the parameter." - the SdKey.apply() implementations currently don't work, see I07dfc378705eba1318e9e8652796cbde106c6a52 for a fix. Change-Id: I234fc4317f0bdc1a486f0cee4fa432c1dce9b463 Jenkins: skip-card-test --- M pySim/esim/saip/personalization.py 1 file changed, 151 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/98/40198/14 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I234fc4317f0bdc1a486f0cee4fa432c1dce9b463 Gerrit-Change-Number: 40198 Gerrit-PatchSet: 14 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in pysim[master]: personalization: add param_source.py, add batch.py
by fixeria 24 Apr '26

24 Apr '26

Attention is currently required from: laforge, neels. fixeria has uploaded a new patch set (#9) to the change originally created by neels. ( https://gerrit.osmocom.org/c/pysim/+/41845?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified-1 by Jenkins Builder Change subject: personalization: add param_source.py, add batch.py ...................................................................... personalization: add param_source.py, add batch.py Implement pySim.esim.saip.batch.BatchPersonalization, generating N eSIM profiles from a preset configuration. Batch parameters can be fed by a constant, incrementing, random or from CSV rows: add pySim.esim.saip.param_source.* classes to feed such input to each of the BatchPersonalization's ConfigurableParameter instances. Related: SYS#6768 Change-Id: I01ae40a06605eb205bfb409189fcd2b3a128855a Jenkins: skip-card-test --- A pySim/esim/saip/batch.py A pySim/esim/saip/param_source.py 2 files changed, 325 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/45/41845/9 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01ae40a06605eb205bfb409189fcd2b3a128855a Gerrit-Change-Number: 41845 Gerrit-PatchSet: 9 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: personalization: allow reading back multiple values from PES
by fixeria 24 Apr '26

24 Apr '26

Attention is currently required from: dexter, laforge, neels. fixeria has uploaded a new patch set (#13) to the change originally created by neels. ( https://gerrit.osmocom.org/c/pysim/+/40199?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by neels, Verified-1 by Jenkins Builder Change subject: personalization: allow reading back multiple values from PES ...................................................................... personalization: allow reading back multiple values from PES Change-Id: Iecb68af7c216c6b9dc3add469564416b6f37f7b2 Jenkins: skip-card-test --- M pySim/esim/saip/personalization.py 1 file changed, 22 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/99/40199/13 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iecb68af7c216c6b9dc3add469564416b6f37f7b2 Gerrit-Change-Number: 40199 Gerrit-PatchSet: 13 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026