Attention is currently required from: pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154?usp=email )

Change subject: remsim: server: add a client timeout test ......................................................................

Patch Set 2:

(7 comments)

File remsim/RemsimServer_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/bdc1b9e7_6f85a... : PS2, Line 183: testcase TC_connect_client_timeout_reconnect() runs on test_CT {

TC_connect_client_ipa_ping_timeout_reconnect

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/8fc304fd_4fb49... : PS2, Line 189: g_T_guard.start(180.0);

These timings are way to high. […]

There is no VTY on the remsim server. I've reduced the time outs a little bit. I hope this won't run into instabilities.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/1360ec24_5dfcf... : PS2, Line 197: mtc.stop;

Misc_Helpers.f_shutdown() here and below.

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/e9f78437_06bea... : PS2, Line 216: }

these are usually indented one more level.

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/f8ce79ff_c1b50... : PS2, Line 219: setverdict(fail, "Timed out. Server did not closed the connection.");

did not close

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/ab306907_eaec4... : PS2, Line 232: if (not match(js.clients[0], tr_JsClient(CONNECTED_CLIENT, rspro[1].rspro_id))) {

Shouldn't this be rspro[0]. […]

It is the same rspro_id for all clients.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/7b170985_15bf2... : PS2, Line 661: execute( TC_connect_client_timeout_reconnect() );

if it crashes, add a comment saying it crashes on version "<= N" and put it at the end.

Done