Attention is currently required from: dexter, laforge, neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41845?usp=email ) Change subject: personalization: add param_source.py, add batch.py ...................................................................... Patch Set 9: (2 comments) File pySim/esim/saip/param_source.py: https://gerrit.osmocom.org/c/pysim/+/41845/comment/9391e7f1_0289ed8b?usp=ema... : PS8, Line 116:

I wonder what happens when input_str is something like this: "12..345". […] This is a valid concern, indeed. I've added an additional check.

https://gerrit.osmocom.org/c/pysim/+/41845/comment/86df4c62_e85134ad?usp=ema... : PS8, Line 131: val = random.randint(*self.val_first_last) # TODO secure random source?

The line where you assign self. […] Done

-- To view, visit https://gerrit.osmocom.org/c/pysim/+/41845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01ae40a06605eb205bfb409189fcd2b3a128855a Gerrit-Change-Number: 41845 Gerrit-PatchSet: 9 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: dexter <pmaier@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Fri, 24 Apr 2026 15:04:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier@sysmocom.de>