Attention is currently required from: dexter, laforge, neels.
fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41845?usp=email )
Change subject: personalization: add param_source.py, add batch.py ......................................................................
Patch Set 9:
(2 comments)
File pySim/esim/saip/param_source.py:
https://gerrit.osmocom.org/c/pysim/+/41845/comment/9391e7f1_0289ed8b?usp=ema... : PS8, Line 116:
I wonder what happens when input_str is something like this: "12..345". […]
This is a valid concern, indeed. I've added an additional check.
https://gerrit.osmocom.org/c/pysim/+/41845/comment/86df4c62_e85134ad?usp=ema... : PS8, Line 131: val = random.randint(*self.val_first_last) # TODO secure random source?
The line where you assign self. […]
Done
-
fixeria