fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42671?usp=email ) Change subject: jobs/gerrit-verifications.yml: pysim: allow skipping card tests ...................................................................... jobs/gerrit-verifications.yml: pysim: allow skipping card tests I've already implemented this logic in 6a3b8a0, however by mistake I added it to master-builds.yml instead of gerrit-verifications.yml. This is wrong because we specifically need this feature for Jenkins verification, not for the master builds. For daily master builds, on the other hand, we specifically want to execute all existing job types, so revert my recent changes from master-builds.yml, but keep the new job type. Change-Id: I986d88545f64e13cd571ba9ff56bc924822e39a0 Fixes: 6a3b8a0 ("jobs/master-builds.yml: pysim: allow skipping card tests") --- M jobs/gerrit-verifications.yml M jobs/master-builds.yml 2 files changed, 12 insertions(+), 11 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved; Verified Jenkins Builder: Verified diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 1177a51..1585b10 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -103,6 +103,7 @@ timeout_cmd: '/usr/bin/timeout 30m' wrapper_cmd: '{timeout_cmd} /osmo-ci/scripts/wrapper_core_bt_on_error.sh' cmd: '{docker_run_ccache} {docker_img} {wrapper_cmd} /build/contrib/jenkins.sh' + check_jenkins_mark: 'git show --summary --format=%B | grep "^Jenkins:" | grep -q' gerrit_url: 'ssh://jenkins@gerrit.osmocom.org:29418' repos_url: '{gerrit_url}/{repos}' gerrit_project: '{repos}' @@ -535,16 +536,22 @@ concurrent: false slave_axis: !!python/tuple [simtester,osmocom-gerrit] a2_name: JOB_TYPE - a2: !!python/tuple ["test", "distcheck", "pylint", "docs"] + a2: !!python/tuple ["test", "card-test", "distcheck", "pylint", "docs"] combination_filter: > - (JOB_TYPE == "test" && label == "simtester") || + (JOB_TYPE == "test" && label == "osmocom-gerrit") || + (JOB_TYPE == "card-test" && label == "simtester") || (JOB_TYPE == "distcheck" && label == "osmocom-gerrit") || (JOB_TYPE == "pylint" && label == "osmocom-gerrit") || (JOB_TYPE == "docs" && label == "osmocom-gerrit") cmd: | case "$JOB_TYPE" in - "test") - {timeout_cmd} ./contrib/jenkins.sh + "card-test") + if {check_jenkins_mark} "skip-card-test"; then + # skip tests requiring physical cards + echo "GERRIT_PIPELINE_JOB_SKIPPED" + else + {timeout_cmd} ./contrib/jenkins.sh + fi ;; *) {docker_run} \ diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 4fcffdf..68c62fd 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -86,7 +86,6 @@ timeout_cmd: '/usr/bin/timeout 30m' wrapper_cmd: '{timeout_cmd} /osmo-ci/scripts/wrapper_core_bt_on_error.sh' cmd: '{docker_run_ccache} {docker_img} {wrapper_cmd} /build/contrib/jenkins.sh' - check_jenkins_mark: 'git show --summary --format=%B | grep "^Jenkins:" | grep -q' trigger: email: jenkins-notifications@lists.osmocom.org laforge@gnumonks.org gerrit_url: 'https://gerrit.osmocom.org' @@ -650,12 +649,7 @@ cmd: | case "$JOB_TYPE" in "card-test") - if {check_jenkins_mark} "skip-card-test"; then - # skip tests requiring physical cards - echo "GERRIT_PIPELINE_JOB_SKIPPED" - else - {timeout_cmd} ./contrib/jenkins.sh - fi + {timeout_cmd} ./contrib/jenkins.sh ;; *) {docker_run} \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I986d88545f64e13cd571ba9ff56bc924822e39a0 Gerrit-Change-Number: 42671 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de>