lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[XS] Change in osmo-ttcn3-hacks[master]: bsf: Several typo fixes
by pespin 02 Nov '26

02 Nov '26
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44021?usp=email ) Change subject: bsf: Several typo fixes ...................................................................... bsf: Several typo fixes Change-Id: Icb70149a349355d6069a3d63657f4e10178d9b2a --- M bsf/ConnHdlr.ttcn M bsf/README.md 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/44021/1 diff --git a/bsf/ConnHdlr.ttcn b/bsf/ConnHdlr.ttcn index 74594d7..7159e21 100644 --- a/bsf/ConnHdlr.ttcn +++ b/bsf/ConnHdlr.ttcn @@ -92,14 +92,14 @@ f_http2_server_emu_unregister(f_http2_server_path_match(), idx := HTTP2_CONN_SCP); } -function f_http2_adapter_connect_pcf(integer idx := 0) +function f_http2_adapter_connect_bsf(integer idx := 0) runs on ConnHdlr { f_http2_adapter_connect(mp_bsf_hostname, mp_bsf_sbi_port, mp_pcf_local_ip, idx := idx); } function f_http2_adapter_connect_send_bsf(template (value) HTTP2_Msg http2_msg, integer idx := 0) runs on ConnHdlr { - f_http2_adapter_connect_pcf(idx := idx); + f_http2_adapter_connect_bsf(idx := idx); f_http2_adapter_send(http2_msg); } diff --git a/bsf/README.md b/bsf/README.md index 5f9a700..5ef82b6 100644 --- a/bsf/README.md +++ b/bsf/README.md @@ -5,11 +5,11 @@ * N15: SBI (emulates AMF) * N36: SBI (emulates UDR) -{% dot pcf_tests.svg +{% dot bsf_tests.svg digraph G { rankdir=LR; ATS [label="ATS\nBSF_Tests.ttcn"]; - UDM [label="AMF\open5gs-pcfd",shape="box"]; + UDM [label="AMF\open5gs-bsfd",shape="box"]; ATS -> UDM [label="N7"]; ATS -> UDM [label="N15"]; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44021?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icb70149a349355d6069a3d63657f4e10178d9b2a Gerrit-Change-Number: 44021 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: smf: Fix wrong expect in TC_n11_createSession_pfcp_sess_est_timeout
by pespin 02 Nov '26

02 Nov '26
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44019?usp=email ) Change subject: smf: Fix wrong expect in TC_n11_createSession_pfcp_sess_est_timeout ...................................................................... smf: Fix wrong expect in TC_n11_createSession_pfcp_sess_est_timeout The UECM registration only happens after full registration towards the UE happens, ie. after PFCP Session Modification procedure. Hence, at this point in the test the UECM is not registered yet and hence needs no deletion. Furthermore, the as_namf_comm_post_n1n2_messages_pdu_sess_establishment_reject() altstep was missing an answer to towards the IUT; add it. Related: https://github.com/open5gs/open5gs/issues/4878 Change-Id: I7636f271d22df2417e57839e03dab62314f8aa24 --- M smf/SMF_Session_CT_5G.ttcn M smf/SMF_Tests.ttcn 2 files changed, 27 insertions(+), 20 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/smf/SMF_Session_CT_5G.ttcn b/smf/SMF_Session_CT_5G.ttcn index d535b53..86aca29 100644 --- a/smf/SMF_Session_CT_5G.ttcn +++ b/smf/SMF_Session_CT_5G.ttcn @@ -573,6 +573,27 @@ } } +/* 3GPP TS 29.518 Table 6.1.3.5.3.1-2 200 OK */ +private function f_namf_comm_N1N2MessageTransferRspData(HTTP2_Msg http2_rx) +runs on SMF_Session_CT { + var template (value) HTTP2_Msg http2_tx; + var octetstring body_enc; + var template (value) N1N2MessageTransferRspData n1n2msg_rsp; + + n1n2msg_rsp := ts_N1N2MessageTransferRspData(cause := ts_N1N2MessageTransferCause(N1_N2_TRANSFER_INITIATED)) + body_enc := f_enc_N1N2MessageTransferRspData(valueof(n1n2msg_rsp)); + + http2_tx := ts_HTTP2_Msg_200_OK(http2_rx.conn_id, + http2_rx.stream_id, + headers := { + ts_HTTP2_Hdr_content_type("application/json; charset=utf-8") + }, + body := ts_HTTP2_Data_frame(http2_rx.stream_id, + end_stream_flag := true, + data := body_enc)); + HTTP2_CONN[HTTP2_CONN_SCP].send(http2_tx); +} + /* 5.2.2.3.1 N1N2MessageTransfer, PDU Session establishment (see clause 4.3.2 of 3GPP TS 23.502) */ altstep as_namf_comm_post_n1n2_messages_pdu_sess_establishment_reject(template (present) GMM_GSM_Cause exp_cause := ?) runs on SMF_Session_CT { @@ -581,10 +602,7 @@ [] as_namf_comm_post_n1n2_messages(http2_rx, parts) { var N1N2MessageTransferReqData n1n2msg_req; var NGAP_IEs.PDUSessionResourceSetupRequestTransfer setup_req_transf; - var template (value) N1N2MessageTransferRspData n1n2msg_rsp; var NG_NAS_DL_SM_Message_Type dl_nas; - var template (value) HTTP2_Msg http2_tx; - var octetstring body_enc; /* Decode 1st part: SBI json: */ f_dec_N1N2MessageTransferReqData(parts[0].data, n1n2msg_req); // TODO: check returned integer. @@ -593,6 +611,10 @@ dl_nas := dec_NG_NAS_DL_SM_Message_Type(parts[1].data); f_ng_nas_handle_session_establishment_reject(dl_nas, exp_cause); setverdict(pass); + + /* Tx answer: */ + f_namf_comm_N1N2MessageTransferRspData(http2_rx); + setverdict(pass); } } @@ -605,10 +627,7 @@ [] as_namf_comm_post_n1n2_messages(http2_rx, parts) { var N1N2MessageTransferReqData n1n2msg_req; var NGAP_IEs.PDUSessionResourceReleaseCommandTransfer rel_cmd_transf; - var template (value) N1N2MessageTransferRspData n1n2msg_rsp; var NG_NAS_DL_SM_Message_Type dl_nas; - var template (value) HTTP2_Msg http2_tx; - var octetstring body_enc; /* Decode 1st part: SBI json: */ f_dec_N1N2MessageTransferReqData(parts[0].data, n1n2msg_req); // TODO: check returned integer. @@ -622,18 +641,7 @@ f_ngap_pdu_handle_PDUSessionResourceReleaseCommandTransfer(rel_cmd_transf); /* Tx answer: */ - n1n2msg_rsp := ts_N1N2MessageTransferRspData(cause := ts_N1N2MessageTransferCause(N1_N2_TRANSFER_INITIATED)) - body_enc := f_enc_N1N2MessageTransferRspData(valueof(n1n2msg_rsp)); - - http2_tx := ts_HTTP2_Msg_200_OK(http2_rx.conn_id, - http2_rx.stream_id, - headers := { - ts_HTTP2_Hdr_content_type("application/json; charset=utf-8") - }, - body := ts_HTTP2_Data_frame(http2_rx.stream_id, - end_stream_flag := true, - data := body_enc)); - HTTP2_CONN[HTTP2_CONN_SCP].send(http2_tx); + f_namf_comm_N1N2MessageTransferRspData(http2_rx); setverdict(pass); } } diff --git a/smf/SMF_Tests.ttcn b/smf/SMF_Tests.ttcn index 14003d2..f093c4a 100644 --- a/smf/SMF_Tests.ttcn +++ b/smf/SMF_Tests.ttcn @@ -874,12 +874,11 @@ /* SMF deregisters on UDM: */ alt { [] as_nudm_sdm_delete_IndividualSubscription() { setverdict(pass); } /* expected incoming msg */ - [] as_namf_comm_post_n1n2_messages_pdu_sess_establishment_reject() { /* Unexpecte msg: */ + [] as_namf_comm_post_n1n2_messages_pdu_sess_establishment_reject() { /* Unexpected msg: */ setverdict(fail, "Received PDU SESS REJ while waiting for UDM! https://github.com/open5gs/open5gs/issues/4878"); repeat; } } - as_nudm_uecm_delete_IndividualSmfRegistration(); /* SMF Rejects the Create Session back to the UE: */ as_namf_comm_post_n1n2_messages_pdu_sess_establishment_reject(cs_GMM_GSM_Cause(omit, int2bit(38 /* Network Failure */, 8))); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7636f271d22df2417e57839e03dab62314f8aa24 Gerrit-Change-Number: 44019 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: smf: Fix wrong expect in TC_n11_createSession_pfcp_sess_est_timeout
by pespin 02 Nov '26

02 Nov '26
Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44019?usp=email ) Change subject: smf: Fix wrong expect in TC_n11_createSession_pfcp_sess_est_timeout ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7636f271d22df2417e57839e03dab62314f8aa24 Gerrit-Change-Number: 44019 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 02 Nov 2026 15:31:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: smf: Fix wrong expect in TC_n11_createSession_pfcp_sess_est_timeout
by fixeria 02 Nov '26

02 Nov '26
Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44019?usp=email ) Change subject: smf: Fix wrong expect in TC_n11_createSession_pfcp_sess_est_timeout ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7636f271d22df2417e57839e03dab62314f8aa24 Gerrit-Change-Number: 44019 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Nov 2026 15:23:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in pysim[master]: esim.saip: keep keyAccess and keyCounterValue of security domain keys
by dexter 02 Nov '26

02 Nov '26
Attention is currently required from: hampushellsberg, laforge, lynxis lazus. dexter has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44011?usp=email ) Change subject: esim.saip: keep keyAccess and keyCounterValue of security domain keys ...................................................................... Patch Set 2: Code-Review+1 (4 comments) Patchset: PS2: I think the patch is correctly carried out, however I am not entirely convinced of the KVN=>Length lookup table method. But I also do not want to block. File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/44011/comment/f61aa1a6_3da79e36?usp=em… : PS2, Line 1176: return 3 # SCP03 I would be very careful with those KVN Value mapping. Yes there are those typical ranges and they are even (not openly) specified. However, that does not mean that deviations are impossible. https://gerrit.osmocom.org/c/pysim/+/44011/comment/3766e412_082adb2b?usp=em… : PS2, Line 1178: 'is unknown' % kvn) (you do not have to break the string. Output strings are allowed to overshoot the line limit of 120 cols.) File tests/unittests/test_esim_saip.py: https://gerrit.osmocom.org/c/pysim/+/44011/comment/2979a5cf_ca86a51d?usp=em… : PS2, Line 88: self.assertEqual(counter(0xff), '0001') # SCP02 Cosmetic: Maybe re-order a bit so that the two SCP02 assertions are next to each other? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7df8ef6f2c81cd8544a04dbf7ff5d096685103e3 Gerrit-Change-Number: 44011 Gerrit-PatchSet: 2 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 02 Nov 2026 14:26:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in pysim[master]: esim.saip: derive nb_rec from efFileSize when the descriptor omits it
by dexter 02 Nov '26

02 Nov '26
Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43984?usp=email ) Change subject: esim.saip: derive nb_rec from efFileSize when the descriptor omits it ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: Maybe I don't get it, but I don't see how this patch changes the behavior? File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/43984/comment/fc8226b4_564e3420?usp=em… : PS3, Line 369: if self.rec_len and not fd_dec['num_of_rec']: To me this looks equivalent. self.nb_rec is pre-initialized with none. self.nb_rec gets populated when fd_dec['num_of_rec'] has a value. Otherwise it stays none. Which means we enter this code path. when fd_dec['num_of_rec'] is none. With the patch: We check fd_dec['num_of_rec'] directly, so when it is none, we also enter the code path. Or do I miss anything? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I191b234446c278a5252a903d170c3336d9e0c1ba Gerrit-Change-Number: 43984 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 02 Nov 2026 12:32:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[S] Change in pysim[master]: esim.saip: fix decoding of rfu PEs with an empty body
by hampushellsberg 02 Nov '26

02 Nov '26
Attention is currently required from: dexter, hampushellsberg, jolly, laforge. Hello Jenkins Builder, dexter, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/44012?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: esim.saip: fix decoding of rfu PEs with an empty body ...................................................................... esim.saip: fix decoding of rfu PEs with an empty body rfu1..rfu5 are PE-Dummy, an empty SEQUENCE. from_der() creates a generic ProfileElement for them and sets the type afterwards, but the constructor treated the empty dict like a new PE and derived a header name from the unset type, so a profile with such a PE failed to load with an AttributeError. Only create a header if 'decoded' is None, as documented. The folder osmocom-pysim-saip-empty-pe-body of hampushellsberg-dev/PySIM-upstream-patches on GitHub has the analysis and a repro. Change-Id: Ic47f74e8c111643c4ba435a9bac6aa9838bd3584 --- M pySim/esim/saip/__init__.py M tests/unittests/test_esim_saip.py 2 files changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/12/44012/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44012?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic47f74e8c111643c4ba435a9bac6aa9838bd3584 Gerrit-Change-Number: 44012 Gerrit-PatchSet: 2 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
1 0
0 0
[S] Change in pysim[master]: personalization: SmspTpScAddr edits record 1 of EF.SMSP only
by hampushellsberg 02 Nov '26

02 Nov '26
Attention is currently required from: dexter, laforge, neels, osmith. hampushellsberg has uploaded a new patch set (#4) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43983?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by dexter, Verified+1 by Jenkins Builder Change subject: personalization: SmspTpScAddr edits record 1 of EF.SMSP only ...................................................................... personalization: SmspTpScAddr edits record 1 of EF.SMSP only SmspTpScAddr decoded the whole EF.SMSP body as record 1 and wrote one encoded record back as the whole body. EF.SMSP is linear fixed and a profile can declare more than one record: both TS.48 v5 profiles in smdpp-data/upp carry a fileDescriptor with record length 42 and no record count, and efFileSize 84, so two records. While pySim takes the record count from the template (one record) this goes unnoticed; once the count follows efFileSize, the body holds both records, decoding all 84 bytes as one record fails on the alpha identifier, and test_configurable_parameters fails. Decode and encode record 1 only, and keep the records after it. The folder osmocom-pysim-saip-record-count of hampushellsberg-dev/PySIM-upstream-patches on GitHub carries this patch next to the record count fix that needs it. Change-Id: I47b1abc97d7b8caad0c74d7af2e5da38e9a895b1 --- M pySim/esim/saip/personalization.py M tests/unittests/test_configurable_parameters.py 2 files changed, 29 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/83/43983/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I47b1abc97d7b8caad0c74d7af2e5da38e9a895b1 Gerrit-Change-Number: 43983 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
1 0
0 0
[M] Change in pysim[master]: esim.saip: keep keyAccess and keyCounterValue of security domain keys
by hampushellsberg 02 Nov '26

02 Nov '26
Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/44011?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: esim.saip: keep keyAccess and keyCounterValue of security domain keys ...................................................................... esim.saip: keep keyAccess and keyCounterValue of security domain keys SecurityDomainKey only stored the usage qualifier, KID, KVN and key components, and ProfileElementSD._pre_encode() rebuilds keyList from it, so a non-default keyAccess and any keyCounterValue were lost on re-encode. Store both. keyAccess is only written if it is not '00'. The counter is an integer, encoded with the length of the protocol the KVN is reserved for (SAIP section 8.6.3: 2, 3 and 5 bytes for SCP02, SCP03 and SCP80, on the KVN ranges listed in global_platform/uicc.py), also when it was decoded with another length. A counter on any other KVN raises ValueError. The folder osmocom-pysim-saip-sd-key-access-counter of hampushellsberg-dev/PySIM-upstream-patches on GitHub has the analysis and a repro. Change-Id: I7df8ef6f2c81cd8544a04dbf7ff5d096685103e3 --- M pySim/esim/saip/__init__.py M tests/unittests/test_esim_saip.py 2 files changed, 71 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/11/44011/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7df8ef6f2c81cd8544a04dbf7ff5d096685103e3 Gerrit-Change-Number: 44011 Gerrit-PatchSet: 2 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>
1 0
0 0
[S] Change in pysim[master]: personalization: SmspTpScAddr edits record 1 of EF.SMSP only
by hampushellsberg 02 Nov '26

02 Nov '26
Attention is currently required from: laforge, neels, osmith. hampushellsberg has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43983?usp=email ) Change subject: personalization: SmspTpScAddr edits record 1 of EF.SMSP only ...................................................................... Patch Set 3: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/43983/comment/1b7a3f7b_f5c307e7?usp=em… : PS3, Line 651: if rec_len > Sounds excellent, thanks! Done in patch set 4: the condition is gone, and TestSmspTpScAddr in est_configurable_parameters.py edits a one-record and a two-record EF.SMSP and checks the second record is kept (without the fix the two-record case fails on the alpha identifier). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I47b1abc97d7b8caad0c74d7af2e5da38e9a895b1 Gerrit-Change-Number: 43983 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 02 Nov 2026 11:59:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: hampushellsberg <hampushellsberg(a)gmail.com> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 67
  • 68
  • 69
  • 70
  • 71
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.