[XS] Change in pysim[master]: esim.saip: derive nb_rec from efFileSize when the descriptor omits it
Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43984?usp=email ) Change subject: esim.saip: derive nb_rec from efFileSize when the descriptor omits it ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: Maybe I don't get it, but I don't see how this patch changes the behavior? File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/43984/comment/fc8226b4_564e3420?usp=ema... : PS3, Line 369: if self.rec_len and not fd_dec['num_of_rec']: To me this looks equivalent. self.nb_rec is pre-initialized with none. self.nb_rec gets populated when fd_dec['num_of_rec'] has a value. Otherwise it stays none. Which means we enter this code path. when fd_dec['num_of_rec'] is none. With the patch: We check fd_dec['num_of_rec'] directly, so when it is none, we also enter the code path. Or do I miss anything? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I191b234446c278a5252a903d170c3336d9e0c1ba Gerrit-Change-Number: 43984 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: hampushellsberg <hampushellsberg@gmail.com> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Mon, 02 Nov 2026 12:32:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
participants (1)
-
dexter