[M] Change in pysim[master]: esim.saip: keep keyAccess and keyCounterValue of security domain keys
Attention is currently required from: hampushellsberg, laforge, lynxis lazus. dexter has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44011?usp=email ) Change subject: esim.saip: keep keyAccess and keyCounterValue of security domain keys ...................................................................... Patch Set 2: Code-Review+1 (4 comments) Patchset: PS2: I think the patch is correctly carried out, however I am not entirely convinced of the KVN=>Length lookup table method. But I also do not want to block. File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/44011/comment/f61aa1a6_3da79e36?usp=ema... : PS2, Line 1176: return 3 # SCP03 I would be very careful with those KVN Value mapping. Yes there are those typical ranges and they are even (not openly) specified. However, that does not mean that deviations are impossible. https://gerrit.osmocom.org/c/pysim/+/44011/comment/3766e412_082adb2b?usp=ema... : PS2, Line 1178: 'is unknown' % kvn) (you do not have to break the string. Output strings are allowed to overshoot the line limit of 120 cols.) File tests/unittests/test_esim_saip.py: https://gerrit.osmocom.org/c/pysim/+/44011/comment/2979a5cf_ca86a51d?usp=ema... : PS2, Line 88: self.assertEqual(counter(0xff), '0001') # SCP02 Cosmetic: Maybe re-order a bit so that the two SCP02 assertions are next to each other? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7df8ef6f2c81cd8544a04dbf7ff5d096685103e3 Gerrit-Change-Number: 44011 Gerrit-PatchSet: 2 Gerrit-Owner: hampushellsberg <hampushellsberg@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: hampushellsberg <hampushellsberg@gmail.com> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Mon, 02 Nov 2026 14:26:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
participants (1)
-
dexter