Attention is currently required from: hampushellsberg, laforge, lynxis lazus.
Patch set 2:Code-Review +1
4 comments:
Patchset:
I think the patch is correctly carried out, however I am not entirely convinced of the KVN=>Length lookup table method. But I also do not want to block.
File pySim/esim/saip/__init__.py:
Patch Set #2, Line 1176: return 3 # SCP03
I would be very careful with those KVN Value mapping. Yes there are those typical ranges and they are even (not openly) specified. However, that does not mean that deviations are impossible.
Patch Set #2, Line 1178: 'is unknown' % kvn)
(you do not have to break the string. Output strings are allowed to overshoot the line limit of 120 cols.)
File tests/unittests/test_esim_saip.py:
Patch Set #2, Line 88: self.assertEqual(counter(0xff), '0001') # SCP02
Cosmetic: Maybe re-order a bit so that the two SCP02 assertions are next to each other?
To view, visit change 44011. To unsubscribe, or for help writing mail filters, visit settings.