lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[S] Change in osmo-ttcn3-hacks[master]: SGP23_Constants: use a reasonable default for sm_dp_oid
by dexter 03 Nov '26

03 Nov '26
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43930?usp=email ) Change subject: SGP23_Constants: use a reasonable default for sm_dp_oid ...................................................................... SGP23_Constants: use a reasonable default for sm_dp_oid The function f_SGP23_ACTIVATION_CODE_2 takes a paramter sm_dp_oid, which currently has no reasonable default value. Let's use the default as defined in SGP.23. Since the Activation Code requires the SM-DP+ OID in its human readable form, this patch also adds a converter function that converts an objid into a charstring. Change-Id: Iadf45954f18685c96d46b7df37c103eac3654332 Related: SYS#8203 --- M library/Osmocom_Types.ttcn M library/euicc/SGP23_Constants.ttcn 2 files changed, 22 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved jolly: Looks good to me, but someone else must approve diff --git a/library/Osmocom_Types.ttcn b/library/Osmocom_Types.ttcn index 6fbcb39..cbeed02 100644 --- a/library/Osmocom_Types.ttcn +++ b/library/Osmocom_Types.ttcn @@ -11,6 +11,8 @@ module Osmocom_Types { import from General_Types all; +import from TCCConversion_Functions all; //f_strstr() +import from Misc_Helpers all; //f_str_replace() type integer uint8_t (0..255) with { variant "unsigned 8 bit" }; type integer uint16_t (0..65535) with { variant "unsigned 16 bit" }; @@ -460,4 +462,21 @@ return bits; } +/* Convert an ASN.1 object identifier to a printable string (e.g. "2.999.10") */ +function f_objid2str(objid oid) return charstring { + var charstring oid_str := log2str(oid); + var integer left := f_strstr(oid_str, "{ ", 0); + var integer right := f_strstr(oid_str, " }", 0); + if (left < 0) { + setverdict(fail, "invalid OID"); + return ""; + } + if (right < 0) { + setverdict(fail, "invalid OID"); + return ""; + } + left := left + 2; + return f_str_replace(substr(oid_str, left, right - left), " ", "."); +} + } with { encode "RAW"; variant "FIELDORDER(msb)" } diff --git a/library/euicc/SGP23_Constants.ttcn b/library/euicc/SGP23_Constants.ttcn index a1695ad..480f122 100644 --- a/library/euicc/SGP23_Constants.ttcn +++ b/library/euicc/SGP23_Constants.ttcn @@ -17,6 +17,8 @@ module SGP23_Constants { +import from Osmocom_Types all; + /* Generic Constants (see also: SGP.23, annex A, section A1) */ const octetstring SGP23_EID1 := '89049032123451234512345678901235'O; const octetstring SGP23_EID2 := '89049032112341234012345678901375'O; @@ -30,7 +32,7 @@ } function f_SGP23_ACTIVATION_CODE_2(charstring test_dp_address := SGP23_TEST_DP_ADDRESS1, charstring matching_id := SGP23_MATCHING_ID_2, - charstring sm_dp_oid := "foo") return charstring { + charstring sm_dp_oid := f_objid2str(SGP23_S_SM_DPp_OID)) return charstring { return "1$" & test_dp_address & "$" & matching_id & "$" & sm_dp_oid; } function f_SGP23_ACTIVATION_CODE_3(charstring test_dp_address := SGP23_TEST_DP_ADDRESS1, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43930?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iadf45954f18685c96d46b7df37c103eac3654332 Gerrit-Change-Number: 43930 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in pysim[master]: esim.saip: the keyList of a PE-SecurityDomain is optional
by laforge 03 Nov '26

03 Nov '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/43990?usp=email ) Change subject: esim.saip: the keyList of a PE-SecurityDomain is optional ...................................................................... esim.saip: the keyList of a PE-SecurityDomain is optional keyList is OPTIONAL in the SecurityDomain PE, with SIZE (1..MAX). ProfileElementSD._post_decode() read it unconditionally, so an SD without keys raised KeyError: 'keyList', and _pre_encode() always wrote it, so an SD without keys was encoded with an empty keyList. Read the member with a default, and write it only when there is a key. The folder osmocom-pysim-saip-sd-optional-key-list of hampushellsberg-dev/PySIM-upstream-patches on GitHub has the analysis and a repro. Change-Id: Ibcc371edc36ea19cf9b0f58586fdd3bb42dc8dac --- M pySim/esim/saip/__init__.py 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 0a50dd3..60da704 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -1224,10 +1224,14 @@ def _post_decode(self): self.usip = self.C9() self.usip.from_bytes(self.decoded['instance']['applicationSpecificParametersC9']) - self.keys = [SecurityDomainKey.from_saip_dict(x) for x in self.decoded['keyList']] + # keyList is OPTIONAL (SIZE (1..MAX)): an SD without keys omits it + self.keys = [SecurityDomainKey.from_saip_dict(x) for x in self.decoded.get('keyList', [])] def _pre_encode(self): - self.decoded['keyList'] = [x.to_saip_dict() for x in self.keys] + if self.keys: + self.decoded['keyList'] = [x.to_saip_dict() for x in self.keys] + else: + self.decoded.pop('keyList', None) self.decoded['instance']['applicationSpecificParametersC9'] = self.usip.to_bytes() def has_scp(self, scp: int) -> bool: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43990?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibcc371edc36ea19cf9b0f58586fdd3bb42dc8dac Gerrit-Change-Number: 43990 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com>
1 0
0 0
[XS] Change in pysim[master]: esim.saip: the keyList of a PE-SecurityDomain is optional
by laforge 03 Nov '26

03 Nov '26
Attention is currently required from: dexter, hampushellsberg, neels. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43990?usp=email ) Change subject: esim.saip: the keyList of a PE-SecurityDomain is optional ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43990?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibcc371edc36ea19cf9b0f58586fdd3bb42dc8dac Gerrit-Change-Number: 43990 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Nov 2026 07:41:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in pysim[master]: esim.saip: encode an optimised body against the creation content
by laforge 03 Nov '26

03 Nov '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/43989?usp=email ) Change subject: esim.saip: encode an optimised body against the creation content ...................................................................... esim.saip: encode an optimised body against the creation content File.file_content_to_tuples(optimize=True) compared the body with the template default, or 'FF', and never with the Fcp's own fill or repeat pattern, which is what the eUICC creates the file with. A byte the body shared with the template default but not with the pattern was left out, and the card kept the pattern there. The fillFileOffset values were also counted from the bytes written so far rather than from the pointer, so every block after the first landed too far into the file. Take the baseline from expand_fill_pattern() when the Fcp declares a pattern, and count each offset from the end of the block written before it. The folder osmocom-pysim-saip-optimised-body-encoding of hampushellsberg-dev/PySIM-upstream-patches on GitHub has the analysis and a repro. Change-Id: Id991f066d6bd2afb6695f06d456613c742311e24 --- M pySim/esim/saip/__init__.py 1 file changed, 16 insertions(+), 11 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 2f305c0..0a50dd3 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -499,19 +499,22 @@ if not optimize: # simplistic approach: encode the full file, ignoring the template/default return [('fillFileContent', self.body)] - # Try to 'compress' the file body, based on the default file contents. - if self.template: + # Try to 'compress' the file body, based on the content the eUICC creates the file with: + # a fill/repeat pattern in the Fcp overwrites the template default (SAIP section 8.3.3) + if self.fill_pattern: + default = self.expand_fill_pattern() + elif self.template: default = self.template.expand_default_value_pattern(length=len(self.body)) - if not default: - sm = SequenceMatcher(a=b'\xff'*len(self.body), b=self.body) - else: - if default == self.body: - # 100% match: return an empty tuple list to make eUICC use the default - return [] - sm = SequenceMatcher(a=default, b=self.body) else: - # no template at all: we can only remove padding + default = None + if not default: + # no pattern and no default: we can only remove padding sm = SequenceMatcher(a=b'\xff'*len(self.body), b=self.body) + else: + if default == self.body: + # 100% match: return an empty tuple list to make eUICC use the default + return [] + sm = SequenceMatcher(a=default, b=self.body) matching_blocks = sm.get_matching_blocks() # we can only make use of matches that have the same offset in 'a' and 'b' matching_blocks = [x for x in matching_blocks if x.size > 0 and x.a == x.b] @@ -519,9 +522,11 @@ ret = [] cur = 0 for block in non_matching_blocks: + # fillFileOffset moves the pointer relative to its current position, and + # fillFileContent leaves it after the last byte written (SAIP section 8.3.5) ret.append(('fillFileOffset', block.a - cur)) ret.append(('fillFileContent', self.body[block.a:block.a+block.size])) - cur += block.size + cur = block.a + block.size return ret def __str__(self) -> str: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43989?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id991f066d6bd2afb6695f06d456613c742311e24 Gerrit-Change-Number: 43989 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com>
1 0
0 0
[S] Change in pysim[master]: esim.saip: apply proprietaryEFInfo when the Fcp has no fileDescriptor
by laforge 03 Nov '26

03 Nov '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/43988?usp=email ) Change subject: esim.saip: apply proprietaryEFInfo when the Fcp has no fileDescriptor ...................................................................... esim.saip: apply proprietaryEFInfo when the Fcp has no fileDescriptor File.from_fileDescriptor() applied proprietaryEFInfo (the special file information, the fill or repeat pattern, a BER-TLV maximum file size) only inside the branch that decodes the Fcp's own fileDescriptor. A file whose structure comes from its template, with an Fcp that changes only the pattern, kept fill_pattern None, and its body was the template default where the eUICC holds the pattern. Apply proprietaryEFInfo to any working EF whose type is known, from the Fcp's descriptor or from the template, in the same order as before. The folder osmocom-pysim-saip-proprietary-efinfo-without-descriptor of hampushellsberg-dev/PySIM-upstream-patches on GitHub has the analysis and a repro. Change-Id: I8b874a3c5f328a6f4c5b5f13e7bd7b641740b2df --- M pySim/esim/saip/__init__.py 1 file changed, 19 insertions(+), 15 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 3fbe835..2f305c0 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -377,21 +377,6 @@ self.file_type = 'TR' elif fdb_dec['structure'] == 'ber_tlv': self.file_type = 'BT' - if 'maximumFileSize' in pefi: - self._file_size = self._decode_file_size(pefi['maximumFileSize']) - specialFileInformation = pefi.get('specialFileInformation', None) - if specialFileInformation: - # TS 102 222 Table 5 - if specialFileInformation[0] & 0x80: - self.high_update = True - if specialFileInformation[0] & 0x40: - self.read_and_update_when_deact = True - if 'repeatPattern' in pefi: - self.fill_pattern = pefi['repeatPattern'] - self.fill_pattern_repeat = True - if 'fillPattern' in pefi: - self.fill_pattern = pefi['fillPattern'] - self.fill_pattern_repeat = False elif fdb_dec['file_type'] == 'df': # only set it, if an earlier call to from_template() didn't already set it, as # the template can differentiate between MF, DF and ADF (unlike FDB) @@ -403,6 +388,25 @@ #raise ValueError("%s: from_fileDescriptor without nested 'fileDescriptor'" % self) pass + # proprietaryEFInfo applies to a working EF whether or not the Fcp repeats the + # fileDescriptor its template already defines (TCA SAIP v3.4.1 section 8.3.3) + if self.file_type in ['TR', 'LF', 'CY', 'BT']: + if self.file_type == 'BT' and 'maximumFileSize' in pefi: + self._file_size = self._decode_file_size(pefi['maximumFileSize']) + specialFileInformation = pefi.get('specialFileInformation', None) + if specialFileInformation: + # TS 102 222 Table 5 + if specialFileInformation[0] & 0x80: + self.high_update = True + if specialFileInformation[0] & 0x40: + self.read_and_update_when_deact = True + if 'repeatPattern' in pefi: + self.fill_pattern = pefi['repeatPattern'] + self.fill_pattern_repeat = True + if 'fillPattern' in pefi: + self.fill_pattern = pefi['fillPattern'] + self.fill_pattern_repeat = False + logger.debug("\t%s" % repr(self)) def from_tuples(self, l:List[Tuple]): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43988?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8b874a3c5f328a6f4c5b5f13e7bd7b641740b2df Gerrit-Change-Number: 43988 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com>
1 0
0 0
[S] Change in pysim[master]: esim.saip: expand a record template's default value per record
by laforge 03 Nov '26

03 Nov '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/43987?usp=email ) Change subject: esim.saip: expand a record template's default value per record ...................................................................... esim.saip: expand a record template's default value per record FileTemplate.expand_default_value_pattern() expanded the default once across the requested length. The SAIP templates give a linear fixed or cyclic file its default per record (EF.ICI: 20 records of 38 bytes, 'FF...FF0000000001FFFF'), so only the last record received the tail of the default. When more than one record is asked for, expand one record and repeat it. A transparent file, a single record and a literal default that does not fill its record are unchanged. The folder osmocom-pysim-saip-fill-file-offset-erased-state of hampushellsberg-dev/PySIM-upstream-patches on GitHub has the analysis and a repro. Change-Id: Icff87219718422f11c9924485d2c4d4090381a45 --- M pySim/esim/saip/templates.py 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/esim/saip/templates.py b/pySim/esim/saip/templates.py index 5dfe375..cad5e2c 100644 --- a/pySim/esim/saip/templates.py +++ b/pySim/esim/saip/templates.py @@ -116,11 +116,23 @@ return self.rec_len def expand_default_value_pattern(self, length: Optional[int] = None) -> Optional[bytes]: - """Expand the default value pattern to the specified length.""" + """Expand the default value pattern to the specified length. + + The SAIP section 9 tables give a linear-fixed or cyclic file its default per record + (EF ICI: 20 records of 38 bytes, default 'FF...FF0000000001FFFF'), which is what + _default_value_len already assumes. A request longer than one record therefore expands + one record and repeats it; expanding once across the file puts the tail of the default + into the last record only. + """ if length is None: length = self._default_value_len() if length is None: raise ValueError("%s does not have a default length" % self) + if self.file_type in ['LF', 'CY'] and self.rec_len and length > self.rec_len: + record = self.expand_default_value_pattern(self.rec_len) + if record and len(record) == self.rec_len: + count, rest = divmod(length, self.rec_len) + return record * count + record[:rest] if not self.default_val: return None if not '...' in self.default_val: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43987?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icff87219718422f11c9924485d2c4d4090381a45 Gerrit-Change-Number: 43987 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com>
1 0
0 0
[XS] Change in pysim[master]: esim.saip: a ranged template file resolves to the start of its range
by laforge 03 Nov '26

03 Nov '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/43986?usp=email ) Change subject: esim.saip: a ranged template file resolves to the start of its range ...................................................................... esim.saip: a ranged template file resolves to the start of its range The templates list a file defined over a FID range once per FID, all rows sharing one pe_name, and ProfileTemplate.__init_subclass__() indexed them by plain assignment, so the last row of each range won: a PE-PHONEBOOK whose ef-adn carries no fileID came out as EF.ADN at 4F5F, and EF.PBC, EF.UID, EF.EXT1 and EF.CCP1 likewise at the end of their ranges. Keep the first row listed for a pe_name, which is the start of the range in every template table. The folder osmocom-pysim-saip-template-range-fid of hampushellsberg-dev/PySIM-upstream-patches on GitHub has the analysis and a repro. Change-Id: Ifc218e68465e8a4bbdd2c3d960622538b3284c99 --- M pySim/esim/saip/templates.py 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/esim/saip/templates.py b/pySim/esim/saip/templates.py index 50080b4..5dfe375 100644 --- a/pySim/esim/saip/templates.py +++ b/pySim/esim/saip/templates.py @@ -184,7 +184,11 @@ else: cur_df.children.append(f) f.parent = cur_df - cls.files_by_pename[f.pe_name] = f + # SAIP section 9.1: a file listed once per FID of a range shares one + # pe_name, and the first instance is created at the start of the + # range, so the first row listed is the one a PE without a fileID + # refers to. + cls.files_by_pename.setdefault(f.pe_name, f) ProfileTemplateRegistry.add(cls) @classmethod -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43986?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifc218e68465e8a4bbdd2c3d960622538b3284c99 Gerrit-Change-Number: 43986 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com>
1 0
0 0
[S] Change in pysim[master]: esim.saip: let a GenericFileManagement PE create the MF
by laforge 03 Nov '26

03 Nov '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/43982?usp=email ) Change subject: esim.saip: let a GenericFileManagement PE create the MF ...................................................................... esim.saip: let a GenericFileManagement PE create the MF A profile without PE-MF creates the MF as the first file of a PE-GenericFileManagement. ProfileElementGFM.add_file() resolved every file's parent through the sequence's MF, which does not exist yet at that point, so decoding such a profile failed with "AttributeError: 'NoneType' object has no attribute 'lookup_by_fidpath'". While the sequence has no MF, the DF with FID 3F00 becomes the MF root (sequence.mf and cur_df), as FsProfileElement.add_file() does for a PE-MF, and any other file is registered by path. A rootless ProfileElementSequence.cd() selects nothing instead of dereferencing the missing MF. The folder osmocom-pysim-saip-gfm-mf-creation of hampushellsberg-dev/PySIM-upstream-patches on GitHub has the analysis and a repro. Change-Id: Iceb910070e359c3830871f9048e448d6b115acae --- M pySim/esim/saip/__init__.py 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified dexter: Looks good to me, but someone else must approve diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 55811a8..11f549d 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -830,6 +830,23 @@ def add_file(self, file: File, path: Path): logger.debug("%s.add_file(path=%s, %s)" % (self.__class__.__name__, path, repr(file))) if hasattr(self.pe_sequence, 'mf'): + if self.pe_sequence.mf is None and file.fid == 0x3f00 and file.file_type == 'DF': + # TCA SAIP §8.1: without a PE-MF, the MF is created as the first file of a + # PE-GenericFileManagement; PE-MF is not allowed in an IoT Minimal Profile (§7.5). + if file.pe_name in self.files: + raise KeyError('Cannot add file: %s already exists' % file.pe_name) + file.node = FsNodeMF(file) + self.pe_sequence.mf = file.node + self.pe_sequence.cur_df = file.node + self.files[file.pe_name] = file + return + if self.pe_sequence.mf is None: + # no MF yet: keep the file reachable by path, as for a PE decoded without a sequence + path_str = str(path) if isinstance(path, Path) else self.path_str(path) + if path_str in self.files: + raise KeyError('Cannot add file: %s already exists' % path_str) + self.files[path_str] = file + return if isinstance(path, Path): parent = self.pe_sequence.mf.lookup_by_path(Path(path[:-1])) else: @@ -2066,6 +2083,10 @@ # remove the leading MF, in case it's specified explicitly while len(path) and path[0] == 0x3f00: path.pop(0) + if self.mf is None: + # no MF yet (a GFM creating the file system from scratch): nothing to select + self.cur_df = None + return df = self.mf for p in path: if not p in df.children: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43982?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iceb910070e359c3830871f9048e448d6b115acae Gerrit-Change-Number: 43982 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com>
1 0
0 0
[M] Change in pysim[master]: esim.saip: map cdmaParameter, nonStandard, iot and opt-iot to classes
by laforge 03 Nov '26

03 Nov '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/43985?usp=email ) Change subject: esim.saip: map cdmaParameter, nonStandard, iot and opt-iot to classes ...................................................................... esim.saip: map cdmaParameter, nonStandard, iot and opt-iot to classes ProfileElement.class_for_petype() maps every member of the ProfileElement CHOICE to a class except cdmaParameter, nonStandard, csim, opt-csim, iot and opt-iot. Those elements decode into a bare ProfileElement, so their files never reach the file system model. Add ProfileElementCDMA and ProfileElementNonStandard as plain ProfileElement subclasses; ProfileElementIoT, an FsProfileElement whose template spans the MF and ADF.USIM and which reuses an MF a preceding PE-GenericFileManagement created; ProfileElementOptIoT, the optional files below that ADF.USIM with DF.5GS and DF.SAIP; and the FilesIotMandatory and FilesIotOptional templates. NaaUsim lists the new types and templates, and _rebuild_pes_by_naa() starts the usim NAA at a PE-IoT, which is what creates ADF.USIM in such a profile. csim and opt-csim stay unmapped. The folder osmocom-pysim-saip-extra-profile-elements of hampushellsberg-dev/PySIM-upstream-patches on GitHub has the analysis and a repro. Change-Id: I7873f3c8be9bd5766856fb42f9ec6dc9817065a7 --- M pySim/esim/saip/__init__.py M pySim/esim/saip/templates.py 2 files changed, 203 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 11f549d..3fbe835 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -99,11 +99,11 @@ aid = h2b("a0000000871002") mandatory_services = ["usim"] pe_types = ["usim", "opt-usim", "phonebook", "gsm-access", "eap", "df-5gs", "df-saip", - "df-snpn", "df-5gprose"] + "df-snpn", "df-5gprose", "iot", "opt-iot"] templates = [oid.ADF_USIM_by_default, oid.ADF_USIMopt_not_by_default, oid.DF_PHONEBOOK_ADF_USIM, oid.DF_GSM_ACCESS_ADF_USIM, oid.DF_EAP, oid.DF_5GS, oid.DF_SAIP, oid.DF_SNPN, - oid.DF_5GProSe] + oid.DF_5GProSe, oid.IoT_by_default, oid.IoTopt_not_by_default] adf = ADF_USIM() class NaaIsim(Naa): @@ -615,11 +615,11 @@ 'pinCodes': ProfileElementPin, 'pukCodes': ProfileElementPuk, 'akaParameter': ProfileElementAKA, - # TODO: cdmaParameter + 'cdmaParameter': ProfileElementCDMA, 'securityDomain': ProfileElementSD, 'rfm': ProfileElementRFM, 'application': ProfileElementApplication, - # TODO: nonStandard + 'nonStandard': ProfileElementNonStandard, 'end': ProfileElementEnd, 'mf': ProfileElementMF, 'cd': ProfileElementCD, @@ -637,6 +637,8 @@ 'df-saip': ProfileElementDfSAIP, 'df-snpn': ProfileElementDfSNPN, 'df-5gprose': ProfileElementDf5GProSe, + 'iot': ProfileElementIoT, + 'opt-iot': ProfileElementOptIoT, } if pe_type in class4petype: return class4petype[pe_type] @@ -1458,6 +1460,135 @@ # provide some reasonable defaults for a MNO-SD self.decoded['templateID'] = str(oid.ADF_USIMopt_not_by_default_v2) +class ProfileElementCDMA(ProfileElement): + """Class representing the ProfileElement for the CDMA parameters (PE-CDMAParameter).""" + type = 'cdmaParameter' + +class ProfileElementNonStandard(ProfileElement): + """Class representing a non-standard, issuer specific ProfileElement (PE-NonStandard).""" + type = 'nonStandard' + +class ProfileElementIoT(FsProfileElement): + """Class representing the ProfileElement for the IoT Minimal Profile mandatory files. A single PE + creates the MF-level files and ADF.USIM (Section 8.3.4.8.1 and 9.10.1 of TCA SAIP V3.4.1).""" + type = 'iot' + + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) + if decoded: + return + self.decoded['templateID'] = str(oid.IoT_by_default) + for fname in ['mf', 'ef-iccid', 'ef-dir', 'adf-usim', 'ef-imsi', 'ef-ust', 'ef-acc', 'ef-ecc']: + self.decoded[fname] = [] + + @property + def adf_name(self) -> str: + return b2h(self.decoded['adf-usim'][0][1]['dfName']) + + @property + def imsi(self) -> Optional[str]: + template = templates.ProfileTemplateRegistry.get_by_oid(self.templateID) + f = File('ef-imsi', self.decoded['ef-imsi'], template.files_by_pename.get('ef-imsi', None)) + return dec_imsi(b2h(f.body)) + + def file_template_for_path(self, path: Path, adf: Optional[str] = None) -> Optional[templates.FileTemplate]: + # the template spans the MF and ADF.USIM, so the paths of its files are absolute + template = templates.ProfileTemplateRegistry.get_by_oid(self.templateID) + for f in template.files: + if f.path == path or f.path.relative_to_mf() == path: + return f + + def _root_template_mf(self): + """'mf' is OPTIONAL in PE-IoT: root the MF of the template so that ADF.USIM has a parent.""" + template = templates.ProfileTemplateRegistry.get_by_oid(self.templateID) + mf = File('mf', None, template.files_by_pename['mf']) + if self.pe_sequence.mf: + self.files['mf'] = mf + mf.node = self.pe_sequence.mf + return + super().add_file(mf) + + def add_file(self, file: File): + if self.pe_sequence and file.pe_name == 'mf' and self.pe_sequence.mf: + # the MF was created by a preceding PE-GenericFileManagement (Section 8.1): re-use it + if 'mf' in self.files: + raise KeyError('Cannot add file: mf already exists') + self.files['mf'] = file + file.node = self.pe_sequence.mf + return + if self.pe_sequence and file.pe_name != 'mf' and not 'mf' in self.files: + self._root_template_mf() + super().add_file(file) + +class ProfileElementOptIoT(FsProfileElement): + """Class representing the ProfileElement for the IoT Minimal Profile optional files below ADF.USIM, + including DF.5GS and DF.SAIP (Section 8.3.4.8.2 and 9.10.2 of TCA SAIP V3.4.1).""" + type = 'opt-iot' + + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) + if decoded: + return + self.decoded['templateID'] = str(oid.IoTopt_not_by_default) + + @staticmethod + def _relative_path(template: templates.ProfileTemplate, ft: templates.FileTemplate) -> Path: + """Path of a template row below ADF.USIM. Follows the ppath of the row, as the template tree + cannot express two sibling DFs (DF.5GS, DF.SAIP) within one template.""" + names = [] + for fid in ft.ppath: + container = [c for c in template.files if c.fid == fid and c.file_type in ['MF', 'DF', 'ADF']] + names.append(container[0].name if container else '%04X' % fid) + names.append(ft.name) + return Path(names) + + def file_template_for_path(self, path: Path, adf: Optional[str] = None) -> Optional[templates.FileTemplate]: + template = templates.ProfileTemplateRegistry.get_by_oid(self.templateID) + adf = adf or 'ADF.USIM' + for f in template.files: + relative = self._relative_path(template, f) + if Path([adf]) + relative == path or Path(['MF', adf]) + relative == path: + return f + + def _usim_adf_node(self) -> 'FsNodeDF': + """Resolve ADF.USIM as created by the preceding PE-IoT (or an ADF 7FF1 below the MF).""" + iot_pe = self.pe_sequence.get_closest_prev_pe_for_templateID(self, oid.IoT_by_default) + if iot_pe and 'adf-usim' in iot_pe.files and iot_pe.files['adf-usim'].node: + return iot_pe.files['adf-usim'].node + if self.pe_sequence.mf: + try: + return self.pe_sequence.mf[0x7ff1] + except KeyError: + pass + if self.pe_sequence.cur_df: + return self.pe_sequence.cur_df + raise ValueError('PE-OPT-IoT requires ADF.USIM of a preceding PE-IoT (Section 8.3.4.8.2)') + + def add_file(self, file: File): + if file.pe_name in self.files: + raise KeyError('Cannot add file: %s already exists' % file.pe_name) + self.files[file.pe_name] = file + if not self.pe_sequence: + return + template = templates.ProfileTemplateRegistry.get_by_oid(self.templateID) + pe_df = self._usim_adf_node() + # walk the intermediate DFs (DF.5GS, DF.SAIP); a DF the PE left out is created from its template row + for fid in (file.template.ppath if file.template else []): + try: + pe_df = pe_df[fid] + continue + except KeyError: + pass + container = [c for c in template.files if c.fid == fid and c.file_type in ['MF', 'DF', 'ADF']] + if not container: + raise KeyError('no template DF %04X on the path of %s' % (fid, file)) + path_file = self.files.get(container[0].pe_name) + if not path_file: + path_file = File(container[0].pe_name, None, container[0]) + self.files[container[0].pe_name] = path_file + pe_df = path_file.node if path_file.node else pe_df.add_file(path_file) + self.pe_sequence.cur_df = pe_df.add_file(file) + class ProfileElementISIM(FsProfileElement): """Class representing the ProfileElement for ADF.ISIM Mandatory Files""" type = 'isim' @@ -1735,7 +1866,8 @@ of a list of a list of PEs.""" self.pres_by_naa = {} petype_not_naa_related = ['securityDomain', 'rfm', 'application', 'end'] - naa = ['mf', 'usim', 'isim', 'csim'] + # PE-IoT creates ADF.USIM of an IoT Minimal Profile, so it starts the 'usim' NAA + naa = {'mf': 'mf', 'usim': 'usim', 'isim': 'isim', 'csim': 'csim', 'iot': 'usim'} cur_naa = None cur_naa_list = [] for pe in self.pe_list: @@ -1747,7 +1879,7 @@ if not cur_naa in self.pes_by_naa: self.pes_by_naa[cur_naa] = [] self.pes_by_naa[cur_naa].append(cur_naa_list) - cur_naa = pe.type + cur_naa = naa[pe.type] cur_naa_list = [] cur_naa_list.append(pe) # append the final one diff --git a/pySim/esim/saip/templates.py b/pySim/esim/saip/templates.py index a7fe69e..50080b4 100644 --- a/pySim/esim/saip/templates.py +++ b/pySim/esim/saip/templates.py @@ -795,6 +795,71 @@ FileTemplate(0x4f06, 'EF.5G_PROSE_UIR', 'TR', None, 32, 2, 0x06, None, True, ass_serv=[139,1005]), ] +class FilesIotMandatory(ProfileTemplate): + """Mandatory Files of the IoT Minimal Profile (MF and ADF.USIM) as per Section 9.10.1 v3.4.1""" + created_by_default = True + oid = OID.IoT_by_default + files = [ + FileTemplate(0x3f00, 'MF', 'MF', None, None, 7, None, None, False, ['pinStatusTemplateDO']), + FileTemplate(0x2f05, 'EF.PL', 'TR', None, 2, 1, 0x05, 'FF...FF', False), + FileTemplate(0x2fe2, 'EF.ICCID', 'TR', None, 10, 6, None, None, False), + FileTemplate(0x2f00, 'EF.DIR', 'LF', 1, None, 5, 0x1e, None, False, ['size']), + FileTemplate(0x2f06, 'EF.ARR', 'LF', 8, 33, 5, None, None, False), + FileTemplate(0x2f08, 'EF.UMPC', 'TR', None, 5, 5, 0x08, None, False), + FileTemplate(0x7ff1, 'ADF.USIM', 'ADF', None, None, 7, None, None, False, ['aid', 'pinStatusTemplateDO']), + FileTemplate(0x6f07, 'EF.IMSI', 'TR', None, 9, 2, 0x07, None, True, ppath=[0x7ff1]), + FileTemplate(0x6f06, 'EF.ARR', 'LF', None, None, 5, 0x17, None, False, pe_name='ef-arr-usim', ppath=[0x7ff1]), + FileTemplate(0x6f08, 'EF.Keys', 'TR', None, 33, 4, 0x08, '07FF...FF', False, high_update=True, ppath=[0x7ff1]), + FileTemplate(0x6f09, 'EF.KeysPS', 'TR', None, 33, 4, 0x09, '07FF...FF', False, high_update=True, pe_name='ef-keysPS', ppath=[0x7ff1]), + FileTemplate(0x6f31, 'EF.HPPLMN', 'TR', None, 1, 2, 0x12, '0A', False, ppath=[0x7ff1]), + FileTemplate(0x6f38, 'EF.UST', 'TR', None, 17, 2, 0x04, '000000000100...00', False, ppath=[0x7ff1]), + FileTemplate(0x6f5b, 'EF.START-HFN', 'TR', None, 6, 4, 0x0f, 'F00000F00000', False, high_update=True, ppath=[0x7ff1]), + FileTemplate(0x6f5c, 'EF.THRESHOLD', 'TR', None, 3, 2, 0x10, 'FFFFFF', False, ppath=[0x7ff1]), + FileTemplate(0x6f73, 'EF.PSLOCI', 'TR', None, 14, 4, 0x0c, 'FFFFFFFFFFFFFFFFFFFF0000FF01', False, high_update=True, ppath=[0x7ff1]), + FileTemplate(0x6f78, 'EF.ACC', 'TR', None, 2, 2, 0x06, None, True, ppath=[0x7ff1]), + FileTemplate(0x6f7b, 'EF.FPLMN', 'TR', None, 12, 4, 0x0d, 'FF...FF', False, ppath=[0x7ff1]), + FileTemplate(0x6f7e, 'EF.LOCI', 'TR', None, 11, 4, 0x0b, 'FFFFFFFFFFFFFF0000FF01', False, high_update=True, ppath=[0x7ff1]), + FileTemplate(0x6fad, 'EF.AD', 'TR', None, 4, 5, 0x03, '00000002', False, ppath=[0x7ff1]), + FileTemplate(0x6fb7, 'EF.ECC', 'LF', 1, 4, 5, 0x01, 'FF...FF', False, ppath=[0x7ff1]), + FileTemplate(0x6fc4, 'EF.NETPAR', 'TR', None, 128, 4, None, 'FF...FF', False, high_update=True, ppath=[0x7ff1]), + ] + +class FilesIotOptional(ProfileTemplate): + """Optional Files of the IoT Minimal Profile below ADF.USIM as per Section 9.10.2 v3.4.1""" + created_by_default = False + optional = True + oid = OID.IoTopt_not_by_default + base_path = Path('ADF.USIM') + extends = FilesIotMandatory + files = [ + FileTemplate(0x6f3b, 'EF.FDN', 'LF', 20, 26, 8, None, 'FF...FF', False, ass_serv=[2, 89]), + FileTemplate(0x6f3c, 'EF.SMS', 'LF', 10, 176, 4, None, '00FF...FF', False, ass_serv=[10]), + FileTemplate(0x6f42, 'EF.SMSP', 'LF', 1, 38, 4, None, 'FF...FF', False, ass_serv=[12]), + FileTemplate(0x6f43, 'EF.SMSS', 'TR', None, 2, 4, None, 'FFFF', False, ass_serv=[10]), + FileTemplate(0x6f46, 'EF.SPN', 'TR', None, 17, 5, None, None, True, ass_serv=[19]), + FileTemplate(0x6f56, 'EF.EST', 'TR', None, 1, 8, 0x05, None, True, ass_serv=[2, 6, 34, 35]), + FileTemplate(0x6f61, 'EF.OPLMNwAcT', 'TR', None, 40, 2, 0x11, 'FFFFFF0000', False, ass_serv=[42], repeat=True), + FileTemplate(0x6f62, 'EF.HPLMNwAcT', 'TR', None, 5, 2, 0x13, 'FFFFFF0000', False, ass_serv=[43], repeat=True), + FileTemplate(0x6fd9, 'EF.EHPLMN', 'TR', None, 15, 2, 0x1d, 'FF...FF', False, ass_serv=[71]), + FileTemplate(0x6fe3, 'EF.EPSLOCI', 'TR', None, 18, 4, 0x1e, 'FFFFFFFFFFFFFFFFFFFFFFFFFFFFFF000001', False, ass_serv=[85], high_update=True), + FileTemplate(0x6fe4, 'EF.EPSNSC', 'LF', 1, 80, 4, 0x18, 'FF...FF', False, ass_serv=[85], high_update=True), + FileTemplate(0x5fc0, 'DF.5GS', 'DF', None, None, 7, None, None, False, ['pinStatusTemplateDO'], pe_name='df-df-5gs'), + FileTemplate(0x4f01, 'EF.5GS3GPPLOCI', 'TR', None, 20, 4, 0x01, 'FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF00000001', False, ass_serv=[122], high_update=True, ppath=[0x5fc0]), + FileTemplate(0x4f02, 'EF.5GSN3GPPLOCI', 'TR', None, 20, 4, 0x02, 'FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF00000001', False, ass_serv=[122], high_update=True, ppath=[0x5fc0]), + FileTemplate(0x4f03, 'EF.5GS3GPPNSC', 'LF', 2, 62, 4, 0x03, 'FF...FF', False, ass_serv=[122, 136], high_update=True, ppath=[0x5fc0]), + FileTemplate(0x4f04, 'EF.5GSN3GPPNSC', 'LF', 2, 62, 4, 0x04, 'FF...FF', False, ass_serv=[122, 136], high_update=True, ppath=[0x5fc0]), + FileTemplate(0x4f05, 'EF.5GAUTHKEYS', 'TR', None, 110, 4, 0x05, 'FF...FF', False, ass_serv=[123], high_update=True, ppath=[0x5fc0]), + FileTemplate(0x4f06, 'EF.UAC_AIC', 'TR', None, 4, 2, 0x06, None, True, ass_serv=[126], ppath=[0x5fc0]), + FileTemplate(0x4f07, 'EF.SUCI_Calc_Info','TR', None, 44, 2, 0x07, 'FF...FF', False, ass_serv=[124], ppath=[0x5fc0]), + FileTemplate(0x4f08, 'EF.OPL5G', 'LF', 1, 10, 5, 0x08, 'FF...FF', False, ass_serv=[129], ppath=[0x5fc0]), + FileTemplate(0x4f09, 'EF.SUPI_NAI', 'TR', None, 20, 2, 0x09, None, True, ass_serv=[130], pe_name='ef-supi-nai', ppath=[0x5fc0]), + FileTemplate(0x4f0a, 'EF.Routing_Indicator', 'TR', None, 4, 2, 0x0a, 'F0FF0000', False, ass_serv=[124], ppath=[0x5fc0]), + FileTemplate(0x4f0b, 'EF.URSP', 'BT', None, 200, 2, None, None, False, ass_serv=[132], ppath=[0x5fc0]), + FileTemplate(0x4f0c, 'EF.TN3GPPSNN', 'TR', None, 1, 2, 0x0c, '00', False, ass_serv=[135], ppath=[0x5fc0]), + FileTemplate(0x5fd0, 'DF.SAIP', 'DF', None, None, 7, None, None, False, ['pinStatusTemplateDO'], pe_name='df-df-saip'), + FileTemplate(0x4f01, 'EF.SUCI_Calc_Info_USIM', 'TR', None, 44, 3, None, 'FF...FF', False, ass_serv=[125], pe_name='ef-suci-calc-info-usim', ppath=[0x5fd0]), + ] + class FilesIsimMandatory(ProfileTemplate): """Mandatory Files at ADF.ISIM as per Section 9.6.1""" created_by_default = True -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43985?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7873f3c8be9bd5766856fb42f9ec6dc9817065a7 Gerrit-Change-Number: 43985 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com>
1 0
0 0
[S] Change in pysim[master]: esim.saip: encode an optimised body against the creation content
by laforge 03 Nov '26

03 Nov '26
Attention is currently required from: hampushellsberg. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43989?usp=email ) Change subject: esim.saip: encode an optimised body against the creation content ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43989?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id991f066d6bd2afb6695f06d456613c742311e24 Gerrit-Change-Number: 43989 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Comment-Date: Tue, 03 Nov 2026 07:40:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 65
  • 66
  • 67
  • 68
  • 69
  • 70
  • 71
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.