lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[S] Change in pysim[master]: esim.saip: keep keyAccess and keyCounterValue of security domain keys
by hampushellsberg 02 Nov '26

02 Nov '26
Attention is currently required from: laforge. hampushellsberg has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44011?usp=email ) Change subject: esim.saip: keep keyAccess and keyCounterValue of security domain keys ...................................................................... Patch Set 1: (1 comment) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/44011/comment/9d7b12cd_52160467?usp=em… : PS1, Line 1156: > Case 1: I would say let's raise an exception so we as developers/maintainers get note of it and can […] Done in patch set 2, as you suggested: the counter is an int whose length comes from the KVN, so there is no explicit length argument; a counter on a KVN outside the table raises ValueError when the key is encoded (decoding still works), and a decoded counter is re-encoded with the length its KVN gives. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7df8ef6f2c81cd8544a04dbf7ff5d096685103e3 Gerrit-Change-Number: 44011 Gerrit-PatchSet: 1 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 02 Nov 2026 11:58:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: hampushellsberg <hampushellsberg(a)gmail.com> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
1 0
0 0
[XL] Change in pysim[master]: esim/asn1: add the SGP.22 v3.1 RSPDefinitions module as rsp_v3
by hampushellsberg 02 Nov '26

02 Nov '26
Attention is currently required from: laforge. hampushellsberg has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44007?usp=email ) Change subject: esim/asn1: add the SGP.22 v3.1 RSPDefinitions module as rsp_v3 ...................................................................... Patch Set 1: (1 comment) File pySim/esim/rsp.py: https://gerrit.osmocom.org/c/pysim/+/44007/comment/ce9dacbe_81c95b32?usp=em… : PS1, Line 35: asn1_v3 > is there a reason why this is defined as a function rather than as a global variable (like asn1 abov […] Yes: lru_cache runs the compile once, on the first call, and returns the same module after that. I kept it lazy because compiling the v3.1 module together with the SAIP and PKIX modules it imports takes about 0.4 s here (the v2 module about 0.2 s), and pySim.esim.rsp is imported by es8p, es9p, osmo-smdpp and the ES2+/ES9+ contrib tools, of which only osmo-smdpp uses v3 (for EUICCInfo1). As a module-level variable like asn1, every one of them would pay that at import. Would you rather have the variable anyway, for consistency with asn1? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44007?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I670ec73f9958882a8d3fe4b589bdafa3fbf702ea Gerrit-Change-Number: 44007 Gerrit-PatchSet: 1 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-CC: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 02 Nov 2026 11:57:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
1 0
0 0
[S] Change in pysim[master]: personalization: SmspTpScAddr edits record 1 of EF.SMSP only
by dexter 02 Nov '26

02 Nov '26
Attention is currently required from: hampushellsberg, laforge, neels, osmith. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43983?usp=email ) Change subject: personalization: SmspTpScAddr edits record 1 of EF.SMSP only ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: The patch is plausible. Having a unit-test would make sense I think. Also because we already had a lot of trouble with EF.SMSP and this particular code location. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I47b1abc97d7b8caad0c74d7af2e5da38e9a895b1 Gerrit-Change-Number: 43983 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 02 Nov 2026 11:46:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in docker-playground[master]: redmine: update from 6.1.4 to 6.1.6
by laforge 02 Nov '26

02 Nov '26
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/44020?usp=email ) Change subject: redmine: update from 6.1.4 to 6.1.6 ...................................................................... redmine: update from 6.1.4 to 6.1.6 Change-Id: Ia0176a37017d6d96b1c4c61e353b0bea3dc181b6 --- M redmine/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/20/44020/1 diff --git a/redmine/Dockerfile b/redmine/Dockerfile index 5c6ef3e..91aa775 100644 --- a/redmine/Dockerfile +++ b/redmine/Dockerfile @@ -1,4 +1,4 @@ -FROM redmine:6.1.3 +FROM redmine:6.1.6 RUN apt-get update && \ apt-get -y upgrade && \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/44020?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia0176a37017d6d96b1c4c61e353b0bea3dc181b6 Gerrit-Change-Number: 44020 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>
1 0
0 0
[S] Change in pysim[master]: esim.saip: let a GenericFileManagement PE create the MF
by dexter 02 Nov '26

02 Nov '26
Attention is currently required from: jolly, laforge, neels, osmith. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43982?usp=email ) Change subject: esim.saip: let a GenericFileManagement PE create the MF ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Maybe @nhofmeyr@sysmocom.de has an opinion about this. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43982?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iceb910070e359c3830871f9048e448d6b115acae Gerrit-Change-Number: 43982 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 02 Nov 2026 11:22:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[S] Change in pysim[master]: esim.saip: let a GenericFileManagement PE create the MF
by dexter 02 Nov '26

02 Nov '26
Attention is currently required from: jolly, laforge, osmith. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43982?usp=email ) Change subject: esim.saip: let a GenericFileManagement PE create the MF ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: The code looks reasonable, but I cannot fully oversee the consequences this change will have. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43982?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iceb910070e359c3830871f9048e448d6b115acae Gerrit-Change-Number: 43982 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 02 Nov 2026 11:21:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: smf: Fix wrong expect in TC_n11_createSession_pfcp_sess_est_timeout
by pespin 02 Nov '26

02 Nov '26
Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44019?usp=email to look at the new patch set (#3). Change subject: smf: Fix wrong expect in TC_n11_createSession_pfcp_sess_est_timeout ...................................................................... smf: Fix wrong expect in TC_n11_createSession_pfcp_sess_est_timeout The UECM registration only happens after full registration towards the UE happens, ie. after PFCP Session Modification procedure. Hence, at this point in the test the UECM is not registered yet and hence needs no deletion. Furthermore, the as_namf_comm_post_n1n2_messages_pdu_sess_establishment_reject() altstep was missing an answer to towards the IUT; add it. Related: https://github.com/open5gs/open5gs/issues/4878 Change-Id: I7636f271d22df2417e57839e03dab62314f8aa24 --- M smf/SMF_Session_CT_5G.ttcn M smf/SMF_Tests.ttcn 2 files changed, 27 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/44019/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7636f271d22df2417e57839e03dab62314f8aa24 Gerrit-Change-Number: 44019 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: smf: Fix wrong expect in TC_n11_createSession_pfcp_sess_est_timeout
by pespin 02 Nov '26

02 Nov '26
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44019?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: smf: Fix wrong expect in TC_n11_createSession_pfcp_sess_est_timeout ...................................................................... smf: Fix wrong expect in TC_n11_createSession_pfcp_sess_est_timeout The UECM registration only happens after full registration towards the UE happens, ie. after PFCP Session Modification procedure. Hence, at this point in the test the UECM is not registered yet and hence needs to deletion. Furthermore, the as_namf_comm_post_n1n2_messages_pdu_sess_establishment_reject() altstep was missing an answer to towards the IUT; add it. Related: https://github.com/open5gs/open5gs/issues/4878 Change-Id: I7636f271d22df2417e57839e03dab62314f8aa24 --- M smf/SMF_Session_CT_5G.ttcn M smf/SMF_Tests.ttcn 2 files changed, 27 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/44019/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7636f271d22df2417e57839e03dab62314f8aa24 Gerrit-Change-Number: 44019 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder
1 0
0 0
[XS] Change in osmo-ttcn3-hacks[master]: smf: Fix wrong expect in TC_n11_createSession_pfcp_sess_est_timeout
by pespin 02 Nov '26

02 Nov '26
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44019?usp=email ) Change subject: smf: Fix wrong expect in TC_n11_createSession_pfcp_sess_est_timeout ...................................................................... smf: Fix wrong expect in TC_n11_createSession_pfcp_sess_est_timeout The UECM registration only happens after full registration towards the UE happens, ie. after PFCP Session Modification procedure. Hence, at this point in the test the UECM is not registered yet and hence needs to deletion. Related: https://github.com/open5gs/open5gs/issues/4878 Change-Id: I7636f271d22df2417e57839e03dab62314f8aa24 --- M smf/SMF_Tests.ttcn 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/44019/1 diff --git a/smf/SMF_Tests.ttcn b/smf/SMF_Tests.ttcn index 14003d2..f093c4a 100644 --- a/smf/SMF_Tests.ttcn +++ b/smf/SMF_Tests.ttcn @@ -874,12 +874,11 @@ /* SMF deregisters on UDM: */ alt { [] as_nudm_sdm_delete_IndividualSubscription() { setverdict(pass); } /* expected incoming msg */ - [] as_namf_comm_post_n1n2_messages_pdu_sess_establishment_reject() { /* Unexpecte msg: */ + [] as_namf_comm_post_n1n2_messages_pdu_sess_establishment_reject() { /* Unexpected msg: */ setverdict(fail, "Received PDU SESS REJ while waiting for UDM! https://github.com/open5gs/open5gs/issues/4878"); repeat; } } - as_nudm_uecm_delete_IndividualSmfRegistration(); /* SMF Rejects the Create Session back to the UE: */ as_namf_comm_post_n1n2_messages_pdu_sess_establishment_reject(cs_GMM_GSM_Cause(omit, int2bit(38 /* Network Failure */, 8))); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7636f271d22df2417e57839e03dab62314f8aa24 Gerrit-Change-Number: 44019 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in asn1c[master]: coverity CID#300603
by dexter 02 Nov '26

02 Nov '26
Attention is currently required from: neels. dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/asn1c/+/39378?usp=email ) Change subject: coverity CID#300603 ...................................................................... Patch Set 1: -Code-Review (1 comment) Patchset: PS1: @nhofmeyr@sysmocom.de: I think we should abandon this patch. -- To view, visit https://gerrit.osmocom.org/c/asn1c/+/39378?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asn1c Gerrit-Branch: master Gerrit-Change-Id: I1cab41ff53fb3c7d94a07cb148197324f4188d9c Gerrit-Change-Number: 39378 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Nov 2026 10:30:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 68
  • 69
  • 70
  • 71
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.