lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[S] Change in pysim[master]: esim.saip: apply proprietaryEFInfo when the Fcp has no fileDescriptor
by laforge 03 Nov '26

03 Nov '26
Attention is currently required from: dexter, hampushellsberg, jolly. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43988?usp=email ) Change subject: esim.saip: apply proprietaryEFInfo when the Fcp has no fileDescriptor ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43988?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8b874a3c5f328a6f4c5b5f13e7bd7b641740b2df Gerrit-Change-Number: 43988 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Nov 2026 07:40:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in pysim[master]: esim.saip: expand a record template's default value per record
by laforge 03 Nov '26

03 Nov '26
Attention is currently required from: dexter, hampushellsberg, jolly. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43987?usp=email ) Change subject: esim.saip: expand a record template's default value per record ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43987?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icff87219718422f11c9924485d2c4d4090381a45 Gerrit-Change-Number: 43987 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Nov 2026 07:40:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in pysim[master]: esim.saip: a ranged template file resolves to the start of its range
by laforge 03 Nov '26

03 Nov '26
Attention is currently required from: dexter, hampushellsberg, jolly. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43986?usp=email ) Change subject: esim.saip: a ranged template file resolves to the start of its range ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43986?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifc218e68465e8a4bbdd2c3d960622538b3284c99 Gerrit-Change-Number: 43986 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Nov 2026 07:40:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in pysim[master]: esim.saip: map cdmaParameter, nonStandard, iot and opt-iot to classes
by laforge 03 Nov '26

03 Nov '26
Attention is currently required from: dexter, hampushellsberg, jolly. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43985?usp=email ) Change subject: esim.saip: map cdmaParameter, nonStandard, iot and opt-iot to classes ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43985?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7873f3c8be9bd5766856fb42f9ec6dc9817065a7 Gerrit-Change-Number: 43985 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Nov 2026 07:40:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in pysim[master]: esim.saip: let a GenericFileManagement PE create the MF
by laforge 03 Nov '26

03 Nov '26
Attention is currently required from: jolly, osmith. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43982?usp=email ) Change subject: esim.saip: let a GenericFileManagement PE create the MF ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43982?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iceb910070e359c3830871f9048e448d6b115acae Gerrit-Change-Number: 43982 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 03 Nov 2026 07:39:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in pysim[master]: esim.saip: let a GenericFileManagement PE create the MF
by neels 03 Nov '26

03 Nov '26
Attention is currently required from: jolly, laforge, osmith. neels has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43982?usp=email ) Change subject: esim.saip: let a GenericFileManagement PE create the MF ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: (I'm not familiar this part of the code, can't say much) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43982?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iceb910070e359c3830871f9048e448d6b115acae Gerrit-Change-Number: 43982 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 03 Nov 2026 00:51:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[XS] Change in pysim[master]: esim.saip: derive nb_rec from efFileSize when the descriptor omits it
by neels 03 Nov '26

03 Nov '26
Attention is currently required from: dexter, hampushellsberg, laforge. neels has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43984?usp=email ) Change subject: esim.saip: derive nb_rec from efFileSize when the descriptor omits it ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I191b234446c278a5252a903d170c3336d9e0c1ba Gerrit-Change-Number: 43984 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Nov 2026 00:41:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in pysim[master]: personalization: SmspTpScAddr edits record 1 of EF.SMSP only
by neels 03 Nov '26

03 Nov '26
Attention is currently required from: dexter, hampushellsberg, laforge. neels has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43983?usp=email ) Change subject: personalization: SmspTpScAddr edits record 1 of EF.SMSP only ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I47b1abc97d7b8caad0c74d7af2e5da38e9a895b1 Gerrit-Change-Number: 43983 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Nov 2026 00:29:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in pysim[master]: esim.saip: keep keyAccess and keyCounterValue of security domain keys
by hampushellsberg 02 Nov '26

02 Nov '26
Attention is currently required from: dexter, laforge, lynxis lazus. hampushellsberg has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44011?usp=email ) Change subject: esim.saip: keep keyAccess and keyCounterValue of security domain keys ...................................................................... Patch Set 2: (1 comment) File tests/unittests/test_esim_saip.py: https://gerrit.osmocom.org/c/pysim/+/44011/comment/dfc2ca3b_87cb3710?usp=em… : PS2, Line 88: self.assertEqual(counter(0xff), '0001') # SCP02 > Cosmetic: Maybe re-order a bit so that the two SCP02 assertions are next to each other? Agreed, the ranges are a convention and deviations exist; pySim's own SCP02 accepts '01' and '70' for sysmocom cards. That's why a KVN outside the table raises instead of guessing, as laforge suggested on patch set 1: such a key gets noticed and the table extended, and decoding never fails. A deviation inside a range, e.g. an SCP02 keyset on '01', would still get the SCP80 length. Is that acceptable to you, or would you like that case handled too? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7df8ef6f2c81cd8544a04dbf7ff5d096685103e3 Gerrit-Change-Number: 44011 Gerrit-PatchSet: 2 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Nov 2026 21:02:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
1 0
0 0
[XS] Change in pysim[master]: esim.saip: derive nb_rec from efFileSize when the descriptor omits it
by hampushellsberg 02 Nov '26

02 Nov '26
Attention is currently required from: dexter, laforge. hampushellsberg has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43984?usp=email ) Change subject: esim.saip: derive nb_rec from efFileSize when the descriptor omits it ...................................................................... Patch Set 4: (1 comment) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/43984/comment/56c2acf5_6e825dcd?usp=em… : PS3, Line 369: if self.rec_len and not fd_dec['num_of_rec']: > To me this looks equivalent. […] The difference is a file that comes from a template: File.__init__ calls from_template() before from_fileDescriptor(), and from_template() copies the template's nb_rec, so nb_rec is no longer None when the descriptor is decoded. For such a file with a fileDescriptor that has a record length but no count, and a larger efFileSize, the old check kept the template's count. In the repro, EF.MSISDN (template: 1 record) with record length 34 and efFileSize 68 decodes as 1 record of 34 bytes before and 2 records, 68 bytes, with the patch. Without a template you're right, both behave the same. Should the comment say that from_template() has set nb_rec already? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I191b234446c278a5252a903d170c3336d9e0c1ba Gerrit-Change-Number: 43984 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Nov 2026 21:01:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 66
  • 67
  • 68
  • 69
  • 70
  • 71
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.