[M] Change in pysim[master]: esim.saip: keep keyAccess and keyCounterValue of security domain keys
Attention is currently required from: dexter, laforge, lynxis lazus. hampushellsberg has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44011?usp=email ) Change subject: esim.saip: keep keyAccess and keyCounterValue of security domain keys ...................................................................... Patch Set 2: (1 comment) File tests/unittests/test_esim_saip.py: https://gerrit.osmocom.org/c/pysim/+/44011/comment/dfc2ca3b_87cb3710?usp=ema... : PS2, Line 88: self.assertEqual(counter(0xff), '0001') # SCP02
Cosmetic: Maybe re-order a bit so that the two SCP02 assertions are next to each other? Agreed, the ranges are a convention and deviations exist; pySim's own SCP02 accepts '01' and '70' for sysmocom cards. That's why a KVN outside the table raises instead of guessing, as laforge suggested on patch set 1: such a key gets noticed and the table extended, and decoding never fails. A deviation inside a range, e.g. an SCP02 keyset on '01', would still get the SCP80 length. Is that acceptable to you, or would you like that case handled too?
-- To view, visit https://gerrit.osmocom.org/c/pysim/+/44011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7df8ef6f2c81cd8544a04dbf7ff5d096685103e3 Gerrit-Change-Number: 44011 Gerrit-PatchSet: 2 Gerrit-Owner: hampushellsberg <hampushellsberg@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Mon, 02 Nov 2026 21:02:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier@sysmocom.de>
participants (1)
-
hampushellsberg