Attention is currently required from: dexter, laforge, lynxis lazus.
1 comment:
File tests/unittests/test_esim_saip.py:
Patch Set #2, Line 88: self.assertEqual(counter(0xff), '0001') # SCP02
Cosmetic: Maybe re-order a bit so that the two SCP02 assertions are next to each other?
Agreed, the ranges are a convention and deviations exist; pySim's own SCP02 accepts '01' and '70' for sysmocom cards. That's why a KVN outside the table raises instead of guessing, as laforge suggested on patch set 1: such a key gets noticed and the table extended, and decoding never fails. A deviation inside a range, e.g. an SCP02 keyset on '01', would still get the SCP80 length.
Is that acceptable to you, or would you like that case handled too?
To view, visit change 44011. To unsubscribe, or for help writing mail filters, visit settings.