lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[L] Change in osmo-ttcn3-hacks[master]: eIM_Tests: add a subset of SGP.33-3/SGP.23 testcases
by dexter 03 Nov '26

03 Nov '26
Attention is currently required from: jolly, pespin. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904?usp=email ) Change subject: eIM_Tests: add a subset of SGP.33-3/SGP.23 testcases ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: At least from my perspective we could merge this patch now. The newly introduced tests will not pass immediately since on the eIM side still some pending patches, but all existing tests should remain stable. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ide8fdec56eca4d4577baedfacd2a6a675d9c0e6e Gerrit-Change-Number: 43904 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Nov 2026 12:59:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[L] Change in osmo-ttcn3-hacks[master]: eIM_Tests: add a subset of SGP.33-3/SGP.23 testcases
by dexter 03 Nov '26

03 Nov '26
Attention is currently required from: jolly. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904?usp=email ) Change subject: eIM_Tests: add a subset of SGP.33-3/SGP.23 testcases ...................................................................... Patch Set 9: (2 comments) Patchset: PS8: At least from my perspective we could merge this patch now. The newly introduced tests will not pass immediately since on the eIM side still some pending patches, but all existing tests should remain stable. File eim/eIM_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904/comment/6105caa9_a435… : PS7, Line 1241: private function f_TC_eIM_AuthenticateClient_ErrorCases_Error_Invalid_SM_DPp_pb_certificate(charstring id) > Thanks for giving it a try. This is expected. The reason for this is that in the default sys. […] (I set this to resolved for now) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ide8fdec56eca4d4577baedfacd2a6a675d9c0e6e Gerrit-Change-Number: 43904 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 03 Nov 2026 12:58:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
1 0
0 0
[M] Change in onomondo-eim[master]: esipa_json_handler: return subjectCode and reasonCode on error
by dexter 03 Nov '26

03 Nov '26
dexter has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43819?usp=email ) Change subject: esipa_json_handler: return subjectCode and reasonCode on error ...................................................................... esipa_json_handler: return subjectCode and reasonCode on error When an ESipa request runs into an error, the JSON API only returns a status ("Failed") but no statusCodeData field is returned. This is technically acceptable since the statusCodeData field is an optional field. However, it is common sense that an error response should include a statusCodeData field. So let's at least put a statusCodeData fields with a generic subjectCode and reasonCode field into the response. Let's also add TODO comments and placeholders into the code, so that we can pick this up later to add more specific error codes. (For our concrete implementation the JSON API bindings have no relevance since onomondo-ipa uses the ASN.1 API bindings. This patch is currently only relevant for the TTCN3 testsuite, which requires the presence of the statusCodeData field) Change-Id: I2d836f7f8d8ced10ba0e9880268079a27c804b04 Related: SYS#8203 --- M src/esipa_json_handler.erl 1 file changed, 149 insertions(+), 10 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/src/esipa_json_handler.erl b/src/esipa_json_handler.erl index aad3929..4311776 100644 --- a/src/esipa_json_handler.erl +++ b/src/esipa_json_handler.erl @@ -123,8 +123,31 @@ maps:get(ctxParams1, InitiateAuthenticationOkEsipa, absent) )} ]); + {initiateAuthenticationResponseEsipa, + {initiateAuthenticationErrorEsipa, _InitiateAuthenticationErrorEsipa}} -> + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]); _ -> - join([{header, #{<<"functionExecutionStatus">> => #{<<"status">> => <<"Failed">>}}}]) + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]) end; %GSMA SGP.32, section 6.4.1.2 handle_json({<<"/gsma/rsp2/esipa/authenticateClient">>, EsipaReq}) -> @@ -178,8 +201,44 @@ maps:get(hashCc, AuthenticateClientOkDPEsipa, absent) )} ]); + {authenticateClientResponseEsipa, + {authenticateClientOkDSEsipa, _AuthenticateClientOkDSEsipa}} -> + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]); + {authenticateClientResponseEsipa, + {authenticateClientErrorEsipa, _AuthenticateClientErrorEsipa}} -> + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]); _ -> - join([{header, #{<<"functionExecutionStatus">> => #{<<"status">> => <<"Failed">>}}}]) + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]) end; %GSMA SGP.32, section 6.4.1.3 handle_json({<<"/gsma/rsp2/esipa/getBoundProfilePackage">>, EsipaReq}) -> @@ -214,9 +273,29 @@ ]); {getBoundProfilePackageResponseEsipa, {getBoundProfilePackageErrorEsipa, _GetBoundProfilePackageErrorEsipa}} -> - join([{header, #{<<"functionExecutionStatus">> => #{<<"status">> => <<"Failed">>}}}]); + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]); _ -> - join([{header, #{<<"functionExecutionStatus">> => #{<<"status">> => <<"Failed">>}}}]) + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]) end; %GSMA SGP.32, section 6.4.1.5 handle_json({<<"/gsma/rsp2/esipa/getEimPackage">>, EsipaReq}) -> @@ -315,7 +394,17 @@ {eimPackageError, EimPackageErrorInt} ]); _ -> - join([{header, #{<<"functionExecutionStatus">> => #{<<"status">> => <<"Failed">>}}}]) + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]) end; %GSMA SGP.32, section 6.4.1.6 handle_json({<<"/gsma/rsp2/esipa/provideEimPackageResult">>, EsipaReq}) -> @@ -349,9 +438,29 @@ ]); {provideEimPackageResultError, {provideEimPackageResultError, _ProvideEimPackageResultError}} -> - join([{header, #{<<"functionExecutionStatus">> => #{<<"status">> => <<"Failed">>}}}]); + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]); _ -> - join([{header, #{<<"functionExecutionStatus">> => #{<<"status">> => <<"Failed">>}}}]) + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]) end; %GSMA SGP.32, section 6.4.1.7 handle_json({<<"/gsma/rsp2/esipa/handleNotification">>, EsipaReq}) -> @@ -381,7 +490,17 @@ }} ]); _ -> - join([{header, #{<<"functionExecutionStatus">> => #{<<"status">> => <<"Failed">>}}}]) + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]) end; %GSMA SGP.32, section 6.4.1.8 handle_json({<<"/gsma/rsp2/esipa/cancelSession">>, EsipaReq}) -> @@ -406,9 +525,29 @@ }} ]); {cancelSessionResponseEsipa, {cancelSessionError, _CancelSessionError}} -> - join([{header, #{<<"functionExecutionStatus">> => #{<<"status">> => <<"Failed">>}}}]); + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]); _ -> - join([{header, #{<<"functionExecutionStatus">> => #{<<"status">> => <<"Failed">>}}}]) + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]) end; %Unsupported request handle_json(Request) -> -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I2d836f7f8d8ced10ba0e9880268079a27c804b04 Gerrit-Change-Number: 43819 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
1 0
0 0
[M] Change in onomondo-eim[master]: esipa_json_handler: return subjectCode and reasonCode on error
by dexter 03 Nov '26

03 Nov '26
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43819?usp=email ) Change subject: esipa_json_handler: return subjectCode and reasonCode on error ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I2d836f7f8d8ced10ba0e9880268079a27c804b04 Gerrit-Change-Number: 43819 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 03 Nov 2026 12:40:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in libosmo-gprs[master]: gprs_sndcp_xid: double check buffer size after writing SAPIs
by dexter 03 Nov '26

03 Nov '26
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/44023?usp=email ) Change subject: gprs_sndcp_xid: double check buffer size after writing SAPIs ...................................................................... gprs_sndcp_xid: double check buffer size after writing SAPIs The function encode_pcomp_applicable_sapis writes the applicable SAPIs to the output buffer. For this it requires 2 bytes. After that, each encoder function writes the remaining information to the buffer. The check at the beginning of each encoder function is sufficient to ensure that the buffer is large enough. However, this remains only true in case the number of bytes that encode_pcomp_applicable_sapis writes is 2. If there are changes to the spec or similar, the function might write more than 2 bytes. So let's place an additional length check to be on the secure side. This patch has been ported from: osmo-sgsn.git I059c903885e21215ad1e6b835f34db2c5f70d87a Related: OS#7095 Change-Id: Iff1dd10644e37e344ca822a91d156e50288fcb30 --- M src/sndcp/sndcp_xid.c 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/23/44023/1 diff --git a/src/sndcp/sndcp_xid.c b/src/sndcp/sndcp_xid.c index bd6bcc2..785f4fb 100644 --- a/src/sndcp/sndcp_xid.c +++ b/src/sndcp/sndcp_xid.c @@ -112,6 +112,10 @@ dst += rc; dst_counter += rc; + /* We still need to write 1 byte from here */ + if (dst_maxlen < dst_counter + 1) + return -ENOMEM; + /* Encode s01 (see also: 3GPP TS 44.065, 6.5.2.1, Table 5) */ if (params->s01 < 0 || params->s01 > 255) return -EINVAL; @@ -150,6 +154,10 @@ dst += rc; dst_counter += rc; + /* We still need to write 7 bytes from here */ + if (dst_maxlen < dst_counter + 7) + return -ENOMEM; + /* Encode F_MAX_PERIOD (see also: 3GPP TS 44.065, 6.5.3.1, Table 6) */ if (params->f_max_period < 1 || params->f_max_period > 65535) return -EINVAL; @@ -229,6 +237,10 @@ dst += rc; dst_counter += rc; + /* We still need to write 36 bytes from here */ + if (dst_maxlen < dst_counter + 36) + return -ENOMEM; + /* Encode MAX_CID (see also: 3GPP TS 44.065, 6.5.4.1, Table 10) */ if (params->max_cid < 0 || params->max_cid > 16383) return -EINVAL; @@ -285,6 +297,10 @@ dst += rc; dst_counter += rc; + /* We still need to write 4 bytes from here */ + if (dst_maxlen < dst_counter + 4) + return -ENOMEM; + /* Encode P0 (see also: 3GPP TS 44.065, 6.6.2.1, Table 7a) */ if (params->p0 < 0 || params->p0 > 3) return -EINVAL; @@ -337,6 +353,10 @@ dst += rc; dst_counter += rc; + /* We still need to write 10 bytes from here */ + if (dst_maxlen < dst_counter + 10) + return -ENOMEM; + /* Encode C0 (see also: 3GPP TS 44.065, 6.6.3.1, Table 7c) */ if (params->c0 != 0x80 && params->c0 != 0xC0) return -EINVAL; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/44023?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iff1dd10644e37e344ca822a91d156e50288fcb30 Gerrit-Change-Number: 44023 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
1 0
0 0
[M] Change in pysim[master]: esim.saip: keep keyAccess and keyCounterValue of security domain keys
by dexter 03 Nov '26

03 Nov '26
Attention is currently required from: hampushellsberg, laforge, lynxis lazus. dexter has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44011?usp=email ) Change subject: esim.saip: keep keyAccess and keyCounterValue of security domain keys ...................................................................... Patch Set 3: Code-Review+1 (3 comments) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/44011/comment/c3aca42b_43ac8c02?usp=em… : PS2, Line 1176: return 3 # SCP03 > I would be very careful with those KVN Value mapping. […] (see comments in #88) https://gerrit.osmocom.org/c/pysim/+/44011/comment/bbd0fa19_3cf7b646?usp=em… : PS2, Line 1178: 'is unknown' % kvn) > (you do not have to break the string. […] (don't worry about it). File tests/unittests/test_esim_saip.py: https://gerrit.osmocom.org/c/pysim/+/44011/comment/5a02cb9a_6f402505?usp=em… : PS2, Line 88: self.assertEqual(counter(0xff), '0001') # SCP02 > I think we should merge this as-is and wait if/until any actual problem shows up in the future. I think problems are very unlikely (but not impossible). Ok, then. Let's merge it as its. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7df8ef6f2c81cd8544a04dbf7ff5d096685103e3 Gerrit-Change-Number: 44011 Gerrit-PatchSet: 3 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 03 Nov 2026 10:40:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: hampushellsberg <hampushellsberg(a)gmail.com> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
1 0
0 0
[S] Change in pysim[master]: esim.saip: fix decoding of rfu PEs with an empty body
by dexter 03 Nov '26

03 Nov '26
Attention is currently required from: hampushellsberg, jolly, laforge. dexter has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44012?usp=email ) Change subject: esim.saip: fix decoding of rfu PEs with an empty body ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Looks plausible to me. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44012?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic47f74e8c111643c4ba435a9bac6aa9838bd3584 Gerrit-Change-Number: 44012 Gerrit-PatchSet: 2 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 03 Nov 2026 10:32:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in pysim[master]: esim.saip: keep keyAccess and keyCounterValue of security domain keys
by hampushellsberg 03 Nov '26

03 Nov '26
Attention is currently required from: dexter, hampushellsberg, laforge, lynxis lazus. Hello Jenkins Builder, dexter, laforge, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/44011?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by dexter, Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: esim.saip: keep keyAccess and keyCounterValue of security domain keys ...................................................................... esim.saip: keep keyAccess and keyCounterValue of security domain keys SecurityDomainKey only stored the usage qualifier, KID, KVN and key components, and ProfileElementSD._pre_encode() rebuilds keyList from it, so a non-default keyAccess and any keyCounterValue were lost on re-encode. Store both. keyAccess is only written if it is not '00'. The counter is an integer, encoded with the length of the protocol the KVN is reserved for (SAIP section 8.6.3: 2, 3 and 5 bytes for SCP02, SCP03 and SCP80, on the KVN ranges listed in global_platform/uicc.py), also when it was decoded with another length. A counter on any other KVN raises ValueError. The folder osmocom-pysim-saip-sd-key-access-counter of hampushellsberg-dev/PySIM-upstream-patches on GitHub has the analysis and a repro. Change-Id: I7df8ef6f2c81cd8544a04dbf7ff5d096685103e3 --- M pySim/esim/saip/__init__.py M tests/unittests/test_esim_saip.py 2 files changed, 70 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/11/44011/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7df8ef6f2c81cd8544a04dbf7ff5d096685103e3 Gerrit-Change-Number: 44011 Gerrit-PatchSet: 3 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: ggsn: Accept deletePDPContextRequest for dangling contexts from ggsn
by daniel 03 Nov '26

03 Nov '26
Attention is currently required from: pespin. daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44022?usp=email ) Change subject: ggsn: Accept deletePDPContextRequest for dangling contexts from ggsn ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Shouldn't we focus on fixing *_clients_interact instead then? From reading the related commit that changed the interact test it sounds to me that having those fail was/is acceptable: ``` commit d88ca3bd5384a4f70c498c30399253ee24583db1 Author: Pau Espin Pedrol <pespin(a)sysmocom.de> Date: Wed Mar 4 12:57:04 2026 +0100 ggsn: TC_pdp(4)6_clients_interact: Expect UEs can interact using global IPv6 address The link-local IPv6 address is only meant to be used privately between the UE and the GGSN, but the UEs should be in general able to reach each other using their global IPv6 address (unless some operator policy explicitly forbids it). Since open5gs.git 6cc627c4855703a17c92352660078325c6ce63cc, open5gs-upfd supports proper routing of IPv6 packets between UEs. osmo-ggsn apparently doesn't implement that internal routing logic yet, so these tests will start failing now, but it's actually legit to have it not passing the test anymore. Related: OS#6967 Change-Id: I0267a9c3bb85736a2aeb4f7dd91f44dbce626958 ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1116c8e7a9640003458f837fe8f948cfe55fd6c9 Gerrit-Change-Number: 44022 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Nov 2026 10:09:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in pysim[master]: esim.saip: split a fillFileOffset beyond the range of UInt16
by dexter 03 Nov '26

03 Nov '26
Attention is currently required from: hampushellsberg, jolly. dexter has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44010?usp=email ) Change subject: esim.saip: split a fillFileOffset beyond the range of UInt16 ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: I wonder if this has any practical use, even the spec says: "NOTE: Not all sequences allowed by this diagram are useful (e.g. several sequential "fillFileOffset"). However, the processing defined above simplifies the rules to be followed and the implementation on the eUICC." But its specified that way, so I see no problem with merging this patch. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44010?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iddd98b7f54abaebfdbf6682a8635339d13cf56e3 Gerrit-Change-Number: 44010 Gerrit-PatchSet: 2 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 03 Nov 2026 10:06:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 63
  • 64
  • 65
  • 66
  • 67
  • 68
  • 69
  • ...
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.