lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[M] Change in osmo-msc[master]: add configurable DTMF support via RTP or SIP
by pespin 04 Nov '26

04 Nov '26
Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/44024?usp=email ) Change subject: add configurable DTMF support via RTP or SIP ...................................................................... Patch Set 1: (7 comments) File include/osmocom/msc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/a397a721_49603870?usp… : PS1, Line 149: DTMF_MODE_SIP = 0, /* forward via MNCC to SIP connector (default) */ this should probably be called MNCC, not SIP specifically. https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/61a09959_4d29f179?usp… : PS1, Line 150: DTMF_MODE_RTP, /* RFC 4733 telephone-event via MGCP RQNT */ this naming is also quite generic. maybe DTMF_MODE_RFC4733_TELEPHONE_EVENT, or MGCP_RQNT File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/b1f777c4_4a8a80de?usp… : PS1, Line 1811: struct msc_a *msc_a = trans->msc_a; OSMO_ASSERT(trans) https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/914225cd_44f4f823?usp… : PS1, Line 1819: cl = msc_a->cc.call_leg; OSMO_ASSET(cl) https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/54c916d3_eec9eb69?usp… : PS1, Line 1824: ep_name = osmo_mgcpc_ep_name(cl->mgw_endpoint); check for !ep_name below looks weird. maybe OSMO_ASSERT() https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/2ce13296_a5c684b1?usp… : PS1, Line 1862: /* SIP mode: forward to MNCC handler, let it ACK/REJ */ Probably if() return on this code path with early return would be cleaner. https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/1814d43f_532cb3c3?usp… : PS1, Line 1923: return mncc_recvmsg(trans->net, trans, MNCC_STOP_DTMF_IND, &dtmf); Probably if() return on this code path with early return would be cleaner. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/44024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icd33a0b412f39a56046e57038551332776be2ba1 Gerrit-Change-Number: 44024 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 04 Nov 2026 09:21:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[XS] Change in libosmo-netif[master]: twrtp: fix generation of loss info word in RTCP RR blocks
by pespin 04 Nov '26

04 Nov '26
Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/44027?usp=email ) Change subject: twrtp: fix generation of loss info word in RTCP RR blocks ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/44027?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib34239a4f4619fef097b4c1fb5fc3abed339850d Gerrit-Change-Number: 44027 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Wed, 04 Nov 2026 09:08:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in libosmo-netif[master]: twrtp: fix generation of loss info word in RTCP RR blocks
by falconia 03 Nov '26

03 Nov '26
falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/44027?usp=email ) Change subject: twrtp: fix generation of loss info word in RTCP RR blocks ...................................................................... twrtp: fix generation of loss info word in RTCP RR blocks We generate RTCP SR and RR packets that include reception report blocks describing what our twjit received - see RFC 3550 section 6.4.1. These RR blocks include a 32-bit word that reports our receiver's detection of packet loss in the incoming RTP stream; this word consists of an 8-bit "fraction lost" field and a 24-bit "cumulative number of packets lost" field. Our previous code computed each of these separate fields correctly, but the final step of combining them into the 32-bit word applied the wrong shift, producing garbage as a result. Fix it. Change-Id: Ib34239a4f4619fef097b4c1fb5fc3abed339850d --- M src/twrtp.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/27/44027/1 diff --git a/src/twrtp.c b/src/twrtp.c index 1a1b7be..4d81510 100644 --- a/src/twrtp.c +++ b/src/twrtp.c @@ -851,7 +851,7 @@ lost_fract = 0; else lost_fract = (newly_lost << 8) / delta_expect; - lost_word = (lost_fract << 8) | (cumulative_lost & 0xFFFFFF); + lost_word = (lost_fract << 24) | (cumulative_lost & 0xFFFFFF); rr->ssrc = htonl(rri->ssrc); rr->lost_word = htonl(lost_word); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/44027?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib34239a4f4619fef097b4c1fb5fc3abed339850d Gerrit-Change-Number: 44027 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>
1 0
0 0
[S] Change in libosmo-gprs[master]: gprs_sndcp_xid: double check buffer size after writing SAPIs
by pespin 03 Nov '26

03 Nov '26
Attention is currently required from: dexter, laforge, osmith. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/44023?usp=email ) Change subject: gprs_sndcp_xid: double check buffer size after writing SAPIs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/44023?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iff1dd10644e37e344ca822a91d156e50288fcb30 Gerrit-Change-Number: 44023 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Nov 2026 14:12:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in osmo-mgw[master]: mgcp_client: add RQNT verb and telephone-event codec support
by lynxis lazus 03 Nov '26

03 Nov '26
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/44025?usp=email ) Change subject: mgcp_client: add RQNT verb and telephone-event codec support ...................................................................... mgcp_client: add RQNT verb and telephone-event codec support Add MGCP_VERB_RQNT to enum mgcp_verb for sending Request Notification messages, and CODEC_TELEPHONE_EVT_8000 to enum mgcp_codecs for RFC 4733 telephone-event. Add mgcp_client_tx_rqnt() as a public API for sending RQNT messages with signal (S:) and connection ID (I:) parameters, used by osmo-msc to request DTMF tone generation on the MGW. Extend mgcp_msg_gen() to handle the RQNT verb and a new signal field in struct mgcp_msg. Change-Id: I784d105b03b0ff10fe42ceb8e3a19c74ce58cac8 --- M include/osmocom/mgcp_client/mgcp_client.h M include/osmocom/mgcp_client/mgcp_client_internal.h M src/libosmo-mgcp-client/mgcp_client.c M src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c 4 files changed, 55 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/25/44025/1 diff --git a/include/osmocom/mgcp_client/mgcp_client.h b/include/osmocom/mgcp_client/mgcp_client.h index 16b9c6f..6a077b1 100644 --- a/include/osmocom/mgcp_client/mgcp_client.h +++ b/include/osmocom/mgcp_client/mgcp_client.h @@ -59,6 +59,7 @@ CODEC_IUFP = 96, CODEC_CLEARMODE = 120, /* 3GPP TS 48.103 table 5.4.2.2.1 */ CODEC_COMPR_CSD = 127, /* compressed CSD per TW-TS-007 */ + CODEC_TELEPHONE_EVT_8000 = 101, /* RFC 4733 telephone-event */ }; /* Note: when new codec types are added, the corresponding value strings * in mgcp_client.c (codec_table) must be updated as well. Enumerations @@ -91,6 +92,7 @@ MGCP_VERB_DLCX, MGCP_VERB_AUEP, MGCP_VERB_RSIP, + MGCP_VERB_RQNT, }; struct mgcp_client_conf *mgcp_client_conf_alloc(void *ctx); @@ -130,3 +132,6 @@ unsigned int pt); const char *mgcp_client_name(const struct mgcp_client *mgcp); + +int mgcp_client_tx_rqnt(struct mgcp_client *mgcp, const char *epname, + const char *conn_id, const char *signal); diff --git a/include/osmocom/mgcp_client/mgcp_client_internal.h b/include/osmocom/mgcp_client/mgcp_client_internal.h index 5251bd0..3ff96a7 100644 --- a/include/osmocom/mgcp_client/mgcp_client_internal.h +++ b/include/osmocom/mgcp_client/mgcp_client_internal.h @@ -73,6 +73,7 @@ #define MGCP_MSG_PRESENCE_X_SIDE 0x2000 #define MGCP_MSG_PRESENCE_X_OSMO_OSMUX_CID 0x4000 #define MGCP_MSG_PRESENCE_X_OSMO_IGN 0x8000 +#define MGCP_MSG_PRESENCE_SIGNAL 0x10000 struct mgcp_msg { enum mgcp_verb verb; @@ -93,6 +94,7 @@ char x_side[MGCP_SIDE_ID_MAXLEN]; bool param_present; struct mgcp_codec_param param; + char signal[32]; }; int mgcp_response_parse_params(struct mgcp_response *r); diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index 162bebd..4ae1c7b 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -62,6 +62,7 @@ { CODEC_IUFP, "VND.3GPP.IUFP/16000" }, { CODEC_CLEARMODE, "CLEARMODE/8000" }, { CODEC_COMPR_CSD, "VND.THEMWI.CCSD/8000" }, + { CODEC_TELEPHONE_EVT_8000, "telephone-event/8000" }, { 0, NULL }, }; @@ -1288,6 +1289,7 @@ #define MGCP_DLCX_MANDATORY (MGCP_MSG_PRESENCE_ENDPOINT) #define MGCP_AUEP_MANDATORY (MGCP_MSG_PRESENCE_ENDPOINT) #define MGCP_RSIP_MANDATORY 0 /* none */ +#define MGCP_RQNT_MANDATORY (MGCP_MSG_PRESENCE_ENDPOINT) /* Helper function for mgcp_msg_gen(): Add LCO information to MGCP message */ static int add_lco(struct msgb *msg, struct mgcp_msg *mgcp_msg) @@ -1545,6 +1547,10 @@ mandatory_mask = MGCP_RSIP_MANDATORY; MSGB_PRINTF_OR_RET("RSIP %u", trans_id); break; + case MGCP_VERB_RQNT: + mandatory_mask = MGCP_RQNT_MANDATORY; + MSGB_PRINTF_OR_RET("RQNT %u", trans_id); + break; default: LOGPMGW(mgcp, LOGL_ERROR, "Invalid command verb, can not generate MGCP message\n"); goto exit_error; @@ -1638,6 +1644,10 @@ } + /* Add signal line for RQNT */ + if (mgcp_msg->presence & MGCP_MSG_PRESENCE_SIGNAL) + MSGB_PRINTF_OR_RET("S: %s\r\n", mgcp_msg->signal); + /* Add session description protocol (SDP) */ if (use_sdp && (mgcp_msg->verb == MGCP_VERB_CRCX @@ -1720,3 +1730,40 @@ return rc; return strcmp(a->fmtp, b->fmtp); } + +/*! Send an MGCP RQNT (Request Notification) message to the MGW. + * Used to request DTMF tone generation via RFC 4733 telephone-event. + * \param[in] mgcp MGCP client instance. + * \param[in] epname endpoint name (e.g. "rtpbridge/1@mgw"). + * \param[in] conn_id connection ID on which to inject the signal, or NULL. + * \param[in] signal signal line content (e.g. "D/5" for DTMF 5), or NULL to stop. + * \returns 0 on success, negative on error. */ +int mgcp_client_tx_rqnt(struct mgcp_client *mgcp, const char *epname, + const char *conn_id, const char *signal) +{ + struct mgcp_msg mgcp_msg; + struct msgb *msg; + + memset(&mgcp_msg, 0, sizeof(mgcp_msg)); + mgcp_msg.verb = MGCP_VERB_RQNT; + mgcp_msg.presence = MGCP_MSG_PRESENCE_ENDPOINT | MGCP_MSG_PRESENCE_SIGNAL; + OSMO_STRLCPY_ARRAY(mgcp_msg.endpoint, epname); + + if (conn_id) { + mgcp_msg.presence |= MGCP_MSG_PRESENCE_CONN_ID; + mgcp_msg.conn_id = (char *)conn_id; + } + + if (signal) + OSMO_STRLCPY_ARRAY(mgcp_msg.signal, signal); + /* else: empty signal string stops active tone */ + + msg = mgcp_msg_gen(mgcp, &mgcp_msg); + if (!msg) { + LOGPMGW(mgcp, LOGL_ERROR, + "Failed to generate MGCP RQNT for %s\n", epname); + return -EINVAL; + } + + return mgcp_client_tx(mgcp, msg, NULL, NULL); +} diff --git a/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c b/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c index f2ec7fd..0e30a00 100644 --- a/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c +++ b/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c @@ -136,6 +136,7 @@ { MGCP_VERB_DLCX, "DLCX" }, { MGCP_VERB_AUEP, "AUEP" }, { MGCP_VERB_RSIP, "RSIP" }, + { MGCP_VERB_RQNT, "RQNT" }, {} }; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/44025?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I784d105b03b0ff10fe42ceb8e3a19c74ce58cac8 Gerrit-Change-Number: 44025 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
1 0
0 0
[L] Change in osmo-mgw[master]: mgw: add RFC 4733 DTMF telephone-event generation via RQNT
by lynxis lazus 03 Nov '26

03 Nov '26
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/44026?usp=email ) Change subject: mgw: add RFC 4733 DTMF telephone-event generation via RQNT ...................................................................... mgw: add RFC 4733 DTMF telephone-event generation via RQNT Implement DTMF tone injection as RFC 4733 telephone-event RTP packets, triggered by MGCP RQNT commands with signal requests (S: D/<digit>). Add mgcp_dtmf.c with timer-based packet generation at 20ms intervals, proper marker bit, fixed timestamp per event, and 3x redundant end-of-event packets per RFC 4733 section 2.5. Enhance handle_noti_req() to parse the I: (connection ID) header so DTMF can be targeted at a specific connection. When telephone-event is not negotiated on the connection, the RQNT still succeeds (best-effort) to maintain backward compatibility with the legacy rqnt_cb path. Change-Id: I399600535aa709f7d404b1d3e07d889cf46d69d8 --- A include/osmocom/mgcp/mgcp_dtmf.h M include/osmocom/mgcp/mgcp_endp.h M src/libosmo-mgcp/Makefile.am A src/libosmo-mgcp/mgcp_dtmf.c M src/libosmo-mgcp/mgcp_protocol.c 5 files changed, 379 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/26/44026/1 diff --git a/include/osmocom/mgcp/mgcp_dtmf.h b/include/osmocom/mgcp/mgcp_dtmf.h new file mode 100644 index 0000000..7f12dce --- /dev/null +++ b/include/osmocom/mgcp/mgcp_dtmf.h @@ -0,0 +1,47 @@ +/* + * DTMF tone generation via RFC 4733 telephone-event RTP packets + * + * (C) 2026 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * All Rights Reserved + * + * SPDX-License-Identifier: AGPL-3.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + */ + +#pragma once + +#include <stdbool.h> +#include <stdint.h> +#include <osmocom/core/timer.h> + +struct mgcp_endpoint; +struct mgcp_conn; + +struct mgcp_dtmf_state { + bool active; + uint8_t event; /* RFC 4733 event code (0-15) */ + uint16_t duration; /* accumulated duration in timestamp units */ + uint32_t start_ts; /* RTP timestamp at event start */ + uint8_t payload_type; /* negotiated PT for telephone-event */ + bool first_pkt; /* marker bit on first packet */ + struct osmo_timer_list timer; + struct mgcp_conn *conn; /* dst connection (CN side) */ + struct mgcp_conn *src_conn; /* src connection (RAN side) */ + struct mgcp_endpoint *endp; +}; + +int mgcp_dtmf_start(struct mgcp_endpoint *endp, struct mgcp_conn *conn, + char digit); +void mgcp_dtmf_stop(struct mgcp_endpoint *endp); diff --git a/include/osmocom/mgcp/mgcp_endp.h b/include/osmocom/mgcp/mgcp_endp.h index 4c1fb20..2a804e5 100644 --- a/include/osmocom/mgcp/mgcp_endp.h +++ b/include/osmocom/mgcp/mgcp_endp.h @@ -26,6 +26,7 @@ #include <osmocom/core/msgb.h> #include <osmocom/gsm/i460_mux.h> #include <osmocom/mgcp/mgcp_protocol.h> +#include <osmocom/mgcp/mgcp_dtmf.h> struct sockaddr; struct mgcp_conn; @@ -117,6 +118,9 @@ /*! MGCP_X_OSMO_IGN_* flags from 'X-Osmo-IGN:' header */ uint32_t x_osmo_ign; + /* DTMF generation state (RFC 4733) */ + struct mgcp_dtmf_state dtmf; + /* E1 specific */ struct { struct osmo_i460_schan_desc scd; diff --git a/src/libosmo-mgcp/Makefile.am b/src/libosmo-mgcp/Makefile.am index e51da10..a0ae4b1 100644 --- a/src/libosmo-mgcp/Makefile.am +++ b/src/libosmo-mgcp/Makefile.am @@ -44,4 +44,5 @@ mgcp_rtp_end.c \ mgcp_e1.c \ mgcp_iuup.c \ + mgcp_dtmf.c \ $(NULL) diff --git a/src/libosmo-mgcp/mgcp_dtmf.c b/src/libosmo-mgcp/mgcp_dtmf.c new file mode 100644 index 0000000..e0e2d0e --- /dev/null +++ b/src/libosmo-mgcp/mgcp_dtmf.c @@ -0,0 +1,265 @@ +/* + * DTMF tone generation via RFC 4733 telephone-event RTP packets + * + * (C) 2026 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * All Rights Reserved + * + * SPDX-License-Identifier: AGPL-3.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + */ + +#include <string.h> +#include <arpa/inet.h> + +#include <osmocom/core/logging.h> +#include <osmocom/core/timer.h> +#include <osmocom/core/utils.h> + +#include <osmocom/mgcp/mgcp.h> +#include <osmocom/mgcp/mgcp_endp.h> +#include <osmocom/mgcp/mgcp_conn.h> +#include <osmocom/mgcp/mgcp_codec.h> +#include <osmocom/mgcp/mgcp_network.h> +#include <osmocom/mgcp/mgcp_dtmf.h> + +/* RFC 4733 telephone-event RTP payload (4 bytes) */ +struct rfc4733_payload { + uint8_t event; +#if OSMO_IS_BIG_ENDIAN + uint8_t e:1, r:1, volume:6; +#elif OSMO_IS_LITTLE_ENDIAN + uint8_t volume:6, r:1, e:1; +#endif + uint16_t duration; +} __attribute__((packed)); + +/* DTMF packet interval: 20ms (160 timestamp units at 8kHz) */ +#define DTMF_PKT_DURATION 160 +#define DTMF_PKT_INTERVAL_US 20000 +#define DTMF_VOLUME 10 /* -10 dBm0 */ +#define DTMF_END_REDUNDANCY 3 + +/* Map a DTMF digit character to RFC 4733 event code. + * Returns -1 if the digit is not a valid DTMF character. */ +static int digit_to_event(char digit) +{ + if (digit >= '0' && digit <= '9') + return digit - '0'; + if (digit == '*') + return 10; + if (digit == '#') + return 11; + if (digit >= 'A' && digit <= 'D') + return 12 + (digit - 'A'); + if (digit >= 'a' && digit <= 'd') + return 12 + (digit - 'a'); + return -1; +} + +/* Find the payload type for telephone-event in the connection's codec set. + * Returns the payload type, or -1 if telephone-event was not negotiated. */ +static int find_telephone_event_pt(struct mgcp_conn_rtp *conn_rtp) +{ + struct mgcp_rtp_codecset *cset = &conn_rtp->end.cset; + unsigned int i; + + for (i = 0; i < cset->codecs_assigned; i++) { + if (strcasecmp(cset->codecs[i].subtype_name, + "telephone-event") == 0) + return cset->codecs[i].payload_type; + } + return -1; +} + +/* Build and send a single RFC 4733 telephone-event RTP packet. + * + * DTMF packets share the same SSRC and sequence number space as the + * forwarded audio stream. The source (partner) connection's out_stream + * state is the authoritative counter for what the receiver sees, so we + * read SSRC from it and atomically claim the next sequence number. + * We also bump patch.seq_offset so that the next forwarded audio packet + * is numbered correctly after the DTMF packets. */ +static int dtmf_send_pkt(struct mgcp_dtmf_state *st, bool end_bit) +{ + struct mgcp_conn_rtp *conn_rtp; + struct mgcp_rtp_state *src_state; + uint8_t buf[16]; /* 12 byte RTP header + 4 byte payload */ + struct rfc4733_payload *pl; + uint32_t ssrc; + uint16_t seq; + + if (!st->conn) + return -1; + + conn_rtp = &st->conn->u.rtp; + + /* Get SSRC and next seq from the source connection's out_stream */ + if (st->src_conn && st->src_conn->type == MGCP_CONN_TYPE_RTP) { + src_state = &st->src_conn->u.rtp.state; + ssrc = src_state->out_stream.ssrc; + seq = src_state->out_stream.last_seq + 1; + /* Claim this seq: update out_stream and bump offset */ + src_state->out_stream.last_seq = seq; + src_state->patch.seq_offset++; + } else { + /* No partner connection — use alt counters */ + ssrc = conn_rtp->state.alt_rtp_tx_ssrc; + seq = conn_rtp->state.alt_rtp_tx_sequence++; + } + + /* RTP header */ + buf[0] = 0x80; /* version 2 */ + buf[1] = st->payload_type & 0x7f; + if (st->first_pkt) { + buf[1] |= 0x80; /* marker bit */ + st->first_pkt = false; + } + buf[2] = (seq >> 8) & 0xff; + buf[3] = seq & 0xff; + /* timestamp: fixed at start_ts for entire event (RFC 4733 sec. 2.5.1.2) */ + buf[4] = (st->start_ts >> 24) & 0xff; + buf[5] = (st->start_ts >> 16) & 0xff; + buf[6] = (st->start_ts >> 8) & 0xff; + buf[7] = st->start_ts & 0xff; + /* SSRC */ + buf[8] = (ssrc >> 24) & 0xff; + buf[9] = (ssrc >> 16) & 0xff; + buf[10] = (ssrc >> 8) & 0xff; + buf[11] = ssrc & 0xff; + + /* RFC 4733 payload */ + pl = (struct rfc4733_payload *)&buf[12]; + pl->event = st->event; + pl->e = end_bit ? 1 : 0; + pl->r = 0; + pl->volume = DTMF_VOLUME; + pl->duration = htons(st->duration); + + return mgcp_udp_send(conn_rtp->end.rtp, &conn_rtp->end.addr, + (const char *)buf, sizeof(buf)); +} + +/* Timer callback: send periodic DTMF telephone-event packets */ +static void dtmf_timer_cb(void *data) +{ + struct mgcp_endpoint *endp = data; + struct mgcp_dtmf_state *st = &endp->dtmf; + + if (!st->active) + return; + + dtmf_send_pkt(st, false); + st->duration += DTMF_PKT_DURATION; + + osmo_timer_schedule(&st->timer, 0, DTMF_PKT_INTERVAL_US); +} + +/*! Start generating RFC 4733 telephone-event RTP packets for a DTMF digit. + * \param[in] endp MGW endpoint. + * \param[in] conn connection on which to inject the DTMF event. + * \param[in] digit DTMF digit character ('0'-'9', '*', '#', 'A'-'D'). + * \returns 0 on success, negative on error. */ +int mgcp_dtmf_start(struct mgcp_endpoint *endp, struct mgcp_conn *conn, + char digit) +{ + struct mgcp_dtmf_state *st = &endp->dtmf; + struct mgcp_conn_rtp *conn_rtp; + int event, pt; + + event = digit_to_event(digit); + if (event < 0) { + LOGPENDP(endp, DLMGCP, LOGL_ERROR, + "DTMF: invalid digit '%c'\n", digit); + return -EINVAL; + } + + if (conn->type != MGCP_CONN_TYPE_RTP) { + LOGPENDP(endp, DLMGCP, LOGL_ERROR, + "DTMF: connection is not RTP\n"); + return -EINVAL; + } + conn_rtp = mgcp_conn_get_conn_rtp(conn); + + pt = find_telephone_event_pt(conn_rtp); + if (pt < 0) { + LOGPENDP(endp, DLMGCP, LOGL_ERROR, + "DTMF: telephone-event not negotiated on conn %s\n", + conn->id); + return -ENOTSUP; + } + + /* stop any active DTMF first */ + if (st->active) + mgcp_dtmf_stop(endp); + + st->active = true; + st->event = event; + st->duration = 0; + st->payload_type = pt; + st->conn = conn; + st->endp = endp; + st->first_pkt = true; + + /* Find the source (partner) connection whose out_stream state + * tracks the SSRC and sequence numbers the receiver sees. */ + st->src_conn = mgcp_find_dst_conn(conn); + if (st->src_conn && st->src_conn->type == MGCP_CONN_TYPE_RTP) { + struct mgcp_conn_rtp *src_rtp = &st->src_conn->u.rtp; + st->start_ts = src_rtp->state.out_stream.last_timestamp + + DTMF_PKT_DURATION; + } else { + st->start_ts = mgcp_get_current_ts(8000); + } + + LOGPENDP(endp, DLMGCP, LOGL_INFO, + "DTMF: start digit '%c' (event %d) on conn %s, PT %d\n", + digit, event, conn->id, pt); + + /* Send first packet immediately */ + dtmf_send_pkt(st, false); + st->duration += DTMF_PKT_DURATION; + + /* Schedule periodic 20ms timer */ + osmo_timer_setup(&st->timer, dtmf_timer_cb, endp); + osmo_timer_schedule(&st->timer, 0, DTMF_PKT_INTERVAL_US); + + return 0; +} + +/*! Stop generating DTMF telephone-event RTP packets. + * Sends 3 redundant end-of-event packets and cancels the timer. + * \param[in] endp MGW endpoint. */ +void mgcp_dtmf_stop(struct mgcp_endpoint *endp) +{ + struct mgcp_dtmf_state *st = &endp->dtmf; + int i; + + if (!st->active) + return; + + osmo_timer_del(&st->timer); + + LOGPENDP(endp, DLMGCP, LOGL_INFO, + "DTMF: stop event %d on conn %s, duration %u\n", + st->event, st->conn ? st->conn->id : "?", st->duration); + + /* Send 3 end-of-event packets (RFC 4733 sec. 2.5.1.4) */ + for (i = 0; i < DTMF_END_REDUNDANCY; i++) + dtmf_send_pkt(st, true); + + st->active = false; + st->conn = NULL; + st->src_conn = NULL; +} diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index e33ce35..3fdce1c 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -1181,19 +1181,22 @@ return str[2]; } -/* This can request like DTMF detection and forward, fax detection... it - * can also request when the notification should be send and such. We don't - * do this right now. */ +/* Handle RQNT (Request Notification) for DTMF tone generation. + * Parses S: (signal) and I: (connection ID) lines. When a DTMF signal + * is requested (S: D/<digit>), inject RFC 4733 telephone-event packets + * on the specified connection. An empty S: line stops any active DTMF. */ static struct msgb *handle_noti_req(struct mgcp_request_data *rq) { int res = 0; char *line; char tone = CHAR_MAX; + char conn_id[MGCP_CONN_ID_MAXLEN] = { 0 }; + bool have_signal_line = false; + struct mgcp_conn *conn; LOGP(DLMGCP, LOGL_NOTICE, "RQNT: processing request for notification ...\n"); if (rq->null_endp) { - /* trunk not available so rate_ctr aren't available either. */ LOGP(DLMGCP, LOGL_ERROR, "RQNT: Not allowed in 'null' endpoint!\n"); return create_err_response(rq->cfg, NULL, 502, "RQNT", rq->pdata->trans); } @@ -1201,20 +1204,70 @@ for_each_line(line, rq->pdata->save) { switch (toupper(line[0])) { case 'S': + have_signal_line = true; tone = extract_tone(line); break; + case 'I': + if (line[1] == ':') { + const char *val = line + 2; + while (*val == ' ') + val++; + osmo_strlcpy(conn_id, val, sizeof(conn_id)); + /* strip trailing whitespace */ + while (strlen(conn_id) > 0 && + conn_id[strlen(conn_id) - 1] <= ' ') + conn_id[strlen(conn_id) - 1] = '\0'; + } + break; } } - /* we didn't see a signal request with a tone */ - if (tone == CHAR_MAX) - return create_ok_response(rq->endp, rq->endp, 200, "RQNT", rq->pdata->trans); + /* Empty S: line (no D/ tone) means stop active DTMF */ + if (have_signal_line && tone == CHAR_MAX) { + mgcp_dtmf_stop(rq->endp); + return create_ok_response(rq->endp, rq->endp, 200, "RQNT", + rq->pdata->trans); + } + /* No signal line at all — nothing to do */ + if (!have_signal_line) + return create_ok_response(rq->endp, rq->endp, 200, "RQNT", + rq->pdata->trans); + + /* Look up connection by ID if specified */ + if (conn_id[0]) { + conn = mgcp_endp_get_conn(rq->endp, conn_id); + if (!conn) { + LOGPENDP(rq->endp, DLMGCP, LOGL_ERROR, + "RQNT: unknown connection ID '%s'\n", conn_id); + return create_err_response(rq->endp, rq->endp, 515, + "RQNT", rq->pdata->trans); + } + } else { + /* No I: header — use first connection on the endpoint */ + conn = llist_first_entry_or_null(&rq->endp->conns, + struct mgcp_conn, entry); + if (!conn) { + LOGPENDP(rq->endp, DLMGCP, LOGL_ERROR, + "RQNT: no connections on endpoint\n"); + return create_err_response(rq->endp, rq->endp, 515, + "RQNT", rq->pdata->trans); + } + } + + /* Try RFC 4733 DTMF injection (best-effort, may fail if + * telephone-event was not negotiated on this connection) */ + mgcp_dtmf_start(rq->endp, conn, tone); + + /* Also call legacy callback if configured */ if (rq->cfg->rqnt_cb) res = rq->cfg->rqnt_cb(rq->endp, tone); - return res == 0 ? create_ok_response(rq->endp, rq->endp, 200, "RQNT", rq->pdata->trans) : - create_err_response(rq->endp, rq->endp, res, "RQNT", rq->pdata->trans); + return res == 0 ? + create_ok_response(rq->endp, rq->endp, 200, "RQNT", + rq->pdata->trans) : + create_err_response(rq->endp, rq->endp, 538, "RQNT", + rq->pdata->trans); } /* Connection keepalive timer, will take care that dummy packets are send -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/44026?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I399600535aa709f7d404b1d3e07d889cf46d69d8 Gerrit-Change-Number: 44026 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
1 0
0 0
[M] Change in osmo-msc[master]: add configurable DTMF support via RTP or SIP
by lynxis lazus 03 Nov '26

03 Nov '26
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/44024?usp=email ) Change subject: add configurable DTMF support via RTP or SIP ...................................................................... add configurable DTMF support via RTP or SIP Add VTY option 'dtmf (rtp|sip)' under the 'msc' node to select the DTMF transport method. Default is 'sip', which forwards DTMF via MNCC to the external handler (e.g., osmo-sip-connector for SIP INFO). When set to 'rtp', the CC layer sends MGCP RQNT to the MGW to inject RFC 4733 telephone-event packets into the CN-side RTP stream, and includes telephone-event in the SDP codec negotiation. Add telephone-event/8000 to codec_mapping for SDP/MGCP interworking. Update test expected output for the default SIP mode. Change-Id: Icd33a0b412f39a56046e57038551332776be2ba1 --- M include/osmocom/msc/gsm_data.h M src/libmsc/codec_mapping.c M src/libmsc/gsm_04_08_cc.c M src/libmsc/msc_vty.c M src/libmsc/transaction_cc.c 5 files changed, 87 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/24/44024/1 diff --git a/include/osmocom/msc/gsm_data.h b/include/osmocom/msc/gsm_data.h index 80a7854..0ede628 100644 --- a/include/osmocom/msc/gsm_data.h +++ b/include/osmocom/msc/gsm_data.h @@ -145,6 +145,11 @@ int dst; /* daylight savings */ }; +enum dtmf_mode { + DTMF_MODE_SIP = 0, /* forward via MNCC to SIP connector (default) */ + DTMF_MODE_RTP, /* RFC 4733 telephone-event via MGCP RQNT */ +}; + struct gsm_network { /* TODO MSCSPLIT the gsm_network struct is basically a kitchen sink for * global settings and variables, "madly" mixing BSC and MSC stuff. Split @@ -283,6 +288,9 @@ */ uint8_t tw_rtp_formats; + /* DTMF transport method */ + enum dtmf_mode dtmf_mode; + /* Whether to use call waiting on the network */ bool call_waiting; diff --git a/src/libmsc/codec_mapping.c b/src/libmsc/codec_mapping.c index f3a707b..7c25645 100644 --- a/src/libmsc/codec_mapping.c +++ b/src/libmsc/codec_mapping.c @@ -218,6 +218,15 @@ }, .mgcp = CODEC_CLEARMODE, }, + { + .sdp = { + .payload_type = 101, + .subtype_name = "telephone-event", + .rate = 8000, + .fmtp = "0-15", + }, + .mgcp = CODEC_TELEPHONE_EVT_8000, + }, }; #define foreach_codec_mapping(CODEC_MAPPING) \ diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c index 11bebb0..41e33d1 100644 --- a/src/libmsc/gsm_04_08_cc.c +++ b/src/libmsc/gsm_04_08_cc.c @@ -1804,12 +1804,38 @@ return trans_tx_gsm48(trans, msg); } +/* Send MGCP RQNT to MGW to inject/stop DTMF telephone-event on CN-side RTP. + * signal: e.g. "D/5" to start, or NULL to stop. */ +static void dtmf_send_mgcp_rqnt(struct gsm_trans *trans, const char *signal) +{ + struct msc_a *msc_a = trans->msc_a; + struct call_leg *cl; + const char *conn_id, *ep_name; + struct mgcp_client *mgcp; + + if (!msc_a || !msc_a->cc.call_leg) + return; + + cl = msc_a->cc.call_leg; + if (!cl->rtp[RTP_TO_CN] || !cl->rtp[RTP_TO_CN]->ci) + return; + + conn_id = osmo_mgcpc_ep_ci_id(cl->rtp[RTP_TO_CN]->ci); + ep_name = osmo_mgcpc_ep_name(cl->mgw_endpoint); + mgcp = osmo_mgcpc_ep_client(cl->mgw_endpoint); + if (!conn_id || !ep_name || !mgcp) + return; + + mgcp_client_tx_rqnt(mgcp, ep_name, conn_id, signal); +} + static int gsm48_cc_rx_start_dtmf(struct gsm_trans *trans, struct msgb *msg) { struct gsm48_hdr *gh = msgb_l3(msg); unsigned int payload_len = msgb_l3len(msg) - sizeof(*gh); struct tlv_parsed tp; struct gsm_mncc dtmf; + char signal[8]; memset(&dtmf, 0, sizeof(struct gsm_mncc)); dtmf.callref = trans->callref; @@ -1821,6 +1847,19 @@ TLVP_VAL(&tp, GSM48_IE_KPD_FACILITY)-1); } + if (trans->net->dtmf_mode == DTMF_MODE_RTP) { + /* RTP mode: inject telephone-event via MGW */ + if (dtmf.fields & MNCC_F_KEYPAD) { + snprintf(signal, sizeof(signal), "D/%c", + (char)dtmf.keypad); + dtmf_send_mgcp_rqnt(trans, signal); + } + /* ACK to MS immediately */ + dtmf.msg_type = MNCC_START_DTMF_RSP; + return mncc_tx_to_cc(trans->net, &dtmf); + } + + /* SIP mode: forward to MNCC handler, let it ACK/REJ */ return mncc_recvmsg(trans->net, trans, MNCC_START_DTMF_IND, &dtmf); } @@ -1873,6 +1912,14 @@ memset(&dtmf, 0, sizeof(struct gsm_mncc)); dtmf.callref = trans->callref; + if (trans->net->dtmf_mode == DTMF_MODE_RTP) { + /* RTP mode: stop telephone-event via MGW */ + dtmf_send_mgcp_rqnt(trans, NULL); + dtmf.msg_type = MNCC_STOP_DTMF_RSP; + return mncc_tx_to_cc(trans->net, &dtmf); + } + + /* SIP mode: forward to MNCC handler */ return mncc_recvmsg(trans->net, trans, MNCC_STOP_DTMF_IND, &dtmf); } diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c index a5de12f..c4f0f2c 100644 --- a/src/libmsc/msc_vty.c +++ b/src/libmsc/msc_vty.c @@ -687,6 +687,19 @@ return CMD_SUCCESS; } +DEFUN(cfg_msc_dtmf, cfg_msc_dtmf_cmd, + "dtmf (rtp|sip)", + "DTMF transport method\n" + "DTMF via RTP telephone-event (RFC 4733)\n" + "DTMF via MNCC/SIP signaling\n") +{ + if (strcmp(argv[0], "rtp") == 0) + gsmnet->dtmf_mode = DTMF_MODE_RTP; + else if (strcmp(argv[0], "sip") == 0) + gsmnet->dtmf_mode = DTMF_MODE_SIP; + return CMD_SUCCESS; +} + #define TWFORMAT_STR "Use ThemWi RTP formats\n" #define TWCODEC_MULT "(fr|hr|amr|csd)" #define TWCODEC_OPT " [" TWCODEC_MULT "]" @@ -845,6 +858,9 @@ gsmnet->handover_number.range_start, gsmnet->handover_number.range_end, VTY_NEWLINE); + if (gsmnet->dtmf_mode != DTMF_MODE_SIP) + vty_out(vty, " dtmf rtp%s", VTY_NEWLINE); + if (gsmnet->use_osmux != OSMUX_USAGE_OFF) { vty_out(vty, " osmux %s%s", gsmnet->use_osmux == OSMUX_USAGE_ON ? "on" : "only", VTY_NEWLINE); @@ -2160,6 +2176,7 @@ install_element(MSC_NODE, &cfg_msc_emergency_msisdn_cmd); install_element(MSC_NODE, &cfg_msc_sms_over_gsup_cmd); install_element(MSC_NODE, &cfg_msc_no_sms_over_gsup_cmd); + install_element(MSC_NODE, &cfg_msc_dtmf_cmd); install_element(MSC_NODE, &cfg_msc_osmux_cmd); install_element(MSC_NODE, &cfg_msc_twformat_cmd); install_element(MSC_NODE, &cfg_msc_no_twformat_cmd); diff --git a/src/libmsc/transaction_cc.c b/src/libmsc/transaction_cc.c index 2a540bf..44252c2 100644 --- a/src/libmsc/transaction_cc.c +++ b/src/libmsc/transaction_cc.c @@ -25,6 +25,7 @@ #include <osmocom/msc/transaction_cc.h> #include <osmocom/msc/codec_filter.h> #include <osmocom/msc/csd_filter.h> +#include <osmocom/msc/sdp_msg.h> void trans_cc_filter_init(struct gsm_trans *trans) { @@ -51,6 +52,11 @@ switch (trans->bearer_cap.transfer) { case GSM48_BCAP_ITCAP_SPEECH: codec_filter_run(&trans->cc.codecs, &trans->cc.local, &trans->cc.remote); + /* Offer telephone-event for DTMF when using RTP mode */ + if (trans->net->dtmf_mode == DTMF_MODE_RTP) + sdp_audio_codecs_add(&trans->cc.local.audio_codecs, + 101, "telephone-event", 8000, + "0-15"); LOG_TRANS_CAT_SRC(trans, DCC, LOGL_DEBUG, file, line, "codecs: %s\n", codec_filter_to_str(&trans->cc.codecs, &trans->cc.local, &trans->cc.remote)); break; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/44024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icd33a0b412f39a56046e57038551332776be2ba1 Gerrit-Change-Number: 44024 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
1 0
0 0
[S] Change in pysim[master]: esim.saip: split a fillFileOffset beyond the range of UInt16
by dexter 03 Nov '26

03 Nov '26
Attention is currently required from: hampushellsberg, jolly. dexter has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44010?usp=email ) Change subject: esim.saip: split a fillFileOffset beyond the range of UInt16 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44010?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iddd98b7f54abaebfdbf6682a8635339d13cf56e3 Gerrit-Change-Number: 44010 Gerrit-PatchSet: 2 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 03 Nov 2026 13:27:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in pysim[master]: esim.saip: fix decoding of rfu PEs with an empty body
by dexter 03 Nov '26

03 Nov '26
Attention is currently required from: hampushellsberg, jolly, laforge. dexter has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44012?usp=email ) Change subject: esim.saip: fix decoding of rfu PEs with an empty body ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44012?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic47f74e8c111643c4ba435a9bac6aa9838bd3584 Gerrit-Change-Number: 44012 Gerrit-PatchSet: 2 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 03 Nov 2026 13:26:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in pysim[master]: esim.saip: derive nb_rec from efFileSize when the descriptor omits it
by dexter 03 Nov '26

03 Nov '26
Attention is currently required from: hampushellsberg, laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43984?usp=email ) Change subject: esim.saip: derive nb_rec from efFileSize when the descriptor omits it ...................................................................... Patch Set 4: Code-Review+2 (2 comments) Patchset: PS4: I think its clear to me now, let's merge the patch as it is. File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/43984/comment/ac50893c_1257358d?usp=em… : PS3, Line 369: if self.rec_len and not fd_dec['num_of_rec']: > The difference is a file that comes from a template: File. […] Thanks for clarifying. I didn't know that self.nb_rec might have a value. I thought that we would always have a freshly initialized class. ALso if I view it from another angle: This method is called from_fileDescriptor, so why not take directly from fd_dec (which is derived from the fileDescriptor parameter)? (You might consider to add a comment with a follow-up patch to the section where we initialize those properties.) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I191b234446c278a5252a903d170c3336d9e0c1ba Gerrit-Change-Number: 43984 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 03 Nov 2026 13:19:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: hampushellsberg <hampushellsberg(a)gmail.com> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 62
  • 63
  • 64
  • 65
  • 66
  • 67
  • 68
  • ...
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.