[M] Change in osmo-msc[master]: add configurable DTMF support via RTP or SIP
Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/44024?usp=email ) Change subject: add configurable DTMF support via RTP or SIP ...................................................................... Patch Set 1: (7 comments) File include/osmocom/msc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/a397a721_49603870?usp=... : PS1, Line 149: DTMF_MODE_SIP = 0, /* forward via MNCC to SIP connector (default) */ this should probably be called MNCC, not SIP specifically. https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/61a09959_4d29f179?usp=... : PS1, Line 150: DTMF_MODE_RTP, /* RFC 4733 telephone-event via MGCP RQNT */ this naming is also quite generic. maybe DTMF_MODE_RFC4733_TELEPHONE_EVENT, or MGCP_RQNT File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/b1f777c4_4a8a80de?usp=... : PS1, Line 1811: struct msc_a *msc_a = trans->msc_a; OSMO_ASSERT(trans) https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/914225cd_44f4f823?usp=... : PS1, Line 1819: cl = msc_a->cc.call_leg; OSMO_ASSET(cl) https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/54c916d3_eec9eb69?usp=... : PS1, Line 1824: ep_name = osmo_mgcpc_ep_name(cl->mgw_endpoint); check for !ep_name below looks weird. maybe OSMO_ASSERT() https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/2ce13296_a5c684b1?usp=... : PS1, Line 1862: /* SIP mode: forward to MNCC handler, let it ACK/REJ */ Probably if() return on this code path with early return would be cleaner. https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/1814d43f_532cb3c3?usp=... : PS1, Line 1923: return mncc_recvmsg(trans->net, trans, MNCC_STOP_DTMF_IND, &dtmf); Probably if() return on this code path with early return would be cleaner. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/44024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icd33a0b412f39a56046e57038551332776be2ba1 Gerrit-Change-Number: 44024 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Wed, 04 Nov 2026 09:21:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
participants (1)
-
pespin