Attention is currently required from: lynxis lazus.
7 comments:
File include/osmocom/msc/gsm_data.h:
Patch Set #1, Line 149: DTMF_MODE_SIP = 0, /* forward via MNCC to SIP connector (default) */
this should probably be called MNCC, not SIP specifically.
Patch Set #1, Line 150: DTMF_MODE_RTP, /* RFC 4733 telephone-event via MGCP RQNT */
this naming is also quite generic. maybe DTMF_MODE_RFC4733_TELEPHONE_EVENT, or MGCP_RQNT
File src/libmsc/gsm_04_08_cc.c:
Patch Set #1, Line 1811: struct msc_a *msc_a = trans->msc_a;
OSMO_ASSERT(trans)
Patch Set #1, Line 1819: cl = msc_a->cc.call_leg;
OSMO_ASSET(cl)
Patch Set #1, Line 1824: ep_name = osmo_mgcpc_ep_name(cl->mgw_endpoint);
check for !ep_name below looks weird. maybe OSMO_ASSERT()
Patch Set #1, Line 1862: /* SIP mode: forward to MNCC handler, let it ACK/REJ */
Probably if() return on this code path with early return would be cleaner.
Patch Set #1, Line 1923: return mncc_recvmsg(trans->net, trans, MNCC_STOP_DTMF_IND, &dtmf);
Probably if() return on this code path with early return would be cleaner.
To view, visit change 44024. To unsubscribe, or for help writing mail filters, visit settings.