lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[S] Change in libosmo-gprs[master]: gprs_sndcp_xid: double check buffer size after writing SAPIs
by laforge 04 Nov '26

04 Nov '26
Attention is currently required from: dexter, osmith. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/44023?usp=email ) Change subject: gprs_sndcp_xid: double check buffer size after writing SAPIs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/44023?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iff1dd10644e37e344ca822a91d156e50288fcb30 Gerrit-Change-Number: 44023 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Nov 2026 13:21:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in libosmo-netif[master]: twrtp: fix generation of loss info word in RTCP RR blocks
by laforge 04 Nov '26

04 Nov '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/44027?usp=email ) Change subject: twrtp: fix generation of loss info word in RTCP RR blocks ...................................................................... twrtp: fix generation of loss info word in RTCP RR blocks We generate RTCP SR and RR packets that include reception report blocks describing what our twjit received - see RFC 3550 section 6.4.1. These RR blocks include a 32-bit word that reports our receiver's detection of packet loss in the incoming RTP stream; this word consists of an 8-bit "fraction lost" field and a 24-bit "cumulative number of packets lost" field. Our previous code computed each of these separate fields correctly, but the final step of combining them into the 32-bit word applied the wrong shift, producing garbage as a result. Fix it. Change-Id: Ib34239a4f4619fef097b4c1fb5fc3abed339850d --- M src/twrtp.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/twrtp.c b/src/twrtp.c index 1a1b7be..4d81510 100644 --- a/src/twrtp.c +++ b/src/twrtp.c @@ -851,7 +851,7 @@ lost_fract = 0; else lost_fract = (newly_lost << 8) / delta_expect; - lost_word = (lost_fract << 8) | (cumulative_lost & 0xFFFFFF); + lost_word = (lost_fract << 24) | (cumulative_lost & 0xFFFFFF); rr->ssrc = htonl(rri->ssrc); rr->lost_word = htonl(lost_word); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/44027?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib34239a4f4619fef097b4c1fb5fc3abed339850d Gerrit-Change-Number: 44027 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in libosmo-netif[master]: twrtp: fix generation of loss info word in RTCP RR blocks
by laforge 04 Nov '26

04 Nov '26
Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/44027?usp=email ) Change subject: twrtp: fix generation of loss info word in RTCP RR blocks ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/44027?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib34239a4f4619fef097b4c1fb5fc3abed339850d Gerrit-Change-Number: 44027 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Wed, 04 Nov 2026 13:20:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in osmo-msc[master]: add configurable DTMF support via RTP or SIP
by laforge 04 Nov '26

04 Nov '26
Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/44024?usp=email ) Change subject: add configurable DTMF support via RTP or SIP ...................................................................... Patch Set 1: (2 comments) File include/osmocom/msc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/8955cb38_439f2723?usp… : PS1, Line 149: DTMF_MODE_SIP = 0, /* forward via MNCC to SIP connector (default) */ > this should probably be called MNCC, not SIP specifically. Acknowledged https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/4f1f8b4e_7b35b05f?usp… : PS1, Line 150: DTMF_MODE_RTP, /* RFC 4733 telephone-event via MGCP RQNT */ > this naming is also quite generic. […] Acknowledged, I when I read "DTMF via RTP" i was immediately thinking of in-line tones being injected into the audio, not into telephone events. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/44024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icd33a0b412f39a56046e57038551332776be2ba1 Gerrit-Change-Number: 44024 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 04 Nov 2026 13:20:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-hlr[master]: tests/db_upgrade: fix test failure with sqlite3 >= 3.54.0
by laforge 04 Nov '26

04 Nov '26
Attention is currently required from: fixeria, lynxis lazus, osmith. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-hlr/+/44028?usp=email ) Change subject: tests/db_upgrade: fix test failure with sqlite3 >= 3.54.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/44028?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I7353988516b274eb228818e694dbe857509cf536 Gerrit-Change-Number: 44028 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 04 Nov 2026 13:16:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: udm: Fix TC_result_confirmation_inform expectancies
by fixeria 04 Nov '26

04 Nov '26
Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44029?usp=email ) Change subject: udm: Fix TC_result_confirmation_inform expectancies ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0c7fcfb673717472345b28139e3b4f6a15ef213 Gerrit-Change-Number: 44029 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Nov 2026 12:36:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: udm: Fix TC_result_confirmation_inform expectancies
by pespin 04 Nov '26

04 Nov '26
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44029?usp=email ) Change subject: udm: Fix TC_result_confirmation_inform expectancies ...................................................................... udm: Fix TC_result_confirmation_inform expectancies open5gs-udmd was sending the wrong message, as reported in https://github.com/open5gs/open5gs/issues/4896 The issue has been fixed, to adapt the test to properly trigger the scenario and adapt expectancies. Change-Id: If0c7fcfb673717472345b28139e3b4f6a15ef213 --- M udm/ConnHdlr.ttcn 1 file changed, 39 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/44029/1 diff --git a/udm/ConnHdlr.ttcn b/udm/ConnHdlr.ttcn index db16dc8..0a7ab1c 100644 --- a/udm/ConnHdlr.ttcn +++ b/udm/ConnHdlr.ttcn @@ -286,17 +286,16 @@ var template (value) AuthEvent1 auth_event; auth_event := ts_AuthEvent1(nfInstanceId := g_pars.ausf_instance_id, - success := true, + success := false, timeStamp := "2026-10-20T11:58:44.069417+00:00", /* TODO: generate the now() timestamp string */ authType := ts_AuthType1(FiveG_AKA), - servingNetworkName := g_pars.serving_network); + servingNetworkName := g_pars.serving_network, + authRemovalInd := true); http2_tx := f_n13_prepare_individual_auth_event(auth_event); f_http2_adapter_connect_send_udm(http2_tx, idx := http2_tx.conn_id); - /* FIXME: This is probably incorrect, it should send a DELETE, but it's what open5gs-udmd is sending right now... - * See https://github.com/open5gs/open5gs/issues/4896 */ - as_Nudr_DR_put_authentication_status(); + as_Nudr_DR_delete_authentication_status(); /* 3GPP TS 29.503 Table 6.3.3.6.2.1-3 */ http2_exp_rx := @@ -358,7 +357,7 @@ } } -/* 3GPP TS 29.505 5.2.2.3.1 AuthenticationSubscription (PUT) */ +/* 3GPP TS 29.505 5.2.24.3.1 Resource: AuthenticationStatus (PUT) */ function f_tr_Nudr_DR_put_authentication_status() runs on ConnHdlr return template (present) HTTP2_Msg { var template (present) HTTP2_Msg http2_msg; @@ -373,7 +372,7 @@ return http2_msg; } -/* 3GPP TS 29.505 5.2.2 Resource: AuthenticationSubscription */ +/* 3GPP TS 29.505 5.2.24.3.1 Resource: AuthenticationStatus (PUT) */ altstep as_Nudr_DR_put_authentication_status() runs on ConnHdlr { var HTTP2_Msg http2_rx; @@ -391,4 +390,37 @@ } } +/* 3GPP TS 29.505 5.2.24.3.3 Resource: AuthenticationStatus (DELETE) */ +function f_tr_Nudr_DR_delete_authentication_status() +runs on ConnHdlr return template (present) HTTP2_Msg { + var template (present) HTTP2_Msg http2_msg; + var template (present) HTTP2_header_block hb; + var template (present) HTTP2_pseudo_headers pseudo_headers; + var template HTTP2_header_list headers := *; + + pseudo_headers := tr_HTTP2_pseudo_headers_Req(method := "DELETE", + path := tr_Nudr_DR_path_authentication_status(g_pars.imsi_str)); + hb := tr_HTTP2_header_block(pseudo_headers, headers); + http2_msg := tr_HTTP2_Msg(?, ?, hb := hb, body := omit); + return http2_msg; +} + +/* 3GPP TS 29.505 5.2.24.3.3 Resource: AuthenticationStatus (DELETE) */ +altstep as_Nudr_DR_delete_authentication_status() +runs on ConnHdlr { + var HTTP2_Msg http2_rx; + [] HTTP2_CONN[HTTP2_CONN_SCP].receive(f_tr_Nudr_DR_delete_authentication_status()) -> value http2_rx { + var template (value) HTTP2_Msg http2_tx; + http2_tx := ts_HTTP2_Msg_204_No_Content(http2_rx.conn_id, + http2_rx.stream_id, + headers := { + ts_HTTP2_Hdr_content_type("application/json") + }, + body := omit); + + HTTP2_CONN[HTTP2_CONN_SCP].send(http2_tx); + setverdict(pass); + } +} + } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0c7fcfb673717472345b28139e3b4f6a15ef213 Gerrit-Change-Number: 44029 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-ttcn3-hacks[master]: bsf: Several typo fixes
by pespin 04 Nov '26

04 Nov '26
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44021?usp=email ) Change subject: bsf: Several typo fixes ...................................................................... bsf: Several typo fixes Change-Id: Icb70149a349355d6069a3d63657f4e10178d9b2a --- M bsf/ConnHdlr.ttcn M bsf/README.md 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/bsf/ConnHdlr.ttcn b/bsf/ConnHdlr.ttcn index 74594d7..7159e21 100644 --- a/bsf/ConnHdlr.ttcn +++ b/bsf/ConnHdlr.ttcn @@ -92,14 +92,14 @@ f_http2_server_emu_unregister(f_http2_server_path_match(), idx := HTTP2_CONN_SCP); } -function f_http2_adapter_connect_pcf(integer idx := 0) +function f_http2_adapter_connect_bsf(integer idx := 0) runs on ConnHdlr { f_http2_adapter_connect(mp_bsf_hostname, mp_bsf_sbi_port, mp_pcf_local_ip, idx := idx); } function f_http2_adapter_connect_send_bsf(template (value) HTTP2_Msg http2_msg, integer idx := 0) runs on ConnHdlr { - f_http2_adapter_connect_pcf(idx := idx); + f_http2_adapter_connect_bsf(idx := idx); f_http2_adapter_send(http2_msg); } diff --git a/bsf/README.md b/bsf/README.md index 5f9a700..5ef82b6 100644 --- a/bsf/README.md +++ b/bsf/README.md @@ -5,11 +5,11 @@ * N15: SBI (emulates AMF) * N36: SBI (emulates UDR) -{% dot pcf_tests.svg +{% dot bsf_tests.svg digraph G { rankdir=LR; ATS [label="ATS\nBSF_Tests.ttcn"]; - UDM [label="AMF\open5gs-pcfd",shape="box"]; + UDM [label="AMF\open5gs-bsfd",shape="box"]; ATS -> UDM [label="N7"]; ATS -> UDM [label="N15"]; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44021?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icb70149a349355d6069a3d63657f4e10178d9b2a Gerrit-Change-Number: 44021 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-ttcn3-hacks[master]: bsf: Several typo fixes
by pespin 04 Nov '26

04 Nov '26
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44021?usp=email ) Change subject: bsf: Several typo fixes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44021?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icb70149a349355d6069a3d63657f4e10178d9b2a Gerrit-Change-Number: 44021 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Nov 2026 12:09:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in osmo-hlr[master]: tests/db_upgrade: fix test failure with sqlite3 >= 3.54.0
by fixeria 04 Nov '26

04 Nov '26
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/44028?usp=email ) Change subject: tests/db_upgrade: fix test failure with sqlite3 >= 3.54.0 ...................................................................... tests/db_upgrade: fix test failure with sqlite3 >= 3.54.0 Starting from sqlite3 3.54.0, the CLI prints the column name header even if the query returns no rows. This results in unexpected header lines being printed for empty tables, making the db_upgrade test fail. Skip dumping contents of empty tables, so that the output is the same regardless of the sqlite3 version. Change-Id: I7353988516b274eb228818e694dbe857509cf536 --- M tests/db_upgrade/db_upgrade_test.sh 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/28/44028/1 diff --git a/tests/db_upgrade/db_upgrade_test.sh b/tests/db_upgrade/db_upgrade_test.sh index 8e2b498..8f4dafd 100755 --- a/tests/db_upgrade/db_upgrade_test.sh +++ b/tests/db_upgrade/db_upgrade_test.sh @@ -18,8 +18,11 @@ sqlite3 -batch -header "$db_file" "SELECT name,type,\"notnull\",dflt_value,pk FROM PRAGMA_TABLE_INFO('$table') order by name;" echo echo "Table $table contents:" - columns="$(sqlite3 -batch -noheader "$db_file" "SELECT name FROM PRAGMA_TABLE_INFO('$table') order by name;")" - sqlite3 -batch -header "$db_file" "SELECT $(echo $columns | sed 's/ /,/g') from $table;" + # sqlite3 >= 3.54 prints the header even for empty results, so skip empty tables + if [ "$(sqlite3 -batch -noheader "$db_file" "SELECT COUNT(*) FROM $table;")" != "0" ]; then + columns="$(sqlite3 -batch -noheader "$db_file" "SELECT name FROM PRAGMA_TABLE_INFO('$table') order by name;")" + sqlite3 -batch -header "$db_file" "SELECT $(echo $columns | sed 's/ /,/g') from $table;" + fi done } -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/44028?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I7353988516b274eb228818e694dbe857509cf536 Gerrit-Change-Number: 44028 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 61
  • 62
  • 63
  • 64
  • 65
  • 66
  • 67
  • ...
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.