lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[S] Change in osmo-ttcn3-hacks[master]: RemSIM/server: Expand maintenance mapping test with timeout
by pespin 05 Nov '26

05 Nov '26
Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43839?usp=email ) Change subject: RemSIM/server: Expand maintenance mapping test with timeout ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File remsim/RemsimServer_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43839/comment/b99bc18e_39f9… : PS1, Line 807: f_TC_slotmap_switch_maintenance(tiout := 10); Can we have this timeout a lot lower? like 1-2-3 seconds? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iab27eb51ef51fafc2cdef8aee7dc96892fb613fd Gerrit-Change-Number: 43839 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 05 Nov 2026 10:17:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: RemSIM/server: Add test to verify maintenance mapping
by pespin 05 Nov '26

05 Nov '26
Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43838?usp=email ) Change subject: RemSIM/server: Add test to verify maintenance mapping ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File remsim/RemsimServer_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43838/comment/4ed5d22c_0c80… : PS1, Line 719: /* 2. Create mainenance mapping, while having a regular mapping. */ s/mainenance/maintenance/ (sevgeral times in the file). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43838?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I091dfe999b5b3473c67d6874ca31d238ee75b70e Gerrit-Change-Number: 43838 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 05 Nov 2026 10:14:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in onomondo-eim[master]: sys.dev.config: add missing parameter eim_fqdn
by dexter 05 Nov '26

05 Nov '26
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/44030?usp=email ) Change subject: sys.dev.config: add missing parameter eim_fqdn ...................................................................... sys.dev.config: add missing parameter eim_fqdn The config file sys.dev.config lacks the parameter eim_fqdn. This is a follow up patch to Change-Id Idcee405b0a3096ce8fb1630816ad4353bebfe150) Change-Id: I5502f5cc7ca47c006cbbdb9aac7eed1ca5116215 Related: SYS#8287 --- M config/sys.dev.config 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/30/44030/1 diff --git a/config/sys.dev.config b/config/sys.dev.config index a6eb22a..b12c9e7 100644 --- a/config/sys.dev.config +++ b/config/sys.dev.config @@ -8,6 +8,7 @@ {rest_ip, {127, 0, 0, 1}}, {rest_port, 8080}, {eim_id, "eIM"}, + {eim_fqdn, "127.0.0.1:8000"}, {es9p_ssl_disable, true}, {eim_cert, "sample_eim_cert_nist.crt"}, {eim_key, "sample_eim_cert_nist.key"}, -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/44030?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I5502f5cc7ca47c006cbbdb9aac7eed1ca5116215 Gerrit-Change-Number: 44030 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
1 0
0 0
[M] Change in onomondo-eim[master]: onomondo_eim_app: check eIM certificate on startup
by dexter 05 Nov '26

05 Nov '26
Attention is currently required from: dexter, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-eim/+/43938?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge Change subject: onomondo_eim_app: check eIM certificate on startup ...................................................................... onomondo_eim_app: check eIM certificate on startup The public key from the eIM certificate is used to generate the eIM configuration, which is queried by REST-API users to provision the eIM configuration into new and existing eUICCs. The related private key is then used to sign eCOs and PSMOs which are sent to remote eUICCs. Since the provisioning of invalid key material may lead to catastrophic failures, let's implement a check ensures that the configured key material is correctly configured and valid. Related: SYS#8287 Change-Id: Ib4463ef29bc39c4c11a7c78c2135ec28ba6a2e1f --- M src/crypto_utils.erl M src/onomondo_eim_app.erl 2 files changed, 59 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/38/43938/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43938?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ib4463ef29bc39c4c11a7c78c2135ec28ba6a2e1f Gerrit-Change-Number: 43938 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
1 0
0 0
[S] Change in onomondo-eim[master]: eim_cfg: split eimPublicKey loading into separete function
by dexter 05 Nov '26

05 Nov '26
dexter has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43937?usp=email ) Change subject: eim_cfg: split eimPublicKey loading into separete function ...................................................................... eim_cfg: split eimPublicKey loading into separete function When the eIM configuration is generated, the public eIM key is loaded from the eIM certificate. Let's put this part into a separate function and make this function public. (We will need the function to be public in a follow up patch). Related: SYS#8287 Change-Id: I6b62603e581ea204a55de6bcdb10adcd785642ca --- M src/eim_cfg.erl 1 file changed, 21 insertions(+), 14 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve dexter: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/eim_cfg.erl b/src/eim_cfg.erl index dc2adac..1104853 100644 --- a/src/eim_cfg.erl +++ b/src/eim_cfg.erl @@ -7,24 +7,20 @@ -module(eim_cfg). -include_lib("public_key/include/public_key.hrl"). --export([gen_eim_configuration_data/1]). +-export([get_eimPublicKey_from_eim_cert/0, gen_eim_configuration_data/1]). -% Generate an encoded eIM configuration string, which can be used to program the eIM configuration into an eUICC, -% either via ES10b:AddInitialEim or ESep:addEim (eUICC package, eCO). The Format parameter selects how the output data -% shall be formatted. Two formats are possible: request: AddInitialEimRequest, single: EimConfigurationData -gen_eim_configuration_data(Format) -> - {ok, EimId} = application:get_env(onomondo_eim, eim_id), - {ok, EimFqdn} = application:get_env(onomondo_eim, eim_fqdn), +% Load the eimPublicKey from the configured eIM certificate (see sys.config). +get_eimPublicKey_from_eim_cert() -> + % Load eIM certificate and extract public key. {ok, EimCertPath} = utils:get_env_priv_file_path(onomondo_eim, eim_cert), {ok, EimCertPem} = file:read_file(EimCertPath), [{'Certificate', EimCertBer, not_encrypted}] = public_key:pem_decode(EimCertPem), {ok, EimCert} = 'PKIX1Explicit88':decode('Certificate', EimCertBer), - EimCert_TbsCertificate = maps:get(tbsCertificate, EimCert), - EimCert_SubjectPublicKeyInfo = maps:get(subjectPublicKeyInfo, EimCert_TbsCertificate), - {ok, CounterValue} = application:get_env(onomondo_eim, counter_value), + EimCertTbsCertificate = maps:get(tbsCertificate, EimCert), + EimCertSubjectPublicKeyInfo = maps:get(subjectPublicKeyInfo, EimCertTbsCertificate), - % Check certificate type - EimCert_algorithm = maps:get(algorithm, EimCert_SubjectPublicKeyInfo), + % Make sure that the algorithm is suitable and supported by this eIM. + EimCertAlgorithm = maps:get(algorithm, EimCertSubjectPublicKeyInfo), BrainpoolP256r1 = #{ algorithm => {1, 2, 840, 10045, 2, 1}, parameters => <<6, 9, 43, 36, 3, 3, 2, 8, 1, 1, 7>> @@ -33,12 +29,23 @@ algorithm => {1, 2, 840, 10045, 2, 1}, parameters => <<6, 8, 42, 134, 72, 206, 61, 3, 1, 7>> }, - case EimCert_algorithm of + case EimCertAlgorithm of BrainpoolP256r1 -> ok; Prime256v1 -> ok; _ -> throw("Incorrect eIM certificate, only BrainpoolP256r1 or Prime256v1 may be used!") end, + EimCertSubjectPublicKeyInfo. + +% Generate an encoded eIM configuration string, which can be used to program the eIM configuration into an eUICC, +% either via ES10b:AddInitialEim or ESep:addEim (eUICC package, eCO). The Format parameter selects how the output data +% shall be formatted. Two formats are possible: request: AddInitialEimRequest, single: EimConfigurationData +gen_eim_configuration_data(Format) -> + {ok, EimId} = application:get_env(onomondo_eim, eim_id), + {ok, EimFqdn} = application:get_env(onomondo_eim, eim_fqdn), + EimCertSubjectPublicKeyInfo = get_eimPublicKey_from_eim_cert(), + {ok, CounterValue} = application:get_env(onomondo_eim, counter_value), + % Generate eIM configuration EimConfigurationData = #{ eimId => EimId, @@ -49,7 +56,7 @@ % Optional: instruct the eUICC to calculate an association token associationToken => -1, % Mandatory - eimPublicKeyData => {eimPublicKey, EimCert_SubjectPublicKeyInfo}, + eimPublicKeyData => {eimPublicKey, EimCertSubjectPublicKeyInfo}, % This eIM implementation currently only supports ESipa via HTTPs where the only supported eIM Package % transfer procedure is the eIM Package Retrieval procedure (see also SGP.32, section 3.1.1.1. eimSupportedProtocol => [eimRetrieveHttps], -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43937?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I6b62603e581ea204a55de6bcdb10adcd785642ca Gerrit-Change-Number: 43937 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
1 0
0 0
[S] Change in onomondo-eim[master]: eim_cfg: split eimPublicKey loading into separete function
by dexter 05 Nov '26

05 Nov '26
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43937?usp=email ) Change subject: eim_cfg: split eimPublicKey loading into separete function ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43937?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I6b62603e581ea204a55de6bcdb10adcd785642ca Gerrit-Change-Number: 43937 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 05 Nov 2026 09:44:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in onomondo-eim[master]: eim_cfg: rename parameter "Style"
by dexter 05 Nov '26

05 Nov '26
dexter has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43936?usp=email ) Change subject: eim_cfg: rename parameter "Style" ...................................................................... eim_cfg: rename parameter "Style" The function gen_eim_configuration_data has a parameter "Style". This parameter sets which format the generated eIM configuration should have. Let's call this parameter "Format", which describes better what it is for. Let's also put a comment that explains how the function works. Related: SYS#8287 Change-Id: I34e2d1a7267d766b599da484c113f8e0bf68af21 --- M src/eim_cfg.erl 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve dexter: Looks good to me, approved diff --git a/src/eim_cfg.erl b/src/eim_cfg.erl index d026eee..dc2adac 100644 --- a/src/eim_cfg.erl +++ b/src/eim_cfg.erl @@ -9,7 +9,10 @@ -include_lib("public_key/include/public_key.hrl"). -export([gen_eim_configuration_data/1]). -gen_eim_configuration_data(Style) -> +% Generate an encoded eIM configuration string, which can be used to program the eIM configuration into an eUICC, +% either via ES10b:AddInitialEim or ESep:addEim (eUICC package, eCO). The Format parameter selects how the output data +% shall be formatted. Two formats are possible: request: AddInitialEimRequest, single: EimConfigurationData +gen_eim_configuration_data(Format) -> {ok, EimId} = application:get_env(onomondo_eim, eim_id), {ok, EimFqdn} = application:get_env(onomondo_eim, eim_fqdn), {ok, EimCertPath} = utils:get_env_priv_file_path(onomondo_eim, eim_cert), @@ -58,7 +61,7 @@ AddInitialEimRequest = #{eimConfigurationDataList => EimConfigurationDataList}, Encoded = - case Style of + case Format of request -> % Formatted as AddInitialEimRequest {ok, Asn1Encoded} = 'SGP32Definitions':encode( -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43936?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I34e2d1a7267d766b599da484c113f8e0bf68af21 Gerrit-Change-Number: 43936 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
1 0
0 0
[XS] Change in onomondo-eim[master]: eim_cfg: rename parameter "Style"
by dexter 05 Nov '26

05 Nov '26
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43936?usp=email ) Change subject: eim_cfg: rename parameter "Style" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43936?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I34e2d1a7267d766b599da484c113f8e0bf68af21 Gerrit-Change-Number: 43936 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 05 Nov 2026 09:44:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in osmo-hlr[master]: tests/db_upgrade: fix test failure with sqlite3 >= 3.54.0
by osmith 05 Nov '26

05 Nov '26
Attention is currently required from: fixeria, lynxis lazus. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-hlr/+/44028?usp=email ) Change subject: tests/db_upgrade: fix test failure with sqlite3 >= 3.54.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/44028?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I7353988516b274eb228818e694dbe857509cf536 Gerrit-Change-Number: 44028 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 05 Nov 2026 09:36:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in onomondo-eim[master]: onomondo_eim_app: use individual instance name per HTTP server
by dexter 05 Nov '26

05 Nov '26
dexter has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43921?usp=email ) Change subject: onomondo_eim_app: use individual instance name per HTTP server ...................................................................... onomondo_eim_app: use individual instance name per HTTP server The functions cowboy:start_clear and cowboy:start_tls get an instance name (atom) as the first parameter. This instance name must be unique. We mostly start the ESipa interface with HTTPs enabled and the REST interface with HTTPs disabled, so we get unique instance names in that case by chance. As soon as we switch to HTTP on the ESipa interface as well, the eIM crashes on startup, because the instance name "http_listener_esipa" is used twice (and it's also a wrong name in the case of the REST api). Let's ensure that each HTTP(s) server gehts an indvidual instance name based on the interface name. Change-Id: I43be5666658c407fa1c1fe1a93ae61e428393218 Related: SYS#8287 --- M src/onomondo_eim_app.erl 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: dexter: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/onomondo_eim_app.erl b/src/onomondo_eim_app.erl index a8614d7..688f83a 100644 --- a/src/onomondo_eim_app.erl +++ b/src/onomondo_eim_app.erl @@ -13,7 +13,7 @@ start_http_server(true, Ip, Port, _Cert, _Key, Dispatch, Middlewares, InterfaceName) -> logger:notice("Starting ~s HTTP server at ~p:~p...~n", [InterfaceName, Ip, Port]), cowboy:start_clear( - http_listener_esipa, + list_to_atom("http_listener_" ++ InterfaceName), [ {ip, Ip}, {port, Port} @@ -35,7 +35,7 @@ % implementation still lacks SNI support. The effort required to add SNI support should be manageable as Cowboy % offers SNI support (sni_fun). cowboy:start_tls( - https_listener_esipa, + list_to_atom("https_listener_" ++ InterfaceName), [ {ip, Ip}, {port, Port}, -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I43be5666658c407fa1c1fe1a93ae61e428393218 Gerrit-Change-Number: 43921 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 58
  • 59
  • 60
  • 61
  • 62
  • 63
  • 64
  • ...
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.