lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[S] Change in pysim[master]: esim/asn1/rsp: add OperatorId as an alias of OperatorID
by laforge 03 Nov '26

03 Nov '26
Attention is currently required from: hampushellsberg. laforge has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44008?usp=email ) Change subject: esim/asn1/rsp: add OperatorId as an alias of OperatorID ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > The card-test failure is the simtester agent disconnecting during pip install . […] retriggered -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44008?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I23d8c7e061a5573caa750fe76a6e8756ddbf0898 Gerrit-Change-Number: 44008 Gerrit-PatchSet: 1 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Comment-Date: Tue, 03 Nov 2026 10:05:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: hampushellsberg <hampushellsberg(a)gmail.com>
1 0
0 0
[M] Change in pysim[master]: esim.saip: keep keyAccess and keyCounterValue of security domain keys
by laforge 03 Nov '26

03 Nov '26
Attention is currently required from: dexter, hampushellsberg, lynxis lazus. laforge has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44011?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: esim.saip: keep keyAccess and keyCounterValue of security domain keys ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7df8ef6f2c81cd8544a04dbf7ff5d096685103e3 Gerrit-Change-Number: 44011 Gerrit-PatchSet: 2 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Nov 2026 10:04:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in pysim[master]: esim.saip: keep keyAccess and keyCounterValue of security domain keys
by laforge 03 Nov '26

03 Nov '26
Attention is currently required from: dexter, hampushellsberg, lynxis lazus. laforge has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44011?usp=email ) Change subject: esim.saip: keep keyAccess and keyCounterValue of security domain keys ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7df8ef6f2c81cd8544a04dbf7ff5d096685103e3 Gerrit-Change-Number: 44011 Gerrit-PatchSet: 2 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Nov 2026 10:04:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in pysim[master]: esim.saip: keep keyAccess and keyCounterValue of security domain keys
by laforge 03 Nov '26

03 Nov '26
Attention is currently required from: dexter, hampushellsberg, lynxis lazus. laforge has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44011?usp=email ) Change subject: esim.saip: keep keyAccess and keyCounterValue of security domain keys ...................................................................... Patch Set 2: (1 comment) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/44011/comment/fa6cd7e3_e398cf89?usp=em… : PS1, Line 1156: > Done in patch set 2, as you suggested: the counter is an int whose length comes from the KVN, so the […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7df8ef6f2c81cd8544a04dbf7ff5d096685103e3 Gerrit-Change-Number: 44011 Gerrit-PatchSet: 2 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Nov 2026 10:04:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: hampushellsberg <hampushellsberg(a)gmail.com> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
1 0
0 0
[M] Change in pysim[master]: esim.saip: keep keyAccess and keyCounterValue of security domain keys
by laforge 03 Nov '26

03 Nov '26
Attention is currently required from: dexter, hampushellsberg, lynxis lazus. laforge has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44011?usp=email ) Change subject: esim.saip: keep keyAccess and keyCounterValue of security domain keys ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File tests/unittests/test_esim_saip.py: https://gerrit.osmocom.org/c/pysim/+/44011/comment/f07df900_add5eb3b?usp=em… : PS2, Line 88: self.assertEqual(counter(0xff), '0001') # SCP02 > Agreed, the ranges are a convention and deviations exist; pySim's own SCP02 accepts '01' and '70' fo […] I think we should merge this as-is and wait if/until any actual problem shows up in the future. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7df8ef6f2c81cd8544a04dbf7ff5d096685103e3 Gerrit-Change-Number: 44011 Gerrit-PatchSet: 2 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Nov 2026 10:04:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: hampushellsberg <hampushellsberg(a)gmail.com> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
1 0
0 0
[S] Change in pysim[master]: personalization: SmspTpScAddr edits record 1 of EF.SMSP only
by laforge 03 Nov '26

03 Nov '26
Attention is currently required from: dexter, hampushellsberg. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43983?usp=email ) Change subject: personalization: SmspTpScAddr edits record 1 of EF.SMSP only ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/43983/comment/0f8b1938_15b5c88a?usp=em… : PS3, Line 651: if rec_len > Done in patch set 4: the condition is gone, and TestSmspTpScAddr in est_configurable_parameters. […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I47b1abc97d7b8caad0c74d7af2e5da38e9a895b1 Gerrit-Change-Number: 43983 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Nov 2026 10:01:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: hampushellsberg <hampushellsberg(a)gmail.com> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
1 0
0 0
[S] Change in pysim[master]: log: print a record only once when loggers are nested
by laforge 03 Nov '26

03 Nov '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/44009?usp=email ) Change subject: log: print a record only once when loggers are nested ...................................................................... log: print a record only once when loggers are nested PySimLogger.get() adds a handler to every logger it returns, and a record also reaches the handlers of all parent loggers. As pySim.global_platform and pySim.global_platform.scp both use it, every SCP02/SCP03 log line was printed twice. The folder osmocom-pysim-log-duplicate-handlers of hampushellsberg-dev/PySIM-upstream-patches on GitHub has the analysis and a repro. Change-Id: Icdd68c493db51f3ea30a21f06b747f4e2782624b --- M pySim/log.py M tests/unittests/test_log.py 2 files changed, 13 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve dexter: Looks good to me, approved; Verified Jenkins Builder: Verified diff --git a/pySim/log.py b/pySim/log.py index 5aeeed4..9ec47e5 100644 --- a/pySim/log.py +++ b/pySim/log.py @@ -41,6 +41,10 @@ self.log_callback = log_callback def emit(self, record): + # a record also reaches the handlers PySimLogger.get() put on its parent loggers + if getattr(record, '_pysim_printed', False): + return + record._pysim_printed = True formatted_message = self.format(record) self.log_callback(formatted_message, record) diff --git a/tests/unittests/test_log.py b/tests/unittests/test_log.py index a43fe41..3f1ea41 100755 --- a/tests/unittests/test_log.py +++ b/tests/unittests/test_log.py @@ -150,5 +150,14 @@ PySimLogger.setup(self._test_print_callback, {logging.WARN: YELLOW}) log.warning(TEST_MSG_WARNING) # don't leak cmd2 Color StrEnum + def test_06_nested_loggers(self): + # the record also reaches the handlers of the parent loggers + printed = [] + PySimLogger.setup(printed.append) + PySimLogger.get(__name__ + '.nested') + child = PySimLogger.get(__name__ + '.nested.child') + child.warning(TEST_MSG_WARNING) + self.assertEqual([m.strip() for m in printed], ["WARNING: " + TEST_MSG_WARNING]) + if __name__ == '__main__': unittest.main() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44009?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icdd68c493db51f3ea30a21f06b747f4e2782624b Gerrit-Change-Number: 44009 Gerrit-PatchSet: 2 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
1 0
0 0
[S] Change in pysim[master]: log: print a record only once when loggers are nested
by dexter 03 Nov '26

03 Nov '26
Attention is currently required from: hampushellsberg. dexter has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44009?usp=email ) Change subject: log: print a record only once when loggers are nested ...................................................................... Patch Set 2: Code-Review+2 Verified+1 (1 comment) Patchset: PS2: The patch looks plausible, I have also tried it out and it works fine. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44009?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icdd68c493db51f3ea30a21f06b747f4e2782624b Gerrit-Change-Number: 44009 Gerrit-PatchSet: 2 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Comment-Date: Tue, 03 Nov 2026 09:53:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: ggsn: Accept deletePDPContextRequest for dangling contexts from ggsn
by pespin 03 Nov '26

03 Nov '26
Attention is currently required from: daniel. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44022?usp=email ) Change subject: ggsn: Accept deletePDPContextRequest for dangling contexts from ggsn ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Shouldn't we focus on fixing *_clients_interact instead then? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1116c8e7a9640003458f837fe8f948cfe55fd6c9 Gerrit-Change-Number: 44022 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Nov 2026 09:41:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: ggsn: Accept deletePDPContextRequest for dangling contexts from ggsn
by daniel 03 Nov '26

03 Nov '26
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44022?usp=email ) Change subject: ggsn: Accept deletePDPContextRequest for dangling contexts from ggsn ...................................................................... ggsn: Accept deletePDPContextRequest for dangling contexts from ggsn This seems to happen if the previous tests (*_clients_interact) fail and some PDP contexts from that test carry over to the next. Since the restart counter indicates that the SGSN has restarted osmo-ggsn sends the deletePDPContextRequest for the old PDP contexts and this blocks the port in the altstep. Change-Id: I1116c8e7a9640003458f837fe8f948cfe55fd6c9 --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/22/44022/1 diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index e5b0581..c8e94df 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -775,6 +775,9 @@ f_handle_create_req(ctx, ud, exp_cause); cpr := ud.gtpc.gtpc_pdu.createPDPContextResponse; } + [] GTPC.receive(tr_GTPC_MsgType(g_peer_c, deletePDPContextRequest, ?)) { + repeat; + } } deactivate(d); T_default.stop; @@ -836,6 +839,9 @@ as_DIA_Gy_CCR(ctx, TERMINATION_REQUEST); } alt { + [] GTPC.receive(tr_GTPC_MsgType(g_peer_c, deletePDPContextRequest, ?)) { + repeat; + } [] GTPC.receive(tr_GTPC_MsgType(g_peer_c, deletePDPContextResponse, expect_teid)) -> value ud { if (ud.gtpc.gtpc_pdu.deletePDPContextResponse.cause.causevalue == expect_causevalue) { setverdict(pass); @@ -2051,6 +2057,9 @@ /* Wait to receive echo request and send initial Restart counter */ T_echo.start(int2float(g_use_echo_intval) + 1.0); alt { + [] GTPC.receive(tr_GTPC_MsgType(g_peer_c, deletePDPContextRequest, ?)) { + repeat; + } [] GTPC.receive(tr_GTPC_PING(?)) -> value ud { var uint16_t seq := oct2int(ud.gtpc.opt_part.sequenceNumber); GTPC.send(ts_GTPC_PONG(ud.peer, seq, g_restart_ctr)); @@ -2068,6 +2077,9 @@ g_restart_ctr := int2oct((oct2int(g_restart_ctr) + 1) mod 256, 1); T_echo.start(int2float(g_use_echo_intval) + 1.0); alt { + [] GTPC.receive(tr_GTPC_MsgType(g_peer_c, deletePDPContextRequest, ?)) { + repeat; + } [] GTPC.receive(tr_GTPC_PING(?)) -> value ud { var uint16_t seq := oct2int(ud.gtpc.opt_part.sequenceNumber); GTPC.send(ts_GTPC_PONG(ud.peer, seq, g_restart_ctr)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1116c8e7a9640003458f837fe8f948cfe55fd6c9 Gerrit-Change-Number: 44022 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 64
  • 65
  • 66
  • 67
  • 68
  • 69
  • 70
  • 71
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.