[M] Change in pysim[master]: esim.saip: keep keyAccess and keyCounterValue of security domain keys
Attention is currently required from: hampushellsberg, laforge, lynxis lazus. dexter has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44011?usp=email ) Change subject: esim.saip: keep keyAccess and keyCounterValue of security domain keys ...................................................................... Patch Set 3: Code-Review+1 (3 comments) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/44011/comment/c3aca42b_43ac8c02?usp=ema... : PS2, Line 1176: return 3 # SCP03
I would be very careful with those KVN Value mapping. […] (see comments in #88)
https://gerrit.osmocom.org/c/pysim/+/44011/comment/bbd0fa19_3cf7b646?usp=ema... : PS2, Line 1178: 'is unknown' % kvn)
(you do not have to break the string. […] (don't worry about it).
File tests/unittests/test_esim_saip.py: https://gerrit.osmocom.org/c/pysim/+/44011/comment/5a02cb9a_6f402505?usp=ema... : PS2, Line 88: self.assertEqual(counter(0xff), '0001') # SCP02
I think we should merge this as-is and wait if/until any actual problem shows up in the future. I think problems are very unlikely (but not impossible). Ok, then. Let's merge it as its.
-- To view, visit https://gerrit.osmocom.org/c/pysim/+/44011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7df8ef6f2c81cd8544a04dbf7ff5d096685103e3 Gerrit-Change-Number: 44011 Gerrit-PatchSet: 3 Gerrit-Owner: hampushellsberg <hampushellsberg@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-Attention: hampushellsberg <hampushellsberg@gmail.com> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Tue, 03 Nov 2026 10:40:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: hampushellsberg <hampushellsberg@gmail.com> Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: dexter <pmaier@sysmocom.de>
participants (1)
-
dexter