Attention is currently required from: hampushellsberg, laforge, lynxis lazus.
Patch set 3:Code-Review +1
3 comments:
File pySim/esim/saip/__init__.py:
Patch Set #2, Line 1176: return 3 # SCP03
I would be very careful with those KVN Value mapping. […]
(see comments in #88)
Patch Set #2, Line 1178: 'is unknown' % kvn)
(you do not have to break the string. […]
(don't worry about it).
File tests/unittests/test_esim_saip.py:
Patch Set #2, Line 88: self.assertEqual(counter(0xff), '0001') # SCP02
I think we should merge this as-is and wait if/until any actual problem shows up in the future.
I think problems are very unlikely (but not impossible). Ok, then. Let's merge it as its.
To view, visit change 44011. To unsubscribe, or for help writing mail filters, visit settings.