[S] Change in pysim[master]: esim.saip: keep keyAccess and keyCounterValue of security domain keys
Attention is currently required from: laforge. hampushellsberg has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44011?usp=email ) Change subject: esim.saip: keep keyAccess and keyCounterValue of security domain keys ...................................................................... Patch Set 1: (1 comment) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/44011/comment/9d7b12cd_52160467?usp=ema... : PS1, Line 1156:
Case 1: I would say let's raise an exception so we as developers/maintainers get note of it and can […] Done in patch set 2, as you suggested: the counter is an int whose length comes from the KVN, so there is no explicit length argument; a counter on a KVN outside the table raises ValueError when the key is encoded (decoding still works), and a decoded counter is re-encoded with the length its KVN gives.
-- To view, visit https://gerrit.osmocom.org/c/pysim/+/44011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7df8ef6f2c81cd8544a04dbf7ff5d096685103e3 Gerrit-Change-Number: 44011 Gerrit-PatchSet: 1 Gerrit-Owner: hampushellsberg <hampushellsberg@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Mon, 02 Nov 2026 11:58:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: hampushellsberg <hampushellsberg@gmail.com> Comment-In-Reply-To: laforge <laforge@osmocom.org>
participants (1)
-
hampushellsberg