[S] Change in pysim[master]: personalization: SmspTpScAddr edits record 1 of EF.SMSP only
Attention is currently required from: laforge, neels, osmith. hampushellsberg has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43983?usp=email ) Change subject: personalization: SmspTpScAddr edits record 1 of EF.SMSP only ...................................................................... Patch Set 3: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/43983/comment/1b7a3f7b_f5c307e7?usp=ema... : PS3, Line 651: if rec_len
Sounds excellent, thanks! Done in patch set 4: the condition is gone, and TestSmspTpScAddr in est_configurable_parameters.py edits a one-record and a two-record EF.SMSP and checks the second record is kept (without the fix the two-record case fails on the alpha identifier).
-- To view, visit https://gerrit.osmocom.org/c/pysim/+/43983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I47b1abc97d7b8caad0c74d7af2e5da38e9a895b1 Gerrit-Change-Number: 43983 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-CC: hampushellsberg <hampushellsberg@gmail.com> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Mon, 02 Nov 2026 11:59:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: hampushellsberg <hampushellsberg@gmail.com> Comment-In-Reply-To: laforge <laforge@osmocom.org>
participants (1)
-
hampushellsberg