18 Nov
2012
18 Nov
'12
12:01 p.m.
Hi Sylvain and others,
On Thu, Nov 15, 2012 at 11:59:27AM +0100, Sylvain Munaut wrote:
i applied the patch for gsm322.c. i cannot apply the patch for rffe_dualband.c, because i am not into it. maybe anyone else can review it.
Nothing to review really ... if you apply it it'll break all DCS users. There is no way to detect which phone submodel we run on.
We should probably have a better solution than to manually patch the source. I could imagine:
1) build a DCS and a PCS version of the firmware images 2) have the user set a #define that is evaluated in the RFFE 3) simply include DCS and PCS support in the firmware builds and rely on a configuration file / 'mobile' to define what bands to use
What do you think?
--
- Harald Welte laforge@gnumonks.org http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)